| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 14:26:24 | dansmith | mriedem: yes | |
| 14:26:24 | artom | So actually wouldn't we be able to just resurect https://review.opendev.org/#/c/680806/ and make it depend on stephenfin's series? | |
| 14:27:01 | mriedem | stephenfin: alex_xu: have you done functional testing with the PCPU series where things aren't stubbed out? | |
| 14:27:01 | stephenfin | artom: I could point run whitebox locally? | |
| 14:27:17 | artom | stephenfin, whitebox doesn't have any code to test your stuff | |
| 14:27:18 | sean-k-mooney | dansmith: well tempest has run with out pinning so if i do a run with only pinning that covers it right | |
| 14:27:20 | dansmith | mriedem: they have an etherpad of hand-run test cases | |
| 14:27:38 | alex_xu | mriedem: I done manual test with upgrade case | |
| 14:27:42 | dansmith | sean-k-mooney: yeah, isn't that what we're talking about here? | |
| 14:27:50 | artom | stephenfin, but... in your series, for instances using the PCPU resource class, what's the XML that pins them? | |
| 14:27:51 | stephenfin | artom: It tests that we can boot pinned instances, resize them, etc. | |
| 14:28:02 | artom | <vcpu cpuset=> or <cputune> ? | |
| 14:28:07 | sean-k-mooney | ill kick of 3 runs 1 with vcpu pin set 1 with onlyv cpu_dedicated_set and one with cpu_dedicated_set and cpu_shared_set | |
| 14:28:08 | stephenfin | artom: The same thing that was used for pinning with 'hw:cpu_policy' | |
| 14:28:17 | dansmith | sean-k-mooney: sounds good | |
| 14:28:22 | stephenfin | none of the libvirt XML stuff changes. This is all higher level accounting stuff | |
| 14:28:39 | dansmith | stephenfin: he knows, he's asking from a where-can-we-test perspective I think | |
| 14:29:01 | sean-k-mooney | FN is currenly offline since donnyd is doing a router upgrde so ill use vexhost instead for now | |
| 14:29:04 | stephenfin | Yeah, I get that. The answer is the same place we can test 'hw:cpu_policy=dedicated' currently | |
| 14:29:15 | artom | stephenfin, well I was asking because the allocation-styl <vcpu> pinning is what's done if the instance doens't have a NUMA topology and vcpu_pin_set is set (we talked about this, remember?) | |
| 14:29:16 | donnyd | I am ready to bring FN back online | |
| 14:29:19 | dansmith | stephenfin: unless one knows where that is... | |
| 14:29:21 | artom | stephenfin, and *that* can be tested in the gate | |
| 14:29:39 | artom | stephenfin, but from what you're saying that's not what your series uses | |
| 14:29:42 | sean-k-mooney | donnyd: well either works for this test i just need nested virt | |
| 14:29:52 | stephenfin | artom: yeah, no, the instance will have a NUMA topology because of the pinning | |
| 14:30:08 | sean-k-mooney | but i do need to go write a patch to add a lable that will use all the nested virt provder rater then just one specifically | |
| 14:31:02 | donnyd | sean-k-mooney: I think maybe vexxhost can also run this job. I don't want to speak on behalf of mnaser | |
| 14:31:19 | dansmith | donnyd: I think he's said several times that it can :) | |
| 14:31:30 | mnaser | yes should be ok | |
| 14:32:45 | donnyd | mnaser: do you have a flavor already built? | |
| 14:32:54 | sean-k-mooney | ill do all the nodepool lable stuff next week to make this more resiliant | |
| 14:33:02 | donnyd | kk sean-k-mooney | |
| 14:33:04 | sean-k-mooney | donnyd: this does not need the multi numa node stuff | |
| 14:33:13 | sean-k-mooney | just a single numa node is fine | |
| 14:33:19 | donnyd | oh just nested virt | |
| 14:33:24 | sean-k-mooney | yep | |
| 14:33:35 | sean-k-mooney | we just want to test pinning | |
| 14:33:44 | sean-k-mooney | since that is what we are chaning | |
| 14:34:12 | sean-k-mooney | once artoms stuff is actully merged i can retarget the multi numa job to also test stephens code | |
| 14:34:19 | sean-k-mooney | and get test coverage for both | |
| 14:34:27 | dansmith | migration with pinning "works" today but just blind copies everything to the other side, right? | |
| 14:34:35 | sean-k-mooney | ya | |
| 14:34:50 | dansmith | so these tests should also support migration but with smarts yeah? | |
| 14:35:16 | sean-k-mooney | i can run the migration tests if you like | |
| 14:35:22 | dansmith | yes, definitely | |
| 14:35:32 | sean-k-mooney | but it will do the wrong thing until artoms code lands | |
| 14:35:37 | mnaser | no i didn't get a chance to setup the flavor because it didn't seem pressing at the time :) | |
| 14:35:41 | sean-k-mooney | but if i use concurancy 1 it wont break anything | |
| 14:35:41 | mnaser | ill wait until "we need it" | |
| 14:35:41 | dansmith | we need to at least make sure we don't regress the stupid behavior | |
| 14:35:52 | dansmith | sean-k-mooney: or depends-on artoms? | |
| 14:36:08 | sean-k-mooney | im not sure if there will be a merge conflict | |
| 14:36:11 | sean-k-mooney | ill test that locally | |
| 14:36:15 | dansmith | uh | |
| 14:36:19 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 14:36:24 | dansmith | well, if there is we should rebase the pcpu stuff now, right? | |
| 14:36:35 | sean-k-mooney | am i guess so | |
| 14:36:50 | dansmith | maybe check locally first | |
| 14:36:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 14:36:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 14:36:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Extract pf$N literals as constants from func test https://review.opendev.org/680991 | |
| 14:36:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | |
| 14:36:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Improve dest service level func tests https://review.opendev.org/680998 | |
| 14:36:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Skip querying resource request in revert_resize if no qos port https://review.opendev.org/681513 | |
| 14:36:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Follow up for Ib50b6b02208f5bd2972de8a6f8f685c19745514c https://review.opendev.org/681490 | |
| 14:40:17 | sean-k-mooney | dansmith: artoms funtional tests still ned to be rebased but if i merge the cpu series with artoms serise without that it works locally | |
| 14:40:28 | sean-k-mooney | so ill do that quickly | |
| 14:40:33 | dansmith | sean-k-mooney: ack | |
| 14:40:53 | sean-k-mooney | the functionla patch we are leaving to not need to rebase all the rest | |
| 14:40:55 | dansmith | sean-k-mooney: that means you can depends-on it in your gate jobs yeah? or are you going to rebase all of pcpu and push it up? | |
| 14:41:04 | sean-k-mooney | so that will be rebased when the stuff is merged | |
| 14:41:16 | mriedem | gibi: bauzas: melwitt: i'm +2 up the bw provider migrate/resize series now https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports+status:open | |
| 14:41:23 | mriedem | just a few changes need a +W but they aren't too hard | |
| 14:41:39 | sean-k-mooney | ya i just need to depnd on the second form last patch in artoms serie | |
| 14:41:53 | sean-k-mooney | e.g. the one before the the functionl test | |
| 14:42:08 | sean-k-mooney | but i can have the job that is testing artoms stuff depend on stephens change too | |
| 14:42:20 | sean-k-mooney | and it should all merge fine | |
| 14:42:38 | sean-k-mooney | did i mention that zuul is awsome recently | |
| 14:42:40 | artom | Famous last words ;) | |
| 14:43:40 | sean-k-mooney | i did the merge locally so it should be fine | |
| 14:44:41 | sean-k-mooney | it will be a 4 way merge however (master+numa+cpu+ci) patches | |
| 14:45:04 | dansmith | nothing has even entered the gate yet | |
| 14:45:14 | dansmith | I mean, nothing at all | |
| 14:45:19 | mriedem | check queue is ~200 deep so nothing approved today is going to merge today | |
| 14:45:21 | mriedem | for nova anyway | |
| 14:45:21 | sean-k-mooney | yep | |
| 14:46:01 | dansmith | mriedem: don't burn your cards | |
| 14:46:19 | mriedem | hey, i'm a professional | |
| 14:46:54 | mriedem | oh wait, | |
| 14:47:02 | mriedem | can i switch cigarette for flavored vape? | |
| 14:47:08 | mriedem | i want to be young and hip | |
| 14:48:07 | dansmith | mriedem: vaping kills, haven't you heard? | |
| 14:48:17 | dansmith | apparently kills you faster than cigarettes, which is pretty impressive | |
| 14:48:30 | donnyd | mriedem: the juul virginia tobacco is pretty good | |
| 14:48:54 | mriedem | i did hear a pretty funny quote from trump on his ban on flavored vaping, | |
| 14:49:10 | mriedem | something like, "the kids, they're coming home, and they're saying to their mom, 'hey, i want to vape!', and it's bad" | |
| 14:49:18 | mriedem | like, what kid tells their parents they want to smoke? | |
| 14:49:32 | mriedem | duh | |
| 14:49:32 | mriedem | they just do it and then tell their parents they were at their friend's house, the friend whose parents smoke | |