| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 10:02:31 | efried | [workarounds]try_really_hard_to_get_allocation_candidates_for_pinned_instances_but_suffer_a_performance_hit | |
| 10:02:44 | bauzas | sorry folks, was AFK | |
| 10:02:46 | efried | oh, right, reverse of that | |
| 10:02:49 | stephenfin | *do_not_try_... | |
| 10:02:50 | stephenfin | yup | |
| 10:02:51 | efried | yeah | |
| 10:03:25 | efried | hah, I did that the other day | |
| 10:03:31 | bauzas | you don't imagine how a 9yo can yell at you :p | |
| 10:03:39 | efried | my kid: "why are you so late, dad?" | |
| 10:03:43 | efried | me: "because I suck" | |
| 10:04:13 | bauzas | yeah, life of a remottee | |
| 10:04:16 | bauzas | anyway | |
| 10:04:22 | bauzas | for the workaround name, meh | |
| 10:04:37 | bauzas | just provide a clear doc message, that's it | |
| 10:04:51 | stephenfin | disable_fallback_pcpu_query | |
| 10:04:55 | stephenfin | I'm going with that | |
| 10:04:58 | bauzas | cool | |
| 10:04:58 | efried | ++ | |
| 10:05:12 | bauzas | it could be "brexit" | |
| 10:06:06 | cdent | pcpu_backstop | |
| 10:06:30 | bauzas | this ^ | |
| 10:06:40 | efried | gibi, bauzas, sean-k-mooney: if one of you could ack https://review.opendev.org/#/c/671800/34 at some point soon... | |
| 10:06:55 | alex_xu | stephenfin: +1 disable_fallback_pcpu_query | |
| 10:07:08 | bauzas | efried: I was previously +2 | |
| 10:07:15 | bauzas | efried: but lemme look | |
| 10:07:33 | efried | bauzas: I see a +1 at PS33 | |
| 10:07:40 | bauzas | my bad | |
| 10:07:51 | efried | but yes, please +2+W if you're satisfied | |
| 10:08:00 | efried | this is one I wasn't comfortable +2ing myself. | |
| 10:08:37 | efried | hah, don't do that :P | |
| 10:09:28 | bauzas | oh heh, just discovered https://en.wiktionary.org/wiki/Bauza#English | |
| 10:09:32 | bauzas | \o/ | |
| 10:12:08 | bauzas | efried: https://sbauza.wordpress.com/2014/11/14/how-to-compare-2-patchsets-in-gerrit/ | |
| 10:12:22 | bauzas | (FWIW) | |
| 10:12:42 | efried | You're 26887th in the US | |
| 10:13:30 | bauzas | did the president already paid for France? | |
| 10:13:31 | efried | Yeah, if you moved here there would be 90*4* of you | |
| 10:13:44 | stephenfin | I never learned how to use vimdiff | |
| 10:13:53 | efried | afaict the diff from PS33 is negligible, just that one reinstated assertion in two tests | |
| 10:14:11 | bauzas | that's what I saw | |
| 10:14:19 | bauzas | +Wipped | |
| 10:14:43 | bauzas | stephenfin: you don't really need vimdiff | |
| 10:14:45 | efried | thanks bauzas | |
| 10:14:52 | efried | now, who's going to +A the quota one? | |
| 10:15:39 | alex_xu | by fiinger-guessing game? | |
| 10:36:11 | openstackgerrit | Luyao Zhong proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397 | |
| 10:45:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 10:46:50 | efried | gibi: https://review.opendev.org/#/c/680810/ is failing, can I pull it out of the gate? | |
| 10:48:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make SRIOV computes non symmetric in func test https://review.opendev.org/681667 | |
| 10:50:40 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 10:52:31 | gibi | efried: sure | |
| 10:53:50 | gibi | efried: what is the way to get it out of the gate? | |
| 10:54:12 | gibi | efried: rebase? That patch can be rebased freely as it is not part of the series. | |
| 10:54:19 | efried | yes. cool, thanks. | |
| 10:54:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up for I220fa02ee916728e241503084b14984bab4b0c3b https://review.opendev.org/680810 | |
| 10:54:40 | efried | rebase stops the current run and shoves it to the back of the queue | |
| 10:54:48 | gibi | rebased. | |
| 10:55:04 | efried | thanks, re+W'd | |
| 10:55:04 | gibi | is there any other way that does not involve changing the review itself? | |
| 10:55:12 | efried | gibi: no | |
| 10:55:15 | efried | not that I'm aware of | |
| 10:55:28 | gibi | we will run out of rebase targets if the master is not moving forward :) | |
| 10:55:33 | efried | yeah, I know :( | |
| 10:55:39 | efried | but for now this is the best we can do. | |
| 10:55:49 | gibi | ack | |
| 10:56:31 | aspiers | kashyap, efried: seems hw_firmware_type is missing from glance/etc/metadefs | |
| 10:56:50 | aspiers | and so is hw_mem_encryption | |
| 10:57:01 | efried | what does that mean? | |
| 10:57:16 | aspiers | it means they are not shown as nice user-friendly options in Horizon, for a start | |
| 10:57:21 | aspiers | not sure if there are other implications | |
| 10:57:41 | efried | to refine the question: Is this going to affect a) gate, b) vpmem/cpu-resources series? | |
| 10:58:01 | aspiers | I don't think it affects nova at all | |
| 10:58:09 | aspiers | We probably would have noticed by now if it did | |
| 10:58:26 | efried | then I humbly request the issue be raised *after* this week | |
| 10:58:40 | aspiers | I think it's just for registering metadata as "officially blessed" rather than some arbitrary key/value pair | |
| 10:58:42 | gibi | bauzas, efried: lost a +W in a rebase https://review.opendev.org/#/c/676972 could you please add it back? | |
| 10:58:53 | aspiers | efried: haha sure, it can't be urgent :) | |
| 10:59:12 | aspiers | efried: but probably trivial to fix too, and anyway it's a matter of submitting reviews to glance not nova | |
| 10:59:31 | efried | gibi: done, but you should feel free to re+W in these circumstances | |
| 10:59:48 | efried | aspiers: cool | |
| 10:59:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 11:00:26 | gibi | efried: ack, will do | |
| 11:03:27 | sean-k-mooney | efried: i see bauzas ack'd https://review.opendev.org/#/c/671800/34 but ill take a look now too | |
| 11:04:02 | efried | sean-k-mooney: if you like. Though actually I would rather you re-looked at that one vpmem patch... | |
| 11:04:18 | efried | sean-k-mooney: this un https://review.opendev.org/#/c/678455/36 | |
| 11:04:21 | sean-k-mooney | efried: sure | |
| 11:04:43 | efried | thank you | |
| 11:04:44 | sean-k-mooney | looking at teh cpu seriese have they all been approved | |
| 11:04:49 | efried | mostly | |
| 11:04:59 | efried | we're still working on a couple at the top | |
| 11:05:15 | efried | remember that thing about trying a second GET /a_c if the first one returned no results? | |
| 11:05:31 | sean-k-mooney | ok so we are waiting on the gate for most of them and fixing the last few patches | |
| 11:05:41 | sean-k-mooney | efried: ya | |
| 11:05:57 | sean-k-mooney | efried: is it causing issues | |
| 11:05:58 | efried | I'll save you reading the backscroll, but we're doing something different now: we're going to do both GET /a_c calls up front (with a workaround conf opt) | |
| 11:06:13 | efried | Stephen is working on that now | |
| 11:06:21 | sean-k-mooney | ok | |
| 11:06:28 | sean-k-mooney | what is the advantage of that | |
| 11:06:49 | sean-k-mooney | are we doing them in parallel or something | |
| 11:06:57 | efried | with the cascaded approach, if we did the first one, got results, then sent them down to the filter and the filter rejected all of them, we'd be hosed. | |