Posted	Nick	Remark
#openstack-nova - 2019-09-11
08:01:35	openstackgerrit	Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
08:01:35	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
08:01:36	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470
08:01:36	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640
08:01:37	openstackgerrit	Luyao Zhong proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397
08:05:27	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
08:05:28	openstackgerrit	Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452
08:05:28	openstackgerrit	Luyao Zhong proposed openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450
08:05:29	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454
08:05:29	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver discovering PMEM namespaces https://review.opendev.org/678453
08:05:30	openstackgerrit	Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
08:05:30	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
08:05:31	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470
08:05:31	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640
08:05:32	openstackgerrit	Luyao Zhong proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397
08:09:34	efried	o/ nova
08:09:58	efried	alex_xu, luyao: Is that ---^ ready for another look?
08:10:10	alex_xu	efried: good morning...so early
08:10:31	efried	alex_xu: I thought it might be a good idea for me to get up early and overlap more with you & stephenfin
08:10:41	alex_xu	efried: hah
08:10:53	efried	just today (and maybe tomorrow), not permanently.
08:11:51	efried	but yeah, it's closer to "all-nighter with a nap" than "get up early" :P
08:12:08	alex_xu	efried: no response from luyao, I guess she just get a break after submit patch :)
08:12:28	efried	alex_xu: I saw you worked the quota solution - thank you for that.
08:12:43	alex_xu	efried: np, one more interesting thing https://review.opendev.org/681383
08:12:43	efried	how's the CI thing coming? Does Rui have it set to pull latest yet?
08:13:10	alex_xu	efried: no, I talk with Dolpher that depends on CI team, they are in US
08:13:29	alex_xu	efried: we will know after few hours i guess
08:13:31	efried	argh! If only we had known, we were looking at this yesterday during the day.
08:15:42	efried	alex_xu: Did https://review.opendev.org/#/c/678455/27 wind up sane?
08:16:13	alex_xu	efried: let me check now
08:16:30	efried	If so, perhaps we can ask gibi/bauzas to have a look at it and give the other +2 (expecting the first from stephenfin)
08:16:54	bauzas	efried: which one ?
08:17:14	efried	bauzas: That one piece of vpmem we talked about yesterday - the part that does the libvirt dom xml business.
08:17:18	efried	link above
08:17:35	efried	bauzas: but maybe let alex_xu vet it first to make sure it's worth your time.
08:17:37	bauzas	efried: okay, honestly, it's prio #3 for me
08:17:45	efried	that should work out nicely :)
08:17:48	bauzas	but I can try to look while I wait for stephenfin and gibi
08:17:53	openstackgerrit	Alexandra Settle proposed openstack/nova stable/stein: Fixing broken links https://review.opendev.org/681401
08:18:54	alex_xu	efried: bauzas I guess the only one I want to check is this https://review.opendev.org/#/c/678455/27/nova/virt/hardware.py@2065, I don't know why she can't just assign a cpu_policy and cpu_thread_plicy directly instead of using the flavor and image_metadata
08:21:10	openstackgerrit	Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
08:23:02	luyao	efried: code ready to be reviewed, welcome :)
08:23:10	openstackgerrit	Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
08:23:46	efried	luyao: on it now
08:25:48	alex_xu	luyao: only thing I have https://review.opendev.org/#/c/678455/27/nova/virt/hardware.py@2072
08:26:52	luyao	alex_xu: Okay, I'll test it first.
08:27:13	alex_xu	luyao: thanks a lot
08:29:25	stephenfin	alex_xu: Nicely done :) Looking
08:29:34	alex_xu	stephenfin: \o/
08:30:52	luyao	alex_xu: works well
08:31:02	alex_xu	luyao: \o/
08:34:00	openstackgerrit	Merged openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
08:34:11	openstackgerrit	Merged openstack/nova master: Reject live migration and suspend on SEV guests https://review.opendev.org/680158
08:34:21	openstackgerrit	Merged openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
08:34:58	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972
08:35:31	alex_xu	stephenfin: https://review.opendev.org/#/c/671800/30/nova/virt/hardware.py@2018, I'm not sure we should take crea of numa_usages_from_instance_numa in ResoourceTracker, since the RT only process the instance below to this host, if this host is upgraded, then it will host_cell.pcpuset. If this host is old, then it doesn't know about any pcpuset. But I can help you to test that
08:37:37	gibi	bauzas: the next patch is up: https://review.opendev.org/676972
08:37:45	bauzas	gibi: ack, looking
08:37:49	gibi	thanks
08:50:26	stephenfin	alex_xu: Hmm, that's a good point actually
08:50:34	stephenfin	I keep forgetting the resource tracker runs on the host
08:53:17	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
08:53:23	alex_xu	stephenfin: yea, we only take care of host_cell, not the instance cell, it should be ok for any migration also
08:53:32	aspiers	stephenfin: I just removed SEV from the runway since it merged \o/
08:53:41	aspiers	thanks everyone for all your help
08:54:38	alex_xu	aspiers: congrats, destory the laptop and begin to vacation
08:54:51	aspiers	alex_xu: exactly! X-D ;-)
08:55:02	aspiers	I'm taking vacation next week
08:55:16	alex_xu	aspiers: enjoy :)
08:55:22	aspiers	thanks :)
08:55:45	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827
08:55:45	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
09:00:36	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019
09:03:05	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Extract pf$N literals as constants from func test https://review.opendev.org/680991
09:04:07	stephenfin	aspiers: \o/
09:04:20	stephenfin	efried: You're mad, btw
09:04:34	stephenfin	(the getting up early thing :D)
09:05:29	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Improve dest service level func tests https://review.opendev.org/680998
09:05:31	efried	fly safe gibi
09:06:01	efried	\o/ aspiers!
09:07:52	alex_xu	stephenfin: sean-k-mooney efried found an intersting case for this https://review.opendev.org/#/c/681383/2
09:08:20	alex_xu	but I guess in the end, it will become why choice fallback to PCPU or fallback to VCPU.
09:08:37	aspiers	efried: \o/ indeed, can't thank you enough for all your help! it's been a long road (basically a whole year IIRC)
09:08:58	stephenfin	alex_xu: I just left comments on that
09:09:09	stephenfin	tl;dr: I don't think we should be doing the service version check
09:09:16	efried	aspiers: sadly, your experience was very smooth and quick compared to most of a similar size.
09:09:29	aspiers	haha wow really :)
09:09:34	efried	ask anyone
09:09:51	stephenfin	aspiers: yup, he's not lying
09:09:53	aspiers	I honestly didn't think it would be anywhere near as hard to complete, or as long
09:10:05	aspiers	classic case of engineering underestimation
09:10:06	stephenfin	cpu-resources is on its...fourth cycle?
09:10:06	alex_xu	stephenfin: except we define a rule, the operator must use cpu_dedicated_set for pinning host after upgrade to T
09:10:13	efried	it really shouldn't be, aspiers
09:10:25	efried	...as hard/long to complete
09:10:25	aspiers	stephenfin: :-o
09:10:45	stephenfin	alex_xu: I've been told we can't. We'll break upgrades. You can't require nova.conf changes simply to upgrade to a new major version
09:11:04	aspiers	efried: what are the lessons learnt? other than we should all chip in to help fix CI more :)
09:11:36	efried	aspiers: We keep learning the same lessons over and over again but not reacting

Earlier   Later