| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-06 | |||
| 07:26:55 | cervigni | Yeah I check and thanks god there is one in Perth | |
| 07:26:56 | bauzas | even if you're not Aussie | |
| 07:27:19 | cervigni | Will do that... or I will just forget to come to the os summit and wait for the next one | |
| 07:27:35 | cervigni | I don't think I will give my fingerprints to the chinese governament for any reasons | |
| 07:27:38 | bauzas | oh dear god, I paid for a 1st class train which *has* power plugs but which are dysfunctional | |
| 07:27:49 | cervigni | I already give them allto the Australian one and I was pissed of for a month | |
| 07:28:10 | cervigni | bauzas: I guess it is an Italian train | |
| 07:28:34 | bauzas | Alstom, take it as you wish | |
| 07:28:35 | cervigni | I have never found an outlet working in an Italian train | |
| 07:29:41 | cervigni | going home, good luck with your visas | |
| 07:29:53 | cervigni | let me know how it goes | |
| 07:42:03 | bauzas | gibi: +Wd with concerns | |
| 07:43:26 | bauzas | gibi: my understanding is that you'll fail the resize when you wanna migrate/resize from host A to B when B isn't upgraded, right? | |
| 07:47:49 | bauzas | ttyl | |
| 08:01:50 | openstackgerrit | Yongli He proposed openstack/python-novaclient master: Microversion 2.78 - show server topology https://review.opendev.org/670790 | |
| 08:12:07 | kashyap | Does anyone here how to remove an instance that is stuck in 'pre-migrating' (it's the migration status) state? | |
| 08:12:34 | kashyap | I mean, not _remove_ the instance, but more unjamming it from that state. (Besides some database muckery) | |
| 08:24:16 | yaawang | alex_xu: stephenfin Hi, I have updated patches of vCPU models selection, can you review them if you have time :) https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cpu-model-selection | |
| 08:46:55 | gibi | bauzas: thanks. replied. | |
| 09:07:26 | aspiers | kashyap: some trivial changes for you to review: https://review.opendev.org/#/c/680527/ | |
| 09:07:38 | aspiers | https://review.opendev.org/#/c/680526/ | |
| 09:08:41 | kashyap | aspiers: Stuck in something urgent; but already have them open. | |
| 09:08:54 | openstackgerrit | Guo Jingyu proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/661466 | |
| 09:16:27 | kashyap | aspiers: FWIW, ACK to the tests move; nice catch (by "SEV work") | |
| 09:17:06 | aspiers | kashyap: thanks! | |
| 09:31:16 | openstackgerrit | Merged openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133 | |
| 09:44:27 | dtantsur | morning folks, we seem to have broken ironic with the recent nova patches | |
| 09:45:11 | cdent | dtantsur: sounds fun | |
| 09:46:52 | dtantsur | as always! | |
| 09:50:08 | cdent | when did it stop working? | |
| 09:51:24 | dtantsur | cdent: it's because of https://review.opendev.org/#/c/656027/, a fix is already posted | |
| 09:51:41 | dtantsur | efried: and I also wonder why our regular job did not detect ^^ | |
| 09:51:41 | cdent | ah | |
| 09:51:58 | dtantsur | maybe list_instances is not normally hit or is not critical? | |
| 09:55:49 | cdent | i would guess that most of the time individual instances are retrieved | |
| 09:55:52 | cdent | but that's totally a guess | |
| 10:00:33 | openstackgerrit | hulina proposed openstack/nova master: Nova raise exceptions when extending volume fails https://review.opendev.org/680648 | |
| 10:09:52 | artom | stephenfin, sean-k-mooney, can I get your thoughts on a thing? | |
| 10:10:01 | artom | You know this bit: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4525-L4528 | |
| 10:10:42 | artom | Normally on a host not intended for NUMA instances, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4549 will return None because vcpu_pin_set will not be set | |
| 10:11:51 | stephenfin | looking | |
| 10:12:21 | stephenfin | artom: Yeah, correct | |
| 10:12:33 | artom | If, however, an instance without a NUMA topology lands on a host with vcpu_pin_set not None, guest.cpuset being not None ends up triggering https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L2587-L2590 and we end up pinning guest CPUs that way | |
| 10:13:05 | artom | (via https://libvirt.org/formatdomain.html#elementsCPUAllocation, not our usual vcpupin XML bits) | |
| 10:14:19 | artom | Do we care about *that* form of CPU pinning (the one via <vcpu cpuset=blah>) for live migration? | |
| 10:14:22 | stephenfin | artom: um, I think that's correct, yeah | |
| 10:14:27 | artom | Theoretically we should be recalculating it | |
| 10:14:36 | bauzas | now I'm a bit afraid of my application be rejected because of some coffee traces on my passport :/ | |
| 10:14:39 | stephenfin | yup | |
| 10:14:43 | stephenfin | we should | |
| 10:14:51 | artom | But... in practice, does it actually happen? | |
| 10:14:56 | stephenfin | ohh | |
| 10:15:01 | stephenfin | hmm, I'm not actually sure | |
| 10:15:05 | artom | We tell everyone to split NUMA instances into host aggregates | |
| 10:15:17 | bauzas | stephenfin: I also think we should correctly document the weird case you mention in https://review.opendev.org/#/c/680107/3 | |
| 10:15:19 | stephenfin | I had this written off as being fixed by your series | |
| 10:15:29 | artom | So a non-NUMA instances landing on a host with vcpu_pin_set is... unlikely? | |
| 10:15:38 | artom | stephenfin, hah, I've just noticed that it's a thing | |
| 10:15:42 | bauzas | stephenfin: because the behaviour will change for those not RTFM'ing | |
| 10:15:53 | stephenfin | bauzas: Nope, it won't change | |
| 10:15:56 | stephenfin | *Break | |
| 10:15:58 | stephenfin | bauzas: see here | |
| 10:16:24 | stephenfin | bauzas: https://review.opendev.org/#/c/680107/3/nova/compute/manager.py@861 | |
| 10:16:28 | stephenfin | I'm only warning | |
| 10:16:32 | stephenfin | Not raising | |
| 10:17:01 | stephenfin | bauzas: For those other two conditionals, not that I'm only checking the _new_ options (cpu_dedicated_set, cpu_shared_set) | |
| 10:17:03 | bauzas | see my comment | |
| 10:17:05 | stephenfin | *note | |
| 10:17:18 | stephenfin | Yup. The conditional is here https://review.opendev.org/#/c/680107/3/nova/compute/manager.py@827 | |
| 10:17:29 | openstackgerrit | Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447 | |
| 10:17:30 | openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResourceList objs https://review.opendev.org/678448 | |
| 10:17:31 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450 | |
| 10:17:31 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | |
| 10:17:32 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | |
| 10:17:32 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver discovering PMEM namespaces https://review.opendev.org/678453 | |
| 10:17:32 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | |
| 10:17:33 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | |
| 10:17:33 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | |
| 10:17:34 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640 | |
| 10:17:35 | openstackgerrit | Luyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests https://review.opendev.org/680300 | |
| 10:17:35 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | |
| 10:17:37 | stephenfin | and I early return here https://review.opendev.org/#/c/680107/3/nova/compute/manager.py@839 | |
| 10:18:08 | stephenfin | so lines 841 etc. will only be triggered if the instance has a NUMA topology and that topology has pinning enabled | |
| 10:18:23 | bauzas | oh shit, that's what happen when you review in a crowded Starbucks place | |
| 10:18:31 | bauzas | you're totally right | |
| 10:18:46 | stephenfin | bauzas: but at least you've mediocre coffee on hand :P | |
| 10:18:57 | stephenfin | If it's not clear, I can rework to use an if-else | |
| 10:20:59 | openstackgerrit | Merged openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 10:21:22 | bauzas | stephenfin: nah nah, it's cool | |
| 10:21:42 | bauzas | stephenfin: we could nitpick on getting an extra comment, but meh | |
| 10:22:28 | bauzas | and yeah Starbucks is mediocre, but that's the only place where you can guaranttee both decent wifi coverage and working outlets | |
| 10:22:53 | stephenfin | In the code or the commit message? I can do the latter in a follow-up | |
| 10:23:08 | stephenfin | Yeah, agreed. Costa just isn't the same (and it's UK only) | |
| 10:23:15 | bauzas | I wish I could afford a Regus usage :) | |
| 10:23:46 | bauzas | stephenfin: well, I was thinking of just a comment line in the code itself but that's gross | |
| 10:23:49 | bauzas | nevermind it | |
| 10:23:58 | bauzas | it's just me who can't read coee | |
| 10:24:01 | bauzas | code* | |
| 10:24:29 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | |
| 10:24:47 | stephenfin | 'sall good :D | |