| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-06 | |||
| 00:46:33 | amotoki | brinzhang: sorry, I looked some wrong line when scrolling the review... I will add a comment. | |
| 00:46:35 | brinzhang | as mriedem said, this patch do the ``nova volume-attach`` CLI, not server create | |
| 00:46:50 | brinzhang | amotoki: np | |
| 00:48:41 | brinzhang | amotoki: And I want to keep the option delete-on-termination in novaclient with '--delete-on-termination', but I am not sure use this in OSC is fine? | |
| 00:49:29 | brinzhang | amotoki: As sain in PS3, how about add enable/disable befor the 'delete-on-termination', what do you think? | |
| 00:49:47 | amotoki | brinzhang: sounds good for --delete-on-termination. | |
| 00:50:16 | brinzhang | amotoki: I will keep --delete-on-termination in novaclient. | |
| 00:51:26 | amotoki | brinzhang: if we need an option to specify 'delete_on_termination=False', I see several options: (a) --delete-on-termination / --no-delete-on-termination (b) --enable-delete-on-termination/--disable-delete-on-termination (c) --delete-on-termination / --keep-on-termination | |
| 00:52:04 | amotoki | brinzhang: thought? | |
| 00:53:36 | brinzhang | amotoki: I tend to (b) --enable-delete-on-termination/--disable-delete-on-termination | |
| 00:54:57 | brinzhang | amotoki: I will rebase the novaclient patch, could please review the OSC patch, and you can leave that comment in it? Or after I rebased it. https://review.opendev.org/#/c/673725/6 ^^ | |
| 00:57:36 | amotoki | brinzhang: sure. | |
| 00:58:01 | amotoki | brinzhang: btw, is there any compute API ref corresponding to this? | |
| 01:01:27 | brinzhang_ | amotoki: is this what dou you want?https://docs.openstack.org/api-ref/compute/#attach-a-volume-to-an-instance | |
| 01:02:00 | amotoki | brinzhang_: but I cannot find information on delete_on_termination. | |
| 01:04:13 | brinzhang_ | amotoki: this field in this compute API is new, after https://review.opendev.org/#/c/673133/ is merged, you can look at it. | |
| 01:04:43 | amotoki | brinzhang_: thanks. It would help me when reviewing CLI patch. | |
| 01:05:47 | brinzhang_ | amotoki: but in create server API in request body(block_device_mapping_v2.delete_on_termination (Optional)) has this field, you can reference https://docs.openstack.org/api-ref/compute/?expanded=create-server-detail#create-server | |
| 01:06:24 | amotoki | brinzhang_: mainly I would like to check the default value of the option. | |
| 01:08:00 | openstackgerrit | Akira KAMIO proposed openstack/nova master: VMware: disk_io_limits settings are not reflected when resize https://review.opendev.org/680296 | |
| 01:08:50 | gmann | amotoki: this one - https://review.opendev.org/#/c/673133/16/nova/api/openstack/compute/volumes.py L342 | |
| 01:10:05 | amotoki | gmann: thanks. | |
| 01:37:50 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | |
| 01:39:24 | openstackgerrit | Merged openstack/nova master: Handle VirtDriverNotReady in _cleanup_running_deleted_instances https://review.opendev.org/679473 | |
| 01:41:51 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | |
| 03:06:39 | openstackgerrit | Akihiro Motoki proposed openstack/nova master: PDF documentation build https://review.opendev.org/676730 | |
| 06:10:23 | openstackgerrit | Michael Davies proposed openstack/os-traits master: Add support for ppc64le platforms https://review.opendev.org/680580 | |
| 06:31:52 | openstackgerrit | ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298 | |
| 06:31:53 | openstackgerrit | ya.wang proposed openstack/nova master: Support reporting multi CPU model traits https://review.opendev.org/670300 | |
| 06:31:53 | openstackgerrit | ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | |
| 07:14:22 | gibi | bauzas: hi! I'm about the start changing the bottom of the bw series https://review.opendev.org/#/c/656422 Yesterday we agreed with mriedem that the bottom can be fixed in a follow up, so if you are about to +A that patch then I will go with the followup. If not then I go and fix the patch itself instead | |
| 07:14:46 | bauzas | gibi: yup, I was reviewing and I saw matt's comments | |
| 07:14:51 | bauzas | gibi: as you want | |
| 07:15:18 | bauzas | gibi: I'm not done with reviewing your bottom change but I'm absolutely not opposed to a followup | |
| 07:15:22 | gibi | bauzas: then please continue reviewing it and I do a follow up | |
| 07:15:29 | bauzas | cool | |
| 07:15:34 | gibi | bauzas: and thank you :) | |
| 07:15:45 | bauzas | (on a train with limited connection but whatever :) ) | |
| 07:16:46 | gibi | fun times | |
| 07:16:58 | cervigni | os summit? | |
| 07:17:03 | gibi | yepp | |
| 07:17:17 | cervigni | oh god... I will procrastinate that until 2 weeks before | |
| 07:17:32 | bauzas | yeah | |
| 07:17:39 | bauzas | I need to provide my fingerprints | |
| 07:17:51 | cervigni | I don't even know if taking my laptop or not | |
| 07:17:54 | bauzas | hence me traveling to the closest consulate place | |
| 07:17:59 | cervigni | really? | |
| 07:18:10 | bauzas | yeah, even my passport is biometrical | |
| 07:18:20 | bauzas | and already having my 10 fingerprints | |
| 07:18:34 | cervigni | is this country dependant or not? | |
| 07:18:43 | cervigni | I don't think I have a Chinese consulate here | |
| 07:18:52 | bauzas | but you basically need to go to a visa app center that'll retain your passport by the time it'll take them to check your application | |
| 07:19:06 | cervigni | WHAT? | |
| 07:19:07 | cervigni | hahaha | |
| 07:19:11 | cervigni | RETAIN your passport? | |
| 07:19:19 | bauzas | for Lyon, France, the average delay is 8 working days | |
| 07:19:25 | bauzas | correct | |
| 07:19:43 | cervigni | I don't want anyone to "retain" my passport | |
| 07:19:56 | cervigni | I cannot be legally here without my passport | |
| 07:19:57 | gibi | that sounds pretty bad. I thought in Hungary I only need to send a photocopy of my passport | |
| 07:19:58 | bauzas | cervigni: https://visaforchina.org | |
| 07:20:06 | cervigni | "org" | |
| 07:20:07 | cervigni | haha | |
| 07:20:16 | bauzas | gibi: you don't need to be present yourself ? | |
| 07:20:25 | cervigni | wow nice website | |
| 07:20:28 | cervigni | is this an official website? | |
| 07:20:30 | gibi | bauzas: it seems the travell agencyt can make it work without mee | |
| 07:20:39 | bauzas | gibi: you can pay a TA | |
| 07:20:52 | gibi | my employer pays for it (i hope) | |
| 07:21:05 | bauzas | gibi: but for us, it will still mean that we have to physically move to an appointment to get our fingerprints taken | |
| 07:21:10 | bauzas | gibi: me too | |
| 07:21:22 | cervigni | are we on the F category? | |
| 07:21:25 | cervigni | or M ? | |
| 07:21:40 | gibi | this information is still missing for me, I trust the TA | |
| 07:21:41 | bauzas | cervigni: some asked for F but were said it should be a M | |
| 07:21:55 | bauzas | gibi: just check the website above | |
| 07:22:10 | cervigni | yeah, I don't think we are though commerce and trade | |
| 07:22:14 | bauzas | gibi: if they don't tell you to physically attend an appointment, then cool | |
| 07:22:30 | bauzas | cervigni: I should be able to tell you in 3 hours -ish | |
| 07:22:44 | bauzas | I filed a M | |
| 07:22:46 | cervigni | ok, could you write it in a PM? | |
| 07:22:55 | cervigni | here gmt+8 | |
| 07:23:03 | bauzas | sure | |
| 07:23:09 | cervigni | many thanks | |
| 07:23:20 | gibi | bauzas: there is not even a service center in hungary based on that page. But we have a consulate | |
| 07:23:30 | gibi | anyhow good luck bauzas | |
| 07:24:45 | cervigni | on that website from Australia it seems there is no fingerprint requirements | |
| 07:24:51 | cervigni | though I am italian so it is very confusing | |
| 07:25:11 | bauzas | gibi: good luck for you too then | |
| 07:25:22 | bauzas | gibi: that's probably why it's a good idea for you to follow a TA :) | |
| 07:25:55 | gibi | bauzas: yepp. I saw it working. One of my collague went to China last year | |
| 07:26:09 | gibi | successfully :) | |
| 07:26:37 | bauzas | cervigni: I guess you have to look at the closest service center in Australia | |
| 07:26:48 | bauzas | they should be able to give you instructions | |
| 07:26:55 | cervigni | Yeah I check and thanks god there is one in Perth | |
| 07:26:56 | bauzas | even if you're not Aussie | |
| 07:27:19 | cervigni | Will do that... or I will just forget to come to the os summit and wait for the next one | |
| 07:27:35 | cervigni | I don't think I will give my fingerprints to the chinese governament for any reasons | |
| 07:27:38 | bauzas | oh dear god, I paid for a 1st class train which *has* power plugs but which are dysfunctional | |
| 07:27:49 | cervigni | I already give them allto the Australian one and I was pissed of for a month | |