| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-05 | |||
| 10:39:07 | sean-k-mooney | hardware.py will import utils but utils wont import it | |
| 10:39:33 | sean-k-mooney | so if you remove the change in https://review.opendev.org/#/c/644565/51/nova/virt/libvirt/utils.py@38 | |
| 10:39:38 | sean-k-mooney | its not an issue right | |
| 10:40:30 | aspiers | ohhh OK those CI failures on the first patch are something else | |
| 10:40:42 | aspiers | I thought I saw circular import errors in both patches but I was wrong | |
| 10:40:50 | aspiers | cool | |
| 10:42:11 | sean-k-mooney | there is another way to break circual dependcies in python but moveing htat function is the simplest | |
| 10:42:23 | aspiers | which one? | |
| 10:42:28 | aspiers | sev_enabled? | |
| 10:42:31 | sean-k-mooney | yes | |
| 10:42:34 | sean-k-mooney | moving it to the driver | |
| 10:42:42 | aspiers | you mentioned another function in utils you are gonna move? | |
| 10:42:45 | aspiers | which one? | |
| 10:42:59 | sean-k-mooney | no you dont need to move anything else | |
| 10:43:04 | aspiers | oh that's the only one OK cool | |
| 10:43:06 | sean-k-mooney | just the new funtion your intoducing | |
| 10:43:14 | aspiers | so move that to libvirt/driver.py | |
| 10:43:18 | aspiers | where it was originally :) | |
| 10:43:20 | sean-k-mooney | ya | |
| 10:43:22 | aspiers | cool | |
| 10:43:29 | aspiers | using designer.py made everything a lot cleaner | |
| 10:43:33 | aspiers | this is another example of that | |
| 10:43:42 | aspiers | thanks a lot! | |
| 10:43:45 | sean-k-mooney | we want to kill desigenr.py | |
| 10:43:48 | yonglihe | sean-k-mooney, stephenfin: good morning, guys. | |
| 10:43:51 | aspiers | my brain was hurting from thinking about this | |
| 10:43:53 | sean-k-mooney | or at least we did | |
| 10:44:10 | aspiers | sean-k-mooney: there should be a list of tech debt goals somewhere public | |
| 10:44:11 | sean-k-mooney | yonglihe: hi | |
| 10:44:15 | aspiers | sean-k-mooney: e.g. storyboard | |
| 10:44:28 | aspiers | maybe it's on an etherpad somewhere | |
| 10:44:29 | sean-k-mooney | aspiers: i was going to say etherpad would be good. | |
| 10:44:35 | aspiers | WFM too | |
| 10:44:49 | aspiers | OK, gonna take a break | |
| 10:45:23 | sean-k-mooney | aspiers: the designer.py was intoduced by danpb to breakout some fo the code out of the driver but it was started and never finish and became techdebt | |
| 10:45:39 | sean-k-mooney | really we shoudl merge it into the config.py | |
| 10:45:48 | aspiers | I disagree | |
| 10:45:56 | sean-k-mooney | its basically doing the same thing | |
| 10:46:00 | aspiers | I think the scoping text at the top of config.py is good | |
| 10:46:10 | sean-k-mooney | well i gues | |
| 10:46:12 | aspiers | it's good to keep logic out of config,py | |
| 10:46:22 | sean-k-mooney | config.py is giving you the datamodels | |
| 10:46:24 | aspiers | just keep it parsing/generating XML only | |
| 10:46:28 | sean-k-mooney | and serialistaion code | |
| 10:46:38 | sean-k-mooney | and the designer is wiring up the elements | |
| 10:46:51 | sean-k-mooney | but the problem is so is the driver.py | |
| 10:47:21 | sean-k-mooney | so without moveing more of the xml logic out of the dirver and into the desinger among other things its kind of messey to have it in two places | |
| 10:47:48 | sean-k-mooney | yonglihe: o/ | |
| 10:50:25 | sean-k-mooney | yonglihe: i see stephenfin has +2'd the toplogy api seires. it should merge soon | |
| 10:50:55 | sean-k-mooney | yonglihe: that just leaves your orpahn vm series right | |
| 10:51:22 | openstackgerrit | Adam Spiers proposed openstack/nova master: Ensure q35 machine type is used when booting with SEV https://review.opendev.org/680065 | |
| 10:51:37 | openstackgerrit | Adam Spiers proposed openstack/nova master: Ensure q35 machine type is used when booting with SEV https://review.opendev.org/680065 | |
| 10:52:10 | yonglihe | sure, i notice that. thank you guys. That orphan is real orphan now. -:) | |
| 10:52:44 | sean-k-mooney | ill try and check it out again this week. | |
| 10:53:20 | yonglihe | That's great ! | |
| 10:53:46 | yonglihe | Pile of patches recently. | |
| 10:54:12 | sean-k-mooney | well code freeze is in a week so it always gets hechtic at this time | |
| 10:55:29 | yonglihe | deja vu | |
| 11:12:09 | stephenfin | yaawang, alex_xu: I'm going to address my nits in the docs for https://review.opendev.org/#/c/670298/ and then fast approve, if that's okay. I'd like to see a follow-up for the non-doc fixes though | |
| 11:15:27 | aspiers | sean-k-mooney: https://review.opendev.org/#/c/680065/6/nova/virt/hardware.py@30 still doesn't work because that imports libvirt.driver which imports virt.hardware | |
| 11:15:43 | aspiers | kashyap: ^^^ | |
| 11:16:27 | kashyap | Hmm | |
| 11:16:45 | openstackgerrit | wangfengsheng proposed openstack/nova master: test https://review.opendev.org/680372 | |
| 11:16:48 | kashyap | aspiers: Is it simpler if you just put it in utils? | |
| 11:20:05 | aspiers | kashyap: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-09-05.log.html#t2019-09-05T10:32:41 | |
| 11:21:25 | kashyap | Ah, "The problem is that get_mem_encryption_constraint() and its helpers are tied to virt.hardware" | |
| 11:21:33 | aspiers | yes, keep reading | |
| 11:23:40 | alex_xu | stephenfin: cool | |
| 11:24:13 | cdent | aspiers, sean-k-mooney : https://twitter.com/richard_parris/status/1169414190093627392 | |
| 11:25:02 | aspiers | cdent: heh that's good | |
| 11:28:07 | aspiers | mine too | |
| 11:28:13 | aspiers | argh | |
| 11:28:19 | Sundar | Hi gibi, I resubmitted the Cyborg interaction patch series [1] with the updated notification structure. Please review it when you can. [1] https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/nova-cyborg-interaction | |
| 11:30:13 | aspiers | sean-k-mooney: :) | |
| 11:33:01 | kashyap | aspiers: Sorry for no bright ideas yet; I'm mired in mutliple tasks (multitasking--); now for lunch | |
| 11:33:45 | artom | aspiers, so ideally you'd want to fail early at the compute API level, around the same place _validate_flavor_image_mem_encryption() is called | |
| 11:34:15 | artom | The problem is that we don't want to have driver-specific calls in there (libvirt_utils.get_machine_type) | |
| 11:34:19 | aspiers | artom: That's already happening; the challenge is getting import dependencies right | |
| 11:34:19 | Sundar | sean-k-mooney: How are you? | |
| 11:34:48 | aspiers | artom: Yeah that's a good point, maybe the crux of the problem | |
| 11:34:50 | artom | aspiers, right, sorry, you're calling your thing from get_mem_encryption_constraint | |
| 11:35:16 | aspiers | Well you're right that we're calling driver-specific stuff from the API level | |
| 11:35:45 | artom | But if we move to fail within libvirt, which is where the machine type stuff belongs, it's super late (around https://review.opendev.org/#/c/644565/51/nova/virt/libvirt/driver.py@4931 presumably) | |
| 11:35:49 | sean-k-mooney | Sundar: hi. im ok i did not sleef last night but other then that im good | |
| 11:36:01 | sean-k-mooney | Sundar: how is the cyborg integration comming | |
| 11:36:17 | aspiers | artom: exactly | |
| 11:36:36 | aspiers | artom: so how to achieve https://review.opendev.org/#/c/680065/6//COMMIT_MSG ? | |
| 11:36:45 | artom | aspiers, I don't want to over design, but maybe drivers need a validate_image_props() or something | |
| 11:36:56 | aspiers | urgh | |
| 11:37:00 | artom | I know :( | |
| 11:37:29 | aspiers | a cloud suddenly passed over the chances of landing SEV before feature freeze :-( | |
| 11:37:31 | Sundar | sean-k-mooney: The integ is progressing. When you tried to deploy Cyborg, perhaps you may have grappled with which patch series to deploy. Many of them have merged now. If you have the time, I can explain further. | |
| 11:37:44 | artom | That's what we get for exposing driver-specific stuff in what's essentially our API | |
| 11:38:08 | aspiers | artom: you referring to stuff like hw_machine_type extra spec? | |
| 11:38:18 | aspiers | I don't see how that could be avoided | |
| 11:38:19 | Sundar | sean-k-mooney: Hope Cyborg is not what's keeping you up ;) | |
| 11:38:21 | sean-k-mooney | Sundar: i ended up spending the last few days teting artoms numa live migration patch. | |
| 11:38:32 | Sundar | Ah, I see | |
| 11:38:49 | sean-k-mooney | Sundar: no i set up a clean vm to test cyborg in with centos 7 as you suggeted | |
| 11:39:02 | sean-k-mooney | but i did not get time to actully execute devstack and deploy it | |