| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-04 | |||
| 18:17:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | |
| 18:17:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | |
| 18:17:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | |
| 18:17:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | |
| 18:17:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | |
| 18:17:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.opendev.org/637070 | |
| 18:17:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | |
| 18:19:22 | sean-k-mooney | while its on the dest node with the invalid pinning we get the message we expect in the update resouce providers http://paste.openstack.org/show/770652/ whic is the same behavior as master today | |
| 18:21:40 | sean-k-mooney | dansmith: artom im going to lie down and take some panadol and hopefully my headache will go away. let me know if i need to test anything else and i will do it tomorrow | |
| 18:22:00 | dansmith | sean-k-mooney: cool, thanks for these confirmations... | |
| 18:22:35 | donnyd | sean-k-mooney: using 2x the ceph defaults to start | |
| 18:22:40 | donnyd | we will see how it goes | |
| 18:22:50 | sean-k-mooney | 2x? | |
| 18:23:14 | dansmith | was that intended for me? | |
| 18:23:54 | melwitt | probably | |
| 18:24:47 | sean-k-mooney | oh the rbd defualt chunk size | |
| 18:24:57 | sean-k-mooney | ya that was for dan | |
| 18:25:10 | mriedem | artom: can this be abandoned now? https://review.opendev.org/#/c/634605/ | |
| 18:25:14 | mriedem | your series is kind of hard to follow in gerrit | |
| 18:25:22 | mriedem | especially when the topic branch no longer matches the bp name | |
| 18:25:47 | artom | mriedem, done | |
| 18:25:55 | sean-k-mooney | i think this is the new topic branch https://review.opendev.org/#/q/topic:bp/numa-aware-live-migration-patch27+(status:open+OR+status:merged) | |
| 18:25:56 | artom | mriedem, wtf, where did '-patch27' come from? | |
| 18:26:10 | artom | sean-k-mooney, for your tests? | |
| 18:26:12 | mriedem | artom: guessing you were doing some weird local feature branch rebasing | |
| 18:26:19 | sean-k-mooney | no | |
| 18:26:28 | artom | I didn't do it intentionally | |
| 18:26:43 | sean-k-mooney | i mean that sames to be what most of the new ones are tagged with | |
| 18:26:48 | mriedem | is anything using this? https://review.opendev.org/#/c/679319/ | |
| 18:27:12 | sean-k-mooney | this is the last patch https://review.opendev.org/#/c/672595/ | |
| 18:27:26 | artom | mriedem, nope, abandon away | |
| 18:27:29 | sean-k-mooney | so that is the 7 pathces theat matter | |
| 18:27:55 | sean-k-mooney | i guess 6 pathces. | |
| 18:28:06 | mriedem | and https://review.opendev.org/#/c/679656/ is the thing testing it? | |
| 18:28:13 | melwitt | I've been wondering what happened to the automatic topic naming in gerrit. it was nice when it used to do that | |
| 18:28:22 | mriedem | which is...on a different topic branch | |
| 18:28:24 | mriedem | so hard to find... | |
| 18:28:42 | sean-k-mooney | mriedem: feel free to change it | |
| 18:28:59 | dansmith | melwitt: that is a function of git-review I think | |
| 18:29:43 | melwitt | hm, I didn't think I had changed git-review versions. I will check that | |
| 18:29:43 | mriedem | https://review.opendev.org/#/q/topic:bp/numa-aware-live-migration+(status:open+OR+status:merged)+project:openstack/nova | |
| 18:29:47 | mriedem | looking better | |
| 18:30:27 | dansmith | melwitt: see the -t section, which says "if not specified, a bug number from the commit summary will be used" https://linux.die.net/man/1/git-review | |
| 18:30:39 | melwitt | thank you | |
| 18:31:00 | mriedem | is that only if you're on the master branch? | |
| 18:31:05 | mriedem | i'm always in a topic branch | |
| 18:31:11 | artom | mriedem, cleaned it up a bit, sorry for the mess | |
| 18:31:33 | dansmith | mriedem: no | |
| 18:31:42 | dansmith | mriedem: bug takes precedence, otherwise local branch name | |
| 18:31:52 | dansmith | I never submit from the master branch locally.. | |
| 18:31:52 | melwitt | I'm not sure what happened but in the past, I never had to worry about my random topic branch name getting pushed to gerrit (as long as I have a bug or bp) but lately I noticed it's not adjusting it anymore | |
| 18:32:26 | mriedem | same, ok i guess i just didn't notice since i'm always using bug/xxx or bp/xxx | |
| 18:33:22 | sean-k-mooney | it will still take the topic if you do git checkout -b whatever | |
| 18:33:36 | dansmith | sean-k-mooney: only if there is no other tag in the commit message | |
| 18:33:55 | sean-k-mooney | a recent version of git-review removed some of the auto topic stuff | |
| 18:33:55 | dansmith | sean-k-mooney: go lie down :) | |
| 18:34:12 | sean-k-mooney | ya i will but stephenfin change how this works recently | |
| 18:34:20 | melwitt | aw man | |
| 18:34:27 | sean-k-mooney | i think they weanted to remvoe the auto topic form the commit message | |
| 18:34:29 | melwitt | I need to downgrade then probably | |
| 18:34:38 | sean-k-mooney | but leave the auto topic form branch name | |
| 18:34:39 | mriedem | i thought sean-k-mooney was going to lie down? | |
| 18:34:47 | melwitt | git-review version 1.28.0 | |
| 18:34:48 | sean-k-mooney | ok o/ | |
| 18:35:09 | mriedem | now that he's gone, | |
| 18:35:22 | dansmith | https://opendev.org/opendev/git-review/commit/af955c932eb97433199781b5d4f7fb5fb5af8a6f | |
| 18:35:40 | dansmith | https://opendev.org/opendev/git-review/commit/03768832c4a73c3079ce24d84fecae1da39b2d71 | |
| 18:35:57 | dansmith | "frequently does the wrong thing" ... not that I ever saw. | |
| 18:36:07 | melwitt | yeah like, what? | |
| 18:36:16 | dansmith | melwitt: that second commit is likely what you've noticed I guess | |
| 18:36:27 | melwitt | stephenfin you're killin me | |
| 18:36:56 | melwitt | and yeah, I think you're right dansmith | |
| 18:37:01 | melwitt | I'm gonna downgrade | |
| 18:37:13 | dansmith | the story links in that commit are broken, | |
| 18:37:29 | dansmith | and no gerrit links so I dunno what kind of review that stuff gets | |
| 18:37:50 | melwitt | fun | |
| 18:38:00 | dansmith | I pretty much always name my local branches with bug/X and bp/Y anyway, so I probably wouldn't notice | |
| 18:38:13 | dansmith | because I actually don't like that I end up with them different in gerrit vs. local | |
| 18:38:15 | melwitt | I'm a renegade | |
| 18:39:18 | melwitt | https://en.wikipedia.org/wiki/Renegade_(TV_series) | |
| 18:39:24 | mriedem | was just thinking that | |
| 18:39:38 | mriedem | i had a friend that couldn't leave the house all summer in middle school because his parents made him babysit his sister, | |
| 18:39:43 | mriedem | and he'd be watching renegade every day | |
| 18:40:15 | melwitt | lol, an excellent choice | |
| 18:40:19 | mriedem | so we had to go to his house b/c he coudn't leave, but then we had to watch renegade | |
| 18:42:01 | mriedem | who is lorenzo roundhouse kicking today? | |
| 18:43:36 | melwitt | heh | |
| 18:54:09 | zbr | efried: does https://review.opendev.org/#/c/674057/ look ok now? | |
| 18:59:17 | artom | I'm a dumbass | |
| 18:59:42 | artom | I spent literally hours, at this point, trying to stub, mock, or hack __dict__ to pin a compute RPC object | |
| 19:00:09 | artom | (Because def router is an @property that can't be set/stubbed, and it's using a global singleton) | |
| 19:00:30 | artom | When what I *should* have done is just inherited from ComputeAPI and overwrote def router >_< | |
| 19:02:58 | dansmith | can't you just kill router on the instance that each one gets? | |
| 19:03:09 | dansmith | service.manager.rpcapi.router = mock.Mock() ? | |
| 19:03:14 | dansmith | or whatever | |
| 19:03:54 | artom | @property makes it un-settable | |
| 19:04:09 | dansmith | can you delattr it? | |
| 19:04:35 | artom | Huh, didn't think to try that | |
| 19:04:39 | dansmith | anyway, doesn't matter | |
| 19:30:36 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |