Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-04
18:05:18 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/migrate_server.py#L127-L137
18:05:22 dansmith although it's not clear if that chunk size affects streaming like the filesystem one does
18:05:58 sean-k-mooney aspiers: so that his proably the method you want to extend to call into hardware.py and check if sev is requested
18:06:06 mriedem aspiers: i don't know that it matters really; i liked the decorator b/c you don't have to copy/paste the validation logic
18:06:31 mriedem if you do it in nova.compute.api.API methods you'll have to handle whatever exception you raise so that the api doesn't return a 500
18:06:43 aspiers mriedem: got it
18:06:58 sean-k-mooney mriedem: well you chould still use a decorator on thos funcitons
18:07:12 mriedem sean-k-mooney: i'd rather not use a decorator on those
18:07:17 aspiers yes, so decorate nova.compute.api.API and handle the new exception in nova.api.openstack.compute.migrate_server
18:07:19 mriedem the decorator for wsgi stuff is really about wsgi
18:07:27 sean-k-mooney ok
18:07:32 mriedem the compute API methods already have decorators that do sniff tests
18:07:37 mriedem like task_state, is locked, etc
18:07:42 aspiers yeah I was copying those
18:07:59 aspiers now we just have to spend 3 hours bikeshedding the new exception name
18:08:12 sean-k-mooney aspiers: or just add a method to hardware.py that raise the correct excption
18:08:24 sean-k-mooney then jsut call it in all the palces you need too
18:08:35 aspiers hardware.py doesn't know what operation is being done
18:08:37 sean-k-mooney most of the exception in hardware.py inherit form the http ones
18:09:04 sean-k-mooney yes but you can call it form the api and pass in the oppertion if its needed
18:09:23 aspiers that feels like mixing up layers to me
18:09:42 aspiers I think I have enough hints to get it done now, thanks guys
18:09:59 sean-k-mooney not sure i helped much
18:10:10 mriedem stephenfin: ok, -1 :)
18:10:14 aspiers sean-k-mooney: ;-)
18:13:07 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Public method to retrieve custom resources https://review.opendev.org/676029
18:13:07 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
18:13:08 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Update provider tree with new custom resources https://review.opendev.org/676522
18:13:49 sean-k-mooney dansmith: artom: so live migration form (master) src node to (artoms code) dest node with unpinned or pinned rpc
18:14:02 sean-k-mooney appears to work the same as if we pin to the old rpc version
18:14:05 sean-k-mooney e.g. no xml updates
18:15:03 sean-k-mooney and you can live migrate it back too
18:16:34 mriedem here it comes
18:17:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
18:17:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
18:17:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
18:17:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
18:17:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
18:17:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
18:17:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
18:17:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
18:17:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
18:17:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
18:17:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
18:17:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
18:17:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
18:17:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
18:17:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
18:17:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012
18:17:54 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.opendev.org/637070
18:17:54 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058
18:19:22 sean-k-mooney while its on the dest node with the invalid pinning we get the message we expect in the update resouce providers http://paste.openstack.org/show/770652/ whic is the same behavior as master today
18:21:40 sean-k-mooney dansmith: artom im going to lie down and take some panadol and hopefully my headache will go away. let me know if i need to test anything else and i will do it tomorrow
18:22:00 dansmith sean-k-mooney: cool, thanks for these confirmations...
18:22:35 donnyd sean-k-mooney: using 2x the ceph defaults to start
18:22:40 donnyd we will see how it goes
18:22:50 sean-k-mooney 2x?
18:23:14 dansmith was that intended for me?
18:23:54 melwitt probably
18:24:47 sean-k-mooney oh the rbd defualt chunk size
18:24:57 sean-k-mooney ya that was for dan
18:25:10 mriedem artom: can this be abandoned now? https://review.opendev.org/#/c/634605/
18:25:14 mriedem your series is kind of hard to follow in gerrit
18:25:22 mriedem especially when the topic branch no longer matches the bp name
18:25:47 artom mriedem, done
18:25:55 sean-k-mooney i think this is the new topic branch https://review.opendev.org/#/q/topic:bp/numa-aware-live-migration-patch27+(status:open+OR+status:merged)
18:25:56 artom mriedem, wtf, where did '-patch27' come from?
18:26:10 artom sean-k-mooney, for your tests?
18:26:12 mriedem artom: guessing you were doing some weird local feature branch rebasing
18:26:19 sean-k-mooney no
18:26:28 artom I didn't do it intentionally
18:26:43 sean-k-mooney i mean that sames to be what most of the new ones are tagged with
18:26:48 mriedem is anything using this? https://review.opendev.org/#/c/679319/
18:27:12 sean-k-mooney this is the last patch https://review.opendev.org/#/c/672595/
18:27:26 artom mriedem, nope, abandon away
18:27:29 sean-k-mooney so that is the 7 pathces theat matter
18:27:55 sean-k-mooney i guess 6 pathces.
18:28:06 mriedem and https://review.opendev.org/#/c/679656/ is the thing testing it?
18:28:13 melwitt I've been wondering what happened to the automatic topic naming in gerrit. it was nice when it used to do that
18:28:22 mriedem which is...on a different topic branch
18:28:24 mriedem so hard to find...
18:28:42 sean-k-mooney mriedem: feel free to change it
18:28:59 dansmith melwitt: that is a function of git-review I think
18:29:43 melwitt hm, I didn't think I had changed git-review versions. I will check that
18:29:43 mriedem https://review.opendev.org/#/q/topic:bp/numa-aware-live-migration+(status:open+OR+status:merged)+project:openstack/nova
18:29:47 mriedem looking better
18:30:27 dansmith melwitt: see the -t section, which says "if not specified, a bug number from the commit summary will be used" https://linux.die.net/man/1/git-review
18:30:39 melwitt thank you
18:31:00 mriedem is that only if you're on the master branch?
18:31:05 mriedem i'm always in a topic branch
18:31:11 artom mriedem, cleaned it up a bit, sorry for the mess
18:31:33 dansmith mriedem: no
18:31:42 dansmith mriedem: bug takes precedence, otherwise local branch name
18:31:52 dansmith I never submit from the master branch locally..
18:31:52 melwitt I'm not sure what happened but in the past, I never had to worry about my random topic branch name getting pushed to gerrit (as long as I have a bug or bp) but lately I noticed it's not adjusting it anymore
18:32:26 mriedem same, ok i guess i just didn't notice since i'm always using bug/xxx or bp/xxx
18:33:22 sean-k-mooney it will still take the topic if you do git checkout -b whatever
18:33:36 dansmith sean-k-mooney: only if there is no other tag in the commit message
18:33:55 sean-k-mooney a recent version of git-review removed some of the auto topic stuff
18:33:55 dansmith sean-k-mooney: go lie down :)

Earlier   Later