| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-30 | |||
| 10:58:13 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 10:59:10 | sean-k-mooney | the reproduce is basicaly boot a qemu l2 gues with kvm enabled in a l1 guest where the host is intel x86 | |
| 10:59:35 | sean-k-mooney | it picks up support for vmx in the l1 guest but enable svm in the l2 guest | |
| 10:59:49 | donnyd | sean-k-mooney: is the numa thing working | |
| 10:59:51 | sean-k-mooney | i have seen other similar case for other instruction too | |
| 11:00:00 | sean-k-mooney | donnyd: havent tried it yet | |
| 11:00:06 | donnyd | oh ok | |
| 11:00:11 | sean-k-mooney | but im 99% sure it will | |
| 11:00:27 | sean-k-mooney | you have configured the flavor more or less how i do for dev | |
| 11:02:38 | stephenfin | kashyap: Is the secure boot spec punted til U? | |
| 11:02:42 | stephenfin | *to | |
| 11:02:50 | stephenfin | (i.e. https://review.opendev.org/#/c/506720/) | |
| 11:03:33 | kashyap | stephenfin: No, it's not. It's the CPU APIs spec that's punted to U | |
| 11:03:54 | kashyap | SB spec aiming for Train, still. I'm optimistic like that | |
| 11:05:28 | openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | |
| 11:21:20 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | |
| 11:27:42 | openstackgerrit | Merged openstack/nova master: Add functional test for AggregateMultiTenancyIsolation + migrate https://review.opendev.org/571265 | |
| 11:56:32 | openstackgerrit | Adam Spiers proposed openstack/nova master: libvirt/host.py: remove unnecessary temporary variable https://review.opendev.org/679340 | |
| 11:57:05 | openstackgerrit | Adam Spiers proposed openstack/nova master: libvirt/host.py: remove unnecessary temporary variable https://review.opendev.org/679340 | |
| 11:57:21 | openstackgerrit | Adam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely https://review.opendev.org/679339 | |
| 12:15:52 | openstackgerrit | sean mooney proposed openstack/nova master: make config drives sticky bug 1835822 https://review.opendev.org/669738 | |
| 12:15:53 | openstackgerrit | sean mooney proposed openstack/nova master: Whether to use config drive depends on instance.configdrive https://review.opendev.org/485930 | |
| 12:15:53 | openstack | bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney) | |
| 12:16:19 | sean-k-mooney | ... i forgot to update the commit message | |
| 12:16:33 | sean-k-mooney | actully no never mind i di | |
| 12:16:41 | sean-k-mooney | didnt need too | |
| 12:19:10 | lyarwood | urgh, stupid question time. I'm using functional.libvirt.base.ServersTestBase and mocking calls to nova.virt.libvirt.host.Host.get_connection but my functional test is still barfing http://paste.openstack.org/show/767633/ | |
| 12:19:27 | sean-k-mooney | yep | |
| 12:19:41 | sean-k-mooney | so that does not work proably | |
| 12:19:50 | sean-k-mooney | you have to use _host i think | |
| 12:20:04 | sean-k-mooney | its sometimes works proably and sometiems does not dependin on your other mocking | |
| 12:21:36 | lyarwood | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1595962.py - yeah I'm basically following the approach taken in here | |
| 12:22:05 | lyarwood | but using https://github.com/openstack/nova/blob/744615559eb575bb0cf0a5ddc91acf255ebc3825/nova/tests/functional/libvirt/base.py#L30-L93 as the base class | |
| 12:22:44 | lyarwood | aaaaaaah that's already mocking it in setup | |
| 12:22:47 | lyarwood | my bad | |
| 12:23:19 | sean-k-mooney | this | |
| 12:23:21 | sean-k-mooney | self.useFixture(fixtures.MonkeyPatch( | |
| 12:23:23 | sean-k-mooney | 'nova.virt.libvirt.host.libvirt', | |
| 12:23:25 | sean-k-mooney | fakelibvirt)) | |
| 12:24:02 | sean-k-mooney | when you do | |
| 12:24:03 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1595962.py#L41 | |
| 12:24:17 | lyarwood | No, lower | |
| 12:24:23 | lyarwood | # Mock the 'get_connection' function, as we're going to need to provide | |
| 12:24:24 | lyarwood | # custom capabilities for each test | |
| 12:24:26 | lyarwood | _p = mock.patch('nova.virt.libvirt.host.Host.get_connection') | |
| 12:24:28 | lyarwood | self.mock_conn = _p.start() | |
| 12:24:30 | lyarwood | self.addCleanup(_p.stop) | |
| 12:25:29 | sean-k-mooney | i dont see that in the file you linked but sounds like you have figured it out | |
| 12:27:04 | lyarwood | sean-k-mooney: sorry that's in the base class I'm using in the second link | |
| 12:27:12 | lyarwood | sean-k-mooney: and yeah it's working now | |
| 12:41:22 | openstackgerrit | François Palin proposed openstack/nova master: Add retry when attachment_delete or terminate_connection fails https://review.opendev.org/669674 | |
| 12:45:21 | openstackgerrit | sean mooney proposed openstack/nova master: fix lxml compatibility issues https://review.opendev.org/678964 | |
| 12:45:58 | sean-k-mooney | prometheanfire: efried ^ now using self.assertXmlEqual | |
| 12:46:17 | aspiers | sean-k-mooney: \o/ | |
| 12:46:31 | aspiers | glad I invested some time into that function | |
| 12:46:45 | sean-k-mooney | i was doing it the old way | |
| 12:46:54 | sean-k-mooney | then erric remided me it existited | |
| 12:47:24 | sean-k-mooney | i dont know why testtoold decied that matches shoudl return nothing for sucess | |
| 12:47:44 | sean-k-mooney | but i hate that api so im glad we have a wrapper | |
| 12:48:33 | sean-k-mooney | prometheanfire: actully we need to invert the depends on relationship | |
| 12:48:51 | sean-k-mooney | your upperconstaits bump needs to depend on the nova change | |
| 12:49:22 | openstackgerrit | sean mooney proposed openstack/nova master: fix lxml compatibility issues https://review.opendev.org/678964 | |
| 12:49:27 | efried | sean-k-mooney: +2, thank you | |
| 12:49:51 | sean-k-mooney | efried: hehe care to +2 again | |
| 12:49:51 | efried | race condition | |
| 12:49:54 | efried | done | |
| 12:49:59 | sean-k-mooney | thanks | |
| 12:50:09 | sean-k-mooney | prometheanfire: do you mind if i update your patch to depend on mine | |
| 12:50:13 | efried | since you were updating the commit message, you could have s/XMLMatcher/assertXmlEqaual/ | |
| 12:50:23 | efried | but technically still true, so meh | |
| 12:50:31 | sean-k-mooney | oh i can if you want | |
| 12:50:34 | efried | nah | |
| 12:50:37 | sean-k-mooney | ok | |
| 12:51:58 | luyao | dansmith: Are you around? | |
| 12:56:21 | mriedem | luyao: he's out today | |
| 12:58:12 | luyao | mriedem: okey, thanks for telling me this | |
| 12:58:51 | sean-k-mooney | mriedem: i finally got around to updating https://review.opendev.org/#/c/669738/. the functional tests are now in there own module as you asked. sorry for the delay. | |
| 12:59:03 | gibi | mriedem: hi! thanks for the reviews on the nova-grenade-multinode patches. It seems that GRENADE_PHASE var is not defined even in a grenade job. but GRENADE_NEW_BRANCH is, so I'm pushing a new patch set soon | |
| 12:59:10 | sean-k-mooney | oh i added a shelve/unshelve test too | |
| 12:59:49 | mriedem | gibi: hmm, when i looked at the job results yesterday i thought i looked for that, but can't remember the details now | |
| 13:00:23 | gibi | mriedem: here is a run with env dumped https://b8c08d7c14d41636ca2c-db936121e3703832159c63a0fb95ab4b.ssl.cf5.rackcdn.com/679210/5/check/nova-grenade-multinode/2489dbd/job-output.txt | |
| 13:00:35 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | |
| 13:00:54 | mriedem | gibi: GRENADE_(NEW|OLD)_BRANCH should work yeah, we've used that before https://github.com/openstack/nova/blob/stable/pike/nova/tests/live_migration/hooks/run_tests.sh#L52 | |
| 13:00:58 | luyao | mriedem: Welcome to review this patch series if you would like, I'll appreciate that. Current design is NOT virt driver specific. https://review.opendev.org/#/q/topic:bp/virtual-persistent-memory+(status:open) | |
| 13:02:08 | mriedem | gibi: ok you're going to drop that env dump yeah? | |
| 13:02:10 | mriedem | that's just WIP? | |
| 13:02:25 | gibi | mriedem: yes, I just noticed it | |
| 13:02:31 | gibi | mriedem: new PS is coming | |
| 13:02:56 | mriedem | luyao: i'll be honest with you, that series is likely not something i'm going to be focusing on in the next 2 weeks to feature freeze, i'm already committed to reviewing some other series that have been around longer | |
| 13:03:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | |
| 13:03:38 | mriedem | sean-k-mooney: btw, totally unrelated, i realize our docs for AggregateInstanceExtraSpecsFilter kind of suck https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html?highlight=aggregate_instance_extra_specs#aggregateinstanceextraspecsfilter | |
| 13:04:00 | mriedem | meaning, what the hell is aggregate_instance_extra_specs supposed to mean to a user trying to configure flavors or aggregates for that filter? | |
| 13:04:10 | mriedem | looking at the code it doesn't even really make sense to me | |
| 13:04:35 | sean-k-mooney | i know i hate that filter and tried to replaces it | |
| 13:04:59 | mriedem | should at least have an example of how to use it | |
| 13:05:08 | mriedem | it came up while triaging this bug https://bugs.launchpad.net/nova/+bug/1841932 | |
| 13:05:08 | sean-k-mooney | yes | |
| 13:05:09 | openstack | Launchpad bug 1841932 in OpenStack Compute (nova) "hide_hypervisor_id extra_specs in nova flavor cannot pass AggregateInstanceExtraSpecsFilter" [Undecided,Incomplete] | |
| 13:05:20 | sean-k-mooney | i can proably add one if you want | |
| 13:05:49 | luyao | mriedem: Yes, I fully understand you, but any comments are welcome, even small and short. :) | |