| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-29 | |||
| 15:15:45 | efried | sorry, yeat | |
| 15:15:47 | efried | yeah | |
| 15:16:09 | efried | dustinc is hopefully polishing those up later today. | |
| 15:22:43 | mriedem | efried: yeah i can get back on that one | |
| 15:22:50 | efried | thanks mriedem | |
| 15:30:40 | mriedem | efried: i'm going to push a novaclient release request so that we can get https://review.opendev.org/#/c/665336/ in for train | |
| 15:30:47 | mriedem | we'll likely have another novaclient release at FF | |
| 15:31:06 | efried | mriedem: ack | |
| 15:32:09 | dustinc | efried, stephenfin: my plan is to work on the series more today, I gave it a shot late last night but it didn’t seem to work as expected and I was too tired to keep at it. | |
| 15:32:28 | efried | dustinc: I've got a -1 on the node.list one coming, in case you haven't started yet | |
| 15:33:14 | stephenfin | bauzas: btw https://review.opendev.org/#/c/679273/ | |
| 15:34:27 | efried | dustinc: done, lmk if that doesn't make sense. | |
| 15:46:07 | dustinc | Thanks efried I’ll check it out in a bit. Out at an appt now. | |
| 15:55:19 | artom | stephenfin, sean-k-mooney, sanity check a thing for me. Context is fitting hugepages: https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L632-L658 | |
| 15:55:43 | artom | If the host only has 1 size of pages available (ex: only 2048), that avail_pagesize[:-1] will end up with an empty list | |
| 15:55:45 | artom | And the fail | |
| 15:55:49 | artom | *And then | |
| 15:55:57 | artom | Is that a realistic scenario in the real world? | |
| 15:56:02 | sean-k-mooney | that wont happen. | |
| 15:56:07 | artom | I'm hitting this in func tests, wondering if I'm doing something wrong | |
| 15:56:37 | sean-k-mooney | if you have 1 item in the list [0] == [-1] | |
| 15:57:01 | artom | [] | |
| 15:57:01 | artom | >>> [1][:-1] | |
| 15:57:05 | sean-k-mooney | and [:-1] will b the empty list | |
| 15:57:22 | artom | Yeah, which makes https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L647 a problem | |
| 15:57:46 | sean-k-mooney | lets talk about this later | |
| 15:57:58 | artom | OK? | |
| 15:58:01 | stephenfin | artom: but [1][-1:] | |
| 15:58:07 | stephenfin | [1] | |
| 15:58:23 | stephenfin | [1][:-1] is only used for large pages | |
| 15:58:24 | sean-k-mooney | trying to listen to matt | |
| 15:58:28 | stephenfin | a host won't have only large pages | |
| 15:58:35 | sean-k-mooney | correct | |
| 15:58:40 | artom | stephenfin, that'll only get hit if inst_cell.pagesize == MEMPAGES_SMALL | |
| 15:58:53 | sean-k-mooney | the kernel cannoth run with only hugepages | |
| 15:58:59 | artom | stephenfin, aha, so in the real world, you can't have only 2048 size pages | |
| 15:59:08 | stephenfin | correct | |
| 15:59:19 | stephenfin | there have to be 4k pages | |
| 15:59:21 | artom | stephenfin, gotcha, thanks | |
| 15:59:25 | stephenfin | on x86(_64) anyway | |
| 15:59:33 | sean-k-mooney | if you did they would be the native page size on the system | |
| 15:59:34 | artom | Right, in retrospect, when you put it that way, it seems kinda obvious | |
| 15:59:36 | stephenfin | I don't know what pagesizes are on other platforms | |
| 15:59:37 | sean-k-mooney | not a hugepage | |
| 15:59:49 | sean-k-mooney | ntataive page size can be bigger then 4k | |
| 16:00:03 | artom | So I need to setup my fake hostinfo accordingly | |
| 16:00:27 | sean-k-mooney | mem_size small menas that you get teh smallest pageszie on the host | |
| 16:00:36 | sean-k-mooney | so if the only one is 2048 then that what you get | |
| 16:06:02 | bauzas | calling it a day | |
| 16:06:15 | bauzas | stephenfin: I'm a mean guy https://review.opendev.org/#/c/679273/1 | |
| 16:06:59 | bauzas | no, seriously, I'm torn but I feel from an operators perspective that 'upgrades' is better. That said, that would in theory leave us having some kind of nova-manage stuff to do | |
| 16:07:11 | bauzas | nova-status, my bad | |
| 16:07:19 | stephenfin | I was also on the fence | |
| 16:07:28 | stephenfin | I can do upgrades | |
| 16:07:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for I491eb7abe1405b27c552cdef142c688a46e914f2 https://review.opendev.org/679273 | |
| 16:07:58 | stephenfin | bauzas: ^ | |
| 16:08:49 | openstackgerrit | Merged openstack/nova master: trivial: Rename 'nova.tests.unit.test_nova_manage' https://review.opendev.org/679095 | |
| 16:10:04 | bauzas | stephenfin: https://docs.openstack.org/nova/latest/contributor/releasenotes.html#when-a-release-note-is-needed makes me torn | |
| 16:10:13 | bauzas | (and that's actually me who wrote this) | |
| 16:10:58 | stephenfin | I'm not planning to backport this fix though | |
| 16:11:07 | stephenfin | so upgrade impact does make sense | |
| 16:19:45 | artom | Hrmm, is the conductor/scheduler code for live migration host selection even set up to handle the case of no host being found? | |
| 16:20:00 | mriedem | yes | |
| 16:20:58 | mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L439 | |
| 16:21:00 | artom | OK, then I'm doing something wrong | |
| 16:21:48 | artom | Oh, wait, are func tests using cast as call? | |
| 16:21:53 | artom | So it gets bubbled up to the API? | |
| 16:25:11 | aspiers | stephenfin: can I raise exception.FlavorImageConflict from within ResourceRequest? | |
| 16:25:44 | stephenfin | Probably not | |
| 16:25:52 | stephenfin | You don't _need_ it though, right? | |
| 16:25:55 | aspiers | Yes I do | |
| 16:26:01 | aspiers | Otherwise the conflict isn't handled correctly | |
| 16:26:05 | stephenfin | Per the "this happens in the API already" conversation? | |
| 16:26:14 | stephenfin | or am I mixing things up? | |
| 16:26:19 | aspiers | Oh I see | |
| 16:26:32 | aspiers | Hrm I guess :-/ | |
| 16:27:29 | stephenfin | It'll be raised if the API check didn't work for some reason, right? | |
| 16:27:33 | aspiers | Yes | |
| 16:27:46 | stephenfin | Cool. I wouldn't try handling it | |
| 16:27:48 | stephenfin | Let things die | |
| 16:27:49 | aspiers | OK | |
| 16:28:01 | stephenfin | Something's wrong. People should know | |
| 16:28:04 | aspiers | Right | |
| 16:28:19 | stephenfin | Sweet | |
| 18:01:45 | openstackgerrit | Merged openstack/nova stable/rocky: rt: only map compute node if we created it https://review.opendev.org/676280 | |
| 18:01:52 | openstackgerrit | Merged openstack/nova stable/rocky: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676513 | |
| 18:01:54 | openstack | bug 1839560 in OpenStack Compute (nova) rocky "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | |
| 18:15:41 | mriedem | artom: ideally any new functional tests for your stuff won't use the CastAsCall fixture | |
| 18:15:51 | mriedem | b/c it makes things unrealistic for how the user would experience the API | |
| 18:19:28 | mriedem | efried: https://review.opendev.org/#/c/679251/ is good now | |
| 18:22:12 | openstackgerrit | Merged openstack/nova stable/rocky: Restore soft-deleted compute node with same uuid https://review.opendev.org/676514 | |
| 18:23:09 | sean-k-mooney | by the way i dont know if people say my commnet on patchset 20 last night | |
| 18:23:28 | sean-k-mooney | https://review.opendev.org/#/c/672595/21 | |
| 18:23:30 | artom | sean-k-mooney, the test results? | |
| 18:23:34 | sean-k-mooney | yep | |
| 18:23:46 | artom | The executive summary would be "woot", correct? | |
| 18:23:54 | sean-k-mooney | yes | |
| 18:24:00 | artom | Woot! | |
| 18:24:06 | sean-k-mooney | it seamed to work as intended | |
| 18:24:35 | sean-k-mooney | i am currently redeployting ot test a different patch | |