| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-29 | |||
| 14:04:56 | mriedem | professional debugging | |
| 14:05:07 | artom | So it's just my func test then :( | |
| 14:05:31 | bauzas | stephenfin: previously, we were only reporting a total VCPUs | |
| 14:05:41 | bauzas | stephenfin: now, we're about to report both VCPU and PCPU | |
| 14:05:51 | bauzas | based on the flags use | |
| 14:06:10 | stephenfin | bauzas: So if I'm understanding you correctly... | |
| 14:06:13 | stephenfin | Previously: | |
| 14:06:36 | stephenfin | no CPU-related configuration -> report all host CPUs (online and offline) as VCPU | |
| 14:06:53 | stephenfin | 'vcpu_pin_set' -> report all host CPUs listed in this option as VCPU | |
| 14:06:54 | bauzas | correct | |
| 14:07:12 | stephenfin | (and there's a check to make sure everything listed in 'vcpu_pin_set' is online) | |
| 14:07:15 | sean-k-mooney | stephenfin: vcpu_pin_set requried all cpus to be online | |
| 14:07:23 | mriedem | damn melwitt is out today and tomorrow | |
| 14:07:26 | sean-k-mooney | if it they were not you could not start the agent | |
| 14:07:29 | bauzas | and dansmith too | |
| 14:07:33 | stephenfin | sean-k-mooney: Ooof, beaten to the punch ;) | |
| 14:07:34 | bauzas | mriedem: ^ | |
| 14:07:46 | mriedem | dan is out tomorrow | |
| 14:07:49 | stephenfin | After: | |
| 14:07:51 | mriedem | i thought anyway | |
| 14:07:55 | sean-k-mooney | stephenfin: :) | |
| 14:08:12 | bauzas | gosh, those people taking perpetual PTOs... | |
| 14:08:12 | stephenfin | no CPU-related configuration -> report all *online* host CPUs as VCPU | |
| 14:08:30 | spatel | sean-k-mooney: ^^ | |
| 14:08:37 | spatel | I need your 5 min | |
| 14:08:51 | bauzas | stephenfin: so, this is a non-breaking change for no CPU-related config, I agree | |
| 14:09:02 | stephenfin | (we now only report the online ones since it was a bug to report offline ones) | |
| 14:09:10 | stephenfin | 'vcpu_pin_set' -> report all host CPUs listed in this option as VCPU | |
| 14:09:11 | bauzas | I agree | |
| 14:09:20 | bauzas | stephenfin: that said, a reno file would be good | |
| 14:09:27 | stephenfin | I thought I had one? | |
| 14:09:53 | stephenfin | https://review.opendev.org/#/c/671793/16/releasenotes/notes/cpu-resources-d4e6a0c12681fa87.yaml ? | |
| 14:10:00 | mriedem | lyarwood: while you're doing stable reviews, can you hit this rocky regression? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/rocky+topic:bug/1839560 | |
| 14:10:04 | bauzas | stephenfin: sorry, I meant some notes saying we now only report 'active' CPUs | |
| 14:10:10 | stephenfin | ohh, yeah | |
| 14:10:14 | sean-k-mooney | spatel: im just getting back from lunch was about to make coffee whats the issue? | |
| 14:10:34 | stephenfin | bauzas: alex_xu and I discussed that earlier. I said I'd add a follow-up reno, yeah | |
| 14:10:34 | bauzas | anyway, back to the interesting case | |
| 14:10:45 | stephenfin | Was considering making it a bug but we're not going to backport this so meh | |
| 14:10:47 | bauzas | cool then, just adding a comment while we speak on it | |
| 14:10:49 | stephenfin | *filing a bug | |
| 14:10:53 | stephenfin | ack | |
| 14:12:05 | bauzas | anyway, back to the case where people were playing with vcpu_pin_set and they were getting VCPUs | |
| 14:12:16 | bauzas | now, we're deprecating this option | |
| 14:12:20 | artom | mriedem, addressed your feedback in https://review.opendev.org/#/c/635669/ btw, Zuul failure doesn't look related, despite being in the live migration job | |
| 14:12:44 | bauzas | stephenfin: deprecating it is good and that's what we agreed, but we should still report VCPUs, am I right? | |
| 14:12:53 | mriedem | artom: have you looked into why https://review.opendev.org/#/c/678887/13 is failing? | |
| 14:13:06 | Roamer` | mriedem, thanks for the +2 on the StorPool volume driver's native I/O change. Is there a chance it might get a +W too, or should I bother somebody else, or is it too late in the release cycle or something? it's a practically no-risk change (well, okay, obviously you'd have to trust us on that :)) | |
| 14:13:22 | mriedem | Roamer`: takes 2 +2s so you have to find someone else | |
| 14:13:29 | Roamer` | mriedem, thanks | |
| 14:13:38 | spatel | sean-k-mooney: I have VM-1 now i want to build VM-2 on other compute nodes and want to do IP takeover | |
| 14:13:40 | mriedem | another core please see https://review.opendev.org/#/c/676172/ | |
| 14:13:42 | stephenfin | bauzas: Yup, nothing changes from a placement perspective until you unset vcpu_pin_set and set cpu_dedicated_set or cpu_shared_set | |
| 14:13:44 | sean-k-mooney | bauzas: this bit has chagned in the last few days. if you set it we planned to report both vCPUs and pCPUs | |
| 14:13:51 | lyarwood | mriedem: ack will take a look now | |
| 14:13:52 | artom | mriedem, not yet, looking now | |
| 14:14:04 | bauzas | sean-k-mooney: that would have been a bug then | |
| 14:14:11 | Roamer` | so, yeah, anybody up for reviewing a trivial "add io=native to the StorPool volume driver" change? :) https://review.opendev.org/#/c/676172/ | |
| 14:14:14 | sean-k-mooney | bauzas: what would | |
| 14:14:19 | spatel | I have tried to create fix-ip with neutron but its not letting me do that because of policy issue. | |
| 14:14:24 | bauzas | sean-k-mooney: given people were using vcpu_pin_set for pinning, we should stick with only VCPU in this case | |
| 14:14:40 | sean-k-mooney | bauzas: no that breaks upgrades | |
| 14:14:50 | bauzas | gosh | |
| 14:15:09 | sean-k-mooney | vcpu_pin_set defines the set of host cpu that can be used for pinned or floating vms | |
| 14:15:11 | mriedem | stephenfin: i never saw any operator replies to "More upgrade issues with PCPUs - input wanted" - i wonder if you should re-post that but tag with [nova] ? | |
| 14:15:17 | bauzas | sean-k-mooney: what breaks upgrades is having less VCPU between two releases with exact same config options | |
| 14:15:27 | stephenfin | sean-k-mooney: I think you're getting mixed up here | |
| 14:15:30 | mriedem | people, including myself, filter non-tagged things into a general folder and might have missed it b/c of all the noise | |
| 14:15:45 | stephenfin | mriedem: Good call. I need to reply with my resolution for that anyway | |
| 14:15:52 | artom | <domain type='qemu'> | |
| 14:15:52 | artom | mriedem, aha | |
| 14:15:56 | bauzas | sean-k-mooney: upgrading to Train with no config change should stick with exact same reporting | |
| 14:16:00 | artom | libvirtError: Requested operation is not valid: cpu affinity is not supported | |
| 14:16:07 | sean-k-mooney | bauzas: yes | |
| 14:16:10 | artom | So looks like the virt_type=kvm config didn't take | |
| 14:16:12 | stephenfin | sean-k-mooney, bauzas: While 'vcpu_pin_set' is configured, we continue to *only* report VCPU | |
| 14:16:12 | sean-k-mooney | well no | |
| 14:16:15 | sean-k-mooney | it should not | |
| 14:16:17 | sean-k-mooney | and cannot | |
| 14:16:23 | stephenfin | and the exact same amount of them as before | |
| 14:16:30 | mriedem | artom: virt_type=kvm on the controller node https://zuul.opendev.org/t/openstack/build/095bd2d0dff74761a946c29ac69b607a/log/logs/etc/nova/nova-cpu.conf.txt.gz | |
| 14:16:31 | sean-k-mooney | you did not need to define vcpu_pin_set to use pinning | |
| 14:16:31 | bauzas | but we're deprecating it, so we're cool | |
| 14:16:44 | ivve | hey, is there any way to change chipset for kvm/qemu instances from default PIIX3 into ICH9 ? would that be done in nova.conf? | |
| 14:16:51 | mriedem | artom: it's the subnode that is misconfigured https://zuul.opendev.org/t/openstack/build/095bd2d0dff74761a946c29ac69b607a/log/logs/subnode-2/etc/nova/nova-cpu.conf.txt.gz | |
| 14:16:54 | stephenfin | We will only report PCPU if you set '[compute] cpu_dedicated_set' | |
| 14:16:55 | mriedem | still has virt_type=qemu | |
| 14:17:01 | bauzas | stephenfin: excellent then | |
| 14:17:06 | bauzas | stephenfin: re-reading https://review.opendev.org/#/c/671793/16/nova/virt/libvirt/driver.py | |
| 14:17:27 | sean-k-mooney | stephenfin: and we will have the global config to contol the schdluer translation right | |
| 14:17:41 | stephenfin | sean-k-mooney: Yup, that's here https://review.opendev.org/#/c/671801/32/nova/conf/workarounds.py | |
| 14:17:58 | artom | mriedem, I guess line 1 of https://review.opendev.org/#/c/678887/13/playbooks/legacy/nova-live-migration/run.yaml is at fault | |
| 14:18:33 | mriedem | artom: why? | |
| 14:18:35 | sean-k-mooney | that needs to be set to true | |
| 14:18:49 | artom | mriedem, I'm assuming "primary" just means the controller | |
| 14:19:01 | stephenfin | sean-k-mooney: This is the important thing that has changed https://review.opendev.org/#/c/671800/22/nova/virt/libvirt/driver.py@6649 | |
| 14:19:01 | sean-k-mooney | stephenfin: we have to have the transaltion disabeld by default | |
| 14:19:36 | mriedem | artom: oh that line 1 - hosts: primary yeah | |
| 14:19:40 | mriedem | sec, i'm going to take the easy route | |
| 14:19:57 | artom | mriedem, you're handling it? OK, I'll stay off then | |