| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-29 | |||
| 12:20:55 | alex_xu | stephenfin: sean-k-mooney yea, it is behavior change, but agree with that, it is bug | |
| 12:21:22 | kashyap | sean-k-mooney: Might ping for some inputs / another set of eyes along the way. :-) | |
| 12:24:49 | sean-k-mooney | alex_xu: it really depends on how we got the cores before. nproc for example by defualt only reports the online core i belive | |
| 12:25:06 | sean-k-mooney | so it may not be a behavior change if the api we are calling in libvirt does the same | |
| 12:25:10 | sean-k-mooney | but i suspect it is | |
| 12:25:24 | sean-k-mooney | a behavior change | |
| 12:25:28 | alex_xu | ah, right | |
| 12:26:03 | alex_xu | but whatever, I can't think of people want to disable cpu also | |
| 12:26:59 | sean-k-mooney | well they might in the future for reasons. cough speed select cough | |
| 12:27:11 | alex_xu | hah | |
| 12:27:22 | sean-k-mooney | but we would want such feature to work with nova not against it | |
| 12:27:23 | alex_xu | no, it isn't disable, it is about you can see or not | |
| 12:27:42 | alex_xu | right | |
| 12:27:47 | stephenfin | sean-k-mooney: I thought I'd got that already. Sure, let me get it | |
| 12:28:53 | stephenfin | alex_xu: If you'd like, I can split that change out into its own fix so we can maybe backport it (though it's low priority) | |
| 12:29:14 | stephenfin | I think we should have a release note too, just in case | |
| 12:29:27 | alex_xu | stephenfin: I'm ok with it now, since agree with that it is corner case. maybe release note is enough | |
| 12:29:28 | stephenfin | I'll tack both on at the end and move them in if/when I need to rebase | |
| 12:29:38 | stephenfin | cool, reno it is | |
| 12:29:41 | alex_xu | cool | |
| 12:30:13 | alex_xu | I also didn't found any problem with https://review.opendev.org/#/c/671800/22, I think what i need is test now | |
| 12:30:57 | stephenfin | alex_xu: There are quite a few functional tests but they're at the end of the series https://review.opendev.org/#/c/671801 | |
| 12:31:26 | alex_xu | cool, I need to check it out | |
| 12:31:30 | stephenfin | I think sean-k-mooney is planning to test manually too. I was hoping to do the same myself but I've been prioritizing reviews | |
| 12:32:12 | stephenfin | Oh, and Bhagyashri Shewale (NTT) has been testing it for me. I should get them to leave comments if it works as expected | |
| 12:32:21 | alex_xu | stephenfin: the first test I want to do is resize | |
| 12:32:35 | stephenfin | Oh, I bet I don't have one for that | |
| 12:32:51 | stephenfin | I can put that together later this afternoon though | |
| 12:32:52 | alex_xu | \o/ | |
| 12:34:04 | sean-k-mooney | stephenfin: test which PCPUs in placment | |
| 12:34:07 | sean-k-mooney | or something else | |
| 12:34:12 | stephenfin | yarp | |
| 12:34:17 | sean-k-mooney | ah yes | |
| 12:34:39 | sean-k-mooney | i plan to test that preferably with artroms and gibis stuff too | |
| 12:34:57 | sean-k-mooney | so hopfully some of this will start merging to make that simpelre to do | |
| 12:35:18 | sean-k-mooney | when you think its a good time to test it let me know and ill test it standalone | |
| 12:36:49 | stephenfin | sean-k-mooney: I think it's good to go now, tbh | |
| 12:37:55 | sean-k-mooney | ok are there specific things you would like me to test | |
| 12:38:10 | stephenfin | Yup, if you give me five I can put together a list of test cases for things that I think should be covered | |
| 12:38:37 | sean-k-mooney | cool add it to an etherpad | |
| 12:39:00 | sean-k-mooney | i can then run through it add updated it with my results | |
| 12:39:04 | alex_xu | I guess resize is just won't be trigger between old and new, since there is no PCPU on old node. | |
| 12:39:44 | stephenfin | Yeah, a resize from a host reporting PCPU to one reporting VCPU won't be possible since it won't get past the scheduler | |
| 12:39:56 | sean-k-mooney | well that depends | |
| 12:40:08 | sean-k-mooney | if you resize form pinned to non pinned it woudl be | |
| 12:40:15 | stephenfin | Good point, actually | |
| 12:40:36 | sean-k-mooney | a cold migrate would not be | |
| 12:40:38 | alex_xu | oh | |
| 12:41:30 | stephenfin | We have functional coverage for cold migrate (for the NUMA-aware vSwitches feature) already but not resize. Should be easy enough add | |
| 12:41:58 | sean-k-mooney | ya its the same test just with two flavors instead of 1 | |
| 12:42:17 | sean-k-mooney | well kind of | |
| 12:45:32 | alex_xu | anyway, i want to end today early. see you guys tomorrow~ | |
| 12:45:45 | stephenfin | o/ | |
| 12:53:25 | openstackgerrit | Merged openstack/nova stable/stein: Delete unused get_all_host_states method https://review.opendev.org/676255 | |
| 12:53:37 | stephenfin | sean-k-mooney: https://etherpad.openstack.org/p/nova-cpu-resources | |
| 13:01:00 | sean-k-mooney | cool ill try and find time to do that proably on tuesday but ill see if i can get to it sooner. | |
| 13:01:21 | sean-k-mooney | stephenfin: do you want me to test on real hardware or vms | |
| 13:01:31 | stephenfin | VMs should be fine, right? | |
| 13:01:40 | stephenfin | there's nothing hardware specific about this | |
| 13:02:05 | sean-k-mooney | ok if i dont need to use the hardware im using to test artoms stuff that makes it simpler to test | |
| 13:15:23 | openstackgerrit | Merged openstack/nova stable/stein: Convert HostMapping.cells to a dict https://review.opendev.org/676256 | |
| 13:15:30 | openstackgerrit | Merged openstack/nova stable/stein: Cache host to cell mapping in HostManager https://review.opendev.org/676257 | |
| 13:15:38 | openstackgerrit | Merged openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825 | |
| 13:17:52 | openstackgerrit | Kobi Samoray proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247 | |
| 13:21:27 | efried | stephenfin: you around? I keep trying to context-switch in before asking you these questions, but it's always too late by then. So I'm going to be a bit off the cuff here... | |
| 13:21:38 | stephenfin | I am | |
| 13:21:40 | stephenfin | go for it | |
| 13:21:49 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 13:21:49 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 13:21:50 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 13:21:50 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | |
| 13:23:03 | efried | stephenfin: okay: Am I crazy or do I remember somewhere in the cpu-resources series where you are making a design decision based on the assumption that operators are supposed to be segregating their dedicated instances from their shared instances? | |
| 13:23:21 | stephenfin | that was there but it's gone now | |
| 13:24:23 | efried | okay, cause my next question was going to be: ...but post- the feature, you *can* put shared and dedicated instances on the same host, right? | |
| 13:24:33 | efried | ...just not shared & dedicated on the same *guest*. | |
| 13:24:33 | stephenfin | correct | |
| 13:24:37 | stephenfin | yup | |
| 13:24:58 | efried | cool. Cause otherwise... not much point configuring both shared & dedicated set, eh? :P | |
| 13:25:02 | efried | okay, next thing... | |
| 13:26:20 | efried | (in -oslo) | |
| 13:30:21 | mriedem | dansmith: i've updated this prep resize at dest cross-cell patch to remove some of the unused stuff and cleanup the commit/docstrings https://review.opendev.org/#/c/633293/46 - i'm still not really sold on munging this into the existing prep_resize and tried to explain why in the commit and docstring on the method if that helps | |
| 13:31:18 | mriedem | i of course can if it's going to be a blocker, i think it would mean changing prep_resize to consider if migration.cross_cell_move is True and if so, don't reschedule and don't cast to resize_instance on the source | |
| 13:34:23 | bauzas | efried: I think we stated a lot of implications between shared and pinned instances in the spec | |
| 13:35:58 | efried | bauzas: Yeah, I just got a poke from elsewhere that made me remember seeing that assumption/limitation in the code somewhere and I was like "wha...?" | |
| 13:36:20 | bauzas | efried: I'd recommend you to open the spec while you review the cpu-resources series | |
| 13:36:29 | bauzas | that and take some aspirin | |
| 13:36:47 | bauzas | I've started reviewing it but I'm not yet able to sharpen my pen | |
| 13:36:50 | efried | yes, I have it (the in-flight edited version) open. | |
| 13:37:24 | efried | I've been thrashing like a 386 running minecraft though, been reviewing like three patches every other day. | |
| 13:42:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move live_migration test hooks under gate/ https://review.opendev.org/679251 | |
| 13:44:28 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode https://review.opendev.org/678841 | |
| 13:44:40 | openstackgerrit | Merged openstack/nova master: Docs and functional test for max_local_block_devices https://review.opendev.org/678268 | |
| 13:44:56 | openstackgerrit | Merged openstack/nova master: Add a "Caveats" section to the eventlet profiling docs https://review.opendev.org/676672 | |
| 13:45:05 | openstackgerrit | Merged openstack/nova master: docs: pretty up return code table or heal_allocations https://review.opendev.org/678063 | |
| 13:45:18 | openstackgerrit | Merged openstack/nova master: doc: pretty up return code table for sync_aggregates https://review.opendev.org/678064 | |
| 13:46:59 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210 | |
| 13:47:38 | Sundar | mriedem: Re. the comment in https://etherpad.openstack.org/p/nova-runways-train that tests are failing on Cyborg patches, as of now, they are few and seem unrelated to the code. Even back then, there was really only 1 failure related to the patches. What can we do to get reviews on these patches? | |
| 13:49:48 | openstackgerrit | Merged openstack/nova master: rbd: use MAX_AVAIL stat for reporting bytes available https://review.opendev.org/556692 | |
| 13:52:09 | openstackgerrit | Merged openstack/nova master: Switch some GitHub URLs to point to opendev.org https://review.opendev.org/677185 | |
| 13:52:17 | openstackgerrit | Merged openstack/nova stable/stein: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/675714 | |