Posted	Nick	Remark
#openstack-nova - 2019-08-27
00:16:06	sean-k-mooney	it was an automatic rebase against master
00:16:09	sean-k-mooney	no conflicts
00:16:24	sean-k-mooney	so just commit and rebase against master and push
00:16:30	sean-k-mooney	artom: ^
00:16:40	artom	sean-k-mooney, ack, thanks
00:18:41	sean-k-mooney	also something is broken with hw:mem_page_size=small. i get an error about pagesize changeing when i try to migrate when i set that.
00:18:58	sean-k-mooney	not sure if that is related to your changes or not
00:52:42	artom	sean-k-mooney, do the 2 hosts have different page sizes?
00:52:58	artom	(Or it could be a legit bug with that code, as it's new)
00:59:30	artom	Oh snap, rollback works
00:59:35	artom	*actually* works
01:00:01	artom	If I don't drop the move claim on the dest (comment that bit out), the test fails with the expected pinning assertion
01:01:16	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669
01:01:17	openstackgerrit	Artom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims https://review.opendev.org/634828
01:01:17	openstackgerrit	Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
01:01:18	openstackgerrit	Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
01:01:18	openstackgerrit	Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229
01:01:19	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
01:01:19	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
01:35:00	openstackgerrit	Merged openstack/nova master: [Trivial]Remove unused helper get_vif_devname_with_prefix https://review.opendev.org/678136
02:30:39	openstackgerrit	Merged openstack/nova stable/stein: rt: only map compute node if we created it https://review.opendev.org/676278
02:30:46	openstackgerrit	Merged openstack/nova stable/stein: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676507
02:30:47	openstack	bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem)
02:30:53	openstackgerrit	Merged openstack/nova stable/stein: Restore soft-deleted compute node with same uuid https://review.opendev.org/676509
03:47:27	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
03:47:27	openstackgerrit	Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
03:47:28	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
04:35:50	openstackgerrit	Merged openstack/nova master: [Trivial]Remove unused helper _get_min_service_version https://review.opendev.org/678446
05:10:48	openstackgerrit	Dustin Cowles proposed openstack/nova master: WIP: Load the custom resource providers to resource tracker https://review.opendev.org/676522
06:22:07	openstackgerrit	melanie witt proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.opendev.org/507486
06:22:08	openstackgerrit	melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840
08:29:36	aspiers	kashyap: welcome back
08:36:58	aspiers	kashyap: hope you had a good time!
08:37:33	kashyap	Partly, yes. And partly it was a "responsibility trip" :-)
08:41:36	openstackgerrit	zhangyujun proposed openstack/nova master: Should not raise when restore power on failed https://review.opendev.org/624854
09:05:37	licanwei	#join #airshipit
09:34:25	aspiers	sean-k-mooney: let me know if I can help with bp/image-metadata-prefiltering
09:34:40	aspiers	sean-k-mooney: that's not me being generous, you're just ahead of me on the runway ;-)
09:35:00	aspiers	looks like there are some CI failures, maybe I could fix those
09:44:24	openstackgerrit	Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447
09:44:25	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
09:44:25	openstackgerrit	Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448
09:44:26	openstackgerrit	Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450
09:44:26	openstackgerrit	Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451
09:44:27	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453
09:44:27	openstackgerrit	Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452
09:44:28	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
09:44:28	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454
09:44:29	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470
09:44:29	openstackgerrit	Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
10:02:05	openstackgerrit	mathieu bultel proposed openstack/nova master: Return security groups by name https://review.opendev.org/678776
10:18:19	aspiers	bauzas: I was just looking at fixing some of the issues in sean-k-mooney's patch you just reviewed https://review.opendev.org/#/c/666914/
10:18:32	bauzas	cool
10:18:50	aspiers	although I'm not sure if I'd be treading on his toes
10:19:01	bauzas	well, sean is there :)
10:19:12	aspiers	https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/logs_14/666914/11/check/openstack-tox-py27/ee133dd/testr_results.html.gz shows an ordering error which is probably the dict.values issue you mention
10:19:19	aspiers	only on py27 not py3
10:19:34	aspiers	I'm not sure if he's around today
10:20:39	sean-k-mooney	bauzas: yep i know values change between py27 and py3X
10:20:50	sean-k-mooney	i normally would use six.iteritems
10:21:03	sean-k-mooney	but aspiers and stephenfin prefer that i dont
10:21:11	openstackgerrit	Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190
10:21:18	aspiers	sean-k-mooney: I don't personally care but it seems that everyone else does
10:21:28	bauzas	why so ?
10:21:37	sean-k-mooney	aspiers: i dont like use writing slow code by default
10:21:58	bauzas	wait, six.itervalues() isn't exactly slow
10:22:14	sean-k-mooney	no thats what i prefer to use
10:22:16	sean-k-mooney	for values
10:22:22	sean-k-mooney	or iteritems for items
10:22:23	stephenfin	I only care insofar as it generally doesn't make any difference and I'd rather one less 'six' thing to clean up when we move to Python 3 only
10:22:38	sean-k-mooney	stephenfin: in aggreate it does
10:22:46	bauzas	https://github.com/benjaminp/six/blob/master/six.py#L584
10:23:02	stephenfin	on python 2, yes
10:23:04	bauzas	that's what does six.itervalues
10:23:05	aspiers	I'm with stephenfin on this. The majority of cases we are talking about involve like 3 elements
10:23:15	stephenfin	but OSP 16 will be deployed with Python 3 (RHEL 8)
10:23:15	bauzas	stephenfin: of course
10:23:22	aspiers	so the cost of cleaning up six stuff is higher than the performance hit
10:23:29	stephenfin	I suspect SUSE and Canonical will be doing something similar
10:23:31	stephenfin	Yeah, that ^
10:23:46	sean-k-mooney	aspiers: yes but if we ever packport the code we pay that cost for years
10:23:50	bauzas	technically we support py2 for a while
10:23:52	sean-k-mooney	hell if we dont we still do
10:24:01	bauzas	and the "we" is about the upstream code
10:24:03	aspiers	if there are exceptions with like 10000 element dicts then fine we can make an exception for those
10:24:08	sean-k-mooney	we have people only finally moving to queens
10:24:14	stephenfin	bauzas: Correct. But no distro is packaging it that I'm aware of
10:24:22	sean-k-mooney	we will have people on py27 downstream until 2023
10:24:33	stephenfin	sean-k-mooney: There's no performance impact either, right? It's a memory impact
10:24:39	stephenfin	Not for new code
10:24:40	bauzas	stephenfin: sure but then that's not a good reason for not supporting py27 :)
10:24:55	sean-k-mooney	stephenfin: no its slower to use .items or .values on py27 too
10:24:58	bauzas	anyway
10:25:01	aspiers	this is a classic bikeshed discussion X-D
10:25:05	stephenfin	no, but it is a good reason to make an already mostly unnecessary thing even more unnecessary
10:25:08	bauzas	aspiers: this
10:25:11	stephenfin	I want blue.
10:25:13	sean-k-mooney	we are making a copy of all the values and construction an new list
10:25:21	bauzas	stephenfin: i want snow
10:25:25	aspiers	stephenfin: you can have any blue, as long as it's black

Earlier   Later