| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-26 | |||
| 09:34:36 | sean-k-mooney | thinking about that a bit more i think that is only with alembic but still better to avoid it | |
| 09:34:53 | kashyap | aspiers: Hey, just catching up with changes post PTO. Will respond once I finish processing The Pile. | |
| 09:35:03 | kashyap | s/changes/patches/ | |
| 09:35:37 | alex_xu | sean-k-mooney: yea, agree with you | |
| 09:41:16 | sean-k-mooney | stephenfin: ah yes it is extras https://opendev.org/openstack/devstack/src/branch/master/inc/python#L419 | |
| 09:43:59 | luyao | sean-k-mooney, alex_xu: Get it.! I will add a patch to remove vpmems column first. Thank you. | |
| 09:44:44 | alex_xu | luyao: you needn't a separate patch remove vpmem column, you can have new script do the remove and add new resource column sametime | |
| 09:49:07 | sean-k-mooney | luyao: basicaly dont update the migration script that added the vpmem column, just add another to remvoe it and add the resources column | |
| 09:57:39 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 09:59:01 | bhagyashris__ | stephenfin: Hi, I just address review comments that you have given on patch https://review.opendev.org/#/c/674895/17 related to functional test and uploaded it for community review | |
| 10:00:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: requirements: Move DB dependencies to 'extras' https://review.opendev.org/677475 | |
| 10:00:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969 | |
| 10:01:32 | stephenfin | bhagyashris__: That's failing pretty hard at the moment, it seems? | |
| 10:02:00 | stephenfin | Is there more patches expected? | |
| 10:02:05 | stephenfin | *are | |
| 10:03:17 | bhagyashris__ | stephenfin: I saw the functional test cases are failing because of change in dependent patches , I haven't yet checked where it's failing so are you going to check that point or should I? | |
| 10:03:30 | stephenfin | It's late for you, right? I can do it if so | |
| 10:03:35 | stephenfin | I need to fix the base patch anyway | |
| 10:04:09 | bhagyashris__ | stephenfin: I just confirming because most of the time we reworked on same point | |
| 10:05:12 | luyao | sean-k-mooney, alex_xu: 'migration script' you mean is the files under nova/db/sqlalchemy/migrate_repo/versions/ right? | |
| 10:05:18 | bhagyashris__ | Yeah it's almost EOD here but I can do it by tomorrow | |
| 10:05:36 | bhagyashris__ | stephenfin: if you are ok ? | |
| 10:05:43 | stephenfin | Yup, I can do it | |
| 10:05:50 | stephenfin | Oh, sorry | |
| 10:05:54 | stephenfin | Yeah, tomorrow is good | |
| 10:06:05 | stephenfin | I'll work on fixing that other patch though, since I broke it | |
| 10:06:12 | stephenfin | and leave the last one to you | |
| 10:08:28 | bhagyashris__ | stephenfin: okay. Just reconfirming -> you will fix the main issue and after that I will continuously working on patch https://review.opendev.org/#/c/674895/17 to fix the functional test after your changes . | |
| 10:08:36 | bhagyashris__ | stephenfin: right? | |
| 10:08:42 | stephenfin | sure | |
| 10:09:05 | bhagyashris__ | stephenfin: ok Thank you :) | |
| 10:14:58 | sean-k-mooney | stephenfin: so i just did a thing and it worked | |
| 10:16:16 | sean-k-mooney | stephenfin: i finally tested my theory about nested pcie passthough. and yes you can do it if you add an iommu to the l1 guest and tweak the pcie layout so that the device is in a seperate iommu group | |
| 10:45:54 | bhagyashris__ | melwitt, mriedem, efrid, alex_xu: Requet you to review https://review.opendev.org/#/c/612626/ . | |
| 11:24:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 11:24:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729 | |
| 11:24:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 11:59:02 | shilpasd | stephenfin: need discussion related to python3-train patch for masakari-monitors https://review.opendev.org/#/c/669387/ for py27/py36 and py37, here observed 'import libvirt' is an issue | |
| 11:59:26 | shilpasd | stephenfin: can you pl give me some pointers to resolve this | |
| 12:39:41 | openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448 | |
| 12:39:41 | openstackgerrit | Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447 | |
| 12:39:42 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450 | |
| 12:39:42 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | |
| 12:39:43 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | |
| 12:39:43 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451 | |
| 12:39:44 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | |
| 12:39:44 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453 | |
| 12:39:45 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | |
| 12:39:45 | openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | |
| 12:39:46 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | |
| 14:20:36 | efried | mriedem, melwitt, dansmith: Could I please get eyes on https://review.opendev.org/#/c/678237/ to unwedge u-c https://review.opendev.org/#/c/678207/ | |
| 14:21:19 | mriedem | " We get to stop doing this soon, I promise." fool me once, shame on you, fool me twice... | |
| 14:21:38 | efried | but mordred *also* promises | |
| 14:22:19 | sean-k-mooney | did we "fix" something like this recently | |
| 14:22:27 | efried | sean-k-mooney: you mean https://review.opendev.org/#/c/676495/ ? | |
| 14:22:40 | sean-k-mooney | yes | |
| 14:22:43 | efried | You mean, every time we release a new sdk we have to re-fix our fixture that stubs out something private in sdk? Yes. | |
| 14:22:58 | efried | the long term solution is to not stub out private sdk stuff. | |
| 14:23:05 | mordred | srrsly | |
| 14:23:12 | mordred | yes | |
| 14:23:13 | efried | sdk is going to expose a fixture that we can simply import and use | |
| 14:23:15 | sean-k-mooney | yep seams like what we should be doing | |
| 14:23:20 | mordred | the sdk is going to give you the happy fixture | |
| 14:23:22 | mordred | and you will use that | |
| 14:23:25 | mordred | and it will be tested in the sdk | |
| 14:23:29 | mordred | so we won't break you | |
| 14:23:36 | efried | right, and then as they change internals, they'll change the fixture, and we'll automatically "keep up". | |
| 14:23:48 | mriedem | i might as well just fast approve this | |
| 14:23:55 | mriedem | it's test only and holding up the u-c change | |
| 14:24:05 | efried | yes, the u-c patch proves it works | |
| 14:24:12 | efried | and the nova patch proves it still works at 0.34.0 | |
| 14:24:12 | sean-k-mooney | efried: we try to do that with plamcent but we have been broken with the placement fixture in the past | |
| 14:24:24 | efried | sure, but less likely | |
| 14:24:39 | sean-k-mooney | we will need to similarly pull the sdk out of requirements and install it spereatly in tox right | |
| 14:24:48 | sean-k-mooney | e.g. to consume it form master? | |
| 14:24:51 | efried | eh? Why would we need to do that? | |
| 14:25:02 | sean-k-mooney | the same reason we do it for the placement fixture | |
| 14:25:13 | efried | oh, no, tracking against real releases should be fine. | |
| 14:25:22 | sean-k-mooney | ok | |
| 14:25:34 | sean-k-mooney | i guess for placement we do it to get eraly acess to features | |
| 14:25:34 | efried | When we've needed to pre-test a feature, we twiddle the project list in .zuul.yaml | |
| 14:25:50 | efried | yes, which is actually probably not necessary anymore | |
| 14:25:55 | efried | actually probably not advisable. | |
| 14:26:01 | efried | we should bring that up with cdent when he gets back. | |
| 14:26:04 | sean-k-mooney | yes the second one | |
| 14:26:07 | efried | (which I thought was today, but I guess not) | |
| 14:26:22 | sean-k-mooney | i think it is still nessacary for some feature but we have a backlog of feature to catch up on | |
| 14:26:40 | openstackgerrit | Merged openstack/nova master: Document archive_deleted_rows return codes https://review.opendev.org/677819 | |
| 14:27:03 | efried | sean-k-mooney: I actually don't remember the last time we did something in nova that *needed* to track against unreleased placement. | |
| 14:27:35 | sean-k-mooney | well all of the nested stuff would have needed it if we did that this cycle. | |
| 14:27:35 | efried | and iiuc having it set up this way allows us to do things like... merge a nova feature before placement is released accordingly, thereby breaking nova (cf. the aforementioned fixture issue). | |
| 14:27:43 | efried | yeah, but we can just release placement | |
| 14:27:50 | efried | releases are pretty cheap. | |
| 14:28:18 | sean-k-mooney | maybe. i guess depends on is really the way to test this stuff | |
| 14:29:15 | efried | right, I'm saying, I'm not sure there's a good reason for us to have placement in required projects by default. | |
| 14:29:40 | sean-k-mooney | i wasnt refering to required proejcts specifcally | |
| 14:30:05 | efried | that's how we end up with nova running against master placement in the gate, nah? | |
| 14:30:40 | mriedem | you need placement in required projects in the gate jobs b/c it's a service not a library | |
| 14:30:55 | mriedem | if you want to freeze the fixture or something, yo'ud need to make it a library i think | |
| 14:31:17 | openstackgerrit | Merged openstack/nova master: Change nova-manage unexpected error return code to 255 https://review.opendev.org/677832 | |