Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-26
07:09:33 kashyap Starts processing The Pile(tm).
07:12:18 gibi bauzas: the bottom of the support-move-ops-with-qos-ports in here https://review.opendev.org/#/c/655110 mriedem has votes on the firt couple of patches. The current top of the series has the full support for cold migrate (and possibly resize)
07:12:38 gibi bauzas: I appreciate any reviews :)
07:13:27 lpetrut Hi, a quick question about failed live migrations: should the instances end up in error state even if the rollback is successful? this behavior was introduced by https://github.com/openstack/nova/blob/62f6a0a1bc6c4b24621e1c2e927177f99501bef3/nova/compute/manager.py#L6813-L6820 a couple of years ago.
07:13:31 lpetrut looks like the libvirt driver won't raise an exception when the instance is recovered: https://github.com/openstack/nova/blob/62f6a0a1bc6c4b24621e1c2e927177f99501bef3/nova/virt/libvirt/driver.py#L8080-L8086
07:13:34 lpetrut I'm thinking about doing the same with the Hyper-V driver: avoid propagating migration exceptions if the instance is recovered.
07:20:04 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Follow up for microversion 2.75 https://review.opendev.org/678473
07:20:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
07:20:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
07:20:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
07:21:45 lpetrut although the admin may just reset the state, not setting the instance to error state makes it clear that no further steps are required in order to fully recover the instance, reducing the amount of time required for debugging
07:27:49 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113
07:27:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
07:32:32 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140
07:34:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972
07:37:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
07:37:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
07:41:39 openstackgerrit Akihiro Motoki proposed openstack/nova master: PDF documentation build https://review.opendev.org/676730
07:44:39 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
07:52:32 openstackgerrit Lucian Petrut proposed openstack/nova master: Avoid error state for recovered instances after failed migrations https://review.opendev.org/678481
07:55:41 openstackgerrit Lucian Petrut proposed openstack/nova master: Avoid error state for recovered instances after failed migrations https://review.opendev.org/678481
08:37:14 openstackgerrit Lucian Petrut proposed openstack/nova master: Avoid error state for recovered instances after failed migrations https://review.opendev.org/678481
09:16:53 stephenfin sean-k-mooney: https://review.opendev.org/678497
09:21:27 sean-k-mooney im not sure how setup_develop works but will that pass mysql as an extra or just install an addtional package via pip
09:27:32 alex_xu sean-k-mooney: stephenfin we can't revert a db migraton script, right? we should add new script to revert the upgrade for the old one, is that correct?
09:27:59 sean-k-mooney alex_xu: we should not do a revert in general
09:28:10 sean-k-mooney are you asking for the pmem column
09:28:14 alex_xu sean-k-mooney: yes
09:28:29 alex_xu and we already have another upgrade script after vpmem
09:28:32 sean-k-mooney just add a new migration that drops the column and adds the devices column
09:28:47 alex_xu got it
09:29:45 sean-k-mooney if we had made a release it would be a bit different as we would have had to do an online migration to move the data
09:29:54 alex_xu luyao: ^, this doesn't sound right https://review.opendev.org/#/c/678447/2/nova/db/sqlalchemy/migrate_repo/versions/398_add_resources.py
09:30:19 sean-k-mooney but since i doubt anywone has master deploy with vpmem in production it should be fine to drop and replace
09:30:26 alex_xu yea, so good we aren't such late
09:31:04 alex_xu yes, in the past, we should take care about that. but for now, just not ensure whether we should keep that policy
09:33:10 sean-k-mooney i think the probme with just changing the new colum name woudl be it might mess up sqlachemys migration logic? or maybe im thinking about alembic. one of those compute a hash of the migration to generate a unic version number for the db
09:33:53 sean-k-mooney so i think beyond the fact it would not fix any db that had run the old migration it could break other migrations.
09:34:10 alex_xu yes, I think so
09:34:20 alex_xu then you have to manually tune the migration version
09:34:36 sean-k-mooney thinking about that a bit more i think that is only with alembic but still better to avoid it
09:34:53 kashyap aspiers: Hey, just catching up with changes post PTO. Will respond once I finish processing The Pile.
09:35:03 kashyap s/changes/patches/
09:35:37 alex_xu sean-k-mooney: yea, agree with you
09:41:16 sean-k-mooney stephenfin: ah yes it is extras https://opendev.org/openstack/devstack/src/branch/master/inc/python#L419
09:43:59 luyao sean-k-mooney, alex_xu: Get it.! I will add a patch to remove vpmems column first. Thank you.
09:44:44 alex_xu luyao: you needn't a separate patch remove vpmem column, you can have new script do the remove and add new resource column sametime
09:49:07 sean-k-mooney luyao: basicaly dont update the migration script that added the vpmem column, just add another to remvoe it and add the resources column
09:57:39 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
09:59:01 bhagyashris__ stephenfin: Hi, I just address review comments that you have given on patch https://review.opendev.org/#/c/674895/17 related to functional test and uploaded it for community review
10:00:27 openstackgerrit Stephen Finucane proposed openstack/nova master: requirements: Move DB dependencies to 'extras' https://review.opendev.org/677475
10:00:27 openstackgerrit Stephen Finucane proposed openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969
10:01:32 stephenfin bhagyashris__: That's failing pretty hard at the moment, it seems?
10:02:00 stephenfin Is there more patches expected?
10:02:05 stephenfin *are
10:03:17 bhagyashris__ stephenfin: I saw the functional test cases are failing because of change in dependent patches , I haven't yet checked where it's failing so are you going to check that point or should I?
10:03:30 stephenfin It's late for you, right? I can do it if so
10:03:35 stephenfin I need to fix the base patch anyway
10:04:09 bhagyashris__ stephenfin: I just confirming because most of the time we reworked on same point
10:05:12 luyao sean-k-mooney, alex_xu: 'migration script' you mean is the files under nova/db/sqlalchemy/migrate_repo/versions/ right?
10:05:18 bhagyashris__ Yeah it's almost EOD here but I can do it by tomorrow
10:05:36 bhagyashris__ stephenfin: if you are ok ?
10:05:43 stephenfin Yup, I can do it
10:05:50 stephenfin Oh, sorry
10:05:54 stephenfin Yeah, tomorrow is good
10:06:05 stephenfin I'll work on fixing that other patch though, since I broke it
10:06:12 stephenfin and leave the last one to you
10:08:28 bhagyashris__ stephenfin: okay. Just reconfirming -> you will fix the main issue and after that I will continuously working on patch https://review.opendev.org/#/c/674895/17 to fix the functional test after your changes .
10:08:36 bhagyashris__ stephenfin: right?
10:08:42 stephenfin sure
10:09:05 bhagyashris__ stephenfin: ok Thank you :)
10:14:58 sean-k-mooney stephenfin: so i just did a thing and it worked
10:16:16 sean-k-mooney stephenfin: i finally tested my theory about nested pcie passthough. and yes you can do it if you add an iommu to the l1 guest and tweak the pcie layout so that the device is in a seperate iommu group
10:45:54 bhagyashris__ melwitt, mriedem, efrid, alex_xu: Requet you to review https://review.opendev.org/#/c/612626/ .
11:24:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
11:24:47 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
11:24:47 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
11:59:02 shilpasd stephenfin: need discussion related to python3-train patch for masakari-monitors https://review.opendev.org/#/c/669387/ for py27/py36 and py37, here observed 'import libvirt' is an issue
11:59:26 shilpasd stephenfin: can you pl give me some pointers to resolve this
12:39:41 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448
12:39:41 openstackgerrit Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447
12:39:42 openstackgerrit Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450
12:39:42 openstackgerrit Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
12:39:43 openstackgerrit Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452
12:39:43 openstackgerrit Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451
12:39:44 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454
12:39:44 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453
12:39:45 openstackgerrit Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
12:39:45 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
12:39:46 openstackgerrit Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470
14:20:36 efried mriedem, melwitt, dansmith: Could I please get eyes on https://review.opendev.org/#/c/678237/ to unwedge u-c https://review.opendev.org/#/c/678207/
14:21:19 mriedem " We get to stop doing this soon, I promise." fool me once, shame on you, fool me twice...
14:21:38 efried but mordred *also* promises
14:22:19 sean-k-mooney did we "fix" something like this recently
14:22:27 efried sean-k-mooney: you mean https://review.opendev.org/#/c/676495/ ?
14:22:40 sean-k-mooney yes
14:22:43 efried You mean, every time we release a new sdk we have to re-fix our fixture that stubs out something private in sdk? Yes.
14:22:58 efried the long term solution is to not stub out private sdk stuff.
14:23:05 mordred srrsly
14:23:12 mordred yes

Earlier   Later