Posted	Nick	Remark
#openstack-nova - 2019-08-25
22:03:53	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673
22:07:10	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676
22:07:24	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689
22:07:45	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709
22:08:03	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
#openstack-nova - 2019-08-26
00:16:05	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
02:00:32	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused helper get_vm_ref_from_name https://review.opendev.org/678444
02:15:12	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused helper _get_min_service_version https://review.opendev.org/678446
02:38:06	openstackgerrit	ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299
02:38:06	openstackgerrit	ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298
02:38:07	openstackgerrit	ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300
03:00:16	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336
03:00:17	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414
03:00:17	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894
03:00:18	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
03:00:18	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338
03:00:19	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
03:00:19	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
03:00:20	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
03:00:20	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
03:00:20	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
03:00:21	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
03:00:21	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
03:00:22	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
03:10:39	cervigni	is there anyone online now that can help with VGPU scheduling?
03:25:40	openstackgerrit	Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447
03:25:41	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
03:25:41	openstackgerrit	Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448
03:25:42	openstackgerrit	Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451
03:25:42	openstackgerrit	Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450
03:25:43	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453
03:25:43	openstackgerrit	Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452
03:25:44	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
03:25:44	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454
03:25:45	openstackgerrit	Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
05:40:56	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused helper _get_min_service_version https://review.opendev.org/678446
05:49:16	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused helper get_vm_ref_from_name https://review.opendev.org/678444
05:56:36	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove descriptions of nonexistent hacking rules https://review.opendev.org/678462
06:45:21	openstackgerrit	Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447
06:45:22	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
06:45:22	openstackgerrit	Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448
06:45:23	openstackgerrit	Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451
06:45:23	openstackgerrit	Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450
06:45:24	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453
06:45:24	openstackgerrit	Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452
06:45:25	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
06:45:25	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454
06:45:26	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470
06:45:26	openstackgerrit	Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
07:04:08	bauzas	good morning Nova
07:04:15	gibi	good mornin bauzas
07:04:23	gibi	welcome back
07:04:25	alex_xu	good morning gibi bauzas
07:04:27	bauzas	thanks
07:04:30	gibi	hi alex_xu
07:05:21	bauzas	gibi: good morning
07:05:46	bauzas	gibi: I'll slowly catch up this morning but in case any reviews for your series (which I have no crazy idea of the status yet), you can ping me
07:06:05	bauzas	I haven't forgotten train-3 is soon :)
07:09:33	kashyap	Starts processing The Pile(tm).
07:12:18	gibi	bauzas: the bottom of the support-move-ops-with-qos-ports in here https://review.opendev.org/#/c/655110 mriedem has votes on the firt couple of patches. The current top of the series has the full support for cold migrate (and possibly resize)
07:12:38	gibi	bauzas: I appreciate any reviews :)
07:13:27	lpetrut	Hi, a quick question about failed live migrations: should the instances end up in error state even if the rollback is successful? this behavior was introduced by https://github.com/openstack/nova/blob/62f6a0a1bc6c4b24621e1c2e927177f99501bef3/nova/compute/manager.py#L6813-L6820 a couple of years ago.
07:13:31	lpetrut	looks like the libvirt driver won't raise an exception when the instance is recovered: https://github.com/openstack/nova/blob/62f6a0a1bc6c4b24621e1c2e927177f99501bef3/nova/virt/libvirt/driver.py#L8080-L8086
07:13:34	lpetrut	I'm thinking about doing the same with the Hyper-V driver: avoid propagating migration exceptions if the instance is recovered.
07:20:04	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Follow up for microversion 2.75 https://review.opendev.org/678473
07:20:37	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
07:20:37	openstackgerrit	Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
07:20:38	openstackgerrit	Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
07:21:45	lpetrut	although the admin may just reset the state, not setting the instance to error state makes it clear that no further steps are required in order to fully recover the instance, reducing the amount of time required for debugging
07:27:49	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113
07:27:50	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
07:32:32	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140
07:34:54	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972
07:37:16	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
07:37:17	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
07:41:39	openstackgerrit	Akihiro Motoki proposed openstack/nova master: PDF documentation build https://review.opendev.org/676730
07:44:39	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
07:52:32	openstackgerrit	Lucian Petrut proposed openstack/nova master: Avoid error state for recovered instances after failed migrations https://review.opendev.org/678481
07:55:41	openstackgerrit	Lucian Petrut proposed openstack/nova master: Avoid error state for recovered instances after failed migrations https://review.opendev.org/678481
08:37:14	openstackgerrit	Lucian Petrut proposed openstack/nova master: Avoid error state for recovered instances after failed migrations https://review.opendev.org/678481
09:16:53	stephenfin	sean-k-mooney: https://review.opendev.org/678497
09:21:27	sean-k-mooney	im not sure how setup_develop works but will that pass mysql as an extra or just install an addtional package via pip
09:27:32	alex_xu	sean-k-mooney: stephenfin we can't revert a db migraton script, right? we should add new script to revert the upgrade for the old one, is that correct?
09:27:59	sean-k-mooney	alex_xu: we should not do a revert in general
09:28:10	sean-k-mooney	are you asking for the pmem column
09:28:14	alex_xu	sean-k-mooney: yes
09:28:29	alex_xu	and we already have another upgrade script after vpmem
09:28:32	sean-k-mooney	just add a new migration that drops the column and adds the devices column
09:28:47	alex_xu	got it
09:29:45	sean-k-mooney	if we had made a release it would be a bit different as we would have had to do an online migration to move the data
09:29:54	alex_xu	luyao: ^, this doesn't sound right https://review.opendev.org/#/c/678447/2/nova/db/sqlalchemy/migrate_repo/versions/398_add_resources.py
09:30:19	sean-k-mooney	but since i doubt anywone has master deploy with vpmem in production it should be fine to drop and replace
09:30:26	alex_xu	yea, so good we aren't such late
09:31:04	alex_xu	yes, in the past, we should take care about that. but for now, just not ensure whether we should keep that policy
09:33:10	sean-k-mooney	i think the probme with just changing the new colum name woudl be it might mess up sqlachemys migration logic? or maybe im thinking about alembic. one of those compute a hash of the migration to generate a unic version number for the db
09:33:53	sean-k-mooney	so i think beyond the fact it would not fix any db that had run the old migration it could break other migrations.
09:34:10	alex_xu	yes, I think so
09:34:20	alex_xu	then you have to manually tune the migration version
09:34:36	sean-k-mooney	thinking about that a bit more i think that is only with alembic but still better to avoid it
09:34:53	kashyap	aspiers: Hey, just catching up with changes post PTO. Will respond once I finish processing The Pile.

Earlier   Later