Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-21
19:56:58 melwitt and just saw a ton of hashes
19:56:59 mriedem expand that, then click on the 'changed' box
19:57:05 melwitt thanks
19:57:09 mriedem that gives you a popup,
19:57:18 mriedem then hit the chain link icon in the top right
19:58:47 melwitt got it, thank you
20:05:46 mriedem efried: reading your reply to alex's thread, why do you say that the numa and pci fields in the instance migratoin context are hypervisor specific? as far as i know they aren't, since they are used by libvirt and i think the hyperv driver as well during moves
20:06:11 efried mriedem: then they're specific to libvirt and hyperv.
20:06:24 efried that's luck more than anything else
20:06:31 mriedem you mean because they wouldn't work for powervm or what?
20:06:43 efried yeah, that's the example that springs to my mind obviously.
20:07:34 efried also pretty n/a for ironic if I'm not mistaken.
20:07:45 mriedem ironic doesn't migrate
20:07:50 mriedem but yeah
20:08:03 efried so like, *really* n/a :P
20:08:07 mriedem those fields are only populated if the instance has numa/pci stuff
20:08:11 mriedem which baremetal instances won't have
20:08:45 efried right. And in alex_xu's new world, `resources` would only get populated if the instance has local resources to track.
20:09:22 efried Any time we just need a count, we leave that bit empty and just use the placement inventory structure.
20:15:35 mriedem yeah i haven't read the whole message yet
20:15:40 mriedem nor the etherpad
20:15:45 mriedem only what i've gathered from irc conversations
20:16:16 mriedem efried: mordred: also, this is the patch to remove [neutron]/url from the neutron nova/neutron compute install guide in favor of a KSA-tastic world https://review.opendev.org/677810
20:16:26 mriedem hopefully i didn't misrepresent in the commit message
20:19:06 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
20:22:07 efried mriedem: nicely done, +1
20:27:16 mriedem \o/
20:27:30 mriedem i know you sdk/kds/sta people are particular
20:28:34 mriedem heh, i just realized that archive_deleted_rows returns 1 meaning, we archived some stuff, keep going until you get rc=0,
20:28:43 mriedem but if the command blows up in some unexpected way, we return 1 (rather than like 255)
20:28:53 efried that's eek
20:28:54 mriedem dansmith: that seems not ideal yeah? ^
20:29:22 mriedem https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L2625
20:29:37 dansmith hmm,
20:29:42 dansmith I thought we had an error case
20:29:56 dansmith oh
20:30:02 dansmith you mean if it bubbles up to main
20:30:47 mriedem right
20:30:51 mriedem TypeError or something dumb
20:31:44 dansmith yeah
20:32:01 dansmith honestly, that "return 1" there in main probably conflicts with other things too, no?
20:32:12 dansmith 255 is a common thing for "I dunno wtf happened"
20:33:33 mriedem right, nova-status returns 255, that's what got me looking at this
20:38:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Document archive_deleted_rows return codes https://review.opendev.org/677819
20:38:48 efried dansmith: couple easy ones, if you have a sec: https://review.opendev.org/#/c/676707/ and successor?
20:40:00 dansmith mriedem: yeah I dunno what danger might lurk by changing that now, but surely seems like the right thing
20:40:10 mriedem https://bugs.launchpad.net/nova/+bug/1840978
20:40:11 openstack Launchpad bug 1840978 in OpenStack Compute (nova) "nova-manage commands with unexpected errors returning 1 conflict with expected cases of 1 for flow control" [Undecided,New]
20:40:14 mriedem yeah, just said that in the bug report,
20:40:19 mriedem i think it's just a simple upgrade reno yeah?
20:41:11 dansmith mriedem: well, more like the impact to tripleo, osa, etc
20:41:18 dansmith this potentially affects lots of manage commands
20:41:39 dansmith although this is really SHTF level fail cases, so nobody should really be depending on that
20:43:17 mriedem i counted simple_cell_setup, map_instances and heal_allocations as returning 1 in non-error cases
20:44:06 efried nobody should be relying on 1 being a real failure, because if they are, they're f'ed anyway.
20:44:21 dansmith mriedem: no, I mean cases in all the other commands that could raise
20:44:22 efried so I think this is a situation where it's okay to change it.
20:44:50 dansmith efried: that's my point, the only case would be somewhere that someone tests "is something done yet" by checking if something fails, and uses ret=1 to check
20:44:54 openstackgerrit Eric Fried proposed openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825
20:45:17 efried right, which is invalid.
20:45:21 efried I'm agreeing with you
20:45:24 efried mark your calendar
20:46:08 dansmith I don't think it's invalid
20:46:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825
20:46:32 dansmith there are probably cases where there's no other way to tell if a thing is done yet or not
20:50:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825
20:50:33 mriedem efried: just rebased on top of the change mentioned in the commit
20:50:43 efried yeah, good plan
20:51:12 efried though the warning would be gone anyway since 0.34.0 is in u-c
21:06:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Document archive_deleted_rows return codes https://review.opendev.org/677819
21:06:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Change nova-manage unexpected error return code to 255 https://review.opendev.org/677832
21:14:56 openstackgerrit James E. Blair proposed openstack/nova master: Fix issues building PDF docs https://review.opendev.org/677028
21:16:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Document map_instances return codes in table format https://review.opendev.org/677835
22:27:14 openstackgerrit Merged openstack/nova master: Deprecate Aggregate[Core|Ram|Disk]Filters https://review.opendev.org/673496
22:27:42 openstackgerrit Merged openstack/nova master: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
#openstack-nova - 2019-08-22
00:12:42 openstackgerrit melanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy https://review.opendev.org/677856
01:22:25 openstackgerrit Brin Zhang proposed openstack/nova master: Add docstring to check_availability_zone function https://review.opendev.org/677858
02:06:46 openstackgerrit melanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy https://review.opendev.org/677856
02:21:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480
05:11:23 openstackgerrit Michael Still proposed openstack/nova master: Remove zVM requirement from the top level requirements. https://review.opendev.org/677870
05:28:27 openstackgerrit Merged openstack/nova master: Fix missing rule description in HACKING.rst https://review.opendev.org/677589
07:05:57 openstackgerrit Merged openstack/nova master: Add a hacking rule for non-existent assertions https://review.opendev.org/677596
07:09:53 alex_xu efried: sean-k-mooney this doesn't sounds right https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@205, looks like we can't do the translate in request filter
07:29:33 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.opendev.org/612626
08:11:20 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
08:12:54 openstackgerrit Merged openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580
08:13:05 openstackgerrit Merged openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581
08:13:21 openstackgerrit Merged openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438
08:13:38 openstackgerrit Merged openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826
08:13:49 openstackgerrit Merged openstack/nova master: Make a failure to purge_db fail in post_test_hook.sh https://review.opendev.org/677806
08:14:00 openstackgerrit Merged openstack/nova master: Split fake host capabilities into reusable variables https://review.opendev.org/677710
08:31:33 openstackgerrit Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
08:40:12 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
08:49:42 shilpasd gibi: thanks for reviewing patches for 'isolate aggregates', will fix small nits
08:50:28 gibi shilpasd: I'm moving forward on that series right now, so you can expect more votes from me
08:51:23 shilpasd gibit: thanks
08:58:34 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:26:49 openstackgerrit Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
09:31:35 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:43:11 shilpasd gibi: https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472, we are accepting ignored_keys as [], to make function generalized, So based on 'value' one can get list of aggregates by using this function.

Earlier   Later