Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-19
20:20:26 aspiers efried: and actually there's a request for info from you on that: https://review.opendev.org/#/c/666616/23/nova/tests/unit/virt/libvirt/test_driver.py@23555
20:20:55 aspiers I guess I must have missed some magic when implementing my decorators in order to make them work on classes
20:21:52 efried mm
20:22:13 aspiers actually, now I think about it, it's kind of obvious that my patch_* code would not successfully patch classes
20:22:25 efried okay, well, it's going to take a significant context switch to get back in there, but I'll get there eventually.
20:22:43 aspiers well, unless Python has some magic which automatically applies decorators on a class to the methods within that class
20:23:01 aspiers but I suspect it doesn't
20:32:53 efried no, I suspect that's magic in mock's decorators
20:33:18 sean-k-mooney aspiers: well that depends on the decorator
20:34:21 aspiers efried: yes I suspect so too
20:50:23 openstackgerrit Merged openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536
20:50:30 openstackgerrit Merged openstack/nova master: Fix wrong assertions in unit tests https://review.opendev.org/677102
21:07:24 openstackgerrit Merged openstack/nova-specs master: Allow deep-linking to memory reservation section of AMD SEV spec https://review.opendev.org/677264
21:44:53 openstackgerrit Merged openstack/nova master: Tests: autospecs all the mock.patch usages https://review.opendev.org/470775
22:00:56 mriedem efried: so with https://review.opendev.org/#/c/674678/ we shouldn't see the warnings about things like cinder and barbican, right?
22:01:20 efried mriedem: that's correct.
22:01:25 efried I thought I checked it; are you still seeing those?
22:02:05 efried yeah, looks clean https://zuul.opendev.org/t/openstack/build/6d2b6e55df8949ad9ff19ac305de8b3e/log/logs/screen-n-cpu.txt.gz?severity=3
22:02:21 mriedem no, but i expected to see them in the functional job console log in the patch before that one in the series and don't see them either
22:02:35 efried vs https://logs.opendev.org/57/666857/6/check/nova-live-migration/a379339/logs/screen-n-cpu.txt.gz#_Aug_01_21_21_25_517957
22:02:47 efried I don't think you would see them in console log
22:02:51 efried Only in compute log
22:03:03 efried because that's the only place we're asking for a placement client from
22:03:09 efried uhm, I guess from scheduler as well
22:03:20 efried but yeah, wouldn't expect to see them in console log
22:03:43 mriedem i'd seen those in functional test runs i thought, but yeah i do see them in here https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/logs_07/676707/1/check/tempest-integrated-compute/cafd458/controller/logs/screen-n-cpu.txt.gz
22:03:49 mriedem Encountered an exception attempting to process config for project 'cinder' (service type 'block-storage'): no such option valid_interfaces in group [cinder]: oslo_config.cfg.NoSuchOptError: no such option valid_interfaces in group [cinder]
22:04:18 efried yup, that's the one.
22:04:19 mriedem but not https://c8d945454956429a3061-cc9346598d5bf68c66bcb59fd4223863.ssl.cf1.rackcdn.com/674678/4/check/tempest-integrated-compute/c72e0e2/controller/logs/screen-n-cpu.txt.gz
22:05:23 mriedem ok +2
22:05:47 efried thanks mriedem
22:05:54 efried chipping away at this sdk thing slowly but surely.
22:06:07 mriedem got sidetracked spending time writing a script to cleanup old e-r queries which i'd always just done manually before
23:29:14 openstackgerrit sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914
23:37:59 openstackgerrit Merged openstack/nova master: doc: cleanup 2.75 REST API microversion history doc https://review.opendev.org/677259
23:38:07 openstackgerrit Merged openstack/nova master: Fix use of mock.patch with new_callable=PropertyMock https://review.opendev.org/676738
23:38:22 openstackgerrit Merged openstack/nova master: api-ref: add config_drive to 2.75 rebuild response parameters https://review.opendev.org/677267
#openstack-nova - 2019-08-20
00:46:08 openstackgerrit Merged openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508
00:46:18 openstackgerrit Merged openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280
00:53:26 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.77: Support Specifying AZ to unshelve https://review.opendev.org/665136
01:08:56 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Update api-ref for 2.75 to add config_drive in server update response https://review.opendev.org/677324
02:01:07 openstackgerrit Takashi NATSUME proposed openstack/nova stable/ocata: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676295
02:23:04 openstackgerrit Takashi NATSUME proposed openstack/nova stable/stein: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677329
02:38:40 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677330
03:02:24 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677330
03:41:05 openstackgerrit Takashi NATSUME proposed openstack/nova stable/queens: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677378
03:53:30 openstackgerrit Takashi NATSUME proposed openstack/nova stable/pike: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677379
04:21:28 openstackgerrit huanhongda proposed openstack/nova master: Fix for auth during live-migration (2) https://review.opendev.org/669867
04:38:48 openstackgerrit Takashi NATSUME proposed openstack/nova stable/ocata: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677383
04:55:47 openstackgerrit Takashi NATSUME proposed openstack/nova stable/stein: Fix wrong assertions in unit tests https://review.opendev.org/677388
04:57:01 openstackgerrit Merged openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281
05:04:53 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Fix wrong assertions in unit tests https://review.opendev.org/677389
05:14:10 openstackgerrit Takashi NATSUME proposed openstack/nova stable/queens: Fix wrong assertions in unit tests https://review.opendev.org/677390
05:31:23 openstackgerrit Takashi NATSUME proposed openstack/nova stable/pike: Fix wrong assertions in unit tests https://review.opendev.org/677392
05:45:07 openstackgerrit Takashi NATSUME proposed openstack/nova stable/ocata: Fix wrong assertions in unit tests https://review.opendev.org/677393
07:01:07 openstackgerrit Ghanshyam Mann proposed openstack/python-novaclient master: Microversion 2.75 - Multiple API cleanup changes https://review.opendev.org/676275
08:56:42 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
08:57:31 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
08:57:32 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
08:57:32 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to config.py https://review.opendev.org/636318
09:00:50 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
09:13:30 sean-k-mooney ... awsome my test passes on py27 and py36 but not py37. this will be fun
09:14:32 sean-k-mooney anyone spot anything in https://review.opendev.org/#/c/666914/7/nova/tests/unit/test_utils.py@266
09:17:31 sean-k-mooney oh its the inital assert
09:17:40 sean-k-mooney self.assertEqual(utils._TRAITS_CACHE, {})
09:18:45 sean-k-mooney on python 27 and 36 applying @mock.patch.dict(utils._TRAITS_CACHE, clear=True) to the class patches it in every function but i guess its not working in py37
09:20:03 aspiers sean-k-mooney: oh that's interesting, just like what we were talking about yesterday
09:21:01 sean-k-mooney yesterday as in have the mock apply to all functions
09:21:07 sean-k-mooney in a class
09:21:22 aspiers yes
09:21:55 sean-k-mooney it might still be applying but the sematics of clear=True may have been broken but in any case it broken
09:22:27 aspiers any chance you could test https://review.opendev.org/#/c/666616/31/nova/tests/unit/virt/libvirt/test_driver.py@23813 on py37?
09:22:31 aspiers I don't have a py37 environment
09:22:47 aspiers oh wait, I do
09:23:10 sean-k-mooney adding the mock to the class was a way of sutbing out the field without needed to add a patcher and cleanup function in __init__
09:23:39 aspiers I found a way to apply a mock to all tests in a class, but efried hated it (and he was right, it's fugly)
09:23:55 aspiers https://review.opendev.org/#/c/666616/23/nova/tests/unit/virt/libvirt/test_driver.py@23555
09:24:07 aspiers but it does work at least
09:24:36 aspiers you call __enter__() during setUp() and __exit__() during tearDown()
09:24:54 aspiers brb
09:25:36 sean-k-mooney aspiers: there are cleaner ways
09:26:48 sean-k-mooney ill test it locally with my change and then ill comment on yours
09:41:40 sean-k-mooney well that is annoying my original code passes locally so i guess i need top use the gate to test this.
09:43:15 openstackgerrit sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914
10:16:55 yaawang stephenfin: Hi, can you take a look at the patch: https://review.opendev.org/#/c/670298, it's a part of spec vCPU model selection. :)
10:30:24 cervigni hello guys, I am trying to have the VGPU feature working on rhel7 but I always hit this issue
10:30:30 cervigni 460f-8994-6be8c80fe417,display=off,bus=pci.0,addr=0x6: vfio error: a0543cde-3934-460f-8994-6be8c80fe417: error getting device from group 81: Input/output error
10:30:30 cervigni 2019-08-20 18:28:10.527 17202 ERROR nova.virt.libvirt.driver [req-031bc6f7-be61-406b-aefd-020a24e76f5e d7ef7ad4b0424f78a5010503b095ae84 35d0e97603b04dadaee6dfafbd19e5f9 - default default] [instance: 9300b931-12e5-421a-a8ae-ef1854d4cb38] Failed to start libvirt guest: libvirtError: internal error: qemu unexpectedly closed the monitor: 2019-08-20T10:28:10.301572Z qemu-kvm: -device vfio-pci,id=hostdev0,sysfsdev=/sys/bus/mdev/devices/a0543cde-3934-
10:31:11 cervigni what can this be related to? I intalled the vGPU drivers, flavor is correct, vgpu is set to nvidia-106
10:31:15 sean-k-mooney have you enabled the iommu on the host
10:31:42 cervigni GRUB_CMDLINE_LINUX="crashkernel=auto spectre_v2=retpoline rd.lvm.lv=rhel/root rd.lvm.lv=rhel/swap rhgb quiet intel_iommu=on iommu=pt modprobe.blacklist=nouveau"
10:31:43 cervigni yes
10:32:18 cervigni is there anything else I should enable/disable?
10:32:26 sean-k-mooney is there a traceback in the libvirt instacne log
10:32:52 cervigni yes
10:32:53 cervigni 2019-08-20 10:28:10.318+0000: shutting down, reason=failed
10:32:53 cervigni Verify all devices in group 81 are bound to vfio-<bus> or pci-stub and not already in use
10:32:53 cervigni 2019-08-20T10:28:10.301572Z qemu-kvm: -device vfio-pci,id=hostdev0,sysfsdev=/sys/bus/mdev/devices/a0543cde-3934-460f-8994-6be8c80fe417,display=off,bus=pci.0,addr=0x6: vfio error: a0543cde-3934-460f-8994-6be8c80fe417: error getting device from group 81: Input/output error
10:33:10 sean-k-mooney ah i know what happening then
10:33:32 cervigni really?

Earlier   Later