| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-15 | |||
| 16:20:59 | mnaser | according to the review | |
| 16:20:59 | mriedem | maybe that was OVH? | |
| 16:21:08 | mnaser | Valentin Boucher <valentin.boucher@kontron.com> | |
| 16:21:22 | mriedem | ok i'm thinking ovh was checking out vgpus | |
| 16:21:28 | mriedem | but not sure how to ask, amorin ^? | |
| 16:21:32 | mnaser | valentin lives in montreal | |
| 16:21:32 | mnaser | oh look at that | |
| 16:21:34 | mriedem | *who | |
| 16:21:51 | mriedem | mnaser: i may be 'merican but i know montreal != france :) | |
| 16:21:56 | melwitt | dansmith, mriedem: what do you think about moving onto the next cell if anything fails (down cells)? on the surface, it seemed like a good idea to me but now I'm wondering if that could possibly mislead anyone by making them think archive "completed" when it didn't? | |
| 16:22:02 | mnaser | oh no i was just surprised he's a local :) | |
| 16:22:27 | mriedem | melwitt: can we avoid handling down cells in that already too big patch? | |
| 16:22:43 | melwitt | sure | |
| 16:22:52 | mriedem | e.g. leave a todo in the code where a down cell thing could be handled, which is either log and continue or fail | |
| 16:22:58 | dansmith | agree | |
| 16:23:07 | dansmith | but also, yes I think skip/warn unreachable cells | |
| 16:24:05 | melwitt | yeah, I was thinking just "except Exception" log continue | |
| 16:26:33 | mriedem | stephenfin: i'm guessing i just ruined your day with the "what about pending resizes and migration allocation consumers" thing | |
| 16:26:35 | mriedem | you're welcome | |
| 16:26:51 | stephenfin | yeah, way to bum me out | |
| 16:34:51 | mriedem | dansmith: before i address my comments in https://review.opendev.org/#/c/645611/14 do you want to make a pass? | |
| 16:35:01 | mriedem | s/do you want to/will you please/ | |
| 16:35:52 | dansmith | mriedem: I read your comments before and commented on that physical thing, are there other questions? | |
| 16:36:12 | mriedem | not questions no, | |
| 16:36:15 | dansmith | because tbh, it's fine enough for me and I'd just merge it to claim the version and then address the nits and otherthings later | |
| 16:36:22 | mriedem | but if you have comments on the diff itself, make them now before i make changes | |
| 16:36:35 | dansmith | oh are you pushing the next verison? | |
| 16:36:35 | mriedem | ok i'll start updating then | |
| 16:36:38 | mriedem | yes | |
| 16:36:40 | mriedem | surya is gone | |
| 16:36:58 | dansmith | oh, sorry, she pushed again, my bad | |
| 16:37:02 | dansmith | been distracted | |
| 16:39:15 | mriedem | efried: do you want me to respin for that unrelated change in https://review.opendev.org/#/c/675218/4 ? | |
| 16:39:36 | dansmith | mriedem: there was one legit test failure in the last run, IIRC, but I didn't look into it.. is that fixed? | |
| 16:39:46 | dansmith | otherwise, yeah, I'm fine with current plus your planned changes | |
| 16:40:07 | efried | mriedem: Might as well, it doesn't seem worth a whole fup. I'm here to re+2 it quick. | |
| 16:40:31 | mriedem | dansmith: idk, but i can test locally https://logs.opendev.org/11/645611/13/check/openstack-tox-py27/7deb014/testr_results.html.gz | |
| 16:40:51 | mriedem | efried: ack will do | |
| 16:40:55 | efried | coo | |
| 16:41:00 | dansmith | ookie | |
| 16:43:23 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Restore soft-deleted compute node with same uuid https://review.opendev.org/676514 | |
| 16:43:23 | openstack | bug 1839560 in OpenStack Compute (nova) stein "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | |
| 16:43:23 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression recreate test for bug 1839560 https://review.opendev.org/676513 | |
| 16:50:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218 | |
| 16:57:32 | artom | dansmith, mriedem, hey, you guys were the main reviewers of NUMA LM in Stein, will have bandwidth to do the same in Train, or should I be sucking up to other cores? ;) | |
| 16:57:40 | artom | *will you have | |
| 16:58:08 | dansmith | I will try | |
| 16:58:26 | artom | dansmith, ack, thanks :) | |
| 16:58:48 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | |
| 17:01:52 | mriedem | artom: not today | |
| 17:02:05 | mriedem | artom: you should also beat down the starlingx people's door, | |
| 17:02:12 | artom | mriedem, I wasn't really expecting today :) | |
| 17:02:14 | mriedem | because at the ptg and last summit they were saying this was the big ticket thing they needed | |
| 17:02:15 | artom | I meant in general | |
| 17:02:28 | mriedem | so if this is so critical for starlingx they should have people reviewing and testing it | |
| 17:02:30 | artom | mriedem, yeah, I emailed the ML, and dtroyer and Gerry personally | |
| 17:02:40 | artom | Radio silence :/ | |
| 17:03:00 | mriedem | cfriesen is probably the best starlingx person to review the series but he's been out of nova for awhile now | |
| 17:03:08 | sean-k-mooney | well that and sriov numa policies was on the list too. | |
| 17:03:25 | sean-k-mooney | i think we almost have everything this cycle? | |
| 17:03:35 | artom | Gerry Kopec (not upstream as far as I can tell, though he did leave some reviews) tested it | |
| 17:03:41 | artom | And found some problems | |
| 17:03:50 | artom | Was hoping he'd step up again | |
| 17:04:03 | artom | Radio silence so far. Which is weird, because Dean actually emailed me first | |
| 17:04:06 | artom | Asking how it was going | |
| 17:05:12 | sean-k-mooney | artom: i need to set up a second node but when im done testign a sriov thing i plan to test your numa live migration code with stephens cpu pinning stuff and my sriov migration code and report back | |
| 17:05:26 | sean-k-mooney | eta on that is sometime next week | |
| 17:06:06 | artom | sean-k-mooney, my series has conflicts with stephenfin's, so not sure how you'll test those together | |
| 17:06:12 | artom | Well, resolve manually, I suppose | |
| 17:06:33 | sean-k-mooney | ya i was thinking of doign that but if there are a lot ill test them seperatly | |
| 17:06:33 | mriedem | cpu pinning stuff == PCPU? | |
| 17:06:38 | sean-k-mooney | yes | |
| 17:06:57 | sean-k-mooney | i would also like to test gibis bandwith stuff | |
| 17:07:01 | mriedem | if it were me, i'd test artom's numa live migration stuff w/o trying to wrangle the PCPU stuff in | |
| 17:07:05 | mriedem | jesus | |
| 17:07:09 | mriedem | so yo'ud like to actually not get anything done :) | |
| 17:07:36 | sean-k-mooney | well ill test them seperatly first | |
| 17:07:45 | artom | He'll become a master at git rebasing and conflict resolution though :) | |
| 17:08:00 | sean-k-mooney | but i want to actully test those 4 features in 1 vm in train | |
| 17:08:27 | sean-k-mooney | i guess it better to wait untill some/all have merged to do that | |
| 17:09:09 | mriedem | well i applaud your efforts for at least trying to test this stuff | |
| 17:09:11 | mriedem | since no one else is | |
| 17:09:21 | mriedem | together i mean | |
| 17:09:56 | sean-k-mooney | well people will want to combine those so i want to test them before i get the bug report | |
| 17:10:10 | mriedem | don't worry, the bug report will be in 18+ months | |
| 17:10:20 | mriedem | you might not even be working on openstack at that point | |
| 17:10:33 | sean-k-mooney | ya.... if we are lucky and people deploy train by then | |
| 17:11:27 | artom | I still don't think testing them together before they're even merged is a good idea | |
| 17:11:29 | sean-k-mooney | TIL we still have at least 1 customer with a suppor exception for liberty until 2021 ... | |
| 17:11:33 | artom | Laudable, but not good ;) | |
| 17:11:49 | prometheanfire | nova still has an issue with the latest libvirt https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/logs_16/675816/5/check/cross-nova-py36/a6c71f8/testr_results.html.gz | |
| 17:11:55 | sean-k-mooney | artom: well in that case ill just test them 1 by one | |
| 17:12:06 | artom | But yeah, I totally get mriedem's gripe about the RH dev/QE lag | |
| 17:12:10 | openstackgerrit | Adam Spiers proposed openstack/nova master: Fix use of mock.patch with new_callable=PropertyMock https://review.opendev.org/676738 | |
| 17:12:52 | aspiers | efried: ^^^ hope that's right, still trying to wrap my head around some of this stuff | |
| 17:13:08 | artom | It's been half-assedly brought up internally, but it takes a lot of work (literally - force over a distance) for a long time to change that | |
| 17:13:24 | mriedem | artom: well it's not really only RH, it's any distro that EOLs an old series and customers are forced to move up | |
| 17:13:41 | aspiers | any other mock experts wanna review that? | |
| 17:13:48 | mriedem | which is why we get all the RH queens bug reports bubblin gup now | |
| 17:14:23 | artom | mriedem, are there other significant distros besides OSP at this point? Honest question | |