Posted	Nick	Remark
#openstack-nova - 2019-08-13
01:30:06	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused helper _get_instances_by_filters https://review.opendev.org/676036
01:49:20	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused helper filter_and_format_resource_metadata https://review.opendev.org/676038
02:51:33	openstackgerrit	Merged openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
02:51:42	openstackgerrit	Merged openstack/nova master: DRY get_flavor in flavor manage tests https://review.opendev.org/668281
02:51:51	openstackgerrit	Merged openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
02:52:04	openstackgerrit	Merged openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
03:25:59	openstackgerrit	Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908
03:31:32	openstackgerrit	Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
03:43:48	openstackgerrit	Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
04:14:45	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.76: Support Specifying AZ to unshelve https://review.opendev.org/665136
04:28:08	openstackgerrit	Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
04:28:09	openstackgerrit	Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
04:28:09	openstackgerrit	Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
04:28:10	openstackgerrit	Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
04:28:10	openstackgerrit	Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
04:28:11	openstackgerrit	Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
05:54:09	openstackgerrit	Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
06:09:40	openstackgerrit	Lenny Verkhovsky proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776
06:11:20	openstackgerrit	Lenny Verkhovsky proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776
06:16:34	openstackgerrit	Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
07:28:24	gibi	efried: I felt the same about importing the real fixtures in https://review.opendev.org/#/c/675935 ;)
08:14:03	tssurya	good morning gmann, did you already propose a client side change for microversion 2.75 ? just asking so that I can rebase on client side change on that
08:46:05	zhouyao	bauzas Can you tell me if nvram file can be stored in shared storage?
08:46:35	gmann	tssurya: not yet, I am planning for today or tomorrow.
08:46:48	gmann	i will ping the link.
08:46:57	tssurya	gmann: thanks ! :)
09:01:04	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
09:01:04	openstackgerrit	Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
09:01:05	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
09:07:00	openstackgerrit	Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
09:09:03	openstackgerrit	Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
09:11:01	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
09:12:58	openstackgerrit	Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
09:12:59	openstackgerrit	Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113
09:17:00	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
09:19:00	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Func test for revert migration with bandwidth https://review.opendev.org/676140
09:29:37	openstackgerrit	Stephen Finucane proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338
09:56:43	lyarwood	redkrieg: Apologies for missing your ping yesterday re stable device rescue, it's dropped down to the the bottom of the pile for me recently.
09:57:27	lyarwood	redkrieg: there appears to be growing interest again so I might kick it back to life for the U cycle but I can't really guarantee anything at this point.
09:57:37	slaweq	efried: hi
09:58:04	slaweq	efried: I just opened bug https://bugs.launchpad.net/nova/+bug/1839961 as I see that this test if failing quite often
09:58:05	openstack	Launchpad bug 1839961 in OpenStack Compute (nova) "Test tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc failing often" [Undecided,New]
09:58:49	slaweq	efried: please take a look at it if You will have few minutes, I opened it for nova but maybe it's e.g. tempest issue - I'm not 100% sure
10:30:08	shilpasd	stephenfin: thanks for review 'isolate_aggregate' pre-request filter patches
10:30:34	shilpasd	stephenfin: just small query on https://review.opendev.org/#/c/671075/6/nova/scheduler/request_filter.py@68 and @72
10:30:46	shilpasd	if we have only one ResourceRequest, then we can omit union, right?
10:31:37	stephenfin	shilpasd: Yeah, I think so. That's what we do in nova/scheduler/utils.py https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L461-L483
10:32:05	stephenfin	Ignore the numbered_groups_from_flavor piece and I think you have exactly what you want
10:33:01	stephenfin	Also, there's a check there to see if 'Flavor.extra_specs' exists. However, I assumed it always would so I don't know why that's there. Maybe just tests?
10:35:55	shilpasd	thanks for reference, will address accordingly, and in my changes will check do we need this check 'if 'Flavor.extra_specs' exists', then only add
10:36:29	shilpasd	stephenfin: and for https://review.opendev.org/#/c/671074/5/nova/objects/aggregate.py@541
10:36:34	stephenfin	Makes sense. To say everything is passing so far, I imagine you don't, but it would be no harm to trace the paths to see if the field is ever _not_ set
10:36:37	shilpasd	will edit doc message
10:37:55	shilpasd	sure, will check if field is ever _not_ set, is any causing issue
11:01:19	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
11:03:09	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
11:08:27	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
11:44:52	openstackgerrit	ya.wang proposed openstack/nova master: Add property check when create/rebuild/resize. https://review.opendev.org/674523
11:44:52	openstackgerrit	ya.wang proposed openstack/nova master: Support report driver migrate feature https://review.opendev.org/674522
11:44:53	openstackgerrit	ya.wang proposed openstack/nova master: Change method: _live_migration_flags https://review.opendev.org/674525
11:44:53	openstackgerrit	ya.wang proposed openstack/nova master: Scheduler translate properties to traits https://review.opendev.org/674524
11:44:54	openstackgerrit	ya.wang proposed openstack/nova master: Add releasenote and update docs. https://review.opendev.org/674526
11:59:05	mriedem	stephenfin: replied in https://review.opendev.org/#/c/627892/
12:02:22	openstackgerrit	Peter Penchev proposed openstack/nova master: libvirt: use native AIO mode for StorPool Cinder volumes. https://review.opendev.org/676172
12:26:11	mriedem	tssurya: i've informally reserved 2.76 for you
12:37:49	tssurya	mriedem: just saw the ML, thanks a lot Matt! :)
12:40:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Prevent init_host test to interfere with other tests https://review.opendev.org/675553
12:56:11	yonglihe	melwitt: I came up with some comment to the code you concerned, hope it address your problem. glad to have you take a
12:56:12	yonglihe	look: https://review.opendev.org/#/c/627765/36/nova/compute/manager.py
12:58:43	yonglihe	sean-k-mooney: I bet you will be here again -:) , so could you please take another round of review for https://review.opendev.org/#/c/627765.
12:59:58	sean-k-mooney	hehe i am, ill try an take a look again later today
13:01:43	yonglihe	Thanks
13:02:18	yonglihe	Have a good review day, Sean, -:) .
13:36:21	tssurya	dansmith, mriedem: I opened this bug a few days ago : https://bugs.launchpad.net/nova/+bug/1839009 , would be could if someone could confirm it since I am not exactly sure if its a bug or if its intended to be that way.
13:36:22	openstack	Launchpad bug 1839009 in OpenStack Compute (nova) "os-server-external-events does not behave correctly for failed single events" [Undecided,New]
13:39:09	dansmith	tssurya: yeah, looks like maybe the assumption around "if accepted events" meaning "no instances" is too naive
13:39:46	tssurya	dansmith: yea
13:42:44	dansmith	I dunno what the api recommendation is here,
13:42:56	dansmith	but I would think that just removing the else: raise bit there would be fine,
13:43:04	dansmith	since we calculate the overall and per-event result regardless
13:43:35	dansmith	I think that else is left from my original code that didn't try to do per-event status
13:45:25	tssurya	dansmith: yea we could, but wouldn't it change the existing api behaviour?
13:47:17	dansmith	well, obviously it would, but I think it falls under the "people don't write clients to depend on obviously broken behavior"
13:47:57	dansmith	we could specifically check for "they provided a legit single-event but the instance just wasn't found, so do this special 404" I guess
13:49:30	tssurya	dansmith: hmm yea I didn't do anything to the bug since I wasn't sure what was the right way out
13:49:53	tssurya	but like you said as least for ironic the client assumes everything is done correctly on server side
14:03:22	redkrieg	lyarwood: thanks for getting back to me. if there's anything I can do to help with stable device rescue, please let me know. it would solve some big pain points for me and my clients.
14:07:38	openstack	Launchpad bug 1669468 in devstack "duplicate for #1839961 tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc fails intermittently in neutron multinode nv job" [Medium,Fix released] - Assigned to melanie witt (melwitt)
14:07:38	efried	slaweq: I've seen https://bugs.launchpad.net/nova/+bug/1839961 quite a bit as well. mriedem is our resident bugmeister, though, perhaps he has insight.
14:08:00	slaweq	efried: thx, yes, mriedem already marked it as duplicate of other bug
14:08:03	slaweq	sorry for noise than :)
14:08:09	mriedem	the devstack patch was merged yesterday
14:08:18	slaweq	and thx for fix
14:08:24	mriedem	http://status.openstack.org/elastic-recheck/#1669468
14:08:33	mriedem	if it's still hitting we might have other problems
14:08:42	mriedem	https://review.opendev.org/#/c/675721/
14:09:29	efried	now the list is down to 167
14:16:42	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140
14:17:21	mriedem	tssurya: when are you on vacation?
14:26:31	Tianhao_Hu	About this issue, there are files left after cold migration every time. But the directory left is empty and has no effect on cold migration. I'm wondering that if we can think this is not a bug? Can anyone give me some help on this?

Earlier   Later