Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-12
20:00:46 dansmith and subsequent special counsel investigation
20:00:51 mriedem heh
20:01:03 dansmith all your dirty laundry will be aired
20:01:23 mriedem bnemec: for a BoolOpt, is it possible to leave it unset so you can set the default at runtime somehow, e.g. it's based on another options value?
20:02:08 bnemec mriedem: It is. I believe the default for BoolOpt is actually None, which implies that it was unset since that's not a valid boolean value.
20:02:58 openstack Launchpad bug 1764782 in oslo.config "BoolOpt defaults to None" [Medium,Triaged]
20:02:58 bnemec Which I actually think is a bug (https://bugs.launchpad.net/oslo.config/+bug/1764782) but as Doug points out there's no way to know if people have been relying on that behavior.
20:03:17 mriedem ah i see, looks like boolean type opts are really str opt under the covers and they get cast to booleans
20:03:43 mriedem something like strutils.bool_from_string
20:04:21 mriedem ok in my case i want to add a new option but have it's default be backward compatible to whatever is set for another option
20:04:27 mriedem unless you explicitly override it
20:06:37 bnemec I guess I should note that the more "correct" way to do this is to use get_location: https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.ConfigOpts.get_location
20:06:49 bnemec That will tell you if a user set the option or not in an unambiguous way.
20:08:16 bnemec Or maybe even better, use set_default and set the new opt's default to the value of the old opt: https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.ConfigOpts.set_default
20:10:49 mriedem the get_location stuff is relatively new right?
20:10:55 mriedem like, newer than ocata?
20:13:00 mriedem yeah rocky https://review.opendev.org/#/c/537397/
20:13:47 mriedem i don't plan on backporting this nova workaround too far, but it is super latent (much older than ocata anyway)
20:21:39 bnemec Yeah, although set_default has been around forever and is probably the right thing to do here conceptually.
20:22:12 bnemec You're setting a default for an opt based on a thing calculated in code (in this case from the value of another opt) but want the user to be able to override it if they set the opt explicitly.
20:23:11 mriedem where would i call set_default? where i'm using the new option?
20:23:50 bnemec Sometime between when you register the old opt and when you use the new one.
20:23:53 mriedem iow it's like dict.set_default
20:23:56 mriedem *setdefault
20:25:24 bnemec Something like that, but you just call it once and the config object remembers that you overrode the default for that opt.
20:26:22 bnemec I guess dict inserts the key with the default so that is actually the same.
20:26:37 mriedem this is what i've got right now http://paste.openstack.org/show/756357/
20:28:22 mriedem http://paste.openstack.org/show/756358/
20:28:22 mriedem this is probably better to avoid calling set_default when i don't need to
20:28:34 mriedem otherwise i have to do this somewhere in wsgi init after parsing options and starting the service
20:29:03 mriedem which takes it quite far away from where it's used, which is ok but kind of hard to remember all of this
20:29:40 bnemec Heh, if you're still checking for None then I'm not sure you gain much from using set_default.
20:29:46 bnemec But either should work.
20:33:10 mriedem yeah true :/
20:35:34 bnemec It's probably not worth satisfying my pet peeve about the BoolOpt default by moving the setdefault call to some weird location though.
20:39:56 sean-k-mooney dict not only set the defult i return the value in the dict. so if it was already set it returns the value that was found in the dict and if not it returns you default after setting it in the dict
20:40:22 sean-k-mooney you can discard the return if you dont care but its a nice behavior to have
20:40:38 sean-k-mooney so if we had a CONF.set_default it would be nice to keep it the same
20:41:48 sean-k-mooney that would change your example to http://paste.openstack.org/show/756359/
20:43:01 sean-k-mooney its a minor change but its basicly free to return the value and it makes the useage terser
21:31:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow disabling cold migration to the same host https://review.opendev.org/676022
22:02:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024
22:02:16 mriedem donnyd: sean-k-mooney: ^ and now i'm out o/
22:05:57 donnyd Yesssss
22:16:25 openstackgerrit Merged openstack/nova stable/queens: libvirt: move checking CONF.my_ip to init_host() https://review.opendev.org/672161
22:16:54 openstackgerrit Merged openstack/nova master: Avoid timeout from service update notification tests https://review.opendev.org/675935
22:22:58 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
22:52:15 openstackgerrit Eric Fried proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024
23:09:11 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Limit get_sdk_adapter to requested service type https://review.opendev.org/674678
23:40:22 openstackgerrit Takashi NATSUME proposed openstack/nova stable/stein: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676026
23:53:51 openstackgerrit Takashi NATSUME proposed openstack/nova stable/rocky: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676027
23:59:41 openstackgerrit Takashi NATSUME proposed openstack/nova stable/queens: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676028
#openstack-nova - 2019-08-13
00:00:13 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
00:00:14 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Load custom providers to Resource Tracker https://review.opendev.org/676029
00:10:38 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Load custom providers to Resource Tracker https://review.opendev.org/676029
00:10:38 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341
00:40:14 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix misuse of nova.objects.base.obj_equal_prims https://review.opendev.org/676030
00:45:10 openstackgerrit Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908
00:52:08 openstackgerrit Merged openstack/nova stable/ocata: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674906
01:30:06 openstackgerrit zhufl proposed openstack/nova master: [Trivial]Remove unused helper _get_instances_by_filters https://review.opendev.org/676036
01:49:20 openstackgerrit zhufl proposed openstack/nova master: [Trivial]Remove unused helper filter_and_format_resource_metadata https://review.opendev.org/676038
02:51:33 openstackgerrit Merged openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
02:51:42 openstackgerrit Merged openstack/nova master: DRY get_flavor in flavor manage tests https://review.opendev.org/668281
02:51:51 openstackgerrit Merged openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
02:52:04 openstackgerrit Merged openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
03:25:59 openstackgerrit Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908
03:31:32 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
03:43:48 openstackgerrit Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
04:14:45 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.76: Support Specifying AZ to unshelve https://review.opendev.org/665136
04:28:08 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
04:28:09 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
04:28:09 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
04:28:10 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
04:28:10 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
04:28:11 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
05:54:09 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
06:09:40 openstackgerrit Lenny Verkhovsky proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776
06:11:20 openstackgerrit Lenny Verkhovsky proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776
06:16:34 openstackgerrit Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
07:28:24 gibi efried: I felt the same about importing the real fixtures in https://review.opendev.org/#/c/675935 ;)
08:14:03 tssurya good morning gmann, did you already propose a client side change for microversion 2.75 ? just asking so that I can rebase on client side change on that
08:46:05 zhouyao bauzas Can you tell me if nvram file can be stored in shared storage?
08:46:35 gmann tssurya: not yet, I am planning for today or tomorrow.
08:46:48 gmann i will ping the link.
08:46:57 tssurya gmann: thanks ! :)
09:01:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
09:01:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
09:01:05 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
09:07:00 openstackgerrit Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
09:09:03 openstackgerrit Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
09:11:01 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
09:12:58 openstackgerrit Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
09:12:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113
09:17:00 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
09:19:00 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for revert migration with bandwidth https://review.opendev.org/676140
09:29:37 openstackgerrit Stephen Finucane proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338
09:56:43 lyarwood redkrieg: Apologies for missing your ping yesterday re stable device rescue, it's dropped down to the the bottom of the pile for me recently.
09:57:27 lyarwood redkrieg: there appears to be growing interest again so I might kick it back to life for the U cycle but I can't really guarantee anything at this point.
09:57:37 slaweq efried: hi
09:58:04 slaweq efried: I just opened bug https://bugs.launchpad.net/nova/+bug/1839961 as I see that this test if failing quite often

Earlier   Later