Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-09
18:13:18 mriedem mnaser: i said we should ping dansmith about that in the morning, and now i've already exceeded my sweet dan quota for the day on upgrade checkers and queens backport reviews
18:13:38 dansmith yeah you were done by 8am
18:13:41 mriedem ha
18:13:44 dansmith please try again on monday
18:13:55 mriedem dan is out of the office and out of clothes
18:15:24 mriedem mnaser: i also feel like i woke up at 2am thinking about a way to avoid the revert and still fix the unique constraint thing in a backportable way, but i think it eludes me. something something catch DuplicateEntry on ComputeNode.create(), look for existing deleted node with the same uuid, and just update it and set deleted=0.
18:15:28 mriedem but that's pretty hacky
18:16:12 mnaser that does feel pretty hacky
18:16:24 mnaser does the compute_node entry get created after or before the 'hypervisor' entry
18:16:43 mnaser aka maybe that hack can happen *only if* its using ironic but i dunno, seems like we're digging ourself a bigger hole
18:17:05 mriedem hypervisor entry?
18:17:21 mriedem tbachman: he was gone after the last summit
18:17:23 mnaser sorry its been a long day
18:17:31 tbachman I’m so out of touch
18:17:39 mriedem gone but not forgotten
18:17:41 tbachman heh
18:17:42 mnaser i think he's at aws
18:17:45 mriedem i just chatted him up this morning
18:17:46 mriedem he is
18:17:47 mnaser i still see him respond to placement threads
18:17:53 mnaser on the ML
18:17:55 mnaser so not too far away :P
18:18:31 tbachman Just when I thought I was out, they pull me right back in
18:19:03 mriedem those are more like self-inflicted wounds
18:19:57 tbachman LI profile says Principal Open Source Engineer at AWS
18:20:24 tbachman ah, but I guess he’s a kubernetes guy now
18:20:25 mriedem yes he's working on EKS
18:20:47 tbachman thx for bringing me up to date
18:21:09 tbachman checks yahoo email
18:21:17 tbachman (that last one is actally true)
18:26:12 mriedem melwitt: replied, sort of
18:27:25 melwitt mriedem: thanks. yeah, just thought it was weird if you happened to know what/why that is. I hadn't seen it before
18:38:24 mriedem you must be on cve backport duty with lee
18:42:33 artom mriedem, just come work for us, at this point. You know our internal better than we do ;)
18:42:37 artom *internals
18:43:07 artom Actually don't - we already have too many cores on staff.
18:45:13 melwitt heh, well, it's a cve so important to get the fixes merged and out there. and I had the context on the bug and fix for reviewing
18:45:30 mriedem artom: but then i could support the same-company approvals policy!
18:45:51 artom mriedem, sellout
18:46:04 mriedem melwitt: yeah i know, i appreciate the quick reviews
18:53:53 mriedem dansmith: if you prefer handling the DuplicateEntry-on-create-then-update-and-undelete thing here https://review.opendev.org/#/c/675496/ i can go that directoin
18:54:13 mriedem personally i'd like to keep the ironic node id, compute node uuid and resource provider id all aligned for debuggability
18:54:19 mriedem but it's low priority
18:55:47 mriedem the alignment i mean, not the fix that mnaser is waiting on
19:00:49 dansmith mriedem: un-deleting it lets you do that, no?
19:00:54 dansmith but yeah, definitely my preference
19:05:16 mriedem dansmith: right
19:05:33 mriedem so if i can make that work i'll go with it, will work on a recreate test first,
19:05:41 mriedem again, this was something i think i woke up to at ~2am
19:05:53 mriedem and the cat howling down the hall
19:07:23 dansmith okay
20:08:10 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669
20:08:11 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims https://review.opendev.org/634828
20:08:11 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
20:08:12 openstackgerrit Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605
20:08:12 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229
20:08:13 openstackgerrit Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
20:08:13 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
20:08:14 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Functional test for NUMA live migration https://review.opendev.org/672595
20:08:21 artom OK, that's basically ready.
20:08:38 artom Although as the WIP indicates on the last func test patch, I need to fiddle with it some more to assert more things.
21:04:43 mriedem ha
21:04:47 mriedem another bug
21:05:17 mriedem sumbitch
21:05:18 mriedem https://github.com/openstack/nova/blob/6b7d0caad86fe32ffc49a8672de1eb7258f3b919/nova/compute/resource_tracker.py#L570
21:05:23 mriedem if cn.create() fails,
21:05:29 mriedem we've already mapped it in self.compute_nodes
21:05:32 mriedem so the next time around we won't create it
21:05:34 mriedem sob
21:10:41 mriedem mnaser: dansmith: ok i've got a functional recreate test coming forthwith
21:10:49 mriedem after bashing my brains for about an hour
21:16:59 mriedem heh at least i didn't approve that back in ocata (but was +2)
21:19:19 artom And on http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008401.html's happy note, I'm calling it a week.
21:54:37 openstackgerrit Matt Riedemann proposed openstack/nova master: rt: only map compute node if we created it https://review.opendev.org/675704
21:54:39 openstack bug 1839560 in OpenStack Compute (nova) "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem)
21:54:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1839560 https://review.opendev.org/675705
21:54:40 mriedem ^ later than i'd hoped but i wanted to split out that rt bug fix from the functional test since it goes back to ocata
22:31:46 openstackgerrit Merged openstack/nova master: [Trivial]Remove unused _last_bw_usage_cell_update https://review.opendev.org/675543
22:31:54 openstackgerrit Merged openstack/nova master: docs: update 2.23 REST API version history https://review.opendev.org/674948
22:32:02 openstackgerrit Merged openstack/nova master: api-ref: document valid GET /os-migrations?migration_type values https://review.opendev.org/674949
22:54:23 openstackgerrit Merged openstack/nova master: Make nova-multi-cell job voting and gating https://review.opendev.org/674453
23:04:10 openstackgerrit Merged openstack/nova master: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/675148
23:04:18 openstackgerrit Merged openstack/nova master: Convert HostMapping.cells to a dict https://review.opendev.org/663387
23:50:20 openstackgerrit Merged openstack/nova master: Retrun 400 if invalid query parameters are specified https://review.opendev.org/670440
#openstack-nova - 2019-08-10
00:08:20 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/675714
01:08:22 openstackgerrit Merged openstack/nova master: trivial: Use NoDBTestCase instead of TestCase https://review.opendev.org/675529
01:20:42 openstackgerrit Merged openstack/nova stable/queens: Fix double word hacking test https://review.opendev.org/665790
03:16:56 openstackgerrit Merged openstack/nova stable/queens: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669126
03:30:53 openstackgerrit Merged openstack/nova stable/queens: Fix type error on call to mount device https://review.opendev.org/669629
03:31:00 openstackgerrit Merged openstack/nova stable/queens: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/670100
03:31:08 openstackgerrit Merged openstack/nova stable/queens: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/670226
09:12:03 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072
09:12:57 openstackgerrit Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074
09:15:45 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075
09:16:59 openstackgerrit Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952
10:49:23 openstackgerrit Merged openstack/nova master: Drop usage of lxml's deprecated getchildren() method https://review.opendev.org/675566
10:49:31 openstackgerrit Merged openstack/nova master: Rename 'map' variable to avoid shadowing keywords https://review.opendev.org/675578
12:57:52 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669
12:57:53 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims https://review.opendev.org/634828
12:57:53 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827

Earlier   Later