Posted	Nick	Remark
#openstack-nova - 2019-08-08
22:55:41	mriedem	would need to run it past dansmith in the morning probably
22:55:48	mriedem	for now you can archive the db to workaround it
22:55:59	mriedem	report a bug and i can talk with dan in the early morn
22:57:35	mnaser	or maybe you can pull *all* baremetal nodes and only delete those that are missing (and ignore disabled/maintenance oness)
22:58:05	mriedem	umm
22:58:28	mriedem	i don't know that disabled/maintenance mode is a thing we track in the compute node object
22:58:35	mriedem	unless it's in one of those json-ified fields
22:58:50	mnaser	i meant when the ironic driver pulls the list of nodes
22:59:06	mriedem	oh side-step the cn.destroy
22:59:26	mriedem	yeah maybe, not sure the implications of that though
22:59:39	mriedem	if you're host is managing 1000 nodes, that could be an expensive pull every 60 seconds :)
22:59:46	mriedem	*your
23:00:03	mnaser	you were gonna pull 1000 anyways, the only thing where it would be an issue is if you have 1000 with 990 in maint mode
23:00:23	mriedem	999 problems but the node ain't one?
23:00:33	mnaser	had to go with 990 to not let you get away with that one ha
23:00:38	openstack	Launchpad bug 1839560 in OpenStack Compute (nova) "ironic: moving node to maintenance makes it unusable afterwards" [Undecided,New]
23:00:38	mnaser	https://bugs.launchpad.net/nova/+bug/1839560
23:00:52	mnaser	oh wait
23:01:06	mnaser	i just realized the update_available_resource thing runs inside manager.py so its not ironic specific
23:01:13	mriedem	you'd still have an issue if you deleted the compute service record which will (soft) delete all of the compute nodes associated with it
23:01:18	mriedem	right
23:01:24	mriedem	thought that node destroy stuff is really for ironic
23:01:30	mriedem	in update_available_resource
23:01:34	mriedem	*though
23:01:58	mriedem	https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L401
23:02:00	mnaser	ah yeah but i figured thats you burning yourself if you delete a compute service record (but i can imagine you would have the assumption that it automatically appears if you deleted it again so yeah)
23:02:08	mriedem	^ is a problem when deleting the managing nova-compute service record
23:02:23	mriedem	it will when you restart the nova-compute service
23:02:36	mriedem	or if you leave nova-compute running when you destroy the service
23:02:49	mriedem	see note on https://docs.openstack.org/api-ref/compute/?expanded=delete-compute-service-detail#delete-compute-service
23:03:28	mriedem	so, i guess the revert is probably easiest backportable thing
23:04:29	mnaser	yeah i cant think of anything better, anything else makes the api layer code too ironic-y
23:10:17	mriedem	i'll post a revert for discussion anyway
23:12:14	mriedem	warren zevon is going to help me get through this
23:23:02	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert "Match ComputeNode.uuid to ironic node uuid in RT" https://review.opendev.org/675496
23:28:02	openstackgerrit	Matt Riedemann proposed openstack/nova master: Skip test_migrate_disk_and_power_off_crash_finish_revert_migration https://review.opendev.org/675417
23:28:03	openstackgerrit	Matt Riedemann proposed openstack/nova master: Dump versioned notifications when len assertions fail https://review.opendev.org/675404
23:28:10	mriedem	god i must break more things than i fix
#openstack-nova - 2019-08-09
00:38:45	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047
02:31:23	openstackgerrit	Merged openstack/nova stable/rocky: Don't generate service UUID for deleted services https://review.opendev.org/673821
02:31:29	openstackgerrit	Merged openstack/nova master: Skip test_migrate_disk_and_power_off_crash_finish_revert_migration https://review.opendev.org/675417
02:31:37	openstackgerrit	Merged openstack/nova master: Dump versioned notifications when len assertions fail https://review.opendev.org/675404
02:49:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.opendev.org/523559
02:49:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: run test_rebuild_server_in_error_state in ironic CI job https://review.opendev.org/675391
05:06:09	openstackgerrit	Merged openstack/nova stable/queens: Replace non-nova server fault message https://review.opendev.org/674859
05:48:07	openstackgerrit	Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476
06:08:30	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698
06:24:01	openstackgerrit	Takashi NATSUME proposed openstack/nova master: trivial: Use NoDBTestCase instead of TestCase https://review.opendev.org/675529
06:35:27	openstackgerrit	ya.wang proposed openstack/nova master: Add releasenote and update docs. https://review.opendev.org/674526
07:25:49	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Remove unused _last_bw_usage_cell_update https://review.opendev.org/675543
07:42:49	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480
08:06:41	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Prevent init_host test to interfere with other tests https://review.opendev.org/675553
08:26:16	openstackgerrit	Bhagyashri Shewale proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
09:29:58	openstackgerrit	Stephen Finucane proposed openstack/nova-specs master: Correct nit with cpu-resources https://review.opendev.org/675276
09:34:58	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879
09:45:00	openstackgerrit	Adam Spiers proposed openstack/nova master: Drop usage of lxml's deprecated getchildren() method https://review.opendev.org/675566
09:54:32	alex_xu	sean-k-mooney: i feel we have problem for confirm and revert resize https://review.opendev.org/#/c/621646/23/nova/virt/libvirt/driver.py@1099
09:56:08	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
09:57:49	openstackgerrit	Merged openstack/nova-specs master: Correct nit with cpu-resources https://review.opendev.org/675276
10:06:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894
10:06:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338
10:06:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
10:06:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
10:06:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
10:06:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: fakelibvirt: Stop distinguishing between NUMA, non-NUMA https://review.opendev.org/675570
10:07:19	stephenfin	alex_xu, efried, sean-k-mooney: Okay, with the exception of the reshaper, which still has some todo's in it, I _think_ the PCPU stuff is ready for review. It might look big but the bulk of it is handling tech debt. Let me know if you need advice on any part of it
10:07:47	alex_xu	stephenfin: cool~
10:08:41	stephenfin	alex_xu, efried, sean-k-mooney: I'm going to continue working on the reshaper and then start manual testing once that's done. I particularly want to check Train controller <-> Stein compute node compatibility and upgrades
10:10:50	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047
10:37:41	openstackgerrit	Adam Spiers proposed openstack/nova master: Rename 'map' variable to avoid shadowing keywords https://review.opendev.org/675578
10:38:00	openstackgerrit	Chris Dent proposed openstack/nova master: Add a document that describes profiling eventlet services https://review.opendev.org/674865
10:47:57	openstack	Launchpad bug 1669468 in OpenStack Compute (nova) "tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc fails intermittently in neutron multinode nv job" [Medium,Confirmed]
10:47:57	frickler	can someone help with fixing novnc multinode job config? see my latest comment in https://bugs.launchpad.net/nova/+bug/1669468
10:49:45	frickler	might actually be devstack's fault to properly set up the config, but I'm also not 100% sure how the correct config would look like
11:15:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: Follow up for I491eb7abe1405b27c552cdef142c688a46e914f2 https://review.opendev.org/675589
11:53:23	openstackgerrit	Luyao Zhong proposed openstack/nova master: Populates existing pmems in libvirt device manager https://review.opendev.org/672957
11:53:23	openstackgerrit	Luyao Zhong proposed openstack/nova master: Indroduce new LibvirtConfigGuestPMEM https://review.opendev.org/672956
11:53:24	openstackgerrit	Luyao Zhong proposed openstack/nova master: Support instance creation and resize with pmems https://review.opendev.org/672958
11:53:24	openstackgerrit	Luyao Zhong proposed openstack/nova master: Report pmem namespaces resources by provider tree https://review.opendev.org/634551
11:53:25	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add functional tests for persistent memory https://review.opendev.org/675592
12:43:30	belmoreira	cdent nice blogpost about placement performance. You may also be interested in these results: https://docs.google.com/document/d/1UE3jpukdoX45l5ghUg0AlcWBh95glRiGUv7E3YazXNk/edit
12:43:42	belmoreira	I hope to publish it soon
12:44:27	belmoreira	also ^ efried mriedem
12:44:28	cdent	ah, excellent, I'll give that a read soon, just getting ready to go to lunch
12:47:15	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879
12:54:33	openstackgerrit	Merged openstack/nova master: libvirt: Handle alternative UEFI firmware binary paths https://review.opendev.org/348394
13:16:42	mriedem	party people in the house say hey-o!
13:17:25	cdent	hey? o?
13:18:11	mriedem	that's the kind of enthusiasm i'm looking for
13:18:21	mriedem	lyarwood: can you get this queens backport? https://review.opendev.org/672690
13:18:30	mriedem	dansmith: can you get this one? https://review.opendev.org/668123
13:18:37	mriedem	today is queens release day
13:21:11	gibi	is it Friday yet?
13:22:58	mriedem	yes
13:23:03	mriedem	got another queens backport that needs +W https://review.opendev.org/#/c/669126/
13:23:12	artom	mriedem, didn't know Elizabeth was in jail...
13:24:46	mriedem	i'm missing the reference
13:25:11	cdent	artom: the life of a royal is constant imprisonment and suffering, don't ya know
13:26:09	mriedem	oh queens release day, i see
13:27:47	lyarwood	mriedem: ack done

Earlier   Later