| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-08 | |||
| 09:17:27 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | |
| 09:41:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Serialize datetime in NovaObjectSerializer https://review.opendev.org/675281 | |
| 10:14:10 | openstackgerrit | Alex Xu proposed openstack/nova master: Add functional tests for resize with VGPU https://review.opendev.org/675106 | |
| 10:50:11 | openstackgerrit | Merged openstack/os-vif master: only disable mac ageing for ovs hybrid plug https://review.opendev.org/672834 | |
| 11:52:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879 | |
| 12:30:53 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 12:31:48 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 12:35:48 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | |
| 12:37:07 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 12:49:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 13:19:33 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | |
| 13:20:35 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capablites to get supported device models https://review.opendev.org/666915 | |
| 13:20:44 | openstackgerrit | sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | |
| 13:34:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | |
| 13:34:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 13:34:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 13:34:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338 | |
| 13:42:33 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 13:51:18 | mriedem | lyarwood: dansmith: we're going to be doing a rocky release so can i drop some rocky reviews on you? starting with https://review.opendev.org/#/q/topic:bug/1837955+branch:stable/rocky | |
| 13:51:35 | dansmith | yeah | |
| 13:54:43 | lyarwood | yup post away in here and I'll get to them after this call | |
| 13:54:51 | mriedem | https://review.opendev.org/#/c/674770/ | |
| 13:55:18 | mriedem | dansmith: https://review.opendev.org/#/c/672747/ | |
| 13:55:31 | mriedem | well or lee can upgrade to +W that one | |
| 13:56:02 | mriedem | https://review.opendev.org/#/q/topic:bug/1764556+branch:stable/rocky | |
| 14:00:23 | dansmith | mriedem: I'm not sure what https://review.opendev.org/#/c/674770/1 is actually fixing | |
| 14:00:51 | mriedem | https://review.opendev.org/#/c/669393/ | |
| 14:01:11 | mriedem | dansmith: redundant db calls | |
| 14:01:41 | mriedem | efried: meeting? | |
| 14:02:02 | efried | thanks mriedem, got distracted. | |
| 14:02:03 | dansmith | mriedem: is it actually doing less work? | |
| 14:02:55 | mriedem | the bug report has the details | |
| 14:03:23 | mriedem | oh you mean since it still calls group.get_hosts() right? | |
| 14:04:35 | dansmith | I guess I need to dig further into what is going on under the covers, but it seems like this is just a tiny optimization, not really a fix no? | |
| 14:05:07 | dansmith | the bug seems to be "clean up dead code" or so | |
| 14:05:48 | mriedem | yes i think it is, | |
| 14:05:51 | mriedem | otherwise we'd change to: | |
| 14:05:56 | mriedem | group_hosts = group.hosts yeah? | |
| 14:07:06 | mriedem | guess i never saw the original https://review.opendev.org/#/c/665954/ | |
| 14:08:06 | dansmith | I'm just not sure what the point is | |
| 14:08:17 | dansmith | but it seems like kinda pointless for a backport | |
| 14:09:10 | mriedem | dropped my +2 | |
| 14:09:30 | mriedem | the point was to remove the redundant db query | |
| 14:09:32 | mriedem | which it's not | |
| 14:10:19 | dansmith | which redundant query? the hit to list cells first or something? | |
| 14:10:35 | mriedem | group.get_hosts (and the scatter/gather thing) | |
| 14:17:47 | openstackgerrit | François Palin proposed openstack/nova master: Add retry when attachment_delete or terminate_connection fails https://review.opendev.org/669674 | |
| 14:20:35 | mriedem | stephenfin: https://review.opendev.org/#/c/583247/2 leads to a change in merge conflict, i'd like to abandon the entire series unless there is a valid reason we should move forward with adding code that's not used | |
| 14:20:56 | stephenfin | mriedem: Kill it | |
| 14:21:30 | mriedem | gladly | |
| 14:22:02 | stephenfin | (Nice idea but I don't have time to finish it and guess he won't now) | |
| 14:37:03 | openstack | bug 1825537 in OpenStack Compute (nova) rocky "finish_resize failures incorrectly revert allocations" [Medium,In progress] https://launchpad.net/bugs/1825537 - Assigned to Matt Riedemann (mriedem) | |
| 14:37:03 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional recreate test for regression bug 1825537 https://review.opendev.org/675355 | |
| 14:39:14 | dansmith | mriedem: okay I think I got them all, yeah? | |
| 14:40:29 | mriedem | dansmith: yup i think so, thanks! | |
| 14:44:31 | dansmith | cool | |
| 14:45:03 | gibi | mriedem: I'm reading your grenade + resize comment in https://review.opendev.org/#/c/655721 Would it be enough to tag one of the resize tempest test with "smoke" to get the coverage you miss or we need to change some grenade logic as well? | |
| 14:49:59 | mriedem | tagging a resize tempest test with smoke would make it run during grenade yes | |
| 14:50:17 | artom | Lol, we ain't very smart | |
| 14:50:33 | artom | When we detach an interface, we catch a bunch of exceptions: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/attach_interfaces.py#L209 | |
| 14:51:07 | artom | We then do some RPC | |
| 14:51:09 | artom | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4305 | |
| 14:51:32 | artom | ... which is a cast: https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L572 | |
| 14:52:01 | mriedem | artom: the only thing that wouldn't be in that list is PortNotFound | |
| 14:52:08 | mriedem | the others are all failures from the api | |
| 14:52:40 | mriedem | for all i know some years ago it might have been a call, or the api might have looked up the port first | |
| 14:52:52 | artom | mriedem, ah, good point | |
| 14:53:28 | artom | Yeah, I'm sure there's a valid historical reason for it | |
| 14:53:28 | mriedem | who's not smart now | |
| 14:53:39 | artom | mriedem, when did I ever claim to be smart? | |
| 14:53:54 | artom | It was a just a cute "end state" | |
| 14:54:05 | mriedem | https://review.opendev.org/#/c/130028/2/nova/api/openstack/compute/plugins/v3/attach_interfaces.py@158 | |
| 14:54:09 | artom | (Got reported as a bug downstream, that we can pass anything as a port ID and it still accepts it) | |
| 14:54:09 | mriedem | eli pointed this out in 2014 | |
| 14:54:45 | artom | How in the hell did you pull that review from 5 years ago so fast | |
| 14:55:06 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 14:56:42 | mriedem | pycharm annotation | |
| 14:57:15 | efried | is this the race you were talking about yesterday? | |
| 14:57:15 | efried | mriedem: been seeing this weirdness of late https://logs.opendev.org/41/673341/10/check/nova-tox-functional-py36/b2b2fa5/testr_results.html.gz | |
| 14:57:48 | mriedem | no, but i don't remember talking about weird races yesterday either | |
| 15:01:59 | gibi | efried, mriedem: this was seen in https://review.opendev.org/#/c/666857/ which was reviewed by both of you | |
| 15:02:03 | mriedem | artom: it was all dansmith's fault https://review.opendev.org/#/c/21819/ | |
| 15:02:16 | mriedem | in...grizzly | |
| 15:02:24 | artom | I do love it when that happens | |
| 15:02:39 | mriedem | well, note the size of the change | |
| 15:03:02 | mriedem | Dan Smith <danms@us.ibm.com> | |
| 15:04:10 | dansmith | what's up now? I tried to catch exceptions around a rpc cast? | |
| 15:04:10 | mriedem | artom: push a patch to remove the PortNotFound handling if you want | |
| 15:04:23 | mriedem | dansmith: yes, and 6 years later much hilarity ensued | |
| 15:04:53 | artom | mriedem, I'd rather look up the port ID at the REST API level, and throw the 404 | |
| 15:04:58 | artom | Would that work? | |
| 15:05:01 | mriedem | you mean your customer would | |
| 15:05:12 | mriedem | let's front-load validate all incoming IDs because of one red hat customer! | |
| 15:05:13 | mriedem | yay! | |
| 15:06:02 | artom | I actually don't think there's a customer | |
| 15:06:24 | artom | It's more a matter of aligning with our api-ref docs: https://docs.openstack.org/api-ref/compute/?expanded=detach-interface-detail#detach-interface | |
| 15:06:29 | artom | Which state a 404 could happen | |
| 15:06:35 | artom | ... or we should change the doc | |
| 15:06:43 | mriedem | technically the 404 is for the instance not being found | |
| 15:06:47 | mriedem | the port not being found is a 400 | |