| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-05 | |||
| 13:07:50 | aspiers | c.attrib is for the ... attributes :) | |
| 13:07:53 | kashyap | Err, indeed. What am I smoking | |
| 13:08:01 | aspiers | also, don't use getchildren | |
| 13:08:25 | kashyap | .text holds the additional data... | |
| 13:10:22 | kashyap | aspiers: Oh, I recall you had a patch to replace that, because of new XML library changes | |
| 13:11:11 | kashyap | Right, Element.getchildren() is deprecated | |
| 13:11:31 | aspiers | I haven't done it yet | |
| 13:11:35 | aspiers | but I will | |
| 13:15:23 | kashyap | Nod | |
| 13:32:23 | kashyap | aspiers: Is this readable to you? :D | |
| 13:32:24 | kashyap | elif c.tag == "enum" and c.attrib["name"] == "firmware": | |
| 13:32:25 | kashyap | if child.tag == "value"] | |
| 13:32:25 | kashyap | self.firmwares = [child.text for child in c | |
| 13:32:25 | kashyap | firmwares = [] | |
| 13:33:04 | aspiers | yes but couldn't it cause a KeyError if there's an <enum> without a 'name' attribute? | |
| 13:33:17 | aspiers | which in theory shouldn't happen, but ya know, defensive programming and all that | |
| 13:33:32 | aspiers | this is probably the kind of thing sean-k-mooney was talking about | |
| 13:33:35 | kashyap | aspiers: Hmm, possibly. How do you guard? | |
| 13:33:45 | aspiers | it's just a dict :) | |
| 13:33:59 | aspiers | c.attrib.get("name") | |
| 13:34:29 | belmoreira | Hi. I'm testing the nova upgrade from Rocky to Stein. I was trying to do it without control plane interruption but I'm failing. I was hoping that upgrade_levels for the control plane would do it... but no. | |
| 13:34:43 | aspiers | I think sean-k-mooney would advocate //enum[@name='firmware']/value/text() or whatever | |
| 13:34:55 | kashyap | aspiers: Nod on the attrib / dict :-) | |
| 13:35:04 | kashyap | aspiers: Right ... that's the 'xpath' parsing | |
| 13:35:44 | kashyap | aspiers: I wrote this for QE folks: https://kashyapc.fedorapeople.org/Querying-guest-XML-with-xpath.txt | |
| 13:36:04 | aspiers | how is xpath different from xq? | |
| 13:37:04 | belmoreira | afaik this is not supported, but what are we missing? | |
| 13:38:13 | kashyap | 1 sec; call | |
| 13:39:53 | aspiers | belmoreira: not sure anyone who could answer that is awake yet, unless maybe lyarwood | |
| 13:48:44 | mriedem | stephenfin: i'm having a hard time reasoning why this libvirt functional test you wrote here https://logs.opendev.org/22/674422/1/check/nova-tox-functional/ddac573/testr_results.html.gz is failing on a simple optimization change here https://review.opendev.org/#/c/674422/ | |
| 13:48:52 | mriedem | looks like the test expects something to fail which isn't now | |
| 13:49:16 | mriedem | so it's hitting a StopIteration on a mocked call to open a console file for the guest when spawning it for the 3rd time (1 create, 2 rebuilds) | |
| 13:54:16 | Rubueno | Hi, quick question. We're running OS in accp and prod environments, currently running the same version. Today the nova api returns an unexpected api error in accp when calling "nova list" or "openstack server list --all". It asks to report it at launchpad, just wondering what temlate to follow and whether there's anything I can do at this moment. | |
| 13:56:20 | Rubueno | "Unexpected exception in API method: TypeError: __init__() takes at least 4 arguments (2 given)" | |
| 13:57:10 | kashyap | aspiers: BTW, earlier, c.get() does it; no need for c.attrib.get() :-) -- you know why | |
| 13:58:11 | aspiers | kashyap: oh yeah, that's even better | |
| 14:00:46 | aspiers | kashyap: just to be 100% clear before you vanish for a significant length of time, you're intending to reply to https://review.opendev.org/#/c/673151/ later today right? If you have any nits which you want fixing, I really want to get those done before you go so that you can give an honest +1 :) Not trying to pester as I'm around all day - just making sure :) | |
| 14:01:43 | kashyap | aspiers: Writing right now | |
| 14:01:48 | aspiers | awesome, thanks! | |
| 14:03:01 | kashyap | aspiers: Also, note, don't worry - I've been looking at this for a couple of days, not doing it in a hurry :-) | |
| 14:03:08 | aspiers | cool | |
| 14:03:50 | kashyap | aspiers: Also, congrats ... you are one of the few people who can distinguish the getCapabilities() and getDomainCapabilities() at feature-level :D | |
| 14:04:01 | aspiers | heh | |
| 14:04:31 | aspiers | Well they're kind of confusing | |
| 14:05:29 | alex_xu | mriedem: do you want to give a help on this https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:claim_for_instance? I remember you reviewed the original vgpu code also | |
| 14:06:33 | kashyap | alex_xu: They _are_ confusing. You'll recall - a few months ago, when you added that 'infra' patch for domCaps, we hashed out doc string accuracy over a couple of days. | |
| 14:07:00 | aspiers | I think that last message was meant for me :) | |
| 14:07:09 | aspiers | Yes I do recall that | |
| 14:11:06 | alex_xu | kashyap: emmm...what context? | |
| 14:11:25 | kashyap | alex_xu: Err, I'm sorry. I didn't realize the nick | |
| 14:11:30 | kashyap | Yes, it was for aspiers, indeed | |
| 14:11:40 | alex_xu | ah | |
| 14:12:09 | spatel | sean-k-mooney: morning | |
| 14:12:57 | aspiers | spatel: don't think he's around | |
| 14:15:19 | spatel | aspiers: Thanks, yes it seems. (untill noon tuesday gmt) | |
| 14:20:17 | kashyap | aspiers: Can the fix to test_driver.LibvirtConnTestCase.test_cpu_info be separated out? | |
| 14:20:40 | kashyap | (And also test_get_instance_capabilities()) | |
| 14:20:56 | aspiers | it could, but is it really worth it? | |
| 14:21:29 | aarents | Hi there, can someone tell me who can review this https://review.opendev.org/#/c/670000/ it is about _get_guest_config() potential bug | |
| 14:21:32 | kashyap | aspiers: Not, probably. (I was just looking at it form a "is this strictly necessary for this?") | |
| 14:21:48 | aspiers | aarents: that's a great review number | |
| 14:22:35 | kashyap | aspiers: Just so that it makes future git sleuthing (`blame`, or even goodness forbid bacports :D) easier when not mixing absolutely unnedeed changes in the same patch (but add it in on top). | |
| 14:22:52 | kashyap | aspiers: But it's not worth it here | |
| 14:23:13 | aspiers | kashyap: I can do, I guess all the SEV stuff needs to be rebased anyway | |
| 14:23:27 | aspiers | since I already posted a patch set to address your other nit | |
| 14:23:31 | kashyap | aspiers: Okay, you can do it probably once I hit send shortly | |
| 14:23:38 | kashyap | aspiers: Ahh, right | |
| 14:23:49 | aspiers | kashyap: well if I do it, it will invalidate your +1 | |
| 14:24:00 | aspiers | kashyap: so if I do it, it needs to be now | |
| 14:24:20 | kashyap | aspiers: Hehe, I'll give a "future-proof" +1 that, modulo that test rework, I don't have any further changes | |
| 14:24:37 | aspiers | kashyap: I'll do it now | |
| 14:24:40 | kashyap | aspiers: I'm mostly writing tiny observations as I saw | |
| 14:24:42 | kashyap | Okay... | |
| 14:25:00 | aspiers | kashyap: since we're both insane perfectionists ;-) | |
| 14:25:17 | aarents | aspiers: Yes, It was not so easy to caught that ;) | |
| 14:29:17 | aspiers | kashyap: while I'm at it, should I split out the assertXmlEquals *options addition? | |
| 14:29:54 | kashyap | aspiers: I was thinking about it -- it certainly removes the noise. And makes it slightly easier to reviewers who're _not_ familiar this area, IMHO | |
| 14:29:59 | aspiers | True | |
| 14:30:03 | aspiers | Might as well | |
| 14:56:27 | openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Test blank sdk placement proxy https://review.opendev.org/674625 | |
| 14:56:51 | efried | mriedem, cdent, mordred: would one or more of y'all please check whether I did that ^ right? | |
| 14:57:37 | mordred | efried: I thnik that should do it | |
| 14:58:40 | efried | thx | |
| 14:58:54 | efried | it's the required-projects thing I can never seem to suss | |
| 15:01:10 | mriedem | efried: unrelated to that, i've noticed that we get several warnings from openstacksdk for cinder and barbican not having valid_interfaces in nova conf when functional tests fail, | |
| 15:01:15 | mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22WARNING%20%5Bopenstack%5D%20Disabling%20service%5C%22%20AND%20message%3A%5C%22Encountered%20an%20exception%20attempting%20to%20process%20config%20for%20project%5C%22%20AND%20message%3A%5C%22no%20such%20option%20valid_interfaces%20in%20group%5C%22&from=7d | |
| 15:02:42 | efried | mriedem: that's interesting. Off the cuff, it's gotta be because we're not importing the ksa opts correctly. Investigating... | |
| 15:02:55 | openstackgerrit | Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151 | |
| 15:02:56 | openstackgerrit | Adam Spiers proposed openstack/nova master: Fix libvirt driver tests to use LibvirtConfigCapsGuest instances https://review.opendev.org/674629 | |
| 15:02:56 | openstackgerrit | Adam Spiers proposed openstack/nova master: Allow assertXmlEqual() to pass options to matchers.XMLMatches https://review.opendev.org/674628 | |
| 15:03:00 | aspiers | kashyap: ^^^ | |
| 15:03:55 | aspiers | efried: a couple of those are trivial changes split off from the main patch, and should only take 1--2 mins to review | |
| 15:04:15 | efried | mriedem: oh, right, we never did finish cutting over cinder or barbican to ksa | |
| 15:05:10 | efried | mordred: I wonder if it's worth fixing up the oslo.config method to accept a list of services we care about, so the sdk only builds proxies for those... | |
| 15:06:58 | kashyap | aspiers: Ack | |
| 15:08:51 | mordred | efried: the proxy objects themselves are on-demand. it doesn't build something if it's not used | |
| 15:09:20 | efried | mordred: well, okay, interpreting the conf sections tho | |
| 15:10:20 | mordred | that could maybe be worth it | |
| 15:33:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Stabilize unshelve notification sample tests https://review.opendev.org/674636 | |
| 16:13:48 | mriedem | stephenfin: after debugging for a few hours i think i figured out the problem, | |