| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-05 | |||
| 07:14:48 | alex_xu | dansmith: efried, one more corner case found. For same host resize, we only have one domain xml in the libvirt before confirming the resize. So if the host is down, and then the host back again, we will lose the source allocation. | |
| 07:16:09 | alex_xu | dannins: efried, one method is we write the device allocations(vgpu, vpmem..) into the filesystem under the dir "instance_base_path + '_resize'"... | |
| 07:25:15 | alex_xu | dansmith: efried or we just auto confrim that same host resize after the host back, and cleanup other free vpmem. | |
| 08:48:15 | openstackgerrit | ya.wang proposed openstack/nova master: vCPU mdoels selection https://review.opendev.org/670298 | |
| 08:48:16 | openstackgerrit | ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300 | |
| 08:48:16 | openstackgerrit | ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | |
| 08:48:17 | openstackgerrit | ya.wang proposed openstack/nova master: Add release note https://review.opendev.org/670441 | |
| 09:05:44 | openstackgerrit | ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | |
| 09:05:44 | openstackgerrit | ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298 | |
| 09:05:45 | openstackgerrit | ya.wang proposed openstack/nova master: Add release note https://review.opendev.org/670441 | |
| 09:05:45 | openstackgerrit | ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300 | |
| 09:21:59 | mkrai | mgoddard, Hi Mark! Can you please take a look at the reconfigure spec whenever you've time? https://review.opendev.org/#/c/672252/ | |
| 10:58:23 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 11:15:38 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 11:52:53 | kashyap | alex_xu: When you get a min, want to put this through? This fixes a couple of bugs: https://review.opendev.org/#/c/348394/10/ | |
| 11:54:48 | openstackgerrit | Merged openstack/nova master: Add the support of CPU feature 'AVX512-VNNI' https://review.opendev.org/673480 | |
| 12:08:13 | gibi | kashyap: all those nice emails waiting for me... | |
| 12:08:24 | gibi | kashyap: have a nice vacation! | |
| 12:09:16 | kashyap | Thanks! | |
| 12:20:07 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Filter migrations by user_id/project_id https://review.opendev.org/674243 | |
| 12:55:11 | alex_xu | kashyap: I will try tomorrow morning | |
| 12:55:48 | aspiers | kashyap: any chance you could review https://review.opendev.org/#/c/673151/ before you go? | |
| 12:56:03 | aspiers | kashyap: I mean, finish reviewing it. It blocks the entire SEV series :-( | |
| 12:56:22 | aspiers | welcome back gibi :) | |
| 12:56:44 | kashyap | alex_xu: Sure | |
| 12:56:48 | kashyap | aspiers: Looking | |
| 12:57:08 | gibi | aspiers: thanks :) | |
| 12:58:32 | kashyap | aspiers: I had opened it, and apparently have a little draft (nothing substantial) to your reply. Will hit send today | |
| 13:00:15 | aspiers | kashyap: thanks. If at all possible I would really like to get your +1 before you go | |
| 13:00:25 | kashyap | aspiers: Yes, doing that | |
| 13:03:40 | kashyap | aspiers: A silly XML question | |
| 13:05:13 | aspiers | ? | |
| 13:06:02 | kashyap | aspiers: http://paste.openstack.org/show/755517/ | |
| 13:06:12 | kashyap | Thought it's better to use the pastebin | |
| 13:07:42 | aspiers | c.text | |
| 13:07:50 | aspiers | c.attrib is for the ... attributes :) | |
| 13:07:53 | kashyap | Err, indeed. What am I smoking | |
| 13:08:01 | aspiers | also, don't use getchildren | |
| 13:08:25 | kashyap | .text holds the additional data... | |
| 13:10:22 | kashyap | aspiers: Oh, I recall you had a patch to replace that, because of new XML library changes | |
| 13:11:11 | kashyap | Right, Element.getchildren() is deprecated | |
| 13:11:31 | aspiers | I haven't done it yet | |
| 13:11:35 | aspiers | but I will | |
| 13:15:23 | kashyap | Nod | |
| 13:32:23 | kashyap | aspiers: Is this readable to you? :D | |
| 13:32:24 | kashyap | elif c.tag == "enum" and c.attrib["name"] == "firmware": | |
| 13:32:25 | kashyap | if child.tag == "value"] | |
| 13:32:25 | kashyap | self.firmwares = [child.text for child in c | |
| 13:32:25 | kashyap | firmwares = [] | |
| 13:33:04 | aspiers | yes but couldn't it cause a KeyError if there's an <enum> without a 'name' attribute? | |
| 13:33:17 | aspiers | which in theory shouldn't happen, but ya know, defensive programming and all that | |
| 13:33:32 | aspiers | this is probably the kind of thing sean-k-mooney was talking about | |
| 13:33:35 | kashyap | aspiers: Hmm, possibly. How do you guard? | |
| 13:33:45 | aspiers | it's just a dict :) | |
| 13:33:59 | aspiers | c.attrib.get("name") | |
| 13:34:29 | belmoreira | Hi. I'm testing the nova upgrade from Rocky to Stein. I was trying to do it without control plane interruption but I'm failing. I was hoping that upgrade_levels for the control plane would do it... but no. | |
| 13:34:43 | aspiers | I think sean-k-mooney would advocate //enum[@name='firmware']/value/text() or whatever | |
| 13:34:55 | kashyap | aspiers: Nod on the attrib / dict :-) | |
| 13:35:04 | kashyap | aspiers: Right ... that's the 'xpath' parsing | |
| 13:35:44 | kashyap | aspiers: I wrote this for QE folks: https://kashyapc.fedorapeople.org/Querying-guest-XML-with-xpath.txt | |
| 13:36:04 | aspiers | how is xpath different from xq? | |
| 13:37:04 | belmoreira | afaik this is not supported, but what are we missing? | |
| 13:38:13 | kashyap | 1 sec; call | |
| 13:39:53 | aspiers | belmoreira: not sure anyone who could answer that is awake yet, unless maybe lyarwood | |
| 13:48:44 | mriedem | stephenfin: i'm having a hard time reasoning why this libvirt functional test you wrote here https://logs.opendev.org/22/674422/1/check/nova-tox-functional/ddac573/testr_results.html.gz is failing on a simple optimization change here https://review.opendev.org/#/c/674422/ | |
| 13:48:52 | mriedem | looks like the test expects something to fail which isn't now | |
| 13:49:16 | mriedem | so it's hitting a StopIteration on a mocked call to open a console file for the guest when spawning it for the 3rd time (1 create, 2 rebuilds) | |
| 13:54:16 | Rubueno | Hi, quick question. We're running OS in accp and prod environments, currently running the same version. Today the nova api returns an unexpected api error in accp when calling "nova list" or "openstack server list --all". It asks to report it at launchpad, just wondering what temlate to follow and whether there's anything I can do at this moment. | |
| 13:56:20 | Rubueno | "Unexpected exception in API method: TypeError: __init__() takes at least 4 arguments (2 given)" | |
| 13:57:10 | kashyap | aspiers: BTW, earlier, c.get() does it; no need for c.attrib.get() :-) -- you know why | |
| 13:58:11 | aspiers | kashyap: oh yeah, that's even better | |
| 14:00:46 | aspiers | kashyap: just to be 100% clear before you vanish for a significant length of time, you're intending to reply to https://review.opendev.org/#/c/673151/ later today right? If you have any nits which you want fixing, I really want to get those done before you go so that you can give an honest +1 :) Not trying to pester as I'm around all day - just making sure :) | |
| 14:01:43 | kashyap | aspiers: Writing right now | |
| 14:01:48 | aspiers | awesome, thanks! | |
| 14:03:01 | kashyap | aspiers: Also, note, don't worry - I've been looking at this for a couple of days, not doing it in a hurry :-) | |
| 14:03:08 | aspiers | cool | |
| 14:03:50 | kashyap | aspiers: Also, congrats ... you are one of the few people who can distinguish the getCapabilities() and getDomainCapabilities() at feature-level :D | |
| 14:04:01 | aspiers | heh | |
| 14:04:31 | aspiers | Well they're kind of confusing | |
| 14:05:29 | alex_xu | mriedem: do you want to give a help on this https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:claim_for_instance? I remember you reviewed the original vgpu code also | |
| 14:06:33 | kashyap | alex_xu: They _are_ confusing. You'll recall - a few months ago, when you added that 'infra' patch for domCaps, we hashed out doc string accuracy over a couple of days. | |
| 14:07:00 | aspiers | I think that last message was meant for me :) | |
| 14:07:09 | aspiers | Yes I do recall that | |
| 14:11:06 | alex_xu | kashyap: emmm...what context? | |
| 14:11:25 | kashyap | alex_xu: Err, I'm sorry. I didn't realize the nick | |
| 14:11:30 | kashyap | Yes, it was for aspiers, indeed | |
| 14:11:40 | alex_xu | ah | |
| 14:12:09 | spatel | sean-k-mooney: morning | |
| 14:12:57 | aspiers | spatel: don't think he's around | |
| 14:15:19 | spatel | aspiers: Thanks, yes it seems. (untill noon tuesday gmt) | |
| 14:20:17 | kashyap | aspiers: Can the fix to test_driver.LibvirtConnTestCase.test_cpu_info be separated out? | |
| 14:20:40 | kashyap | (And also test_get_instance_capabilities()) | |
| 14:20:56 | aspiers | it could, but is it really worth it? | |
| 14:21:29 | aarents | Hi there, can someone tell me who can review this https://review.opendev.org/#/c/670000/ it is about _get_guest_config() potential bug | |
| 14:21:32 | kashyap | aspiers: Not, probably. (I was just looking at it form a "is this strictly necessary for this?") | |
| 14:21:48 | aspiers | aarents: that's a great review number | |
| 14:22:35 | kashyap | aspiers: Just so that it makes future git sleuthing (`blame`, or even goodness forbid bacports :D) easier when not mixing absolutely unnedeed changes in the same patch (but add it in on top). | |
| 14:22:52 | kashyap | aspiers: But it's not worth it here | |
| 14:23:13 | aspiers | kashyap: I can do, I guess all the SEV stuff needs to be rebased anyway | |
| 14:23:27 | aspiers | since I already posted a patch set to address your other nit | |