Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-25
14:51:46 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Functional tests for NUMA live migration https://review.opendev.org/672595
14:51:54 artom ^^ There, fixed the merge conflicts
14:52:08 cdent thanks artom will try it from my side of the world
14:52:08 artom For all I know it's not even placement...
14:52:16 artom cdent, appreciated, much thanks :)
14:55:12 efried artom: https://review.opendev.org/#/c/668752/
14:55:30 efried ~2w ago
14:57:30 mriedem i'm pretty sure required=%21COMPUTE_STATUS_DISABLED is saying !disabled
14:57:35 mriedem i.e. forbidden trait
14:57:40 cdent yes
14:57:56 artom Yeah, that's !
14:59:40 sean-k-mooney mriedem: yep it is
15:00:46 sean-k-mooney althouhg ! does not technically have to be url encoded
15:00:56 sean-k-mooney but %21 is the encodeing for !
15:28:28 efried Can we do a release now?
15:28:28 efried It looks like there have been half a dozen or so commits since the last release, of which only one looks like it has any meat (https://review.opendev.org/#/c/658786/)
15:28:28 efried sean-k-mooney: A requirement for cycle-with-intermediary projects is a m-2 release. os-vif qualifies.
15:28:48 efried jangutter: ^
15:33:21 sean-k-mooney efried: actully we just need to have 1 release we dont need one at each milestone
15:33:30 sean-k-mooney that was cycles-with-milestones
15:33:37 sean-k-mooney but ill check and get back to you later
15:33:43 sean-k-mooney just on a meeting
15:34:44 stephenfin efried, mriedem: Can I have pre-commit? Pretty please? https://review.opendev.org/#/c/665518/
15:35:13 stephenfin I've to respin ~8 patches because I forgot to run pep8 :'( https://review.opendev.org/#/c/671797/
15:35:33 stephenfin Not that I'm going to bother yet. I'll fix it when I need to respin
15:37:42 jangutter efried: regarding the meat, I'm happy for it to get barbecued into a release. note that there has been some follow-on stuff (unmerged) that happened afterwards too.
15:39:09 jangutter efried: specifically https://review.opendev.org/#/c/665965/
15:40:07 cdent artom: I responded on your thing. I can see where things go wrong, but not why
15:40:28 cdent what I mean is I can answer the "why" but not the "why of the why"
15:40:43 jangutter efried: my view (stated in the os-vif review) is that I don't think the follow-on is necessary, but I don't feel strongly enough to oppose it.
15:41:09 artom cdent, aha, that's already very helpful
15:41:46 cdent artom: good. i'll be curious to here what the missing piece is
15:41:53 cdent and hear too
15:41:54 artom I know some stuff changed recently around fakelibvirt
15:42:08 artom Maybe a side effect of that was changing the default flavor and/or compute disk size?
15:42:17 mriedem stephenfin: i'll defer your pre-commit request to dansmith
15:42:22 cdent sounds likekly
15:42:25 artom I shall dig, right after this meeting
15:42:36 artom Which is done, thank god
15:42:37 stephenfin ugh, but he's the worst
15:42:46 mriedem i'm an old bugbear so i don't care about pre-commit
15:42:47 stephenfin Um, I mean...the best <3
15:42:53 mriedem and will bitch to no end if it makes me do extra things
15:43:36 artom mriedem's artistic left brain half is actually a tox venv for running pep8
15:43:41 sean-k-mooney mriedem: well if you dont install it it wont do anything
15:43:43 stephenfin It should make you do less things, since you won't need to remember to run fast8
15:43:50 stephenfin but it is different things
15:43:53 stephenfin ...unless we backport
15:44:01 stephenfin ...which I would be game to do
15:44:05 mriedem i would not
15:45:00 sean-k-mooney anyway the important thing about the pre-commit stuff is it should not impact anywayone that does not want to use it
15:45:21 sean-k-mooney they can continue to use tox and the gate will continute to use tox
15:45:33 stephenfin 'zactly. It's purely opt-in
15:45:37 sean-k-mooney for those that want to use it the can install the tool and let it doe its thing
15:46:07 stephenfin sean-k-mooney: I added the tab to spaces converter thing too, if that sweetens the deal for you
15:46:16 sean-k-mooney :)
15:46:17 stephenfin some pre-commit >>> no pre-commit
15:46:28 sean-k-mooney yes yes it does
15:46:39 sean-k-mooney i already likeed it however
15:47:57 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: touch up the os-services docs https://review.opendev.org/672571
15:49:26 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: touch up the os-services docs https://review.opendev.org/672571
15:55:31 sean-k-mooney efried: alex_xu stephenfin i have summerised where i stand on the mix cpu spec in my last top level comment https://review.opendev.org/#/c/668656/5
15:56:35 sean-k-mooney if that seams fair i think we could proceed with it contionally on that restricted time table
15:56:59 sean-k-mooney otherwise i would move this to backlog/U
15:57:09 jangutter stephenfin: tab to space is low hanging fruit. If you really want a holy war, enforce "one space after period."
15:57:43 sean-k-mooney jangutter: the tab to space thing is because we manually enforce no tabs
15:58:06 jangutter sean-k-mooney: yep, pep8 will just do a late fail for you.
15:58:09 sean-k-mooney so the pre-commit hook would detect it for you
15:58:22 sean-k-mooney jangutter: only on python 3 i think
15:58:38 sean-k-mooney on 2 i think it will allow it as long as you dont mix
15:59:32 mriedem oooooo yeahhh https://www.youtube.com/watch?v=Lrle0x_DHBM
15:59:44 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion 2.75: Add 'power-update' external event https://review.opendev.org/645611
16:07:18 efried stephenfin: Isn't pre-commit something you can carry locally at will?
16:08:31 stephenfin I'd need to add it to '.gitignore' but otherwise yes
16:09:32 efried I mean, given the level of meh about putting it in the codebase, that just semes like the better option, doesn't it?
16:09:38 efried It would be, like, two of you using it?
16:11:09 stephenfin Perhaps, but it just rubs me the wrong way if we're being honest
16:11:30 stephenfin I'm not sure why we should be so averse to trying new things, especially when those things are opt-in and don't affect the end product in any way
16:11:35 Nick_A what is the correct way to enable maintenance mode on a hypervisor to prevent new instances from spawning on it? https://docs.openstack.org/python-openstackclient/rocky/cli/command-objects/host.html doesn't seem to work - "Not Implemented" error
16:12:31 Nick_A Never mind - we found it
16:12:34 artom cdent, https://review.opendev.org/#/c/644793/12/nova/tests/functional/libvirt/test_numa_servers.py culprit found
16:12:52 cdent woot
16:12:53 artom cdent, thanks again for your prompt help!
16:13:19 cdent you're welcome. was there a line number associated with that link?
16:13:43 cdent or just the general concept
16:14:12 artom cdent, in general - more specifically, it removed a monkey patch in setup: https://review.opendev.org/#/c/644793/12/nova/tests/functional/libvirt/base.py
16:14:23 artom So then had to mock a bunch of stuff for each test
16:14:30 cdent ah ha
16:14:50 artom Which I wasn't mocking, as I wrote the test before that landed
16:15:08 artom And thus was relying on the setUp monkeypatch, which got pulled from under me
16:15:19 cdent yowsa
16:15:51 artom TBH, the commit message doensn't do a great job of explaining *why* it was necessary to remove that monkeypatch
16:15:57 stephenfin idk. I do a lot of reviews. I write some code. I'm a decent community member, in general. Why do I have to pull teeth to get something in that I'm saying helps my productivity and doesn't hamper anyone else. It's frustrating.
16:16:04 artom But I assume there's a larger context that I'm not aware of
16:16:36 efried stephenfin: +2 on the basis of you really wanting it.
16:16:59 stephenfin Cheers
16:17:08 efried stephenfin: but to answer your question, because it's trivial for you to do it locally without "polluting" the nova codebase with something that's irrelevant to nova.
16:17:16 cdent stephenfin++
16:17:49 stephenfin My counterpoint to that is that I've done, and continue to do, a lot of unpolluting
16:17:51 efried be like me putting a pycharm config

Earlier   Later