| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-23 | |||
| 13:49:29 | dansmith | stephenfin: but no, compute node won't auto serialize that to json, you have to make it do that | |
| 13:50:08 | stephenfin | Oh yeah. Duh | |
| 13:50:11 | stephenfin | Proxy field it is | |
| 13:50:29 | stephenfin | Also, what's horrible about bumping a major version again? | |
| 13:50:36 | stephenfin | *major object version | |
| 13:50:51 | stephenfin | I recall we bumped the Instance object and said never again, but I don't know why never again | |
| 13:51:20 | dansmith | stephenfin: it's not too terrible, but it is a little complicated. instance was the most complicated object, but I don't think we said never again, | |
| 13:51:28 | dansmith | it's just that it needs to be worth it | |
| 13:51:59 | efried | (stephenfin nm, there's no replacement for the landing page yet, I +Wed) | |
| 13:52:21 | dansmith | stephenfin: compute node would probably be much less annoying because of how limited its use is.. i.e. we don't send compute node objects all around to every node like we do instance, | |
| 13:52:33 | dansmith | it's mostly just the compute and conductor that have to touch them | |
| 13:52:56 | stephenfin | Yeah, that's the one I'm most interested in | |
| 13:53:16 | stephenfin | I think I'll wait til os-hypervisors is talking to placement instead of consuming the xxx_usage fields from ComputeNode first though | |
| 13:53:22 | stephenfin | So we can remove those while we're at it | |
| 13:53:35 | stephenfin | (Assuming that ends up being possible) | |
| 13:53:44 | dansmith | the point being to objectify that field, right? why is that a thing now vs. before? Because you're adding stuff to that field or something? | |
| 13:53:56 | dansmith | stephenfin: that sounds like a good idea | |
| 13:54:24 | dansmith | an object change for one field type is less good, but deprecating unused fields with that change is more meaty | |
| 13:55:04 | stephenfin | dansmith: Mostly because it wasn't initially obvious and led to me being bitten by it | |
| 13:55:23 | stephenfin | I am tackling it at in a more piecemeal fashion with https://review.opendev.org/#/c/671799/3 and the two preceding patches though | |
| 13:55:48 | stephenfin | moving the calls to convert the string to an object (and vice versa) close to where the field is actually read/set | |
| 13:55:59 | stephenfin | tl;dr: hardware.py is nasty | |
| 14:05:19 | dansmith | stephenfin: I don't want to nitpick your reno to death, but I do think it's important to note that the change it is describing happened quite a while ago, instead of implying that as of train, something is different | |
| 14:05:37 | dansmith | also happy to edit it myself if you want | |
| 14:05:44 | stephenfin | wrt to which patch now? | |
| 14:05:50 | stephenfin | Sure, suits me :) | |
| 14:06:02 | stephenfin | Assume you mean https://review.opendev.org/#/c/672065/ ? | |
| 14:06:09 | dansmith | yeah | |
| 14:06:56 | stephenfin | Yeah, go for it. Think mriedem made a similar comment when it was part of the claims patch | |
| 14:08:09 | dansmith | yeah, that feedback didn't seem to make the jump, but it's hard to tell because I can't diff revs now | |
| 14:08:46 | stephenfin | I changed 'is now' to 'is' and changed the wording of the libvirt section | |
| 14:08:55 | dansmith | heh | |
| 14:09:41 | stephenfin | Was going to state that it's performed natively in placement since X, but I couldn't determine fully when X was. Thought it was Ocata but mriedem referenced Pikle | |
| 14:09:44 | stephenfin | *Pike | |
| 14:13:26 | dansmith | stephenfin: so, matt's comment was that none of the virt specific stuff belongs in that reno, but in admin docs | |
| 14:13:46 | stephenfin | Oh, I misread that /o\ | |
| 14:13:57 | stephenfin | I thought he was saying the reno was fine but the admin docs should be additional | |
| 14:14:33 | dansmith | well I guess maybe | |
| 14:14:36 | dansmith | here's the thing though: | |
| 14:14:48 | dansmith | these filters would be conflicting with placement since pike | |
| 14:14:59 | dansmith | meaning, they should have been disabled since then, and they warn at startup if enabled | |
| 14:15:10 | dansmith | *that* is when this virt overhead change happened, not now | |
| 14:15:22 | dansmith | so putting it in a reno for train makes it sound like that behavior is now changing, but it is not | |
| 14:15:22 | stephenfin | Fair point | |
| 14:15:28 | stephenfin | Strip it out so? | |
| 14:15:32 | dansmith | so that's why *I* want it not in a reno :) | |
| 14:15:44 | stephenfin | I have the important bits noted at https://review.opendev.org/#/c/672065/2/api-ref/source/parameters.yaml and https://review.opendev.org/#/c/672065/2/doc/source/admin/configuration/schedulers.rst@1355 I think | |
| 14:15:54 | stephenfin | the latter being more importnat | |
| 14:15:57 | dansmith | yeah, so I'll strip it out and add some more words to this, and then go hunting for a place to maybe explain it in a generalized way or something | |
| 14:15:57 | stephenfin | *important | |
| 14:16:24 | dansmith | stephenfin: oh, yeah, that second bit is perfect | |
| 14:16:30 | dansmith | so I think we can just strip this out of the reno then | |
| 14:16:36 | stephenfin | Sounds good to me | |
| 14:16:45 | stephenfin | Happy to do that or will I? | |
| 14:16:55 | dansmith | I have it open already | |
| 14:17:06 | stephenfin | (y) | |
| 14:18:15 | stephenfin | In that case, I've two references to config options in that second bit that should probably do with the ':oslo.config:option:' role, but as a nice-to-have | |
| 14:19:05 | dansmith | can you barf up the rst for me to link to that schedulers section? | |
| 14:23:51 | dansmith | hmm, maybe i just use the full link? I thought there was a shortcut | |
| 14:24:38 | stephenfin | To the section I added? | |
| 14:25:35 | stephenfin | You need to add an anchor before the title and then you can use the :ref: role, assuming it's within the same doc build | |
| 14:25:56 | stephenfin | so add e.g. '.. _hypervisor-specific-considerations:' | |
| 14:26:13 | stephenfin | then reference wherever you want with ':ref:`hypervisor-specific-considerations`' | |
| 14:27:01 | stephenfin | or https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#hypervisor-specific-considerations if it's from a reno or something | |
| 14:27:05 | dansmith | ack was just piecing that together from mah grepping | |
| 14:27:09 | dansmith | I have to re-learn this every damn time | |
| 14:28:32 | dansmith | stephenfin: er, I don't see any other :ref: usage in the renos.. are renos in the same build as the other docs? | |
| 14:28:52 | stephenfin | You've to use a URL there | |
| 14:28:59 | openstackgerrit | Eric Fried proposed openstack/nova master: DNM: experiment with GreenThread passthrough https://review.opendev.org/672299 | |
| 14:29:01 | stephenfin | because they're a different build | |
| 14:29:07 | dansmith | right okay, but the anchor makes it #able yeah? | |
| 14:29:11 | stephenfin | Yup | |
| 14:29:24 | dansmith | stephenfin: aren't you glad I'm saving you time by doing this myself? :P | |
| 14:29:38 | stephenfin | Very :) | |
| 14:29:43 | dansmith | haha | |
| 14:29:50 | stephenfin | Here's another example, fwiw https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios | |
| 14:29:58 | stephenfin | That should have an anchor in the rST | |
| 14:30:10 | dansmith | that's the one I was copying yeah | |
| 14:30:51 | stephenfin | though interestingly that has no anchor | |
| 14:31:15 | dansmith | it does | |
| 14:31:17 | dansmith | oh no, | |
| 14:31:22 | dansmith | that one was auto from the heading I think | |
| 14:31:25 | dansmith | I found another one though | |
| 14:31:39 | dansmith | capabilities-as-traits is what I copied | |
| 14:31:49 | stephenfin | Ah yeah, the auto from the heading behavior isn't the default, I thought | |
| 14:31:57 | stephenfin | Might be a thing we do in openstackdocstheme | |
| 14:32:09 | stephenfin | Or not, idk. Doesn't matter. capabilities-as-traits is good | |
| 14:34:54 | openstackgerrit | Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023 | |
| 14:37:09 | sean-k-mooney1 | stephenfin: the headings are automaticaly referenceable via the css selector | |
| 14:37:23 | sean-k-mooney1 | its thte content list or what ever we use that arnt | |
| 14:39:08 | dansmith | stephenfin: I'm going to address my other nit I just commented as well | |
| 14:42:06 | dansmith | and your comment on the config option | |
| 14:43:04 | stephenfin | coolness | |
| 14:48:54 | aspiers | sean-k-mooney: I'm about to review your https://review.opendev.org/#/c/670189/ - thanks for working on that | |
| 14:49:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated CPU, RAM, disk claiming in resource tracker https://review.opendev.org/551026 | |
| 14:49:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated Core/Ram/DiskFilter https://review.opendev.org/672065 | |
| 14:49:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove 'nova.virt.driver.ComputeDriver.estimate_instance_overhead' https://review.opendev.org/672106 | |
| 14:50:59 | sean-k-mooney | aspiers: nice to see you around again. and i need it for my own stuff too so its not entily un selfish :) | |
| 14:56:27 | aspiers | sean-k-mooney: :) | |
| 14:56:44 | aspiers | sean-k-mooney: I am not sure why I thought that defaulting to q35 would be OK :-/ | |