Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-07-19
18:06:37 efried \o/
18:06:38 efried thanks dansmith
18:17:16 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414
18:17:17 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790
18:17:17 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789
18:17:18 openstackgerrit Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792
18:17:18 openstackgerrit Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791
18:17:19 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'pcpus' to the resource tracker https://review.opendev.org/671794
18:17:19 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
18:17:20 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Remove unused function parameter https://review.opendev.org/671796
18:17:20 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795
18:17:21 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798
18:17:21 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797
18:17:22 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
18:17:22 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799
18:17:23 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta https://review.opendev.org/671801
18:17:40 stephenfin efried: FYI ^
18:18:13 efried nice. alex_xu ^
18:18:15 stephenfin The second to last patch needs a lot more work to handle upgrades properly (tests are failing too) and I still need to do the reshape, but that's where my head's at
18:24:17 efried dansmith: Not sure if you're still following oslo.service SIGHUP, but you may be able to tell whether it's doing the right thing based on the logs I just posted https://review.opendev.org/#/c/641907/
18:30:55 efried artom: the results are in. So far your patch is going to wind up needing to undo the changes I'm making to the tests as a result. It may end up being more prudent to put the poison patch on top of yours, once yours finishes tests and we find out what *it* will have to change.
18:33:48 artom efried, I don't mind handling any conflicts that come up
18:34:08 artom efried, to put it bluntly, you handle yours, I'll handle mine :P
18:34:35 openstackgerrit Merged openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497
18:34:41 efried There are only three failures: one func, two unit. All three will be n/a afaict under your patch.
18:34:52 efried maybe I should just wait until yours comes back.
18:35:08 efried dustinc: ----^
18:35:11 artom n/a afaict
18:35:13 artom ?
18:35:14 efried lmk when you want to start talking impl
18:35:50 dustinc oh good!
18:36:09 dustinc I am back in office today and want to get my freshly failing tests fixed on other, let's start Monday morning?
18:36:11 efried artom: I mean all three of them come from invoking driver.get_host_ip_addr
18:36:17 efried dustinc: sure
18:36:22 artom efried, honestly, if it makes your life easier, drop my patch entirely
18:36:29 dustinc efried: great, ttyt
18:36:55 efried artom: I'm not looking for an easy life. I want danger. I want thrills.
18:37:27 artom Have you tried insulting Putin?
18:38:08 artom It's just... I won't know for sure what needs fixing until I have your full patch in front of me
18:38:15 efried http://logs.openstack.org/71/671471/5/check/nova-tox-functional/318a334/testr_results.html.gz
18:38:15 efried http://logs.openstack.org/71/671471/5/check/openstack-tox-py27/0282bb0/testr_results.html.gz
18:38:15 efried artom: Here's yours:
18:39:22 artom I dunno, your call
18:39:31 efried the only overlap is the functional one, test_cold_migrate_with_physnet, which fails in yours because of init_host and in mine because of get_ip. The fix there might actually be the same.
18:39:32 efried so
18:39:34 efried let's do this
18:39:35 artom Given that this is latent, we could indeed merge my fix first
18:39:48 efried fix yours til it passes on top of mine
18:39:53 efried then we'll swap them
18:39:57 efried which should actually make mine pass.
18:40:12 efried dig?
18:41:10 artom efried, right, I think I get you
18:41:15 efried It's not exactly latent when your patch goes from 3 netifaces calls to 44 :)
18:41:33 artom Yours breaks because of driver.get_host_ip_addr()
18:41:37 artom Mine will fix that ^^
18:41:43 efried correct
18:41:46 artom But it will break others things in the process
18:41:50 efried correct
18:41:52 efried until it doesn't.
18:42:09 artom Yes, which is why I'm paid the big bucks, apparently
18:42:36 efried gotta do something to afford your meth habit
18:43:31 artom "Meth. Why?" is indeed a good anti-drugs slogan
19:23:34 openstackgerrit Artom Lifshitz proposed openstack/nova master: libvirt: move checking CONF.my_ip to init_host() https://review.opendev.org/671471
19:23:35 openstackgerrit Artom Lifshitz proposed openstack/nova master: Poison netifaces.interfaces() in tests https://review.opendev.org/671773
19:24:09 artom efried, let's wait for Zuul, but I think I got them all
19:24:26 efried artom: cool. did you reverse them as well?
19:24:30 artom Aye
19:24:42 efried okay. Thanks for sticking with this.
19:24:51 artom Np :)
19:27:44 redkrieg hello all, I'm trying to use rescue mode to install windows, but the official iso (which works in a computer when burned) says no bootable device found in rescue mode. an ubuntu iso works fine on the same host. has anyone else ever hit this issue?
19:38:48 efried redkrieg: That's... not exactly a nova issue, is it?
19:40:46 redkrieg I don't know if it's something specific to rescue mode's way of mounting isos. I've been able to use the iso with libvirt in the past. it's fine, I'll find a more appropriate venue
19:41:30 efried redkrieg: Sorry, yeah, #openstack is more appropriate for support. This channel is for dev.
19:42:24 redkrieg thanks, I'll ask there
19:44:54 artom efried, hrmm, one thing I forgot to consider was the backport situation
19:45:02 artom That poison patch isn't going back
19:45:17 efried artom: that's fine, then, because you switched em.
19:45:21 efried You don't rely on the poison patch
19:45:29 efried and your swizzle of the mocks is appropriate to backport.
19:45:48 artom Oh yeah
19:45:58 efried and I'm not too worried about whether stable branches have other violations we'll be missing.
19:46:17 efried though we can always backport the poison patch to find out, then abandon it.
19:46:25 efried but it seems pretty unlikely.
19:46:38 artom Yeah
19:46:47 artom Thanks for your help in all this, btw :)
19:47:22 efried for sure
21:02:42 efried artom: +2
21:03:47 artom efried, \o/
21:04:23 efried dansmith: we got this one all ready for you https://review.opendev.org/#/c/671471/
21:23:05 openstackgerrit Eric Fried proposed openstack/nova master: Remove @safe_connect from _delete_provider https://review.opendev.org/671866
21:41:11 openstackgerrit Eric Fried proposed openstack/nova master: Remove @safe_connect from _delete_provider https://review.opendev.org/671866
22:03:40 openstackgerrit Eric Fried proposed openstack/nova master: Disambiguate logs in delete_allocation_for_instance https://review.opendev.org/671869
22:03:54 efried o/
22:46:11 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
22:46:12 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
22:46:12 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
22:46:13 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
22:46:13 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
#openstack-nova - 2019-07-20
02:17:34 openstackgerrit Merged openstack/nova master: Optimize SchedulerReportClient.delete_resource_provider https://review.opendev.org/657070
03:26:43 openstackgerrit Merged openstack/nova master: Exit 1 when db sync runs before api_db sync https://review.opendev.org/665626

Earlier   Later