| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-19 | |||
| 16:40:37 | efried | we'll see if either/both explode :) | |
| 16:40:44 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | |
| 16:41:57 | sean-k-mooney | gibi_off: ill fix the failing tests in ^ on monday so you can ignore it for now | |
| 16:43:02 | sean-k-mooney | GenericPoisonFixture i like the name :) | |
| 16:46:00 | artom | ericyoung, ack, thanks. Don't we already have a DB poison fixture somewhere? If you're making a generic one, should it gobble that up? | |
| 16:46:10 | artom | Whoops, efried ^^ | |
| 16:46:49 | efried | artom: There are two other poison fixtures that I could conceivably roll into this one, but their messages are much more specific and they do more specific things, so I left them alone for now. | |
| 16:49:25 | artom | *snerk* I understand you mean method | |
| 16:49:34 | artom | But... maybe not have the name of a hard drug in our code? ;) | |
| 16:52:43 | efried | artom: Heh, yeah, I just didn't want to shadow variable names. It makes my IDE mildly upset, and confuses me. | |
| 16:53:04 | artom | func | |
| 16:53:05 | artom | ? | |
| 16:53:40 | efried | I should point out http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-07-15.log.html#t2019-07-15T20:49:08 | |
| 16:54:20 | efried | (You thought nobody was listening) | |
| 16:54:22 | artom | efried, what I looking at? 1836595? | |
| 16:54:57 | artom | Oh, yeah, thank you zhufl ^_^ | |
| 16:56:31 | efried | dansmith: will you be able to get back to (and hopefully close) https://review.opendev.org/612497 (providers.yaml) today? | |
| 16:56:55 | dansmith | hopefully | |
| 17:51:28 | dansmith | efried: you wanna fix at least my typo nit and I'll +2+W? No long test run required for these, so a quick bump for a typo seems fine | |
| 17:52:54 | efried | dansmith: okay, you want me to smash in the fup while I'm at it? | |
| 17:54:41 | dansmith | oh I didn't see the fup, yeah might as well and gibi is +2 there, so ... easy | |
| 17:55:51 | efried | dansmith: Do you want me to say "exactly one" identification mechanism, or is "at least one" good? | |
| 17:56:26 | dansmith | efried: the point of my comment is "exactly one" is important.. if you say "at least one" you need to define what happens if they put name and uuid and they don't match | |
| 17:56:51 | efried | right, that would be an error. | |
| 17:57:05 | efried | "exactly one" would restrict us in the future if we wanted to do some kind of pattern matching | |
| 17:57:23 | efried | has_trait: CUSTOM_FOO | |
| 17:57:23 | efried | name_matches: /pattern/ | |
| 17:57:25 | efried | kind of thing | |
| 17:57:54 | efried | but I'm fine either way. | |
| 17:58:38 | dansmith | sure, but as it is today, I would think "exactly one" gets you a crisper definition.. then when you add a match you can say "zero or one of name/uuid and one or more filters" or something like that.. but I don't care whether you go loose or tight, just define the edges if you go loose | |
| 17:59:17 | dansmith | if you want to put this in your fup for bikeshedding I can just +W the bottom one | |
| 17:59:49 | efried | dansmith: so tbc you're okay if I leave it defined as is but add "error if you specify both and they don't match"? | |
| 18:00:52 | dansmith | I think "at least one" is better than "either" because I'm not sure whether either means "one but not both", but yes, if you want "at least one" and define the edges, that's fine | |
| 18:01:16 | dansmith | but, what happens if I do $COMPUTE_NODE and name and there's no match? Is that an error because I won't ever do anything, or is that a 'well no match but that's what you asked for' ? | |
| 18:02:07 | dansmith | and, that might be right at startup, but not after a reshuffle, | |
| 18:02:23 | dansmith | and in the zero hour case with ironic, the compute starts up with no nodes at first | |
| 18:02:48 | dansmith | not trying to complicate this, which is why I thought "exactly one" makes this easier for the moment :) | |
| 18:02:54 | efried | okay okay | |
| 18:04:51 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | |
| 18:05:06 | efried | dansmith: smashed and done ^ | |
| 18:06:37 | efried | \o/ | |
| 18:06:38 | efried | thanks dansmith | |
| 18:17:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414 | |
| 18:17:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790 | |
| 18:17:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789 | |
| 18:17:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | |
| 18:17:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791 | |
| 18:17:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'pcpus' to the resource tracker https://review.opendev.org/671794 | |
| 18:17:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | |
| 18:17:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused function parameter https://review.opendev.org/671796 | |
| 18:17:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | |
| 18:17:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | |
| 18:17:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | |
| 18:17:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | |
| 18:17:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | |
| 18:17:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 18:17:40 | stephenfin | efried: FYI ^ | |
| 18:18:13 | efried | nice. alex_xu ^ | |
| 18:18:15 | stephenfin | The second to last patch needs a lot more work to handle upgrades properly (tests are failing too) and I still need to do the reshape, but that's where my head's at | |
| 18:24:17 | efried | dansmith: Not sure if you're still following oslo.service SIGHUP, but you may be able to tell whether it's doing the right thing based on the logs I just posted https://review.opendev.org/#/c/641907/ | |
| 18:30:55 | efried | artom: the results are in. So far your patch is going to wind up needing to undo the changes I'm making to the tests as a result. It may end up being more prudent to put the poison patch on top of yours, once yours finishes tests and we find out what *it* will have to change. | |
| 18:33:48 | artom | efried, I don't mind handling any conflicts that come up | |
| 18:34:08 | artom | efried, to put it bluntly, you handle yours, I'll handle mine :P | |
| 18:34:35 | openstackgerrit | Merged openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | |
| 18:34:41 | efried | There are only three failures: one func, two unit. All three will be n/a afaict under your patch. | |
| 18:34:52 | efried | maybe I should just wait until yours comes back. | |
| 18:35:08 | efried | dustinc: ----^ | |
| 18:35:11 | artom | n/a afaict | |
| 18:35:13 | artom | ? | |
| 18:35:14 | efried | lmk when you want to start talking impl | |
| 18:35:50 | dustinc | oh good! | |
| 18:36:09 | dustinc | I am back in office today and want to get my freshly failing tests fixed on other, let's start Monday morning? | |
| 18:36:11 | efried | artom: I mean all three of them come from invoking driver.get_host_ip_addr | |
| 18:36:17 | efried | dustinc: sure | |
| 18:36:22 | artom | efried, honestly, if it makes your life easier, drop my patch entirely | |
| 18:36:29 | dustinc | efried: great, ttyt | |
| 18:36:55 | efried | artom: I'm not looking for an easy life. I want danger. I want thrills. | |
| 18:37:27 | artom | Have you tried insulting Putin? | |
| 18:38:08 | artom | It's just... I won't know for sure what needs fixing until I have your full patch in front of me | |
| 18:38:15 | efried | http://logs.openstack.org/71/671471/5/check/nova-tox-functional/318a334/testr_results.html.gz | |
| 18:38:15 | efried | http://logs.openstack.org/71/671471/5/check/openstack-tox-py27/0282bb0/testr_results.html.gz | |
| 18:38:15 | efried | artom: Here's yours: | |
| 18:39:22 | artom | I dunno, your call | |
| 18:39:31 | efried | the only overlap is the functional one, test_cold_migrate_with_physnet, which fails in yours because of init_host and in mine because of get_ip. The fix there might actually be the same. | |
| 18:39:32 | efried | so | |
| 18:39:34 | efried | let's do this | |
| 18:39:35 | artom | Given that this is latent, we could indeed merge my fix first | |
| 18:39:48 | efried | fix yours til it passes on top of mine | |
| 18:39:53 | efried | then we'll swap them | |
| 18:39:57 | efried | which should actually make mine pass. | |
| 18:40:12 | efried | dig? | |
| 18:41:10 | artom | efried, right, I think I get you | |
| 18:41:15 | efried | It's not exactly latent when your patch goes from 3 netifaces calls to 44 :) | |
| 18:41:33 | artom | Yours breaks because of driver.get_host_ip_addr() | |
| 18:41:37 | artom | Mine will fix that ^^ | |
| 18:41:43 | efried | correct | |
| 18:41:46 | artom | But it will break others things in the process | |
| 18:41:50 | efried | correct | |
| 18:41:52 | efried | until it doesn't. | |
| 18:42:09 | artom | Yes, which is why I'm paid the big bucks, apparently | |