| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-12 | |||
| 23:24:01 | openstackgerrit | Artom Lifshitz proposed openstack/nova stable/rocky: Revert resize: wait for events according to hybrid plug https://review.opendev.org/670648 | |
| #openstack-nova - 2019-07-13 | |||
| 00:34:11 | openstackgerrit | Merged openstack/nova master: Remove needs:* todo from deprecated APIs api-ref https://review.opendev.org/668234 | |
| 00:44:24 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027 | |
| 00:44:25 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690 | |
| 00:44:25 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028 | |
| 00:44:26 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for getting network metadata from node https://review.opendev.org/670213 | |
| 00:44:26 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691 | |
| 04:43:57 | openstackgerrit | Merged openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715 | |
| 04:49:48 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 11:41:31 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889 | |
| 12:15:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: Fix no propagation of nova context request_id https://review.opendev.org/670694 | |
| #openstack-nova - 2019-07-14 | |||
| 02:59:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: Fix no propagation of nova context request_id https://review.opendev.org/670694 | |
| 07:37:52 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 14:28:34 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631 | |
| 14:28:34 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add functional test for resize crash compute restart revert https://review.opendev.org/670393 | |
| 14:28:35 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | |
| #openstack-nova - 2019-07-15 | |||
| 01:26:17 | openstackgerrit | Arthur Dayne proposed openstack/python-novaclient stable/rocky: Add Python 3 Train unit tests https://review.opendev.org/670749 | |
| 01:27:04 | openstackgerrit | ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | |
| 01:27:05 | openstackgerrit | ya.wang proposed openstack/nova master: Add release note https://review.opendev.org/670441 | |
| 01:27:05 | openstackgerrit | ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300 | |
| 03:19:08 | openstack | Launchpad bug 1836141 in OpenStack Compute (nova) "vm resize failed due to the remains left by failed actions" [Undecided,New] | |
| 03:19:08 | Spencer_Yu | https://bugs.launchpad.net/nova/+bug/1836141 Some failed actions would leave the remains in resize instance, which will lead next resize to fail. | |
| 04:37:29 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DRY get_flavor in flavor manage tests https://review.opendev.org/668281 | |
| 06:54:30 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120 | |
| 08:23:56 | alex_xu | efried: bauzas need your help on the direction https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:claim_for_instance | |
| 09:38:16 | sean-k-mooney | stephenfin: do you know the history behind why we went form testr to ostestr to stestr? im wondering if we should consider regerting to testr or look at finding a non subunit based alternitive | |
| 09:40:55 | sean-k-mooney | https://blog.kortar.org/?p=370 | |
| 09:41:54 | sean-k-mooney | found the history ^ | |
| 09:42:36 | stephenfin | sean-k-mooney: I was pretty sure testr was subunit-based, tbh | |
| 09:42:54 | sean-k-mooney | it is | |
| 09:43:02 | sean-k-mooney | that does not mean it has the same bug | |
| 09:57:10 | cdent | sean-k-mooney: are you talking about the overflow bug with too much logging? or something else? | |
| 10:04:23 | sean-k-mooney | cdent: ya we are now hitting it downstream | |
| 10:04:51 | sean-k-mooney | RHEL8 ship newer versions of some libs then upper constratis uses for stien | |
| 10:05:11 | sean-k-mooney | cdent: so we get more deprecation warnings then upstream | |
| 10:05:19 | cdent | the same bug is present in testr and ostestr (which is a testr wrapper). My understanding is the issue is in testtools and/or subunit not testr or stestr | |
| 10:05:43 | cdent | and it really comes down to a binary data structure being too small | |
| 10:05:54 | cdent | it should be per test | |
| 10:06:05 | sean-k-mooney | cdent: well yes and no | |
| 10:06:12 | sean-k-mooney | it is in subunit parser | |
| 10:06:20 | sean-k-mooney | but the subunit protocal | |
| 10:06:33 | cdent | so finding and turning off the deprecation warnings (or simply fixing them) is probably the easiest thing | |
| 10:06:35 | sean-k-mooney | allows large packets to be fragmented | |
| 10:06:47 | sean-k-mooney | i think the issue is we are not fragmenting the stream | |
| 10:07:04 | sean-k-mooney | cdent: ya that is how we are fixing it upstream | |
| 10:07:18 | sean-k-mooney | but downstream that is more of a challange | |
| 10:07:43 | sean-k-mooney | it either requires backporting things that may not be backported upstream or downstream only patches | |
| 10:13:35 | sean-k-mooney | cdent: i was wondering if there was a way to redirect all deperecation warnings to a seperate file so that it does not end up in the test output | |
| 10:14:05 | sean-k-mooney | we should be able to install a python logging filter i think but i havent tried | |
| 10:15:15 | cdent | yeah, that does appear to be the case | |
| 10:18:43 | sean-k-mooney | the trick would be using a generic enough regex to match deprecations without redirecting real errors. we would also want the gate jobs to copy the deprecation file so that we can actully track how big it is and squash them | |
| 10:22:57 | sean-k-mooney | it lookse like we already filter a bunch of waring here https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L815-L877 | |
| 10:24:02 | sean-k-mooney | cdent: actully https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L820 should be makeing deprecation warning print once | |
| 10:24:10 | sean-k-mooney | but maybe that is per test? | |
| 10:24:49 | sean-k-mooney | i would have assumed it would be per logger but maybe we dont use the warning filter in all places we should | |
| 10:26:10 | cdent | could be that it is not turned on everywhere? there are some tests that don't use the usual base? | |
| 10:27:34 | sean-k-mooney | the test that is exploding downswtream is the test_instace_action functional test which runns a bunch of tests interall https://github.com/openstack/nova/blob/7279d6fa009c6e276188bcad0ad5a1832849a4f9/nova/tests/functional/notification_sample_tests/test_instance.py#L357-L377 | |
| 10:28:13 | sean-k-mooney | it is not direcly using the fixtre but ill look at its inheritance tree | |
| 10:28:26 | sean-k-mooney | maybe we dont use it in the functional tests | |
| 10:29:37 | gibi | sean-k-mooney: does not this solved the problem https://review.opendev.org/#/c/656844/ ? | |
| 10:30:56 | sean-k-mooney | i can check if we have that on osp 15 which is stine but migi was saying the backport he has tried sofar do not fix it for us | |
| 10:31:28 | sean-k-mooney | we dont have auto import of backports so its possible we are missing that one | |
| 10:36:17 | sean-k-mooney | gibi: ya we have that and no it does not fix it for us | |
| 10:43:45 | sean-k-mooney | cdent: looks like the waring filter is installed for the functional tests | |
| 10:43:54 | sean-k-mooney | so i guess we are still looking too much | |
| 10:44:21 | sean-k-mooney | part of the issue is i think stestr is creating a log stream per worker not per test | |
| 12:56:31 | hongda | Hello everyone. Can you help to review: https://review.opendev.org/#/c/670016/ and https://review.opendev.org/#/c/669867/ ? They tried to fix live-migration failure when token expires. Thanks a lot. XD | |
| 13:00:46 | sean-k-mooney | we would have to fix this on master first before https://review.opendev.org/#/c/670016/ can be applied | |
| 13:00:54 | sean-k-mooney | why is that stable only by the way | |
| 13:01:54 | efried | alex_xu: Talk to me | |
| 13:05:34 | sean-k-mooney | hongda: im not sure we should just blindly use the admin context | |
| 13:06:10 | sean-k-mooney | we could be it would proably be better to only use the admin context if the token had expired | |
| 13:07:15 | sean-k-mooney | hongda: it also looks like you are reusing an old bug that was closed in 2017 | |
| 13:07:24 | efried | sean-k-mooney: I'm not paying much attention here, but service auth was made for a situation where you start off with a user token for a long-running operation and then it expires somewhere in the middle. | |
| 13:07:29 | sean-k-mooney | hongda: it would be better to file a new noen and reference it | |
| 13:07:30 | efried | wrap the user auth in a service auth and you're good. | |
| 13:07:34 | efried | what service is this for? | |
| 13:08:02 | sean-k-mooney | efried: hongda patches https://review.opendev.org/#/c/669867/1 | |
| 13:08:12 | sean-k-mooney | and this stable only patch https://review.opendev.org/#/c/670016/ | |
| 13:08:21 | openstack | Launchpad bug 1647451 in OpenStack Compute (nova) newton "Post live migration step could fail due to auth errors" [Medium,Fix committed] - Assigned to Lee Yarwood (lyarwood) | |
| 13:08:21 | sean-k-mooney | its related to https://bugs.launchpad.net/nova/+bug/1647451 | |
| 13:09:08 | sean-k-mooney | efried: so instead of juat createing an admin client here https://review.opendev.org/#/c/669867/1/nova/network/neutronv2/api.py we shoudl use the service auth thing right | |
| 13:10:28 | efried | sean-k-mooney: I'm going to have to take a closer look at this a bit later. What's the operation that starts this flow? | |
| 13:10:41 | efried | i.e. why does the user token have the opportunity to expire before list_ports? | |
| 13:11:37 | sean-k-mooney | efried: i ltrally just started looking at this 10 mins ago. but i belive its the admin does openstack server migrate --live near the end of the lifetime of the token | |
| 13:11:51 | sean-k-mooney | and it expires midway | |
| 13:11:57 | openstackgerrit | Merged openstack/python-novaclient master: Remove deprecated methods and properties https://review.opendev.org/667762 | |
| 13:12:00 | sean-k-mooney | or you know the live migration just take a while | |
| 13:12:17 | efried | at a glance, it appears as though the rest of the stuff in this flow is using admin auth | |
| 13:12:20 | sean-k-mooney | in either case it expires by the time it gets to post live migrate | |
| 13:12:45 | efried | but I don't want to discount the possibility that the list_ports is being done under user auth specifically to guard against someone kicking off this operation when they shouldn't. | |
| 13:12:47 | sean-k-mooney | well live-migate is an admin only op so its propably fine | |
| 13:14:01 | efried | okay. There's some more opportunities to reuse the admin client in this flow as well. | |
| 13:14:08 | efried | Let me come back to this after my mtg | |
| 13:14:40 | sean-k-mooney | sure i was more worried about breaking the api request id tracking stuff | |
| 13:15:09 | sean-k-mooney | but i guess that will be preseved in the keystone context so it prably fine | |
| 13:15:20 | sean-k-mooney | *proably | |
| 13:18:17 | efried | sean-k-mooney: If get_client with admin=True is breaking the global request ID, then that's broken all over the place. Would be a separate issue, if it's an issue at all. | |
| 13:18:55 | sean-k-mooney | efried: it proably isnt a problem | |
| 13:19:20 | efried | nope, I'm looking at get_client itself now and it's properly handling the global request ID. | |