| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-10 | |||
| 19:48:21 | dansmith | however, | |
| 19:48:27 | mriedem | https://review.opendev.org/#/c/636253/36/nova/tests/functional/test_cross_cell_migrate.py@65 | |
| 19:48:31 | dansmith | the config thing is a complex encoded structure in a string list, | |
| 19:48:38 | dansmith | which doesn't lend itself to that pattern quite as well | |
| 19:49:05 | mriedem | mmm delicious pci whitelist offspring | |
| 19:49:09 | dansmith | maybe have the helper return the contents, and then later have it get the value from config and parse it or something | |
| 19:49:40 | dansmith | but putting the parsing in a part of the code that complains about the format not being adhered to, well in advance of the patch that introduces the config option and doc is kinda silly | |
| 19:49:40 | mriedem | that would lend itself to easier functional testing as well - just stub the helper to return whatever config you are testing | |
| 19:49:45 | dansmith | right | |
| 19:50:13 | efried | yup, agreed | |
| 19:50:54 | dansmith | to be clear, that thing should not just return the string(s), but do the god-awful parsing of the : and | tokens and return a structure | |
| 19:51:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | |
| 19:51:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | |
| 19:51:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | |
| 19:51:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | |
| 19:51:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | |
| 19:51:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | |
| 19:51:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | |
| 19:51:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | |
| 19:51:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | |
| 19:51:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | |
| 19:51:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | |
| 19:51:46 | dansmith | and I'd like to see that whole stack ready to go at merge time, | |
| 19:51:54 | dansmith | not merging dead code in the driver well in advance of the later patch | |
| 19:52:19 | mriedem | dansmith: i lost your +2 on https://review.opendev.org/#/c/631123/because of the db migration | |
| 19:52:22 | dansmith | I didn't walk up the set any further because it has a bunch of merged or abandoned patches in the middle | |
| 19:52:23 | dansmith | so probably needs a good restacking | |
| 19:53:11 | dansmith | mriedem: maybe you'll be more careful with this one | |
| 19:53:26 | mriedem | ? | |
| 19:53:37 | dansmith | you lost the last one I gave you | |
| 19:54:19 | mriedem | i'm pretty sure this is the last time i have to rebase this series | |
| 19:56:57 | efried | Do we cover revert_resize in any of our CI jobs? | |
| 19:57:20 | mriedem | yes | |
| 19:57:58 | mriedem | definitely single node, the trickier is multi-node coverage | |
| 19:58:13 | efried | I'm looking at https://review.opendev.org/#/c/665138/ and not finding out a way to tell whether it's doing... anything at all. | |
| 19:58:54 | mriedem | http://logs.openstack.org/39/669539/1/check/tempest-full-py3/1555a09/job-output.txt.gz#_2019-07-05_22_24_52_926869 | |
| 19:58:56 | artom | efried, you stay away from that stuff. Run, I tell you. RUN! | |
| 19:59:20 | artom | efried, you could try using https://review.opendev.org/#/c/664442/ somehow | |
| 19:59:34 | sean-k-mooney | efried: for what its worth i have poposed that we dont backfil the libvirt pos feature and instead use any bandwith it frees up to work on things like numa in placment or novas use of placement in general | |
| 19:59:51 | efried | sean-k-mooney: proposed internally at RH you mean? | |
| 19:59:58 | sean-k-mooney | ya | |
| 20:00:01 | efried | that's wonderful. | |
| 20:00:27 | efried | I would really like to see us focus on moving forward that way rather than adding to the burden of stuff that helps us stay where we are. | |
| 20:00:38 | sean-k-mooney | we will see if that helps or not but my intent at least is to finish off the work i have started and then see what time is left in the cycle | |
| 20:00:53 | mriedem | efried: the tempest-slow job has a cold migration test that is doing revert resize but it's skipped http://logs.openstack.org/39/669539/1/check/tempest-slow-py3/cd3cb0e/job-output.txt.gz#_2019-07-05_22_44_58_146668 until sean-k-mooney/artom's fix lands... | |
| 20:00:57 | mriedem | so a catch-22 | |
| 20:01:25 | mriedem | https://review.opendev.org/#/c/663405/ | |
| 20:02:09 | sean-k-mooney | mriedem: dansmith merged your change to add teh iptables job to the experimenatl pipline right so that can be used for testing revert for now | |
| 20:02:17 | mriedem | but yeah https://review.opendev.org/#/c/664442/ is the canary | |
| 20:02:24 | mriedem | sean-k-mooney: oh yeah that's right | |
| 20:02:39 | artom | sean-k-mooney, I thought that was single node? | |
| 20:02:41 | mriedem | see? there are only like 5 need-to-know manual on-demand things | |
| 20:03:03 | artom | (That being the reason it failed - we didn't test same host revert with OVS hybrid plug) | |
| 20:03:19 | mriedem | artom: it is | |
| 20:03:39 | mriedem | so neutron-tempest-iptables_hybrid tests ovs hybrid plug same-host resize, | |
| 20:03:52 | mriedem | tempest-slow (will eventually) test multi-node revert | |
| 20:03:56 | mriedem | but not ovs hybrid plug | |
| 20:04:04 | artom | We have same-host resize in tempest-full-py3 too, no? | |
| 20:04:07 | mriedem | and tempest-full tests non-hybrid plug same host resize revert | |
| 20:04:11 | efried | So I could update https://review.opendev.org/#/c/665138/ to depend-on https://review.opendev.org/#/c/664442/ and that would tell me... what? | |
| 20:04:12 | mriedem | yes, but not ovs hybrid plug | |
| 20:04:12 | artom | jynx | |
| 20:04:14 | mriedem | and single node | |
| 20:04:16 | sean-k-mooney | artom: the iptables one is singel node yes | |
| 20:04:33 | artom | My brain is leaking | |
| 20:04:37 | efried | I'm probably too dense today to understand it anyway; maybe I'll just push it to the back of the queue again until I'm feeling sharp. | |
| 20:04:40 | mriedem | and the dnm patch at the top of the series for multi-node ovs hybrid plug=true | |
| 20:04:47 | sean-k-mooney | so same host resize revert can be tested which is basically cold migrate | |
| 20:04:54 | mriedem | efried: you're likely best leaving it to me and dansmith at this point | |
| 20:05:05 | efried | okay | |
| 20:05:11 | dansmith | save. yourself. | |
| 20:05:12 | mriedem | sean-k-mooney: .... we don't test same-host cold migration in the gate | |
| 20:05:14 | sean-k-mooney | technically we might allow same host "migrate" too but never bothered to try that | |
| 20:05:16 | artom | dansmith, that's what I said! | |
| 20:05:17 | mriedem | b/c the libvirt driver doesn't support that | |
| 20:05:29 | mriedem | sean-k-mooney: only the vcenter driver allows that | |
| 20:05:36 | sean-k-mooney | mriedem: well same host cold migrate isnt really useful | |
| 20:05:36 | artom | But noooo, we need "quality" and for things to "work" | |
| 20:05:48 | sean-k-mooney | wait they allow it because its a clustered hypervior | |
| 20:05:52 | mriedem | yes | |
| 20:05:58 | sean-k-mooney | so im guessing its not really the same host right | |
| 20:06:02 | sean-k-mooney | at least internally | |
| 20:06:05 | mriedem | different esxi host | |
| 20:06:15 | sean-k-mooney | right of course it is | |
| 20:06:17 | mriedem | same nova-compute service host | |
| 20:06:44 | mriedem | wonder if i could get some questions onto the openstack COA exam | |
| 20:07:04 | mriedem | "what is a compute node?" BZZZT! | |
| 20:08:42 | sean-k-mooney | when is disk_available_least bigger then free_gb | |
| 20:08:55 | efried | d) all of the above | |
| 20:08:55 | efried | c) an ironic instance | |
| 20:08:55 | efried | b) the physical system on which the nova-compute service runs | |
| 20:08:55 | efried | a) the same as a compute host | |
| 20:09:02 | dansmith | please, you guys are depressing me | |
| 20:09:21 | efried | (btw, I would totally fail that question) | |
| 20:11:20 | efried | mriedem: backporting... | |
| 20:11:36 | openstackgerrit | Eric Fried proposed openstack/nova stable/stein: Perf: Use dicts for ProviderTree roots https://review.opendev.org/670179 | |
| 20:12:02 | efried | I think the rocky backport is going to be dirty, because the mdev stuff I "fixed" wasn't there yet. | |
| 20:12:35 | efried | yup | |
| 20:14:06 | efried | oh, worse than that | |
| 20:15:36 | mriedem | unrelated, but while looking at ironic n-cpu job logs for that change on master, i see we hit a provider inventory conflict and we must refresh and re-push and it works | |