| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-10 | |||
| 15:37:32 | mriedem | locally, | |
| 15:37:33 | artom | mriedem, locally | |
| 15:37:36 | mriedem | tox -e <whatever> -- --failing | |
| 15:37:41 | artom | mriedem++ | |
| 15:38:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | |
| 15:40:07 | stephenfin | mriedem: 'openstack quota list --compute' won't show the _default_ quotas though, will it? | |
| 15:40:13 | stephenfin | (RE: https://review.opendev.org/#/c/667164/2/doc/source/admin/quotas.rst@68) | |
| 15:41:13 | mriedem | stephenfin: honestly i don't know how that command works under the covers, | |
| 15:41:25 | mriedem | "default" doesn't really mean anything for the compute API if you're not looking at the default class | |
| 15:41:31 | mriedem | neutron has an api to see 'defaults' | |
| 15:41:39 | mriedem | but i don't think cinder does and nova doesn't besides the class | |
| 15:43:49 | stephenfin | looks like 'quota list' is no good to us | |
| 15:43:51 | stephenfin | quota informations for requested project" | |
| 15:43:51 | stephenfin | "List quotas for all projects with non-default quota values or list detailed | |
| 15:44:10 | stephenfin | I'll add a note that there are non-compute quotas mixed in there | |
| 15:48:11 | mriedem | yeah this feels like a wild goose chase | |
| 15:48:19 | mriedem | sorting out the clis and docs is a mess | |
| 15:50:05 | openstackgerrit | sean mooney proposed openstack/nova master: WIP: coverage job changes https://review.opendev.org/669912 | |
| 15:59:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | |
| 15:59:55 | stephenfin | mriedem: ^ addressed what I could of them | |
| 16:00:01 | mriedem | ack | |
| 16:00:42 | spatel | sean-k-mooney: nevermind after reload rabbitmq cluster it fixed issue. | |
| 16:02:55 | sean-k-mooney | spatel: sorry i was on a call earlier but yes we have seen that before | |
| 16:03:43 | sean-k-mooney | restarting rabbit or the compute agged typicaly fixes it | |
| 16:03:51 | spatel | same here | |
| 16:04:32 | sean-k-mooney | its related to how oslo.messaging handels retrasmits and connection issue but i think they are trying to fix it | |
| 16:04:53 | sean-k-mooney | its not really a nova issue as we dont actuly handel creating the queue/exchanges | |
| 16:05:08 | sean-k-mooney | that is all done use by oslo.messaging | |
| 16:14:15 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a placement audit command https://review.opendev.org/670112 | |
| 16:31:23 | sean-k-mooney | alex_xu: efried thanks for your input on https://review.opendev.org/#/c/662264/. I have abandoned it for train so we can focus on similar uses of placements new feature in train and come back to cache in U | |
| 16:32:22 | sean-k-mooney | if im working on that again in U ill propose a placmeent native version that may pull some of the provider yaml stuff it that makes progress | |
| 16:40:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | |
| 16:40:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Scrub available quotas https://review.opendev.org/670125 | |
| 16:40:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | |
| 16:42:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | |
| 16:42:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | |
| 16:42:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Scrub available quotas https://review.opendev.org/670125 | |
| 16:48:08 | openstackgerrit | Merged openstack/nova master: db: Add vpmems to instance_extra https://review.opendev.org/662697 | |
| 16:59:01 | Sundar | Hello gibi, Could you look at https://review.opendev.org/657464 ? I understand it merited a -1 earlier, but I think we have resolved the naming issues in the Cyborg-Nova spec. Thanks. | |
| 16:59:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | |
| 16:59:46 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | |
| 16:59:46 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631 | |
| 17:06:40 | stephenfin | mriedem, melwitt: If we removed the injected_files, injected_file_content_bytes and injected_file_path_bytes quotas in API v2.57, does that mean the conf options in '[quotas]' should have a note saying the quotas aren't used anymore or something? | |
| 17:06:41 | openstackgerrit | Merged openstack/nova master: Remove 'nova.virt.libvirt.compat' https://review.opendev.org/669120 | |
| 17:07:15 | stephenfin | I'm not grasping whether those quotas actually do anything any more and, if so, what's enforcing it | |
| 17:16:29 | sean-k-mooney | stephenfin: i think we still need them since we still support it for older microversions | |
| 17:17:05 | sean-k-mooney | file injection itself is deprecated but you can still use it if you drop back too older microverions | |
| 17:32:50 | openstackgerrit | Merged openstack/nova master: libvirt: Remove unreachable native QEMU iSCSI initiator config code https://review.opendev.org/668750 | |
| 17:50:34 | openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | |
| 18:00:11 | openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | |
| 18:11:00 | mriedem | stephenfin: what sean-k-mooney said | |
| 18:12:57 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669 | |
| 18:12:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828 | |
| 18:12:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | |
| 18:12:59 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | |
| 18:12:59 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | |
| 18:13:00 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 18:13:00 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 18:26:11 | sean-k-mooney | someday we will have v4 api after the go rewite and then we can drop 2.1 api support | |
| 18:46:26 | mriedem | efried: i'm guessing you want to backport this right? https://review.opendev.org/#/c/637225/ | |
| 18:46:28 | mriedem | to at least rocky | |
| 18:48:51 | openstack | Launchpad bug 1835627 in devstack-plugin-ceph "test_shelve_unshelve_server failing on stable/pike (and probably ocata)" [Undecided,Confirmed] | |
| 18:48:51 | mriedem | lyarwood: fyi in case you never saw this https://bugs.launchpad.net/devstack-plugin-ceph/+bug/1835627 | |
| 19:26:18 | dansmith | efried: normally I'd like to see the top of a series be nearly ready to go before we merge a db migration for it: https://review.opendev.org/#/c/662697/ | |
| 19:26:26 | dansmith | I know you didn't +W, but, just my opinion | |
| 19:29:23 | efried | dansmith: I saw that go by and thought of you. | |
| 19:29:37 | efried | I considered -2ing for that reason, but then... didn't. | |
| 19:30:00 | efried | mriedem: yes, I would like to backport https://review.opendev.org/#/c/637225/ | |
| 19:30:19 | dansmith | I would have liked a different column name at least, but alas I missed my slot | |
| 19:30:44 | efried | sean-k-mooney: ack. What would be super awesome is if those efforts were sunk into getting us closer to NUMA modeling in placement. The nested magic stuff has merged. | |
| 19:31:16 | efried | dansmith: is it too late to correct it? We don't actually need to support mid-stream commit levels, do we? | |
| 19:31:41 | dansmith | uh, we do, and it's too late really | |
| 19:32:01 | dansmith | we could migrate the migration, but it's not worth it for that | |
| 19:32:27 | dansmith | but yes, we've always supported deploying any commit.. the sins that come from dropping that expectation are really bad | |
| 19:32:42 | efried | okay | |
| 19:42:31 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression https://review.opendev.org/669958 | |
| 19:43:40 | efried | dansmith: I appreciate you looking at that vpmem series though. I look at the object stuff and all I can do is compare it to existing things - I don't really understand it. | |
| 19:44:27 | efried | btw, the conf thing isn't there because I asked them to put that last, as it's the "master switch" that makes the admin think something should work. Probably some additional refactoring would be appropriate so we're not referencing the conf option before we introduce it. | |
| 19:44:59 | mriedem | is that the thing that starts exposing the inventory? | |
| 19:45:41 | mriedem | hopefully they have pretty robust functional testing before that - which you should be able to do with stubs or something w/o the config option | |
| 19:45:50 | dansmith | efried: putting the config option after code that uses it is backwards | |
| 19:46:32 | mriedem | we've done something like that before to keep a series moving before exposing it in the api, | |
| 19:46:46 | dansmith | but not actually referencing a non-existent config option | |
| 19:46:51 | mriedem | gibi's bw stuff in stein did something like that | |
| 19:46:52 | mriedem | yeah | |
| 19:47:17 | mriedem | my cross-cell resize stuff does something like that with the new policy rule - stubs a compute api method way earlier in the series to make functional testing possible before the api actually supports cross-cell resize | |
| 19:47:39 | dansmith | wrap the check in a is_thing_enabled() method and patch that in your tests or something | |
| 19:47:49 | mriedem | yup that's what both gibi and i did | |
| 19:47:52 | dansmith | yeah | |
| 19:48:19 | dansmith | i this case, | |
| 19:48:21 | dansmith | however, | |
| 19:48:27 | mriedem | https://review.opendev.org/#/c/636253/36/nova/tests/functional/test_cross_cell_migrate.py@65 | |
| 19:48:31 | dansmith | the config thing is a complex encoded structure in a string list, | |
| 19:48:38 | dansmith | which doesn't lend itself to that pattern quite as well | |
| 19:49:05 | mriedem | mmm delicious pci whitelist offspring | |
| 19:49:09 | dansmith | maybe have the helper return the contents, and then later have it get the value from config and parse it or something | |
| 19:49:40 | dansmith | but putting the parsing in a part of the code that complains about the format not being adhered to, well in advance of the patch that introduces the config option and doc is kinda silly | |
| 19:49:40 | mriedem | that would lend itself to easier functional testing as well - just stub the helper to return whatever config you are testing | |
| 19:49:45 | dansmith | right | |
| 19:50:13 | efried | yup, agreed | |