Posted	Nick	Remark
#openstack-nova - 2019-07-04
11:31:11	johnthetubaguy	just seems like we need to ignore libosinfo for now, and just default everything to virtio
11:31:27	kashyap	Right
11:32:08	johnthetubaguy	hmm, OK
11:34:10	openstack	Launchpad bug 1835400 in OpenStack Compute (nova) "Issues booting with os_distro=centos7.0" [Undecided,New]
11:34:10	kashyap	johnthetubaguy: Added a comment here based on the chat here: https://bugs.launchpad.net/nova/+bug/1835400
12:32:27	openstackgerrit	Merged openstack/nova master: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/667421
12:38:00	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669
12:38:01	openstackgerrit	Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828
12:38:01	openstackgerrit	Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
12:38:02	openstackgerrit	Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605
12:38:02	openstackgerrit	Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229
12:38:03	openstackgerrit	Artom Lifshitz proposed openstack/nova master: CONF.workarounds.enable_numa_live_migration is not needed >= Train https://review.opendev.org/640021
12:38:03	openstackgerrit	Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
12:41:29	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/669167
12:41:51	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/669168
12:41:51	openstackgerrit	Josephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption https://review.opendev.org/608696
12:42:28	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt: Add a rbd_connect_timeout configurable https://review.opendev.org/669169
12:59:37	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: vif: Remove MIN_{LIBVIRT,QEMU}_RX_QUEUE_SIZE https://review.opendev.org/669171
13:04:04	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177
13:04:05	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442
13:04:05	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631
13:11:49	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: vif: Remove MIN_{LIBVIRT,QEMU}_RX_QUEUE_SIZE https://review.opendev.org/669171
13:23:49	openstackgerrit	Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955
13:24:19	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Boot a VM with an unaddressed port https://review.opendev.org/641670
13:26:44	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Translatable output strings in heal allocation https://review.opendev.org/668925
13:27:27	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: vif: Remove MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN https://review.opendev.org/669176
13:28:21	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Mova consts from neutronv2/api to constants module https://review.opendev.org/668945
13:29:22	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module https://review.opendev.org/668945
13:45:07	kashyap	What is the 'U' release namE?
13:45:21	sean-k-mooney	we have not choosen one yet
13:46:10	sean-k-mooney	ya i have not seen much since then. we should call it unicorn
13:46:11	gibi	I currently use Unicorn as a workname
13:46:17	gibi	jinx
13:46:26	sean-k-mooney	haha ya me too
13:46:48	sean-k-mooney	it will totally have all my special feature i have wanted for years in it
13:47:03	kashyap	Yes, "nova, make me a sandwich"
13:47:16	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add 'resource_request' to neutronv2/constants https://review.opendev.org/668947
13:47:16	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Use neutron contants in cmd/manage.py https://review.opendev.org/668946
13:47:18	kashyap	https://xkcd.com/149/
13:47:29	sean-k-mooney	that would have been the S release
13:51:40	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181
13:58:57	stephenfin	It so peaceful here without all those pesky Americans cluttering the place up
14:00:16	sean-k-mooney	all of his cross cell migration code of couse so he wonders where the 20 patch series went :)
14:01:19	sean-k-mooney	and by 20 i appernetly ment 43
14:01:32	cdent	stephenfin: merge all the things. also thanks for abandoning that health check thing
14:01:58	cdent	gibi, sean-k-mooney : unfinished
14:04:02	gibi	cdent: not a bad idea :)
14:05:02	jangutter	I thought the "U" release would be "Unnamed".
14:05:24	gibi	sean-k-mooney, stephenfin: if you want to surprise mriedem then this could be easy too https://review.opendev.org/#/q/topic:bp/pre-filter-disabled-computes+(status:open+OR+status:merged)
14:06:05	stephenfin	oh, I can probably do that today
14:21:06	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Remove assumption of http error if consumer not exists https://review.opendev.org/669188
14:25:30	openstackgerrit	John Garbutt proposed openstack/nova master: Stop using virtio1.0-block and virtio1.0-net https://review.opendev.org/669190
14:30:04	sean-k-mooney	johnthetubaguy: regarding ^
14:30:08	openstackgerrit	John Garbutt proposed openstack/nova master: Stop using virtio1.0-block and virtio1.0-net https://review.opendev.org/669190
14:30:20	sean-k-mooney	we will still be ablt ot use virtio 1.0 device if qemu supports it right
14:30:27	sean-k-mooney	we just wont be forcing them
14:30:44	johnthetubaguy	I should probably change the short description
14:31:09	sean-k-mooney	well im reading https://libvirt.org/formatdomain.html#elementsVirtioTransitional now and then going back to read your patch
14:32:03	openstackgerrit	John Garbutt proposed openstack/nova master: Stop sending bad values from libosinfo to libvirt https://review.opendev.org/669190
14:32:29	johnthetubaguy	that is a better tag line
14:32:36	sean-k-mooney	yep
14:32:42	sean-k-mooney	and the patch makes sense too
14:32:49	johnthetubaguy	even better :)
14:33:06	sean-k-mooney	our min version is not 5.2 so we shoudl definetly be normalising
14:33:38	johnthetubaguy	yeah, I mean either way, we can't sent virtio1.0-net its just not a thing libvirt accepts
14:33:51	sean-k-mooney	it will be a while but we should add a todo to remove whne we have the required min version
14:34:12	sean-k-mooney	for the driver typ correct
14:34:20	sean-k-mooney	well the model
14:35:10	sean-k-mooney	actully we ming not need teh todo in that case
14:36:12	johnthetubaguy	we could do something more fancy, when we have new libvirt, I guess, but this seems more... backportable
14:36:38	sean-k-mooney	ya
14:37:13	openstackgerrit	Ghanshyam Mann proposed openstack/nova-specs master: Fix followup comments of policy-defaults-refresh spec https://review.opendev.org/669196
14:39:12	sean-k-mooney	that module in general feels weird.
14:39:30	sean-k-mooney	i was not expecting it to be doing things based on image metadata
14:40:13	sean-k-mooney	it feel like the HardwareProperties class shoulnd not be there
14:41:09	sean-k-mooney	really those properties shoudl jsut be on the image metadata object
14:41:50	sean-k-mooney	thats unrealed to your cahnge but just an observation.
14:43:36	johnthetubaguy	agreed... its odd
14:44:36	sean-k-mooney	is this file used by anything other then the libvirt driver
14:46:46	johnthetubaguy	not that I can see
14:47:00	johnthetubaguy	I suspect it was placed aspirationally
14:47:45	sean-k-mooney	im wondering if we should do this in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py instead
14:49:13	johnthetubaguy	I think there are more issues than that, looking at this more closely
14:49:52	johnthetubaguy	right now we fail to boot instances with the "correct" os_distro, that is probably the main bit
14:50:13	johnthetubaguy	looking at a follow up patch... this isn't right
14:50:22	sean-k-mooney	i think this is only ever used here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L237
14:50:35	sean-k-mooney	outside of test that is
14:51:06	kashyap	johnthetubaguy: Nice, the "Stop sending bad values"...
14:52:04	sean-k-mooney	kashyap: this actully look like a libosinfo bug to me
14:52:27	kashyap	sean-k-mooney: This morning we analyzed, there is definitely a Nova bug here.
14:52:39	kashyap	(If there's a libosinfo bug, that could be extra)
14:53:05	sean-k-mooney	there proably is too but i am not sure that libosinfo should also be retruning virtion1.0-net
14:53:08	openstack	Launchpad bug 1835400 in OpenStack Compute (nova) "Issues booting with os_distro=centos7.0" [Medium,In progress] - Assigned to John Garbutt (johngarbutt)
14:53:08	kashyap	See my comment in the bug: https://bugs.launchpad.net/nova/+bug/1835400
14:53:50	kashyap	Not probably, we pretty sure know there is a Nova bug. Nova's validation is incomplete. And the is_vif_model_valid_for_virt() does not have the full list of hardware models
14:53:51	sean-k-mooney	im not sure it should be encoding the virtio version in the model name
14:54:13	kashyap	We're sure; I checked with the libosinfo + libvirt upstream this morning
14:54:34	kashyap	johnthetubaguy: and I had an hour-long chat here (might want to read the scroll, if you could stomach reading it).
14:54:40	johnthetubaguy	this is another data point: https://github.com/virt-manager/virt-manager/commit/617b92710f50015c5df5f9db15d25de18867957d
14:55:00	kashyap	sean-k-mooney: 'virtio' is the _right_ choice. Beacuse see the documentation johnthetubaguy linked to in the commit message.

Earlier   Later