Posted	Nick	Remark
#openstack-nova - 2019-07-03
19:13:35	sean-k-mooney	mriedem: ya i just clicked in an notice the job that failed faild before the test ran
19:13:44	sean-k-mooney	qqmber: did you confimr the migration
19:14:19	sean-k-mooney	if not the instace might still be pointing at the source node.
19:16:48	qqmber	yes, I did
19:17:10	qqmber	is there any way to confirm that? (I'm 99.9999999% sure I did)
19:17:16	sean-k-mooney	ok i was just wondering if the instace.host could still be set to the old host
19:17:40	sean-k-mooney	which would likely mess up attaching new volumes
19:18:26	qqmber	this instance had 2 volumes before the migration... after the migration one volume "died" (maybe because of the current problem), and now I'm not able to attach new ones...
19:19:15	sean-k-mooney	is the dead volume form the same cinder backend as the one that does not show up
19:21:11	sean-k-mooney	dansmith: by the way for atroms revert resize change you want to avoid the api change by doing the db lookup as mriedem and i were discussing and then have the followup patch on master change to passing the migration object down and remvoe the db lookup right
19:21:29	dansmith	sean-k-mooney: I
19:21:33	sean-k-mooney	cool
19:21:53	dansmith	sean-k-mooney: I'm fine with doing the one thing and backporting it, but mriedem is not, so then yes, those two steps
19:22:01	sean-k-mooney	i kind of prefered that too but was not sure how you would feel about the extra db query
19:22:40	dansmith	sean-k-mooney: IMHO, backporting the interface change is not a problem, so we could avoid the lookup and the two-step dance
19:22:53	dansmith	but mriedem wants the interface to be stable, which is also fine
19:23:04	mriedem	we'll have a two step either way (to remove the TypeError handling)
19:23:04	dansmith	what I'm not okay with is the duck typing on our internal interface
19:23:15	sean-k-mooney	yep
19:23:17	dansmith	mriedem: I'm not okay with the typeerror either.. like, at all.
19:23:44	dansmith	mriedem: we don't need it though, because it's all an internal interface.. we could just pass the thing in and change all the drivers, and backport that
19:23:55	sean-k-mooney	well the type error handeling is for oot drivers
19:24:07	dansmith	sean-k-mooney: right, which I don't care about at all
19:24:09	sean-k-mooney	which i know we technicaly dont support
19:24:29	mriedem	i only really care here b/c of backports
19:24:36	mriedem	if it weren't being backported i'd just say change the interface
19:24:51	mriedem	i'm not losing sleep over this though
19:24:59	sean-k-mooney	ok im just trying to make sure we know what to change while both of ye are on vacation for the next two days
19:25:00	dansmith	right, but I don't get why the backport matters, since this is all inside nova-compute, except for the OOT drivers, which .. I don't care about
19:25:03	dansmith	but whatever
19:25:07	mriedem	oh i'm here friday
19:25:12	dansmith	me too
19:25:18	sean-k-mooney	oh ok
19:25:29	mriedem	i am, however, gone the entire week of the 15th
19:25:31	mriedem	with no laptop
19:25:45	dansmith	so wait until the 15th and then we merge? :D
19:25:52	mriedem	and the revert on the 16th? sure.
19:25:56	dansmith	geg
19:26:01	dansmith	er, heh
19:26:26	sean-k-mooney	i mean its only merged once 3 times the charm right
19:27:03	mriedem	i really look forward to having to eyeball the diff yes
19:28:37	sean-k-mooney	so to sumerise do the two step dance with the db lookup to minimes the backport size
19:29:09	dansmith	yes
19:29:20	sean-k-mooney	cool
19:30:53	sean-k-mooney	ok im catully going to drop for the evenying enjoy tommorow o/
19:35:00	openstackgerrit	Merged openstack/python-novaclient master: Modify the url of upper_constraints_file https://review.opendev.org/665934
19:56:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Follow up for pre-filter-disabled-computes series https://review.opendev.org/668986
19:56:32	efried	sean-k-mooney: I posted that review. The part that pertains to what we were discussing earlier (child providers for LLC) is here https://review.opendev.org/#/c/612497/4/specs/train/approved/provider-config-file.rst@109
19:57:07	efried	sean-k-mooney, dansmith: That spec is probably close enough for y'all to start looking at now. https://review.opendev.org/#/c/612497/
19:57:57	efried	There's still work to be done, as noted, but it's in a place where there are no longer *major* issues that I am seeing. So a good time for *you* to identify major issues :)
20:03:47	mriedem	this all looks dead https://review.opendev.org/#/q/topic:bp/add-emulated-virtual-tpm+(status:open+OR+status:merged)
21:08:40	efried	mriedem: as in, been in merge conflict for a while, or as in, you looked at the code and it doesn't seem like it matches the spec etc?
21:11:15	mriedem	former
21:11:25	mriedem	i feel my abandon finger itching
21:21:58	efried	mriedem: We reapproved that spec for this release (in April). Go abandon something *really* old.
21:24:34	mriedem	blarg
21:26:40	openstackgerrit	Eric Fried proposed openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042
21:41:58	openstackgerrit	Merged openstack/nova master: [FUP] Follow-up patch for SR-IOV live migration https://review.opendev.org/659101
21:42:04	openstackgerrit	Merged openstack/nova stable/stein: Stabilize unshelve notification sample tests https://review.opendev.org/668806
21:42:12	openstackgerrit	Merged openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967
22:45:10	efried	dansmith: I voted on the vgpu affinity spec
22:45:19	efried	gotta run, see y'all Monday o/
23:00:14	openstackgerrit	Merged openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315
23:00:21	openstackgerrit	Merged openstack/nova master: Rename CinderFixtureNewAttachFlow to CinderFixture https://review.opendev.org/668561
23:45:29	openstackgerrit	Merged openstack/nova master: Add neutron-tempest-iptables_hybrid job to experimental queue https://review.opendev.org/667154
#openstack-nova - 2019-07-04
00:16:16	openstackgerrit	Merged openstack/nova stable/queens: fix up numa-topology live migration hypervisor check https://review.opendev.org/648939
00:49:27	brinzhang	Hi all, who is familiar with the schema, please help review this schema check, thanks
00:49:34	brinzhang	https://review.opendev.org/#/c/663851/13/nova/api/openstack/compute/schemas/servers.py
01:06:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
01:06:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
01:06:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
01:06:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
01:06:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
01:06:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
01:06:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
01:06:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
01:06:11	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
01:06:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
01:06:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
01:06:13	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
01:06:13	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
01:06:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
01:06:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
01:06:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
01:06:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
01:06:16	openstackgerrit	Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
01:06:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
01:06:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
01:06:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
01:06:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012
01:22:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042
01:55:59	openstackgerrit	Merged openstack/nova master: Require at least cryptography>=2.7 https://review.opendev.org/667765
02:00:07	alex_xu	efried_pto: bauzas I only question is about why we just use existed json-schema we have. if it is already agreement by a lot of people, it is ok for moving forward
02:49:38	openstackgerrit	Takashi NATSUME proposed openstack/nova master: doc: Replace a wiki link with API ref guide link https://review.opendev.org/669027
02:51:37	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
03:02:03	openstackgerrit	Takashi NATSUME proposed openstack/nova master: doc: Add links to novaclient contributor guide https://review.opendev.org/669028
03:15:38	openstackgerrit	Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548
03:15:38	openstackgerrit	Luyao Zhong proposed openstack/nova master: db: Add vpmems to instance_extra https://review.opendev.org/662697
03:15:39	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree https://review.opendev.org/634551
03:15:39	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549

Earlier   Later