| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-02 | |||
| 14:10:46 | kashyap | gibi: When you can: done. Posted the shortlog as well. | |
| 14:10:46 | sean-k-mooney | you are doing an extra unchelve and shelve that are not needed | |
| 14:10:54 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/667354 | |
| 14:11:06 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/667355 | |
| 14:11:36 | sean-k-mooney | gibi: if _test_shelve_and_shelve_offload_server left it shelved and _test_unshelve_server required a shelved server it would speed up the test case | |
| 14:11:36 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/667355 | |
| 14:12:30 | gibi | sean-k-mooney: I could skip that but then instance would be in SHELVED case between the steps and that would ruin the generic pre-condition of the test steps enforced in https://review.opendev.org/#/c/668675/1/nova/tests/functional/notification_sample_tests/test_instance.py@384 | |
| 14:13:15 | gibi | sean-k-mooney: I could combine the two test step | |
| 14:13:17 | sean-k-mooney | i see | |
| 14:13:26 | gibi | kashyap: ack | |
| 14:13:42 | kashyap | Thanks a ton. | |
| 14:13:58 | sean-k-mooney | into a _test_shelve_shelve_offload_unshelve_server | |
| 14:14:10 | sean-k-mooney | ya that would be more efficent | |
| 14:15:13 | sean-k-mooney | and it would not violate the pre/post condition that the server is active between all steps | |
| 14:16:06 | sean-k-mooney | gibi: that said, these are fucntional tests | |
| 14:16:29 | gibi | kashyap: I'm +2 on the secure boot | |
| 14:16:29 | sean-k-mooney | so we are not actully snapshoting the server and uploading it to glance and then restoring it | |
| 14:16:52 | sean-k-mooney | so what you have is proably fine for the fake driver/fake libvirt whichever we are actully using | |
| 14:16:58 | kashyap | gibi: Thank you. And FWIW, I'm giving a "semi-strong +1" to to the CPU models thing, with a note. | |
| 14:17:08 | gibi | kashyap: thanks | |
| 14:17:13 | kashyap | As I don't want to block it any further, and we can hash out the details in the implementation. | |
| 14:18:49 | gibi | kashyap: ack | |
| 14:25:29 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.opendev.org/629597 | |
| 14:25:42 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: fix up numa-topology live migration hypervisor check https://review.opendev.org/648939 | |
| 14:26:21 | mriedem | lyarwood: can you hit https://review.opendev.org/#/c/629597/ ? | |
| 14:30:35 | mriedem | coreycb: can you ack this? https://review.opendev.org/#/c/668680/ | |
| 14:41:45 | efried | kashyap: Did you forget to hit save or are you still composing? | |
| 14:42:04 | kashyap | efried: Forgot to hit save, bad me. A sec | |
| 14:42:33 | kashyap | Oh, I went noting some grammar nit, and then two other people pinged and got distracted | |
| 14:43:19 | kashyap | efried: Done. | |
| 14:43:32 | efried | thanks kashyap | |
| 14:43:53 | kashyap | We can hash out the technical details (and surely we'd want to do some some robust functional testing _and_ post the results in the review for posterity/record) | |
| 14:44:00 | kashyap | ... in the implementation. | |
| 14:44:20 | kashyap | It's a +0.8. | |
| 14:46:03 | kashyap | efried: If you feel like fixing the grammar edit & re-ACK it; if you don't want to bother, also fine. | |
| 14:47:38 | efried | kashyap: I'm not being that picky anymore. | |
| 14:48:22 | kashyap | Can fully understand. It's just my OCD. | |
| 14:48:41 | kashyap | That's why I never -1 such things (unless it hampers reading, or is too sloppy). | |
| 14:53:47 | efried | kashyap: I've started blithely posting patch sets on other people's changes to correct grammar before I review for content. | |
| 14:54:26 | kashyap | efried: So you wanted to amend that behaviour? :-) | |
| 14:54:30 | kashyap | Can understand | |
| 14:54:35 | efried | alex_xu: if you're around, would you like the +W on https://review.opendev.org/#/c/642030/ ? Else I'll push it in a bit. | |
| 14:55:14 | kashyap | yaawang: Hi, please copy me on the impl of that 'cpu_models' thing. Happy to work out the details. | |
| 14:57:48 | kashyap | LOL | |
| 14:57:57 | kashyap | (Sorry) | |
| 15:04:18 | spatel | sean-k-mooney: morning | |
| 15:04:28 | sean-k-mooney | spatel: o/ | |
| 15:05:24 | spatel | I have testing my new openstack cloud, i have spun vm-1 but i am not seeing any live migration option in drop down menu | |
| 15:05:42 | gibi | kashyap: it is the remains of time I worked on versioned notifications a lot | |
| 15:05:53 | sean-k-mooney | spatel: that sound like a horizon issue | |
| 15:06:10 | spatel | hmm! | |
| 15:06:23 | sean-k-mooney | im not sure how that is displayed but i would not expect horizon to be able to tell if live migration is uspported | |
| 15:06:37 | sean-k-mooney | we do not have a api you can query to discover that | |
| 15:07:00 | kashyap | gibi: Yeah, guessed as much :-) | |
| 15:07:01 | sean-k-mooney | we just have teh endpoint to do a migration which can succeed or fail wehn you call it | |
| 15:07:07 | kashyap | sylvainb: Quite active discussion on that 'mdevctl' thread on libvirt upstream thread | |
| 15:07:17 | kashyap | Err, bauzas: | |
| 15:08:11 | kashyap | (I see that you wanted to try it, 'mdevctl' in Nova. Haven't caught up with the rest of the KM-long thread there, though.) | |
| 15:09:33 | spatel | sean-k-mooney: oh wait, when i logged in as admin i can see live migration | |
| 15:09:48 | sean-k-mooney | spatel: yes live migration is admin only | |
| 15:09:49 | spatel | its not available for end-user | |
| 15:10:23 | sean-k-mooney | spatel: yep the only action an endupser can do that might casue a migration to happen is resize | |
| 15:11:16 | spatel | yes they do have re-size option but not live, i think this is good because we don't want end user do live migration without understanding | |
| 15:11:47 | sean-k-mooney | yep | |
| 15:12:25 | spatel | sean-k-mooney: how do i evacuate single VM? is it something only available in command line? | |
| 15:13:04 | sean-k-mooney | proably. yes | |
| 15:13:43 | sean-k-mooney | you have to use the nova cli instead of opentasck one | |
| 15:13:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Stabilize unshelve notification sample tests https://review.opendev.org/668675 | |
| 15:15:21 | gibi | efried, mriedem: reported bug and fixed up the commit message ^^ | |
| 15:15:33 | efried | gibi: +2, thanks. | |
| 15:15:44 | gibi | efried: thank you | |
| 15:15:58 | efried | yahyoubetcha | |
| 15:23:22 | spatel | sean-k-mooney: let me try and see.. i am running test on cpu-pining live migration using evacuate | |
| 15:32:39 | sean-k-mooney | spatel: it should just be "nova evacuate <server>" and optioncally you can also proved a host as teh last postional arg. | |
| 15:33:33 | sean-k-mooney | since you are on shared stoarge however you need to ensure the vm is stoped and the compute service is disabled before you do the evacuate | |
| 15:37:35 | spatel | oh wait compute service disabled? | |
| 15:38:34 | sean-k-mooney | you cant evacuate form a host where the compute service is enabled | |
| 15:38:49 | sean-k-mooney | spatel: if the compute node is healty then you should jsut do a cold migration | |
| 15:39:05 | sean-k-mooney | cold migration wtih cpu pinning works as intended | |
| 15:39:16 | spatel | and cold migration support CPU-pining and hugepage | |
| 15:39:21 | sean-k-mooney | yep | |
| 15:39:52 | sean-k-mooney | for cold migration we generate a new xml on the destintion node so it works correctly | |
| 15:41:20 | sean-k-mooney | the bug for livemigration is while we caulate a new toplogy for the destination node we dont regenerate teh xml so we move teh vm bug still pin it as if it was on the souce node as we are using the xml form the source node instead of generating a new one for the destination node | |
| 16:35:43 | adrianc | Hi, any chance I can bother one of the fine cores here for a review for a FUP https://review.opendev.org/#/c/659101/ , already has a +2 from stephenfin :) | |
| 16:36:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Clean up test_virtapi https://review.opendev.org/667419 | |
| 16:36:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: manage COMPUTE_STATUS_DISABLED for hypervisor connection https://review.opendev.org/668707 | |
| 16:36:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VirtAPI.update_compute_provider_status https://review.opendev.org/668706 | |
| 16:45:20 | efried | adrianc: done | |
| 16:45:31 | efried | except for the "fine" part | |
| 16:47:50 | openstackgerrit | Merged openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/642030 | |
| 16:51:37 | sean-k-mooney | jaypipes: hehe that was an old pull request :) | |
| 16:56:56 | jaypipes | sean-k-mooney: lol, doing some housecleaning :) | |
| 17:02:56 | efried | jroll: you back today? | |
| 17:08:40 | openstackgerrit | sean mooney proposed openstack/nova-specs master: add libvirt pqos spec https://review.opendev.org/662264 | |
| 17:08:49 | sean-k-mooney | lyarwood: ^ is the updated versions | |
| 17:13:52 | sean-k-mooney | hum looks like i need to fix the diagram | |
| 17:14:10 | jroll | efried: yep, hi! | |
| 17:14:21 | efried | jroll: Wanna talk TPM? | |
| 17:14:37 | jroll | efried: gimme 15, in a meeting atm | |
| 17:14:40 | efried | sho | |