| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-07-02 | |||
| 08:56:51 | lyarwood | yasemin: `16.0.13` isn't a released version of openstack-nova upstream AFAICT, it should contain that patch as it was included in actual early releases but I obviously can't tell | |
| 08:57:23 | lyarwood | yasemin: feel free to open a bug https://launchpad.net/nova/ listing your versions of QEMU, Libvirt and where you got this version of openstack-nova. | |
| 09:36:12 | jrosser | lyarwood: i think that is the 16.0.13 release of openstack-ansible which pulls in this SHA of nova https://github.com/openstack/openstack-ansible/commit/f678b3d9a237a0cad229cad6cbc5fd9254b5a6f4#diff-78907cb9f0dc957a6642505f5b9c135cR150 | |
| 09:43:16 | lyarwood | jrosser: ack thanks | |
| 09:43:42 | lyarwood | yasemin: ^ so you should have that fix, 09593628fda7a6cb947fff34c725e3ef29889dc7 includes https://review.opendev.org/#/q/Iae2962bb86100f03fd3ad9aac3767da876291e74 | |
| 10:14:02 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 10:17:26 | yaawang | Hello, could anyone review these spec? It's about expose auto-converge/post-copy and vcpu model selection :) https://review.opendev.org/651681 https://review.opendev.org/642030 | |
| 10:18:33 | kashyap | stephenfin: You back? | |
| 10:18:52 | kashyap | stephenfin: What is the problem in this rST snippet on the said line: http://paste.openstack.org/show/753749/ | |
| 10:19:53 | stephenfin | and yes, back and not _too_ sunburnt | |
| 10:19:58 | kashyap | Hehe | |
| 10:20:06 | kashyap | (Hope you had a good time) | |
| 10:20:23 | kashyap | The literal block, where do I put it on line-306? Why rST, why you do this to me... | |
| 10:20:34 | stephenfin | 306 needs to be indented more | |
| 10:20:54 | stephenfin | and 303 needs to take the form '(a)', I think | |
| 10:21:09 | stephenfin | since it's not smart enough to realize that the '3.' refers to the above point | |
| 10:21:17 | stephenfin | though you can force the HTML to render that way, of course | |
| 10:21:28 | kashyap | It "worked" :-( | |
| 10:21:37 | kashyap | Let me fiddle | |
| 10:22:37 | stephenfin | In general, I'm learning that even if it looks better in raw form with 2 or 3 spaces, you're better off using four spaces for all indentation since it's more predictable | |
| 10:23:23 | kashyap | Yeah, I hear you | |
| 10:54:42 | kashyap | stephenfin: Another error I don't understand :-( -- http://paste.openstack.org/show/753750/ | |
| 10:55:09 | kashyap | I compared with another spec, and the indentation and bullets in the "History" section look exactly same | |
| 10:56:00 | kashyap | Oh, I think I'm missing the "Introduced" keyword | |
| 10:56:56 | cdent | efried: can you point me to a quick and dirty example of cleanly retrying a set_inventory_for_provider that's gets a generation conflict and that is being called independently . I'd like to cargo cult^w^wlearn by example if possible. | |
| 10:57:32 | stephenfin | kashyap: Yeah, you're missing the description bullet point for the 'Train' release | |
| 10:57:40 | stephenfin | * - Train | |
| 10:57:46 | stephenfin | - Introduce | |
| 10:57:47 | stephenfin | *d | |
| 10:57:49 | kashyap | stephenfin: Yep, figured as much. Done. | |
| 10:57:58 | kashyap | Thanks, and sorry for bothering with these trivialities. | |
| 11:22:03 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.opendev.org/506720 | |
| 11:22:44 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: We'd like to propose a way to create instance to take using of PCPU and VCPU resource in one instance. https://review.opendev.org/668656 | |
| 11:26:37 | kashyap | johnthetubaguy: As promised yesterday, reworked: Add "Secure Boot support for KVM & QEMU guests" spec https://review.opendev.org/506720 | |
| 11:26:49 | kashyap | johnthetubaguy: I added a short changelog in the Gerrit with what I addressed. | |
| 11:26:56 | kashyap | See if that matches our conversation from our past review. | |
| 11:31:27 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 11:39:11 | alex_xu | stephenfin: so we won't support to request PCPU for the instance without numa topo in standard cpu resource tracking spec, right? | |
| 11:39:40 | sean-k-mooney | alex_xu: that is the same as it has always been | |
| 11:39:42 | stephenfin | alex_xu: I wasn't planning to uncouple the two features, no | |
| 11:40:10 | alex_xu | thanks, that is what I'm expecting | |
| 12:09:06 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 12:10:04 | maxbahosh3 | hi there, i have problem with numa and my flavors. | |
| 12:10:06 | maxbahosh3 | i have 2 socket servers and 4 socket servers, and i want to set numa to user all socket for memory | |
| 12:10:12 | maxbahosh3 | i set hw:numa_nodes='2' for 2 socket server and hw:numa_nodes='4' for 4 socket | |
| 12:10:18 | maxbahosh3 | is it any way to configure one flavor to use for both type of servers? | |
| 12:16:30 | sean-k-mooney | maxbahosh3: no | |
| 12:16:52 | sean-k-mooney | you need two flavors or just use hw:numa_nodes=2 for all of them | |
| 12:17:15 | sean-k-mooney | maxbahosh3: well that or just dont set hw:numa_nodes at all | |
| 12:17:29 | sean-k-mooney | but that also means you cant use cpu pinning or hugepages | |
| 12:18:20 | maxbahosh3 | if i use numa nodes 2, just use 2 socket and and oom maybe occur | |
| 12:18:56 | maxbahosh3 | if not set, does it use all of socket? | |
| 12:19:22 | sean-k-mooney | if not set it uses all soceckt | |
| 12:19:42 | sean-k-mooney | what oom errors are you seeing | |
| 12:20:02 | sean-k-mooney | you shoudl not see the kernel killing instances | |
| 12:20:29 | sean-k-mooney | you may not be able to fit a vm but that would just be beacuse of the normal ttris problem | |
| 12:21:05 | maxbahosh3 | i see oom kiiler error cause of it use one instance, use one socket | |
| 12:21:25 | maxbahosh3 | so, i use numa node to use two socket | |
| 12:21:38 | sean-k-mooney | that means you have not correctly reserved memoyr per numa node | |
| 12:22:34 | maxbahosh3 | how can i reserved memory? | |
| 12:22:38 | maxbahosh3 | do you mean reserved_host_memory_mb ? | |
| 12:22:46 | sean-k-mooney | the oom killer runs per numa node and will be trigered whenever the kernel needs memroy on a specific numa node even if there is memory free on a different hode | |
| 12:22:50 | sean-k-mooney | *node | |
| 12:23:05 | sean-k-mooney | the best way to avoid this is to use hugepages | |
| 12:24:13 | sean-k-mooney | reserved_host_memory_mb is not enough. you also neeed to use cgroups to limit the memoy available to qemu/libvirt so that it cannot use all memory on each indivigual node | |
| 12:24:20 | maxbahosh3 | mmm, i didnt ahave any configuration for hugepages ... | |
| 12:24:40 | sean-k-mooney | if you use vm with hugepages it will both improve teh performace of the vms and prevent the OOM issues | |
| 12:25:41 | maxbahosh3 | do you have good tuning link for it? (i'm going to search on google) | |
| 12:31:49 | maxbahosh3 | sean-k-mooney | |
| 12:31:51 | maxbahosh3 | https://www.openstack.org/assets/presentation-media/performance-rhosp-summit-rmahroua2.pdf | |
| 12:32:18 | maxbahosh3 | i found this, i think it's a good point to start this tuning. thanks a lot | |
| 13:04:58 | sean-k-mooney | gibi alex_xu just responded to https://review.opendev.org/#/c/662264/5 ill respin in an hour or two and adress the issue you raised, let me know if the repsoces make sense or if you have other question and ill adress them all as part of the respin. thanks for reviewing :) | |
| 13:05:24 | gibi | sean-k-mooney: ack | |
| 13:08:20 | gibi | sean-k-mooney: your responses looks good to me | |
| 13:08:52 | sean-k-mooney | ok ill leave it as is for people to leave more feedback if the chose too and ill resping as i said in an hour or so | |
| 13:09:10 | gibi | sean-k-mooney: cool | |
| 13:09:23 | sean-k-mooney | in general are you ok with the feature? include the seperate RPs to make reshap simpler in the future? | |
| 13:10:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Stabilize unshelve notification sample tests https://review.opendev.org/668675 | |
| 13:10:52 | gibi | efried, mriedem: super simple test only change ^^ | |
| 13:12:10 | sean-k-mooney | i need to read the commit but how is this sablising the test? | |
| 13:13:03 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.opendev.org/506720 | |
| 13:13:43 | kashyap | lyarwood: Hey, when you get 10-ish minutes, want to have a gander at ⮭ | |
| 13:14:11 | kashyap | (You looked at it previously.) I've also included a short changelog of all the things I addressed, based on johnthetubaguy's feedforward. | |
| 13:16:00 | lyarwood | kashyap: ack will do | |
| 13:16:54 | efried | sean-k-mooney: Thanks for pointing out that MKTME spec. I was expecting it to show up, but didn't see it come in for some reason, possibly because it's proposed to backlog/ and I'm focused on train/. | |
| 13:17:21 | sean-k-mooney | oh i totally missed that | |
| 13:17:28 | sean-k-mooney | i thought it was for train | |
| 13:17:31 | efried | cdent: Unfortunately set_inventory_for_provider retry isn't "clean" because it goes through a dozen layers of the periodic update in the resource tracker | |
| 13:17:39 | efried | gibi: ack | |
| 13:18:10 | sean-k-mooney | in that case im less worried about the scope/alingment with the current sev spec | |
| 13:18:19 | mriedem | lyarwood: melwitt: i replied about the conflicts in this queens backport https://review.opendev.org/#/c/662471/ | |
| 13:18:24 | gibi | sean-k-mooney: yes, those test could fail if the timing is unlucky | |
| 13:18:54 | sean-k-mooney | ya i just figured out how this fixes it | |
| 13:18:56 | efried | cdent: oh, actually, snot so bad. set_inventory_for_provider called by update_from_provider_tree (both in report client) called by _update_to_placement (in resource tracker) | |
| 13:19:04 | efried | cdent: _update_to_placement has the retry decorator on it. | |
| 13:19:11 | sean-k-mooney | gibi: we are setting up the verifies but the test could end before the notificaion is sent | |
| 13:19:15 | efried | e, exception.ResourceProviderUpdateConflict)) | |
| 13:19:15 | efried | retry_on_exception=lambda e: isinstance( | |
| 13:19:15 | efried | @retrying.retry(stop_max_attempt_number=4, | |
| 13:19:15 | efried | cdent: | |