Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-28
15:47:54 efried mriedem: btw, that's what all those handy dandy CLIs were for ^
15:50:35 mriedem jesus that is a large patch,
15:50:38 mriedem can that be split up?
15:50:48 donnyd It reads fine to me. I would just use the same terminology everywhere. we call the function host-aggregate, so when referring to aggregate i would sub for host-aggregate
15:50:56 donnyd or whatever the proper term is
15:52:25 mriedem maybe it's mostly testing and docs...
15:52:27 efried mriedem: It could maybe be split up, but it would be kind of contrived. It's pretty easy to read imo
15:52:28 efried yes.
15:53:24 donnyd Yea, i had no issue at all understanding what is trying to be conveyed
15:53:33 efried donnyd: Thanks for the look. I actually don't know what the accepted term is, I probbaly flubbed several of those.
15:54:03 efried donnyd: (mriedem was talking about the patch as a whole, not specifically the doc)
15:54:38 efried I'll just go on record as saying I think this is a pretty darn cool feature.
15:55:20 efried Considering how weird and complex the implementation is, the external-facing usage model is pretty slick.
15:56:04 efried the most effed up part is how you have to collect the existing traits before you can add the one you want to the host :P
15:56:22 efried ...which of course has nothing to do with the forbidden aggregates feature.
15:57:43 dansmith is this already merged?
15:57:48 mriedem ok ok you win, we can add the PUT /resource_providers/{uuid}/traits/{trait_name} you've always wanted
15:58:03 dansmith I'm confused about how you get the exclusion just because one flavor is tagged
15:58:10 mriedem just like this fine mess https://developer.openstack.org/api-ref/compute/#server-metadata-servers-metadata
15:58:27 dansmith oh jeez,
15:58:29 efried dansmith: not merged
15:58:31 dansmith this is implementation and docs too
15:58:36 dansmith thought this was just a doc patch
16:00:10 efried mriedem: I'm not pulling for an *API* to add a trait, though that wouldn't be terrible. I don't mind if osc-placement does a get-add-replace. What I mind is that the CLI user has to do that. That sucks.
16:00:29 efried but we've already talked about this, hence the story
16:05:51 mriedem efried: i was joking about the api
16:06:09 mriedem the cli sugar should happen, it just needs a warm body,
16:06:15 efried yuh
16:06:23 mriedem speaking of which, i remember someone telling me recently they wanted to work on some code...
16:06:44 efried I think I have zero client patches to my name
16:06:58 efried actually, I might have an ironicclient patch or two :P
16:07:00 mriedem consider this an opportunity for growth
16:11:33 mriedem efried: dustinc: lots of comments and such in https://review.opendev.org/#/c/662881/ but +2; i'm going to post to the ML that i think other cores should be on board with this or nack it before EOD next tuesday for the spec review sprint
16:12:26 efried And pretty sure none of those were actually CLI.
16:12:26 efried 1 python-cinderclient
16:12:26 efried 1 python-glanceclient
16:12:26 efried 3 python-ironicclient
16:12:26 efried I count
16:12:37 efried thanks mriedem
16:36:10 sean-k-mooney i havent reviewed https://review.opendev.org/#/c/662881/8/specs/train/approved/openstacksdk-in-nova.rst
16:36:30 sean-k-mooney but im in favor of using the sdk in general
16:37:01 sean-k-mooney ill try to read it while i wait for dinner but ill proably be +1 on it
16:37:25 sean-k-mooney thanks for mailing the ist as it was not on my radar
17:49:11 dustinc thanks for reviewing everyone
19:00:34 openstackgerrit Merged openstack/nova stable/stein: Fix type error on call to mount device https://review.opendev.org/667921
19:07:26 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Remove needs:* todo from deprecated APIs api-ref https://review.opendev.org/668234
19:08:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Add StopWatch profiling to SchedulerManager.select_destinations https://review.opendev.org/668235
19:09:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Remove needs:* todo from deprecated APIs api-ref https://review.opendev.org/668234
19:15:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Add StopWatch profiling to SchedulerManager.select_destinations https://review.opendev.org/668235
19:16:53 openstackgerrit Merged openstack/nova stable/stein: Change InstanceFaultRollback handling in _error_out_instance_on_exception https://review.opendev.org/666638
19:17:00 openstackgerrit Merged openstack/nova stable/stein: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.opendev.org/666639
19:17:06 openstackgerrit Merged openstack/nova stable/stein: Avoid unnecessary joins in InstanceGroup.get_hosts https://review.opendev.org/664271
19:17:13 openstackgerrit Merged openstack/nova stable/stein: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface https://review.opendev.org/665513
19:17:20 openstackgerrit Merged openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.opendev.org/643853
19:20:40 mriedem fried_rolls: gah -f value -c ID fails me again http://logs.openstack.org/94/667994/2/check/nova-next/1519821/logs/devstack-gate-post_test_hook.txt.gz#_2019-06-28_01_50_02_145
19:29:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
19:45:09 mriedem fried_rolls: what are your thoughts on doing an os-traits release next week? trying to workaround not having https://review.opendev.org/#/c/667209/ released is becoming a pain.
19:49:58 efried mriedem: There's a release proposed right now, which includes ^. smcginnis is waiting for cdent (PTL) ack, but we could probably convince him to push it now if it's going to help you.
19:50:14 efried mriedem: https://review.opendev.org/667111
19:50:53 smcginnis If it's holding up something, we can push it through. Even though it's a Friday and we generally try to avoid that kind of thing right before the weekend.
19:51:01 smcginnis Just depends how time critical it is.
19:51:10 efried this one's pretty benign, release-risk-wise
19:51:18 efried like, really really benign
19:51:33 efried nearly betegn
19:51:35 smcginnis Yeah, I figured something like that would be low risk.
19:52:38 mriedem cool thanks
19:53:23 efried mriedem: you're still a placement core. Add your +1 and let's rip it. cdent will forgive us.
19:54:01 mriedem done
19:54:11 efried nice
19:54:14 efried smcginnis: ^
19:54:34 smcginnis OK, I'll send 'er through. And watch out for the wrath of cdent. :D
19:55:55 efried thank you sir
19:56:25 efried mriedem: You'll need requirements bump before you can use it anyway.
19:58:32 mriedem oh i know
19:58:39 mriedem but that's automatic
19:58:44 mriedem the proposal anyway
20:09:02 openstack Launchpad bug 1834691 in OpenStack Compute (nova) "AttributeError: 'HostState' object has no attribute 'failed_builds'" [Undecided,New]
20:09:02 mriedem AHA https://bugs.launchpad.net/nova/+bug/1834691
20:19:51 efried mriedem: takes a while though.
20:20:28 efried (requirements bot)
20:21:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Init HostState.failed_builds https://review.opendev.org/668243
20:21:43 mriedem what doesn't take awhile is +2ing this trivial bug fix ^ melwitt dansmith efried
20:38:50 efried mriedem: done. tbc the other thing is a separate issue?
20:38:54 mriedem yup
20:38:57 mriedem patch forthcoming
20:39:27 efried mriedem: requirements bump https://review.opendev.org/#/c/668245/
20:39:52 efried smcginnis: https://review.opendev.org/#/c/668245/ do you have the power?
20:40:29 smcginnis efried: Just waiting for zuul to report results on that.
20:40:43 efried slave to process you are, sheesh
20:40:46 smcginnis I can +2, but don't want to ninja that one through.
20:40:47 smcginnis :D
20:42:44 Sundar efried, cdent: Is there a master topic/blueprint for all nested magic stuff? I am looking for better query than https://review.opendev.org/#/q/project:openstack/placement+nested
20:43:06 efried Sundar: It's all in a single spec
20:43:20 efried Sundar: https://docs.openstack.org/placement/latest/specs/train/approved/2005575-nested-magic-1.html
20:43:54 efried unless you mean a doc for all currently implemented features. That would be https://docs.openstack.org/placement/latest/usage/provider-tree.html
20:44:19 efried plus the api-reference https://developer.openstack.org/api-ref/placement/
20:44:55 Sundar We've also had: https://review.opendev.org/657419. Some of your specs, since abandoned (like https://review.opendev.org/658510) were also useful to read
20:45:26 Sundar It would be useful to have a single topic or blueprint for all of these. What do you think?
20:46:23 efried Sundar: That patch was for the arbitrary suffix feature, which is included in the above spec.
20:46:34 efried If you want to track all the patches, you can look at the story

Earlier   Later