Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-27
15:34:37 mriedem now that DB API isn't returning hidden=True by default...
15:34:42 dansmith ...and so checking for instance.hidden in compute/api does what?
15:35:58 mriedem yeah in this case now b/c db api won't return the hidden one, "or instance.hidden" will always be false
15:36:06 dansmith right
15:36:22 mriedem the note above still applies, but the logical or doesn't
15:36:42 mriedem so are you ok with removing the or condition and leaving the comment?
15:37:02 dansmith yep, just said that in the review
15:37:33 mriedem yup, thanks
15:48:24 openstackgerrit melanie witt proposed openstack/nova master: Require at least cryptography>=2.7 https://review.opendev.org/667765
16:09:17 mriedem dansmith: i'm going to drop https://review.opendev.org/#/c/631123/34/nova/tests/unit/compute/test_compute_api.py then since it's not really valid since the db api wouldn't return a hidden=True instance
16:09:27 dansmith yeah
16:13:42 openstackgerrit Miguel Ángel Herranz Trillo proposed openstack/nova master: Add support for cloud-init on LXC instances https://review.opendev.org/667976
16:13:42 openstackgerrit Miguel Ángel Herranz Trillo proposed openstack/nova master: Add support for 'initenv' elements https://review.opendev.org/667975
16:15:40 mriedem looks like someone is trying to make libvirt+lxc work again
16:16:33 openstackgerrit Miguel Ángel Herranz Trillo proposed openstack/nova master: Add support for cloud-init on LXC instances https://review.opendev.org/667976
16:21:24 openstackgerrit Merged openstack/nova-specs master: support virtual persistent memory https://review.opendev.org/601596
16:30:48 efried mriedem: At some point recently you wrote a functional test that used a weigher to prefer host1 so that the assertion that we landed on host2 was provably valid every time (instead of just by chance). Can you put your finger on that easily?
16:31:30 mriedem efried: look for HostNameWeigher in the nova/tests/functional
16:31:32 mriedem there are several examples
16:31:39 efried thanks
16:31:54 mriedem ima push this big ass series b/c i've been rebasing it locally for weeks and want to flush it
16:33:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
16:33:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
16:33:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
16:33:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
16:33:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
16:33:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
16:33:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
16:33:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
16:33:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
16:33:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
16:33:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
16:33:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
16:33:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
16:33:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
16:33:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
16:33:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
16:33:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
16:33:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
16:33:40 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
16:33:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
17:00:02 efried Anyone know artom's status?
17:00:15 efried seemed like he was traveling recently
17:02:49 mnaser efried: i think i remember seeing his nick with some timezone appended to it
17:03:25 efried yeah, I recall that too, GMT+3 or something. But I wasn't sure where he was or whether he was going to be afk for some amount of time
17:03:28 tbachman p!spy artom
17:03:29 tbachman oops
17:03:31 tbachman lol
17:04:04 efried worst spy ever
17:04:08 tbachman lol
17:04:09 edleafe efried: https://leafe.com/timeline/%23openstack-nova/2019-06-27T08:57:05
17:04:15 tbachman purplerbot: log at http://p.anticdent.org/logs/artom
17:04:19 dansmith efried: he's on GMT+3
17:04:56 efried oh, so he's around, just out "early" (relative to me). Cool.
17:05:02 dansmith yar
17:26:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
17:35:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
17:50:13 openstackgerrit Merged openstack/nova master: Remove global state from the FakeDriver https://review.opendev.org/656709
17:50:23 openstackgerrit Merged openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552
18:43:07 openstackgerrit Merged openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
19:47:56 openstackgerrit Merged openstack/nova master: reorder conditions in _heal_allocations_for_instance https://review.opendev.org/655458
21:33:45 openstackgerrit Merged openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.opendev.org/637954
21:36:31 mriedem efried: https://review.opendev.org/#/c/637955/28 tag teamed
21:36:39 openstackgerrit Merged openstack/nova master: pull out put_allocation call from _heal_* https://review.opendev.org/655459
21:36:58 mriedem which do you want to be? https://toomanyposts.files.wordpress.com/2011/11/hartfound.jpg
21:37:55 efried dude, as long as I get to wear pink tights, who cares??
21:38:20 mriedem ok i'm bret then
21:39:29 sean-k-mooney has the follow up spec for numa with pmem been submited or is that for U
21:40:27 efried I haven't seen such a thing
21:40:42 mriedem that seems to be getting the cart way before the horse
21:41:05 sean-k-mooney the current spec says numa will be adress in a follow up spec
21:41:11 sean-k-mooney mriedem: not really
21:41:33 sean-k-mooney i think it makes sense to proced with the current spec that just merged
21:41:51 sean-k-mooney but im concerned the porsal i prolematic
21:43:09 sean-k-mooney specifcaly im really not ok with the driver generating numa object with out goign through the numa toplogy filter unless we ensure we dont restrit the guest ram and cpus to a numa node
21:43:50 sean-k-mooney if we generate a virtual numa node and do no affintiy to a host numa node fo any resoces it proably fine
22:04:14 openstackgerrit Eric Fried proposed openstack/nova master: Un-safe_connect and publicize get_providers_in_tree https://review.opendev.org/668062
22:08:23 openstackgerrit sean mooney proposed openstack/nova-specs master: Libvirt: add vPMU spec for train https://review.opendev.org/651269
23:27:46 alex_xu johnthetubaguy: mriedem_afk sean-k-mooney efried thanks for all the review, I will continue to look at the comment
#openstack-nova - 2019-06-28
00:14:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
00:14:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
00:14:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
00:14:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
00:14:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
00:14:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
00:14:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
00:14:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
00:14:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
00:14:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
00:14:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
00:14:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
00:14:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
00:14:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
00:14:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
00:14:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
00:14:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
00:14:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
00:14:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
00:14:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
00:14:36 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656

Earlier   Later