| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-24 | |||
| 15:45:59 | Nick_A | bug submitted - thank you | |
| 15:47:30 | mriedem | gdi that whole page probably has to be validated now | |
| 15:47:48 | mriedem | Nick_A: thanks | |
| 15:48:15 | mriedem | stephenfin: maybe you want to fix this https://bugs.launchpad.net/nova/+bug/1834057 | |
| 15:48:17 | openstack | Launchpad bug 1834057 in OpenStack Compute (nova) "change default quota command example is incorrect" [Undecided,New] | |
| 15:48:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | |
| 15:48:30 | mriedem | since you imported those docs and changed the cli used to be wrong w/o mentioning it in the commit | |
| 15:51:28 | stephenfin | mriedem: https://github.com/openstack/openstack-manuals/commit/655a9ce2c6372b94d2023242292aaae3a511e631 | |
| 15:53:16 | mriedem | that's not what's in https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/admin-guide/source/cli-set-compute-quotas.rst | |
| 15:58:12 | stephenfin | You're talking about the footer, I assume. I'm guessing that's because I wanted some kind of semi-permanent record though not the exact one | |
| 15:58:19 | stephenfin | But idk what I was thinking nearly two years ago | |
| 15:59:21 | dansmith | that neutron event patch is making it through check pretty well, compared to how it's been the last few weeks, so maybe not quite as long to gate as we thought | |
| 15:59:30 | stephenfin | Point is, I didn't change anything to be wrong. You could have just asked me to investigate and fix without assigning blame | |
| 16:05:47 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Revert "Add irrelevant files in dsvm job" https://review.opendev.org/667151 | |
| 16:06:55 | mriedem | stephenfin: yes the footer in the commit message points at the docs from stable/ocata so that's what i assumed you imported from, and those ocata docs were using nova CLIs but your change was not, so i assumed you changed things while importing | |
| 16:07:34 | mriedem | dansmith: can you slam this through? https://review.opendev.org/#/c/667151/ | |
| 16:07:50 | mriedem | keep the revert train rolling | |
| 16:14:11 | Nick_A | quota value of -1 = unlimited? | |
| 16:15:17 | sean-k-mooney | Nick_A: yes | |
| 16:15:23 | Nick_A | ty | |
| 16:26:14 | openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | |
| 16:29:22 | openstackgerrit | Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.opendev.org/601596 | |
| 16:29:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add neutron-tempest-iptables_hybrid job to experimental queue https://review.opendev.org/667154 | |
| 16:30:12 | mriedem | sean-k-mooney: ^ you can lay your change on top of that and then we can test it in the nova change itself | |
| 16:35:50 | sean-k-mooney | mriedem: yep ill do that. i was in meeting for the last hour and im just getting dinner now. ill submit a fixed patch later today hopefuly before i log off. if not ill work with artom to fix this tomorow. it should not be that hard to do but i have been tied up with other stuff so far today | |
| 16:36:41 | mriedem | sure, that's fine, and why i thought the fast revert was the way to go | |
| 16:37:23 | sean-k-mooney | ya. if it wasnt for the downstream prod issue this would have been the first thing i worked on today | |
| 16:37:42 | sean-k-mooney | anyway ill be back in an hour or so | |
| 16:39:07 | sean-k-mooney | tonyb: the cap that was added for sphinx in global-requirements is breaking the requiremetns check job | |
| 16:39:14 | sean-k-mooney | tonyb: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L459 | |
| 16:39:54 | sean-k-mooney | tonyb: we could merge https://review.opendev.org/#/c/666387/ however can you comment on why this cap was put in global-requirements and not upper-constraits | |
| 16:40:40 | sean-k-mooney | by doing it in global-requirements it is breaking os-vif and other repo but upper-constratis would have just worked | |
| 16:40:43 | sean-k-mooney | https://github.com/openstack/requirements/commit/00b2bcf7d664b1526b4eefe157c33113206d6251 | |
| 16:41:03 | sean-k-mooney | does not really explain why this was chosen but it does call out that you expect it might break things | |
| 16:44:05 | Nick_A | do network quota defaults still need to be set with neutron quota-update ? | |
| 16:44:06 | sean-k-mooney | i personally would prefer to remove the cap in global constratig and make the docs jobs use upper-constratits if they dont already | |
| 16:44:07 | Nick_A | Network quotas are ignored since quota class is not supported | |
| 16:44:07 | Nick_A | # openstack quota set --class default --floating-ips 0 | |
| 16:44:59 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Drop source node allocations if finish_resize fails https://review.opendev.org/667155 | |
| 16:45:27 | Nick_A | " | |
| 16:45:27 | Nick_A | "neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead. | |
| 16:45:38 | mriedem | neutron doesn't have quota classes as far as i know, | |
| 16:45:40 | mriedem | only nova and cinder | |
| 16:45:48 | mriedem | the osc cli docs are not clear about that either | |
| 16:46:17 | mriedem | i'm not sure what the quota options are with neutron, if it's just config (global) and per-project | |
| 16:46:23 | mriedem | that's a question for the -neutron channel | |
| 16:46:27 | Nick_A | gotcha | |
| 16:47:28 | mriedem | https://developer.openstack.org/api-ref/network/v2/index.html#quotas-extension-quotas | |
| 16:47:51 | mriedem | https://docs.openstack.org/neutron/stein/search.html?q=quota isn't helping | |
| 16:48:49 | mriedem | so my uneducated guess is (1) config for global defaults, (2) per-project defaults and (3) project-specific overrides | |
| 16:55:33 | Nick_A | we'll set them globally for now - https://docs.openstack.org/openstack-ansible-os_neutron/latest/ - thank you for looking | |
| 16:56:29 | stephenfin | https://docs.openstack.org/neutron/rocky/contributor/internals/quota.html | |
| 16:56:50 | stephenfin | Not sure if that's relevant or not | |
| 17:19:22 | openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | |
| 17:25:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rewrite quotas documentation https://review.opendev.org/667165 | |
| 17:25:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | |
| 17:26:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | |
| 17:36:23 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | |
| 17:36:30 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | |
| 17:53:21 | dansmith | mriedem: sorry was in a meeting | |
| 18:42:40 | openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | |
| 19:14:35 | openstackgerrit | Merged openstack/nova master: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/667035 | |
| 19:24:17 | openstackgerrit | Eric Fried proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.opendev.org/652103 | |
| 19:24:17 | openstackgerrit | Eric Fried proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.opendev.org/651555 | |
| 19:24:18 | openstackgerrit | Eric Fried proposed openstack/nova master: tests: Use consistent URL regex substitution https://review.opendev.org/665949 | |
| 19:24:18 | openstackgerrit | Eric Fried proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104 | |
| 19:24:19 | openstackgerrit | sean mooney proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | |
| 19:26:36 | sean-k-mooney | efried: thanks for reviewing the libvirt pqos spec. ill review and responed tomorrow | |
| 19:26:46 | efried | yahyoubetcha | |
| 19:30:30 | openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881 | |
| 19:51:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | |
| 19:51:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | |
| 19:51:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | |
| 19:51:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | |
| 19:51:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | |
| 19:51:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | |
| 19:51:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | |
| 19:51:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | |
| 19:51:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | |
| 19:51:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | |
| 19:54:37 | efried | johnthetubaguy: Would you please have a (hopefully final) look at https://review.opendev.org/#/c/658716/ and see if it's approvable? | |
| 20:00:01 | openstackgerrit | Matt Riedemann proposed openstack/os-traits master: Add COMPUTE_STATUS_DISABLED trait https://review.opendev.org/667209 | |
| 20:15:59 | mriedem | efried: i have one of your favorite all time questions, | |
| 20:16:17 | efried | airspeed velocity of an unladen European swallow? | |
| 20:16:55 | mriedem | SchedulerReportClient.set_traits_for_provider uses the ProviderTree cache https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1019 | |
| 20:17:08 | mriedem | but get_provider_traits does not https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L373 | |
| 20:17:47 | mriedem | i'm working on splitting up https://review.opendev.org/#/c/654596/ and the first thing I was going to do was https://review.opendev.org/#/c/654596/2/nova/scheduler/client/report.py as a separate patch which was set_provider_traits w/o the cache, | |
| 20:18:06 | mriedem | so the ComputeVirtAPI/virt driver usage for get/set provider traits would not be tied to a cache | |
| 20:18:25 | mriedem | but now i can't remember why i decided to go the no-cache route, | |
| 20:18:45 | mriedem | since i could link the compute manager / virt api / driver / RT reportclient together and then they'd all be using the same instance of the ProviderTree cache | |
| 20:18:51 | mriedem | and maybe that's desirable | |
| 20:19:28 | mriedem | so i guess main question is, is there any reason get_provider_traits isn't using the cache? | |
| 20:22:03 | mriedem | my more nagging question is if i should try to share the reportclient among compute/rt/virtapi and lean on the cache...though i'm not sure i trust the cache (i guess we'd know if the cache was wrong when we try to set traits on the provider using the wrong generation) | |
| 20:22:24 | efried | mriedem: get_provider_traits is in code paths that have already decided whether the cache is in play or not. It's kind of one of those "low-level" methods that probably - I haven't checked - started off as private and was developed before we had fully developed the caching model. | |
| 20:23:26 | efried | set_traits_for_provider is currently only being used in the rt resource update loop, which has a retry on generation conflicts, i.e. "using" the cache "safely". | |
| 20:24:04 | efried | In principle, up to this point I think we've been avoiding using the cache for any report client *outside* of the compute service. | |
| 20:24:15 | efried | are you intending to *write* traits from the *scheduler*? | |
| 20:24:24 | efried | or conductor | |
| 20:24:27 | efried | ? | |
| 20:26:11 | mriedem | no | |