| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-18 | |||
| 16:24:38 | Nick_A | Is this the place to ask about nova-lxd? | |
| 16:24:44 | dansmith | no. | |
| 16:27:51 | sean-k-mooney | Nick_A: nova-lxd is an out of tree dirver that is effectivly only supported by cannonical | |
| 16:28:23 | Nick_A | gotcha | |
| 16:29:09 | sean-k-mooney | Nick_A: https://github.com/openstack/nova-lxd#support-and-discussions looks like they use #lxcontainers | |
| 16:29:19 | Nick_A | having trouble getting initial root passwords injected with it for lxc and with libguestfs for kvm | |
| 16:30:33 | sean-k-mooney | Nick_A: its not listed here but it does not work for libvirt lxc https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_set_admin_password | |
| 16:30:54 | sean-k-mooney | Nick_A: so i would not be surprised if it was not supported for lxd also | |
| 16:31:56 | sean-k-mooney | Nick_A: https://github.com/openstack/nova-lxd/blob/bbdd85d5ce70e9b959c6b70a8ebc704ae41a1a79/doc/source/support_matrix/support-matrix.ini#L245-L260 its marked as unknon in there own documuentation so i dont think its suppored | |
| 16:32:50 | sean-k-mooney | Nick_A: if you are using config drive it might work https://github.com/openstack/nova-lxd/blob/d0faf787d92e20a55faf35ea6d95dd4d7ae7e598/nova/virt/lxd/driver.py#L584-L590 | |
| 16:33:02 | Nick_A | we've been trying with and without config drive | |
| 16:33:23 | Nick_A | reviewing your links thank you | |
| 16:33:46 | sean-k-mooney | ya i would suggest using user-data and cloud init instead | |
| 16:34:00 | sean-k-mooney | file injection is deprecated for some time now | |
| 17:35:07 | artom | dansmith, any chance I could get you to revisit https://review.opendev.org/#/c/644881/ hopefully one last time? I've added logging, and commented pointing out where they're happening in gate jobs. Should show that the patch works as intended and alleviate your reluctance to merge something you can't test | |
| 17:35:23 | dansmith | artom: I poked mriedem above to look at it | |
| 17:35:27 | dansmith | artom: I will after he does | |
| 17:35:33 | artom | dansmith, ack, appreciated | |
| 17:36:42 | artom | Am I the pony in this situation? | |
| 17:36:44 | artom | I've been worse | |
| 17:41:03 | dansmith | honestly, I have no idea | |
| 18:20:01 | mriedem | i'm trying to get some timings on this host_status perf regression before i kill this devstack env and then i'll get on that resize revert change | |
| 18:56:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression https://review.opendev.org/666042 | |
| 19:24:52 | openstackgerrit | Merged openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | |
| 19:24:59 | openstackgerrit | Merged openstack/nova master: Fix enabled_filters default value in admin config docs https://review.opendev.org/665751 | |
| 19:36:37 | openstackgerrit | François Palin proposed openstack/nova stable/queens: Include all network devices in nova diagnostics https://review.opendev.org/666152 | |
| 19:38:09 | mriedem | man https://review.opendev.org/#/c/644881/ is still queued after nearly 6 hours | |
| 19:38:12 | openstackgerrit | François Palin proposed openstack/nova stable/queens: Include all network devices in nova diagnostics https://review.opendev.org/666152 | |
| 20:19:10 | openstackgerrit | Merged openstack/nova master: Deprecate RetryFilter https://review.opendev.org/663953 | |
| 20:24:46 | mriedem | artom: dansmith: well the last time i commented was PS23 and now it's at PS32 so pretty hard to do a diff (unless I eyeball the patch sets in separate tabs), but i think i've found enough to -1 for now anyway | |
| 20:25:25 | artom | mriedem, cheers :) | |
| 20:25:40 | artom | (Whoever implements "diff of diffs" for Gerrit will have songs written about them) | |
| 20:26:37 | mriedem | mostly easy stuff | |
| 20:27:17 | mriedem | but you've missed some of the 35 conditionals from the existing libvirt driver _create_domain_and_network logic to determine if we should wait for events | |
| 20:28:11 | artom | Oh only 35? | |
| 21:17:47 | sean-k-mooney | dansmith: im pretty sure i know the answer to this but the order in which https://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L157-L161 is defined is not ment to change the behavior of the prefilters right? | |
| 21:18:59 | sean-k-mooney | because if i reorder that alphabetically then it breaks unit test by changing behvior | |
| 21:19:02 | sean-k-mooney | ALL_REQUEST_FILTERS = [ | |
| 21:19:03 | sean-k-mooney | require_tenant_aggregate, | |
| 21:19:05 | sean-k-mooney | map_az_to_placement_aggregate, | |
| 21:19:07 | sean-k-mooney | require_image_type_support, | |
| 21:19:09 | sean-k-mooney | ] | |
| 21:20:06 | sean-k-mooney | works but | |
| 21:20:09 | sean-k-mooney | LL_REQUEST_FILTERS = [ | |
| 21:20:11 | sean-k-mooney | map_az_to_placement_aggregate, | |
| 21:20:13 | sean-k-mooney | require_image_type_support, | |
| 21:20:15 | sean-k-mooney | require_tenant_aggregate, | |
| 21:20:17 | sean-k-mooney | ] | |
| 21:20:21 | sean-k-mooney | breaks | |
| 21:20:54 | aspiers | ooh, interesting | |
| 21:21:23 | sean-k-mooney | yes .... that is totally the word i would use | |
| 21:21:26 | aspiers | :) | |
| 21:21:27 | sean-k-mooney | :0 | |
| 21:22:18 | sean-k-mooney | i was trying to figure out how i broke the teant az fileter with https://review.opendev.org/#/c/665775/1/nova/scheduler/request_filter.py@195 | |
| 21:22:34 | sean-k-mooney | but then i just reorderd them on master and it also broke | |
| 21:27:34 | aspiers | sean-k-mooney: would you be able to advise me on an OVO problem? | |
| 21:27:51 | sean-k-mooney | aspiers: dansmith in case ye are wondering this aggragte https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L163-L165 gets returned here https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L177 and it should not | |
| 21:28:07 | sean-k-mooney | aspiers: i can try | |
| 21:29:08 | aspiers | sean-k-mooney: so neither of these approaches work https://review.opendev.org/#/c/664420/8..9/nova/virt/hardware.py | |
| 21:29:41 | aspiers | sean-k-mooney: and when I changed to hasattr I got a NotImplemented error from the ovo base class because image_meta.py doesn't implement obj_load_attr() | |
| 21:30:30 | aspiers | I tried copying an implementation from one of the other object classes which just does setattr(self, attrname, None), but that errors because None is not a valid value for image properties | |
| 21:31:12 | aspiers | I think the problem is maybe that while outside test environments, ImageMeta objects always have the "properties" property defined, inside test environments they don't | |
| 21:31:46 | sean-k-mooney | i just did "if key in request_spec.image.properties:" | |
| 21:32:07 | sean-k-mooney | but i could be safe and use .get() | |
| 21:32:15 | aspiers | no, I need to test "if properties in image" | |
| 21:32:25 | aspiers | not for some image property | |
| 21:32:36 | aspiers | see https://review.opendev.org/#/c/664420/9/nova/tests/unit/virt/test_hardware.py@3650 where ImageMeta is constructed without properties | |
| 21:32:43 | aspiers | this seems common in unit tests | |
| 21:32:48 | aspiers | they don't bother to populate all the fields | |
| 21:32:57 | sean-k-mooney | e.g. request_spec.get("image",{}).get("properties",{}).get(key) | |
| 21:33:24 | aspiers | I already tried that, it didn't work | |
| 21:33:42 | aspiers | well, I think it might have worked when starting with a request_spec | |
| 21:33:46 | sean-k-mooney | request_spec.get("image",{}).get("properties") will return none if its not set | |
| 21:33:55 | aspiers | but not when starting with objects.ImageMeta() | |
| 21:34:04 | sean-k-mooney | yes it will | |
| 21:34:05 | aspiers | in test_hardware.py there are no request_specs | |
| 21:34:16 | sean-k-mooney | the base ovo implmentes get for all fileds | |
| 21:34:35 | mriedem | wrong | |
| 21:34:45 | mriedem | only if using the DictCompatMixin | |
| 21:35:01 | aspiers | I will try .get() again but I'm pretty sure I tried that already | |
| 21:35:10 | mriedem | *nova/tests/unit/compute/test_compute_api.py | |
| 21:35:12 | mriedem | oops | |
| 21:35:15 | mriedem | NovaObjectDictCompat | |
| 21:35:20 | mriedem | not everything uses that | |
| 21:35:29 | mriedem | and we actually want to ween things off relying on it | |
| 21:35:36 | aspiers | Ahh interesting | |
| 21:36:05 | aspiers | Yeah, the "object or dict" paradigm kinda seemed weird to me | |
| 21:36:31 | mriedem | ImageMetaProps.get is it's own special thing | |
| 21:36:43 | sean-k-mooney | mriedem: ah your right its in VersionedObjectDictCompat https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L773 | |
| 21:36:58 | mriedem | and ImageMeta doesn't use the dict compat mixin | |
| 21:37:02 | mriedem | and RequestSpec.image is an ImageMeta object | |
| 21:37:20 | mriedem | so you can't do request_spec.get('image', {}).get('properties', {}) | |
| 21:37:33 | sean-k-mooney | ya i was actully just assuming it would always be set when we got to the request filetrs | |
| 21:38:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | |
| 21:38:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | |
| 21:38:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | |
| 21:38:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | |
| 21:38:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | |
| 21:38:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | |
| 21:38:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | |