Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-15
09:21:14 openstackgerrit Merged openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
09:21:24 openstackgerrit Merged openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
09:29:37 openstackgerrit Merged openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
09:37:07 openstackgerrit Merged openstack/nova master: Replace joinedload_all with joinedload https://review.opendev.org/664193
09:37:15 openstackgerrit Merged openstack/nova master: Add a test for the _joinedload_all helper https://review.opendev.org/665421
13:53:54 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface https://review.opendev.org/665513
15:39:01 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
15:42:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility https://review.opendev.org/621061
15:42:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
15:42:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315
15:42:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967
16:19:20 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518
16:27:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518
16:28:31 sean-k-mooney finucannot: hehe when i mentioned that to you a while ago i though you said we would not be able to use it in nova
16:29:34 sean-k-mooney finucannot: if we can then i would like to add https://github.com/SeanMooney/gerio/blob/master/.pre-commit-config.yaml#L14-L20
16:30:21 sean-k-mooney so that we dont have to deal with tabs or windows line ending ever being commit for people that choose to instll the hook like i intend too
#openstack-nova - 2019-06-16
03:33:23 openstackgerrit Merged openstack/nova stable/stein: Reset the stored logs at each notification test steps https://review.opendev.org/662965
07:30:04 openstackgerrit Merged openstack/nova master: Summarize output of sample configuration generator https://review.opendev.org/625014
08:03:58 openstackgerrit Merged openstack/nova master: Always Set dhcp_server in network_info https://review.opendev.org/658362
14:26:09 openstackgerrit Tao Yang proposed openstack/nova master: doc:remove the RamFilter from example https://review.opendev.org/665546
14:28:17 openstackgerrit Tao Yang proposed openstack/nova master: doc:remove the RamFilter from example https://review.opendev.org/665546
15:16:22 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
16:02:04 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
16:18:25 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
22:12:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153
22:12:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
22:43:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020
22:43:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027
22:43:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031
22:45:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299
22:45:48 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344
23:13:41 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673
23:19:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676
23:20:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689
23:42:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709
23:42:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
#openstack-nova - 2019-06-17
01:55:44 tonyb sean-k-mooney: done.
03:22:50 openstackgerrit Merged openstack/os-vif stable/stein: set ignore_basepython_conflict = True in tox.ini https://review.opendev.org/665195
03:26:58 openstackgerrit Merged openstack/os-vif stable/stein: Fix mock of built in "open" function in unit tests https://review.opendev.org/665196
05:25:46 openstackgerrit Merged openstack/nova master: Fix :param: in docstring https://review.opendev.org/665289
07:08:36 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912
07:08:37 openstackgerrit Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765
07:35:44 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476
08:17:37 openstackgerrit Tushar Patil proposed openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates https://review.opendev.org/665605
08:28:58 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
08:30:44 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
09:38:13 openstackgerrit Mark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync https://review.opendev.org/665626
09:38:14 openstackgerrit Mark Goddard proposed openstack/nova master: Update docs on db sync ordering & exit code https://review.opendev.org/665627
09:43:43 openstackgerrit Mark Goddard proposed openstack/nova master: Update docs on db sync ordering & exit code https://review.opendev.org/665627
09:43:43 openstackgerrit Mark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync https://review.opendev.org/665626
10:19:36 bhagyashris alex_xu, stephenfin, Sean-k-mooney: Hi, I would just like to hear your opinions on http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html
10:20:14 stephenfin bhagyashris: If sean-k-mooney and alex_xu are around, sure
10:20:24 stephenfin I'm replying to the mails one-by-one at the moment
10:21:05 bhagyashris stephenfin: ok thank you!
10:22:06 stephenfin bhagyashris: Do you have anything available to push to Gerrit. I'm getting nervous about how close the next deadline is
10:22:09 stephenfin *?
10:22:32 stephenfin I would like to start reviewing something and iterating nice and quickly if necessary
10:23:12 bhagyashris alex_xu, stephenfin, Sean-k-mooney: I just have concern about this point http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html
10:23:40 bhagyashris stephenfin: once that will be resolve then I will push the patches soon
10:23:45 stephenfin bhagyashris: Just replied to that http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007172.html
10:24:10 stephenfin bhagyashris: tl;dr: don't worry about it because we can rely on host aggregrates
10:25:08 stephenfin If an operator is using them, then pinned instance will always land on hosts in the pinned aggregrate (or whatever it's called). The VCPU inventory of these instances will never be consumed
10:25:14 stephenfin *of these hosts
10:26:12 bhagyashris stephenfin: I have to request to Matt as well. As he has given -2 and abandoned the patches: https://review.opendev.org/#/q/project:openstack/nova+topic:bp/cpu-resources I have submitted earlier
10:26:54 stephenfin If an operator is not using them, then things will be broken, but they were broken before
10:27:05 stephenfin bhagyashris: I can restore those for you if you're planning to re-use them?
10:27:55 bhagyashris stephenfin: yeah I am plaining to use that patches so that will be great if you can restore it :)
10:28:32 sean-k-mooney bhagyashris: the impmenation you did last cycle was not the same as the current spec. they were abandond becayse they had not been updated in many months and the spec was not approved for last cycle
10:28:34 bhagyashris stephenfin: checking your reply....
10:29:00 stephenfin bhagyashris: Hmm, yeah, looking at them, perhaps it would be better to submit new reviews
10:32:57 bhagyashris stephenfin: yeah but the base implementation has not that much change so I was thinking to push on the same. Only the upgrade patch that anyways not uploaded yet. But if you want to push the new patches then I will push new reviews
10:34:01 stephenfin Yeah, probably easier to just change the commit ID. I don't see that much context that would be useful going forward
10:34:17 stephenfin bhagyashris: Do you think you'll have patches available by the end of this week?
10:34:25 stephenfin At least WIP ones
10:35:06 bhagyashris stephenfin: ok I will push the new patches. Sure I will submit the WIP patches by end of this week
10:35:07 sean-k-mooney looking at the old patches i dont see any logic to soft pin floating instance to the shared_cpu_set
10:35:20 sean-k-mooney i assume that still needs to be written
10:43:19 bhagyashris stephenfin: I just want to ask about your reply that you said the host aggregrates should also be configured correctly that means if user request instance having the flavor extra specs ``resources:PCPU=1 and resources:VPU=1`` on upgrade node then in that case it will report both the VCPU and PCPU resources
10:43:40 stephenfin bhagyashris: No, we're not supporting that at the moment
10:43:57 stephenfin We can support it in U but not in Train
10:44:38 stephenfin Well, we could support it in Train with a big warning that operators need to do their homework, but the spec doesn't encompass that yet
10:44:51 sean-k-mooney stephenfin: its out of scope of the spec
10:44:54 bhagyashris stephenfin: means that flavor (having ``resources:PCPU=1 and resources:VCPU=1``) should have "aggregate_instance_extra_specs:pinned": "true" extra specs as well
10:45:03 sean-k-mooney bhagyashris: no
10:45:21 sean-k-mooney bhagyashris: in train we do not plan to allow host to have both pinned and non pinned cpus
10:45:23 stephenfin As noted in the other email, that was dropped from the spec to focus on getting the important piece - PCPU tracking in placement - done
10:45:27 sean-k-mooney *instances
10:45:33 stephenfin yeah, what sean-k-mooney said
10:45:49 sean-k-mooney host can be mixed but instances cannot, in train
10:47:41 bhagyashris sean-k-mooney : means operator can set either dedicated_set or shared_set only and not the both the set attime ?
10:47:55 stephenfin They can set both
10:48:04 sean-k-mooney mixing pinned and non pinned cpus in a singel instance was not allowed in the spec last cycle either. it was part fo a different spec.
10:48:05 stephenfin cpu_shared_set is also used for emulator threads
10:48:20 stephenfin sean-k-mooney: Nah, it was part of the spec but I scrubbed references to it
10:48:37 stephenfin What wasn't included was the NUMA stuff
10:48:41 sean-k-mooney stephenfin: hum maybe the other spec got folded in at some point
10:48:43 stephenfin *was never included
10:48:47 stephenfin Quite possibly, yeah
10:49:39 stephenfin bhagyashris: We're totally for supporting instances with pinned and unpinned instances in the future but not yet. This is just too complex already without adding more complexity
10:49:46 stephenfin and not having it makes upgrades simpler, as you note

Earlier   Later