Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-14
17:07:38 finucannot lookig
17:07:40 finucannot *looking
17:08:53 efried I definitely don't understand by looking at that code why it would be unreachable or whatever, which you clearly do at a glance (heh).
17:09:11 efried But the hacking rule seems straightforward to me, and uncontroversial, so I put the weird one after.
17:09:21 efried Could put them in parallel, but would have to resolve merge conflict then
17:12:57 mtreinish sean-k-mooney: +2
17:18:16 finucannot melwitt: Fancy sanity checking this patch https://review.opendev.org/#/c/662570/ (it's mriedem's)
17:18:40 melwitt finucannot: ah yep, meant to do that. looking
17:19:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Removing the stale parameters documented for kombu https://review.opendev.org/664153
17:25:59 openstackgerrit Eric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id https://review.opendev.org/663365
17:47:40 openstackgerrit Eric Fried proposed openstack/nova master: Clarify --before help text in nova manage https://review.opendev.org/661289
18:01:33 openstackgerrit melanie witt proposed openstack/nova master: Add 'path' query parameter to console access url https://review.opendev.org/649372
18:02:32 melwitt finucannot: updated ^
18:04:05 efried melwitt: your co-authored-by email address is wrong, intentional?
18:04:47 melwitt efried: no, that's my actual email because someone else owns melwitt@
18:05:04 efried oh, no kidding, and I just noticed after all these years.
18:06:13 melwitt haha, yeah I stubbornly wanted it to look like melwitt@ from a tidiness perspective but it's resulted in some people thinking they emailed me when they really didn't (oops)
21:52:49 openstackgerrit Merged openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003
21:52:59 openstackgerrit Merged openstack/nova master: Fix invalid privsep.readpty test https://review.opendev.org/656262
21:53:08 openstackgerrit Merged openstack/nova master: Add functional recreate test for bug 1829479 and bug 1817833 https://review.opendev.org/663737
21:53:09 openstack bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged] https://launchpad.net/bugs/1829479
21:53:10 openstack bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Undecided,In progress] https://launchpad.net/bugs/1817833 - Assigned to xulei (605423512-j)
21:53:21 openstackgerrit Merged openstack/nova master: Mock time.sleep() in unit tests https://review.opendev.org/648762
21:53:33 openstackgerrit Merged openstack/nova master: Modifying install-guide to include public endpoint for identity service https://review.opendev.org/663530
22:07:52 openstackgerrit Merged openstack/nova master: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface https://review.opendev.org/650097
22:08:00 openstackgerrit Merged openstack/nova master: Hacking N363: `in (not_a_tuple)` https://review.opendev.org/664041
22:08:08 openstackgerrit Merged openstack/nova master: Update quota known issues docs https://review.opendev.org/662570
22:22:22 openstackgerrit Merged openstack/nova stable/stein: Fix double word hacking test https://review.opendev.org/665147
#openstack-nova - 2019-06-15
00:11:42 openstackgerrit Merged openstack/nova stable/stein: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663677
00:15:13 openstackgerrit Merged openstack/nova master: Document restrictions for moving servers between availability zones https://review.opendev.org/650444
09:06:16 openstackgerrit Merged openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312
09:20:43 openstackgerrit Merged openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313
09:21:05 openstackgerrit Merged openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314
09:21:14 openstackgerrit Merged openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527
09:21:24 openstackgerrit Merged openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031
09:29:37 openstackgerrit Merged openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411
09:37:07 openstackgerrit Merged openstack/nova master: Replace joinedload_all with joinedload https://review.opendev.org/664193
09:37:15 openstackgerrit Merged openstack/nova master: Add a test for the _joinedload_all helper https://review.opendev.org/665421
13:53:54 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface https://review.opendev.org/665513
15:39:01 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
15:42:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility https://review.opendev.org/621061
15:42:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
15:42:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315
15:42:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967
16:19:20 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518
16:27:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8' https://review.opendev.org/665518
16:28:31 sean-k-mooney finucannot: hehe when i mentioned that to you a while ago i though you said we would not be able to use it in nova
16:29:34 sean-k-mooney finucannot: if we can then i would like to add https://github.com/SeanMooney/gerio/blob/master/.pre-commit-config.yaml#L14-L20
16:30:21 sean-k-mooney so that we dont have to deal with tabs or windows line ending ever being commit for people that choose to instll the hook like i intend too
#openstack-nova - 2019-06-16
03:33:23 openstackgerrit Merged openstack/nova stable/stein: Reset the stored logs at each notification test steps https://review.opendev.org/662965
07:30:04 openstackgerrit Merged openstack/nova master: Summarize output of sample configuration generator https://review.opendev.org/625014
08:03:58 openstackgerrit Merged openstack/nova master: Always Set dhcp_server in network_info https://review.opendev.org/658362
14:26:09 openstackgerrit Tao Yang proposed openstack/nova master: doc:remove the RamFilter from example https://review.opendev.org/665546
14:28:17 openstackgerrit Tao Yang proposed openstack/nova master: doc:remove the RamFilter from example https://review.opendev.org/665546
15:16:22 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
16:02:04 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
16:18:25 openstackgerrit Tao Yang proposed openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
22:12:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153
22:12:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
22:43:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020
22:43:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027
22:43:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031
22:45:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299
22:45:48 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344
23:13:41 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673
23:19:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676
23:20:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689
23:42:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709
23:42:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712
#openstack-nova - 2019-06-17
01:55:44 tonyb sean-k-mooney: done.
03:22:50 openstackgerrit Merged openstack/os-vif stable/stein: set ignore_basepython_conflict = True in tox.ini https://review.opendev.org/665195
03:26:58 openstackgerrit Merged openstack/os-vif stable/stein: Fix mock of built in "open" function in unit tests https://review.opendev.org/665196
05:25:46 openstackgerrit Merged openstack/nova master: Fix :param: in docstring https://review.opendev.org/665289
07:08:36 openstackgerrit Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912
07:08:37 openstackgerrit Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765
07:35:44 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476
08:17:37 openstackgerrit Tushar Patil proposed openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates https://review.opendev.org/665605
08:28:58 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
08:30:44 openstackgerrit guangchao.pan proposed openstack/nova master: Add a name for the automatically created volume https://review.opendev.org/660096
09:38:13 openstackgerrit Mark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync https://review.opendev.org/665626
09:38:14 openstackgerrit Mark Goddard proposed openstack/nova master: Update docs on db sync ordering & exit code https://review.opendev.org/665627
09:43:43 openstackgerrit Mark Goddard proposed openstack/nova master: Update docs on db sync ordering & exit code https://review.opendev.org/665627
09:43:43 openstackgerrit Mark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync https://review.opendev.org/665626
10:19:36 bhagyashris alex_xu, stephenfin, Sean-k-mooney: Hi, I would just like to hear your opinions on http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html
10:20:14 stephenfin bhagyashris: If sean-k-mooney and alex_xu are around, sure
10:20:24 stephenfin I'm replying to the mails one-by-one at the moment
10:21:05 bhagyashris stephenfin: ok thank you!
10:22:06 stephenfin bhagyashris: Do you have anything available to push to Gerrit. I'm getting nervous about how close the next deadline is
10:22:09 stephenfin *?
10:22:32 stephenfin I would like to start reviewing something and iterating nice and quickly if necessary
10:23:12 bhagyashris alex_xu, stephenfin, Sean-k-mooney: I just have concern about this point http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html
10:23:40 bhagyashris stephenfin: once that will be resolve then I will push the patches soon
10:23:45 stephenfin bhagyashris: Just replied to that http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007172.html
10:24:10 stephenfin bhagyashris: tl;dr: don't worry about it because we can rely on host aggregrates
10:25:08 stephenfin If an operator is using them, then pinned instance will always land on hosts in the pinned aggregrate (or whatever it's called). The VCPU inventory of these instances will never be consumed
10:25:14 stephenfin *of these hosts
10:26:12 bhagyashris stephenfin: I have to request to Matt as well. As he has given -2 and abandoned the patches: https://review.opendev.org/#/q/project:openstack/nova+topic:bp/cpu-resources I have submitted earlier
10:26:54 stephenfin If an operator is not using them, then things will be broken, but they were broken before
10:27:05 stephenfin bhagyashris: I can restore those for you if you're planning to re-use them?
10:27:55 bhagyashris stephenfin: yeah I am plaining to use that patches so that will be great if you can restore it :)

Earlier   Later