| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-12 | |||
| 09:40:06 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | |
| 09:40:44 | asettle | sean-k-mooney, I should never have commented on that post. Now it's a fan fav :p | |
| 09:41:32 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Skip test_check_doubled_words hacking check UT https://review.opendev.org/664841 | |
| 09:42:11 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512 | |
| 09:56:54 | lyarwood | mdbooth: https://review.opendev.org/#/c/457886/ - would you mind taking a look at this today if you have time | |
| 09:57:34 | mdbooth | lyarwood: Ack. I recall not liking it in a previous version? | |
| 09:59:25 | lyarwood | mdbooth: well as long as you're going into this with an open mind | |
| 09:59:35 | lyarwood | mdbooth: but yeah I've reworked it since then iirc | |
| 09:59:36 | mdbooth | lyarwood: ;) | |
| 09:59:43 | mdbooth | lyarwood: I saw. | |
| 10:05:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | |
| 10:05:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 10:05:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | |
| 10:09:25 | sean-k-mooney | asettle: i found a book you will hate or love last night https://www.amazon.com/Accidence-Will-Happen-Non-Pedantic-English/dp/0297871935/ref=tmm_hrd_swatch_0?_encoding=UTF8&qid=1560294844&sr=8-2 | |
| 10:09:52 | asettle | Ha! | |
| 10:09:56 | asettle | I'm not entirely too sure I want to read that, you know | |
| 10:11:24 | sean-k-mooney | i went donw the rabbit whole of is "is comprised of" correct to use in ireland vs other english speaking countries | |
| 10:14:39 | sean-k-mooney | considering i the amount of govenment and university site in ireland that use it i have more or less come to the conclution that in ireland at least its an accepted usage but i came across that book in my adventures | |
| 10:20:19 | cdent | asettle: step away from the usage books | |
| 10:21:10 | asettle | sean-k-mooney, damn that is a rabbit hole | |
| 10:21:32 | asettle | I'll admit - I don't care terribly ;) it took me a little while to wrap my head around the discussion | |
| 10:21:45 | asettle | Thinking about it, I would usually put "is comprised of" but efried is right, it's not correct | |
| 10:22:00 | asettle | cdent, I'm so very far away | |
| 10:24:20 | asettle | Yeah good call. I won't be doing that either :p | |
| 10:25:32 | cdent | save your energy for philosophical debate | |
| 10:25:57 | asettle | Which... I do... regularly? | |
| 10:26:57 | cdent | I mean with efried in particular. It's a bizarre form of stimulating | |
| 10:27:16 | cdent | with grammar you can't win, but philosophy, something else happens | |
| 10:48:10 | sean-k-mooney | cdent: actully that useage book basicly explains why many of the rules we use are no longer followed in common usage and advies that you use common sense when deciding if a rule should be followed or ignored | |
| 10:48:41 | sean-k-mooney | cdent: which is why is said asettle will either love it or hate it :) | |
| 10:49:10 | cdent | in truth, neither you, nor I, are in much of a position to be discussing usage :) | |
| 10:49:38 | sean-k-mooney | the second half of the book i belive tries to explain why some of the rule exist and actully teaches you why some of the rule exisit | |
| 10:51:36 | sean-k-mooney | cdent: that is very true that said i at least can ligitamtly point to the fact i speak a different dialect of english which has idioms from irish carried over :) | |
| 10:52:11 | cdent | hmm. born UK, raised US, now in UK? not really good enough | |
| 10:52:34 | sean-k-mooney | oh i didnt know you grew up in the US what part? | |
| 10:53:39 | cdent | indiana, kentucky, ohio | |
| 10:54:03 | sean-k-mooney | do you ever miss it? | |
| 10:55:55 | sean-k-mooney | efried: did your hacking change merge last night? | |
| 10:58:09 | cdent | For 4 years before I moved to the UK I lived in Seattle. I sometimes miss the pacific northwest, but don't really miss the other parts. | |
| 10:58:32 | kashyap | sean-k-mooney: I think it did | |
| 10:59:16 | cdent | it did, saw the launchpad update | |
| 10:59:39 | sean-k-mooney | cool so i just need to rebase on top of master rather then that specific patch | |
| 11:34:03 | openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | |
| 11:34:04 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 11:34:04 | openstackgerrit | Adam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/662105 | |
| 11:34:05 | openstackgerrit | Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | |
| 11:34:06 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 11:34:06 | openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | |
| 11:34:07 | openstackgerrit | Adam Spiers proposed openstack/nova master: Allow guest devices to include |
|
| 11:34:07 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add |
|
| 11:34:08 | openstackgerrit | Adam Spiers proposed openstack/nova master: Use |
|
| 11:34:08 | openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | |
| 11:34:09 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | |
| 11:39:28 | aspiers | efried: all SEV stuff now in a single series ^^^ The top 3 can be ignored for now however, since the 3rd from top is still WIP. | |
| 12:25:23 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | |
| 12:25:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | |
| 12:25:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | |
| 12:29:01 | alex_xu | efried: sean-k-mooney bauzas do you have any idea how can I process when the user specify both the hw:pmem and resources extraspec https://review.opendev.org/#/c/601596/14/specs/train/approved/virtual-persistent-memory.rst@261 | |
| 12:29:28 | sean-k-mooney | im reading that spec at the moment | |
| 12:29:44 | alex_xu | I thought we should have similar problem when we have numa on placement. how to deal with hw:numa_* stuff and resources | |
| 12:30:33 | sean-k-mooney | well at present the resouces:* extra spec are merged with teh auto calluated set | |
| 12:31:08 | sean-k-mooney | so we caluate teh vcpu and ram form the flavor and then you can override that using resouces:MEMORY_MB=X | |
| 12:31:31 | sean-k-mooney | but ideally i think we would prefer people not to ues resouces: directly | |
| 12:32:07 | alex_xu | +1 on not use resources directly | |
| 12:32:32 | sean-k-mooney | if they use hw:pmem that give us the flexablity adapt to placment modeling changes without needing to modify flavors | |
| 12:33:15 | alex_xu | sean-k-mooney: the problem is we have instance.vpmems field, and we extra the vpmem from extra spec, and put them in instance.vpmems. if the user uses resources directly, then we should parse resources, and put them back to the instance.vpmems? | |
| 12:33:16 | sean-k-mooney | usign resouces:* directly works but its a leaky abstraction | |
| 12:33:35 | alex_xu | also agree with that | |
| 12:34:30 | alex_xu | I thought we will have same problem for instance.numa_topology. if the user use the resources directly, how can we parse the guest numa topo from resources extra spec, and put them back to isntance.numa_topology | |
| 12:35:00 | sean-k-mooney | well today we dont model numa in placmenet | |
| 12:35:20 | sean-k-mooney | if we did then it would be a proablem we would have to sovle yes | |
| 12:35:41 | alex_xu | it is a problem for pmem now :) | |
| 12:35:43 | sean-k-mooney | the hw:* extrapecs are the ahtoritive ones for how the guest is virtualised | |
| 12:36:07 | sean-k-mooney | the resouces:* are authritive for resouce usage | |
| 12:36:19 | sean-k-mooney | if there is a conflcit wew could rais an exception | |
| 12:36:37 | sean-k-mooney | i need to finish re reading the spec but are we adding a request prefilter for this | |
| 12:36:57 | sean-k-mooney | i.e. to convert form hw:pmem to the placement requests? | |
| 12:37:15 | alex_xu | do we need? or just parse the hw:pmem in the ResourceRequest.from_extra_specs ? | |
| 12:37:18 | sean-k-mooney | if so then i would have it validate them and raise an exception if there is a conflict | |
| 12:37:31 | aspiers | sean-k-mooney, alex_xu: I just did something very similar for SEV | |
| 12:37:40 | aspiers | https://review.opendev.org/#/c/664420/4 | |
| 12:37:49 | sean-k-mooney | alex_xu: am we could just parse it there yes | |
| 12:37:51 | alex_xu | aspiers: nice | |
| 12:38:04 | alex_xu | sean-k-mooney: yea | |
| 12:38:14 | sean-k-mooney | aspiers: your using a request prefilter | |
| 12:38:26 | aspiers | yes | |
| 12:39:16 | alex_xu | at least request prefilter is better than mixing everything ResourceRequest.from_extra_specs | |
| 12:39:54 | sean-k-mooney | right the ohter option is to do it here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L387 | |
| 12:40:08 | sean-k-mooney | and in resources_from_request_spec | |
| 12:40:19 | sean-k-mooney | but the prefilter i think are cleaner | |
| 12:40:33 | sean-k-mooney | both would work | |
| 12:40:40 | alex_xu | yes, agree | |
| 12:40:47 | alex_xu | we can add that for pmem | |
| 12:41:48 | sean-k-mooney | alex_xu: as aspiers has done you can do your validation like this https://review.opendev.org/#/c/664420/4/nova/scheduler/request_filter.py@197 | |
| 12:42:05 | sean-k-mooney | to ensure there is no conflict | |
| 12:42:27 | aspiers | right | |
| 12:42:29 | alex_xu | sean-k-mooney: then the instance is going to error status? | |
| 12:42:52 | sean-k-mooney | yes i think so | |
| 12:42:57 | alex_xu | I guess people hate the instance is going to error status.... | |
| 12:43:02 | sean-k-mooney | we will refuse to sechdule | |