Posted	Nick	Remark
#openstack-nova - 2019-06-11
21:08:51	mriedem	can i get some stable core love on https://review.opendev.org/#/q/topic:bug/1830747+branch:stable/rocky ?
21:09:06	mriedem	working on flushing stable/rocky for a release
21:10:12	mordred	efried: oh - yeah - definitely not until it's actually going to test something
21:21:30	openstackgerrit	Eric Fried proposed openstack/nova master: Remove _ContextAuthPlugin.get_endpoint* workaround https://review.opendev.org/664703
21:29:55	openstackgerrit	Merged openstack/nova master: Replace 'is comprised of' with 'comprises' https://review.opendev.org/663175
21:32:19	sean-k-mooney	can we revert ^
21:32:26	sean-k-mooney	efried: it is not correct
21:33:35	sean-k-mooney	... i guess i dont care enought but "is comprised of" was correct "comprises" as used in that patch is not.
21:34:17	sean-k-mooney	"Nova is composed of multiple server processes" would also be correct
21:35:04	efried	sean-k-mooney: google it
21:35:08	efried	pick any result
21:35:51	efried	"is composed of" would be correct. "is comprised of" is not, nor is "comprises of".
21:36:20	efried	but it is correct as patched
21:36:38	sean-k-mooney	the current wording read quite badly to me
21:37:04	sean-k-mooney	the pacing feels wrong
21:38:59	efried	I would have accepted "is composed of", but now that it's grammatically correct, I don't see it being worth changing.
21:39:49	sean-k-mooney	i keep wanting to read it as if there is a comma after comprises
21:40:21	sean-k-mooney	if i force my self t to read it as written the its fine
21:46:45	sean-k-mooney	hum i can reluctanlty agree to never use comprises but https://www.grammarly.com/blog/comprise-vs-compose/ makes some sense
21:53:06	melwitt	I'm surprised someone opened a doc bug for that. as far as I've known, "is comprised of" makes OK sense
21:53:33	sean-k-mooney	melwitt: i was assuming it was a us vs uk thing
21:53:54	melwitt	yeah, I assumed must be a regional thing
22:05:11	efried	no, just such a common mistake it's almost become accepted
22:05:41	efried	Ask asettle :P
22:07:00	sean-k-mooney	got distracted reading the wiki article https://en.wikipedia.org/wiki/Comprised_of
22:07:20	sean-k-mooney	apparently its is commonly used in us patents and dates forn the 18 century
22:08:03	melwitt	¯\_(ツ)_/¯
22:08:17	sean-k-mooney	so i think its on better footing then performant
22:08:54	melwitt	haha right?
22:09:21	efried	oh, please do not base real english on what's in patents
22:09:26	melwitt	of all the other non-words we accept, "is comprised of" is the one to go after
22:10:16	sean-k-mooney	efried: the stonger argument is dont belive everything you read on wikipedia :P
22:50:27	openstackgerrit	Merged openstack/nova stable/rocky: libvirt: Avoid using os-brick encryptors when device_path isn't provided https://review.opendev.org/656463
22:57:38	openstackgerrit	Merged openstack/nova stable/rocky: Stop logging traceback when skipping quiesce https://review.opendev.org/660327
23:16:58	openstackgerrit	Merged openstack/nova stable/rocky: Restore connection_info after live migration rollback https://review.opendev.org/660375
23:17:05	openstackgerrit	Merged openstack/nova stable/rocky: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660362
23:33:21	openstackgerrit	Matt Riedemann proposed openstack/nova master: Make get_provider_by_name public and remove safe_connect https://review.opendev.org/664062
23:37:16	openstackgerrit	Merged openstack/nova stable/rocky: Replace the invalid index of nova-rocky releasenote https://review.opendev.org/663178
23:37:25	openstackgerrit	Merged openstack/nova stable/rocky: [stable-only] Improve the reno for consoleauth upgrade check https://review.opendev.org/661118
#openstack-nova - 2019-06-12
00:58:31	openstackgerrit	Merged openstack/nova stable/rocky: Add regression recreate test for bug 1830747 https://review.opendev.org/662578
00:58:32	openstack	bug 1830747 in OpenStack Compute (nova) rocky "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem)
00:58:38	openstackgerrit	Merged openstack/nova stable/rocky: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/662895
01:12:01	Sundar	Hi all, https://review.opendev.org/#/c/603955/ already has a +2 and a +1. Please review and help to close it. Thanks.
03:16:07	openstackgerrit	tonybrad proposed openstack/nova master: update constraints url https://review.opendev.org/664771
05:39:46	openstackgerrit	Merged openstack/nova master: Skip test_check_doubled_words hacking check UT https://review.opendev.org/664622
05:53:23	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383
07:05:33	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949
07:05:54	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.opendev.org/580336
07:17:27	openstackgerrit	Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559
07:17:49	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796
08:00:46	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011
08:01:01	openstackgerrit	Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036
08:01:25	lyarwood	stephenfin: ^ would you mind +W'ing these again once they pass, had to rebase to pull in https://review.opendev.org/#/c/664622/
08:49:16	openstackgerrit	Surya Seetharaman proposed openstack/nova master: [WIP] Add 'power-update' external event to listen to ironic https://review.opendev.org/645611
08:59:40	openstackgerrit	Brin Zhang proposed openstack/nova master: WIP: Specify availability_zone to unshelve https://review.opendev.org/663851
09:09:38	asettle	efried, "is comprised of" is what gets you going :p love it
09:10:33	aspiers	asettle: this means you're a nova hacker now
09:10:40	asettle	I imagine that's correct, yep
09:21:14	openstackgerrit	Brin Zhang proposed openstack/nova master: WIP: Specify availability_zone to unshelve https://review.opendev.org/663851
09:31:12	openstackgerrit	Li Zhouzhou proposed openstack/nova stable/rocky: NumaTopolgyFilter dosen't work as expected as pci_numa_policy is 'legacy' https://review.opendev.org/664838
09:40:06	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
09:40:44	asettle	sean-k-mooney, I should never have commented on that post. Now it's a fan fav :p
09:41:32	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: Skip test_check_doubled_words hacking check UT https://review.opendev.org/664841
09:42:11	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512
09:56:54	lyarwood	mdbooth: https://review.opendev.org/#/c/457886/ - would you mind taking a look at this today if you have time
09:57:34	mdbooth	lyarwood: Ack. I recall not liking it in a previous version?
09:59:25	lyarwood	mdbooth: well as long as you're going into this with an open mind
09:59:35	lyarwood	mdbooth: but yeah I've reworked it since then iirc
09:59:36	mdbooth	lyarwood: ;)
09:59:43	mdbooth	lyarwood: I saw.
10:05:31	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245
10:05:31	openstackgerrit	Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
10:05:32	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102
10:09:25	sean-k-mooney	asettle: i found a book you will hate or love last night https://www.amazon.com/Accidence-Will-Happen-Non-Pedantic-English/dp/0297871935/ref=tmm_hrd_swatch_0?_encoding=UTF8&qid=1560294844&sr=8-2
10:09:52	asettle	Ha!
10:09:56	asettle	I'm not entirely too sure I want to read that, you know
10:11:24	sean-k-mooney	i went donw the rabbit whole of is "is comprised of" correct to use in ireland vs other english speaking countries
10:14:39	sean-k-mooney	considering i the amount of govenment and university site in ireland that use it i have more or less come to the conclution that in ireland at least its an accepted usage but i came across that book in my adventures
10:20:19	cdent	asettle: step away from the usage books
10:21:10	asettle	sean-k-mooney, damn that is a rabbit hole
10:21:32	asettle	I'll admit - I don't care terribly ;) it took me a little while to wrap my head around the discussion
10:21:45	asettle	Thinking about it, I would usually put "is comprised of" but efried is right, it's not correct
10:22:00	asettle	cdent, I'm so very far away
10:24:20	asettle	Yeah good call. I won't be doing that either :p
10:25:32	cdent	save your energy for philosophical debate
10:25:57	asettle	Which... I do... regularly?
10:26:57	cdent	I mean with efried in particular. It's a bizarre form of stimulating
10:27:16	cdent	with grammar you can't win, but philosophy, something else happens
10:48:10	sean-k-mooney	cdent: actully that useage book basicly explains why many of the rules we use are no longer followed in common usage and advies that you use common sense when deciding if a rule should be followed or ignored
10:48:41	sean-k-mooney	cdent: which is why is said asettle will either love it or hate it :)
10:49:10	cdent	in truth, neither you, nor I, are in much of a position to be discussing usage :)
10:49:38	sean-k-mooney	the second half of the book i belive tries to explain why some of the rule exist and actully teaches you why some of the rule exisit
10:51:36	sean-k-mooney	cdent: that is very true that said i at least can ligitamtly point to the fact i speak a different dialect of english which has idioms from irish carried over :)
10:52:11	cdent	hmm. born UK, raised US, now in UK? not really good enough
10:52:34	sean-k-mooney	oh i didnt know you grew up in the US what part?
10:53:39	cdent	indiana, kentucky, ohio
10:54:03	sean-k-mooney	do you ever miss it?
10:55:55	sean-k-mooney	efried: did your hacking change merge last night?
10:58:09	cdent	For 4 years before I moved to the UK I lived in Seattle. I sometimes miss the pacific northwest, but don't really miss the other parts.
10:58:32	kashyap	sean-k-mooney: I think it did

Earlier   Later