| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-11 | |||
| 12:28:21 | sean-k-mooney | https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#log-translation | |
| 12:28:44 | sean-k-mooney | aspiers: excetions retruned from the api might be | |
| 12:28:51 | aspiers | right, logs != exceptions | |
| 12:28:56 | sean-k-mooney | excptions that are logged are not | |
| 12:29:12 | aspiers | obviously :) I mean exceptions which are raised | |
| 12:29:47 | sean-k-mooney | no what i mean is if you raise an excetip and also log it then the logged version is not translated | |
| 12:30:40 | aspiers | right | |
| 12:30:51 | aspiers | anyway the page you linked answers my questions so thanks for that | |
| 12:49:24 | yaawang | johnthetubaguy: Hi, are you good with the spec after updates? https://review.opendev.org/#/c/651681/ | |
| 13:17:00 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | |
| 13:17:01 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583 | |
| 13:23:17 | sean-k-mooney | mriedem: when you have a sec i need your advice on how we should be mocking "open" in os-vif if you can comment on https://review.opendev.org/#/c/664583/1/vif_plug_ovs/tests/unit/test_linux_net.py | |
| 13:23:28 | sean-k-mooney | that would be awsome | |
| 13:28:38 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | |
| 13:28:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | |
| 13:28:39 | openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | |
| 13:28:59 | mriedem | sean-k-mooney: i just said should probably be using the mock_open stuff that's part of mock rather than directly mocking the builtin | |
| 13:29:05 | mriedem | since i think that's what you're supposed to do | |
| 13:29:41 | sean-k-mooney | mriedem: ah ok i was not sure if there was more or not | |
| 13:29:42 | aspiers | mriedem: he is using mock_open() | |
| 13:30:00 | aspiers | oh ok sorry, not in test__disable_ipv6() | |
| 13:30:08 | yonglihe | spec "show-server-numa-topology" need core reviewer, alex_xu, mriedem , hope you have time , thanks. https://review.opendev.org/#/c/658716/ | |
| 13:30:27 | yonglihe | sean-k-mooney, hi, have a good day. | |
| 13:30:31 | sean-k-mooney | i got confused by the other stuff that aspiers is andding in nova for conditional mocking which we dont need | |
| 13:31:00 | aspiers | sean-k-mooney: right, the conditional stuff isn't usually needed for unit tests, just for functional | |
| 13:31:16 | aspiers | the docstring I added for patch_open covers that in detail | |
| 13:31:20 | sean-k-mooney | yonglihe: o/ | |
| 13:31:48 | sean-k-mooney | aspiers: right but i dont want to prot that to os-vif unless we really need it for something | |
| 13:32:17 | sean-k-mooney | in the unit test we have we dont really need it | |
| 13:32:31 | sean-k-mooney | and our functional test are intended to actully create bridges and ports | |
| 13:32:37 | aspiers | sean-k-mooney: sure, I think I just said that :) | |
| 13:32:50 | aspiers | you don't need it in this case | |
| 13:32:58 | sean-k-mooney | yep | |
| 13:36:09 | yonglihe | sean-k-mooney, we kind of address the NUMA stuff concern, i hope this spec cloud get approved. wish me lucky. | |
| 13:37:46 | sean-k-mooney | yonglihe: yes i reviewd the latest version and it looked fine to me https://review.opendev.org/#/c/658716/ | |
| 13:38:46 | sean-k-mooney | yonglihe: johnthetubaguy and alex_xu are p[roably the people you need to convicne now | |
| 13:40:26 | yonglihe | sean-k-mooney, sure, only if they got spare time. | |
| 13:42:49 | yonglihe | sean-k-mooney, and i'm working on to checking the vm's signature to make sure we delete only the VM OS created. That cleanup orphan suff. | |
| 13:43:52 | stephenfin | lyarwood, artom: Do I need to rebase the whole series for this so? http://logs.openstack.org/11/651311/11/check/openstack-tox-py27/5910a90/testr_results.html.gz | |
| 13:43:59 | stephenfin | Not sure if it's even fixed yet | |
| 13:44:05 | stephenfin | Or do we need a fix? | |
| 13:44:52 | openstackgerrit | Eric Fried proposed openstack/nova master: fup: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | |
| 13:45:25 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove unused mock in libvirt functional base https://review.opendev.org/664449 | |
| 13:49:00 | sean-k-mooney | yonglihe: ah ok cool yes that would be a nice saftey feature to add for the libvirt driver so im glad to hear your looking into it | |
| 13:50:11 | yonglihe | There may have some gap, if that VM no db recording and we want get the whole xml parsed i guess. | |
| 13:56:55 | artom | stephenfin, not sure what to tell you, lyarwood has more context I believe | |
| 14:04:32 | lyarwood | stephenfin / artom ; no you don't need to rebase, I just did it blind before artom pointed out it was a known unresolved issue | |
| 14:04:44 | stephenfin | ah, it's still unresolved | |
| 14:08:12 | yaawang | sean-k-mooney: Hi, I've replied your comment on gerrit, please take a look if you have time. https://review.opendev.org/#/c/651681 | |
| 14:09:48 | artom | dannins, thanks for the review :) I'm not married to the naming, obviously, so I'll try to come up with something better | |
| 14:09:58 | artom | Err, dansmith ^^ | |
| 14:10:21 | dansmith | artom: ack, I feel like an ass complaining about the hardest problem in computer science, but.. | |
| 14:10:36 | dansmith | might be that I'm just feeling my base state | |
| 14:11:04 | artom | dansmith, in terms of where to put them... get_virt_ in to libvirt/driver.py and get_manager_ in the compute manager? They're 2 sides of the same logic, so I kinda think they should go in the same place, one that's callable by both libvirt and the compute manager, so...? | |
| 14:11:11 | artom | dansmith, no, naming is important, it's fine :) | |
| 14:12:07 | dansmith | artom: virtapi is the wrong place for that, IMHO. I'm not opposed to them being adjacent | |
| 14:12:24 | kashyap | efried: Thanks for not minding my nit-pick! New PS looks good to me | |
| 14:12:47 | kashyap | [With the test failures fixed.] | |
| 14:13:00 | efried | thanks. Any idea wtf is up with the doubled words hacking test?? | |
| 14:13:02 | artom | dansmith, fair enough about virtapi being wrong, but... what else do we have? We talked about putting them in utils somewhere | |
| 14:13:29 | kashyap | efried: Which are those? | |
| 14:14:45 | efried | kashyap: This morning I saw py27 failing on several totally unrelated patches on hacking test_check_doubled_words | |
| 14:14:50 | efried | e.g. http://logs.openstack.org/49/664449/1/check/openstack-tox-py27/4ad64aa/testr_results.html.gz | |
| 14:16:13 | dansmith | artom: yeah, I dunno. utils feels a little generic.. what about in neutronapi or thereabouts? | |
| 14:16:23 | efried | nothing about that test has changed. No new hacking rules have been added recently (months). The only thing around hacking that's changed is when stephenfin updated hacking reqs, but that was like 6 weeks ago. | |
| 14:16:44 | stephenfin | efried: Scroll up | |
| 14:16:45 | artom | efried, https://bugs.launchpad.net/nova/+bug/1804062 I think | |
| 14:16:46 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |
| 14:16:55 | kashyap | efried: No idea about that one, afraid. | |
| 14:16:57 | stephenfin | ||
| 14:17:01 | stephenfin | efried: ^ | |
| 14:17:06 | stephenfin | (or down) | |
| 14:17:15 | stephenfin | I'm looking at it | |
| 14:17:18 | efried | stephenfin: But all the failures I saw today were in py27 | |
| 14:17:48 | artom | efried, <lyarwood> artom: no missed that thanks, however this is on 2.7 oddly enough. | |
| 14:17:49 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |
| 14:17:49 | artom | ||
| 14:17:50 | stephenfin | Hmm, Canonical hardly backported the change, did they? | |
| 14:18:12 | artom | dansmith, hrmm, neutronapi does make sense | |
| 14:18:23 | artom | And it's something both compute manager and driver use already | |
| 14:18:27 | artom | *libvirt driver | |
| 14:18:34 | dansmith | artom: mmhmm :) | |
| 14:19:02 | artom | It's still kinda weird that suddenly neutronapi will understand about compute manager and libvirt | |
| 14:19:08 | artom | But... that was going to be weird regardless | |
| 14:19:13 | dansmith | well, it doesn't reall,y | |
| 14:19:31 | dansmith | it just declares "late" and "early" events or something | |
| 14:19:42 | dansmith | it doesn't need to be revert specific, or even compute/virt specific | |
| 14:19:44 | artom | dansmith, ah I see - "bind-time" vs "plug-time" | |
| 14:19:49 | dansmith | something like that yeah | |
| 14:19:56 | artom | Well, except it's *very* revert specific | |
| 14:20:12 | artom | Because IIUC it doesn't happen unless the instance is present on the host, shut off | |
| 14:20:15 | dansmith | the fact that it's revert specific is a nova detail | |
| 14:20:27 | dansmith | it's specific to re-binding without changing the host, or whatever the eff it is | |
| 14:20:58 | artom | Updating the binding to a host that already has the instance | |
| 14:20:58 | efried | stephenfin: looks like it may have been backported, yeah. | |
| 14:21:20 | dansmith | artom: there's also nova/network/somethingelse | |
| 14:21:24 | dansmith | if you prefer | |
| 14:21:26 | prometheanfire | nova tests flakey? | |
| 14:21:42 | efried | prometheanfire: We think we're hitting https://bugs.launchpad.net/nova/+bug/1804062/comments/4 | |
| 14:21:43 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |