| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-06 | |||
| 10:56:28 | lyarwood | mdbooth: so that change disables it by default and leaves some configurables we can wire up over in https://review.opendev.org/#/c/515210/ if we wanted to | |
| 10:58:10 | lyarwood | mdbooth: just respinning to make the requirements more clear and link https://review.opendev.org/#/c/515210/ in the commit message | |
| 10:58:53 | mdbooth | lyarwood: Even with that change though, the test is still broken right? | |
| 10:59:17 | mdbooth | Because if the image has been previously cached by another test it won't actually run. | |
| 10:59:19 | lyarwood | mdbooth: if a valid image and trusted certs are provided then no | |
| 10:59:22 | mdbooth | s/run/validate/ | |
| 10:59:39 | lyarwood | mdbooth: it's no longer using the default image that wouldn't work | |
| 10:59:40 | mdbooth | It will pass, but it won't have tested image validation. | |
| 10:59:55 | mdbooth | Ah... you also updated the ref | |
| 10:59:58 | lyarwood | mdbooth: it should | |
| 11:00:00 | lyarwood | yeah | |
| 11:00:03 | lyarwood | it should cause a download etc | |
| 11:00:17 | mdbooth | lyarwood: Sorry, was being sloppy didn't read that far. | |
| 11:00:23 | lyarwood | the test isn't specifically looking at that btw | |
| 11:00:32 | lyarwood | that's more to just avoid failures | |
| 11:00:46 | lyarwood | the barbican plugin is really testing all of that | |
| 11:00:51 | openstackgerrit | Sharat Sharma proposed openstack/nova master: [Docs] Update the confusing console output https://review.opendev.org/589004 | |
| 11:22:40 | kashyap | sean-k-mooney: So, for the PCIe root ports, default to 32 / max 32 -- yeah? Based on DanPB's tests? | |
| 11:23:17 | sean-k-mooney | yes | |
| 11:27:21 | kashyap | Thx | |
| 11:28:49 | openstackgerrit | Edward Hope-Morley proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607 | |
| 11:49:39 | kashyap | git fetch gerrit | |
| 11:50:04 | kashyap | Oops | |
| 11:50:17 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Update the default number of PCIe root ports to 32 https://review.opendev.org/663614 | |
| 11:50:33 | kashyap | sean-k-mooney: ^ Still need to reword the commit, and tweak the test, perhaps | |
| 11:50:42 | kashyap | (And also to see if any other code path is effected) | |
| 11:54:38 | sean-k-mooney | kashyap: ya just commented on the test you should leave it at 8 as you are testing non defualt config values | |
| 11:55:42 | kashyap | sean-k-mooney: Yeah, you're right. (Aside: Instead of "Update", I'd use the phrase "Preallocate" -- as that captures the intention more correctly?) | |
| 11:55:57 | kashyap | sean-k-mooney: I stole the preallocate word from you | |
| 11:56:01 | sean-k-mooney | i didnt look into the test fully but i suspect we want to test the default, when its set to 0 and when its set to a non default non 0 values | |
| 11:57:07 | kashyap | Right, let me twiddle | |
| 11:57:36 | openstackgerrit | Vlad Gusev proposed openstack/nova stable/stein: Hide hypervisor id on windows guests https://review.opendev.org/663616 | |
| 11:57:49 | sean-k-mooney | well we are updating the config value to preallocate the pcie-ports so tehy are availabel for hotplug when needed | |
| 11:58:54 | kashyap | (Nod) | |
| 12:06:02 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/635220 | |
| 12:07:23 | lyarwood | mdbooth: ^ FYI just stumbled across this | |
| 12:09:38 | mdbooth | lyarwood: Interesting. I wonder why we haven't hit that, yet. | |
| 12:10:24 | artom | lyarwood, yeah, a ML post needs to happen about that | |
| 12:10:30 | artom | (that = q35) | |
| 12:14:28 | mdbooth | lyarwood: I wonder if we've already pulled in the ceph fix downstream? | |
| 12:14:42 | kashyap | artom: I have a half draft sitting; will send something "soon" | |
| 12:14:55 | kashyap | artom: Based on the description notes here: https://bugs.launchpad.net/nova/+bug/1780138 | |
| 12:14:55 | artom | kashyap, appreciated :) | |
| 12:14:56 | openstack | Launchpad bug 1780138 in OpenStack Compute (nova) "Don't assume the guest machine type to be of 'pc'" [Medium,Confirmed] - Assigned to Kashyap Chamarthy (kashyapc) | |
| 12:15:03 | lyarwood | mdbooth: it would be pretty transparent if we hadn't | |
| 12:15:27 | mdbooth | Presumably snapshot would be failing on ceph | |
| 12:15:38 | mdbooth | Why isn't the upstream gate broken? | |
| 12:15:50 | lyarwood | upstream gate is py2 | |
| 12:16:04 | lyarwood | right, actually ceph is still nv on py2 | |
| 12:16:20 | lyarwood | ceph py3 is in the experimental queue | |
| 12:16:48 | mdbooth | lyarwood: Ack. So this looks like a fix we approve of, but probably not a downstream blocker. | |
| 12:17:16 | mdbooth | Should be high priority upstream, though. | |
| 12:51:58 | kashyap | sean-k-mooney: So I dug the upstream logs of #virt channel, and the "max 28" thing for PCIe ports came from this: | |
| 12:52:53 | kashyap | [For aarch64, *apparently*:] | |
| 12:53:05 | kashyap | <paste> | |
| 12:53:06 | kashyap | 13:25 < abologna> hrw: that might be a bug rather than an actual limit, but there's a limit of 256 on... something? possibly devices, each pcie-root-port has 8 functions so that would be 31 to get to 256 devices | |
| 12:53:06 | kashyap | 13:23 < hrw> 29 == uefi dumps to shell instead of booting | |
| 12:53:06 | kashyap | 13:23 < hrw> ok. 28 pcie-root-port entries are maximum | |
| 12:53:10 | kashyap | 13:25 < abologna> hrw: except pcie-root-ports are of course devices themselves | |
| 12:53:13 | kashyap | 13:25 < abologna> hrw: and even after plugging in 28 pcie-root-ports some of pcie-root's slots and functions will be empty | |
| 12:53:16 | kashyap | 13:26 < hrw> will discuss that with our uefi developers ;D | |
| 12:53:19 | kashyap | </end-paste-spam> | |
| 12:53:40 | sean-k-mooney | ok so we should leave it at 28 and just set teh default to 28 | |
| 12:53:40 | kashyap | [That snippet is from Feb 2018, BTW] | |
| 12:54:41 | kashyap | sean-k-mooney: I wondering if I should step into the rabbit hole to test with an AArch64 guest -- to see what is the current limitation? | |
| 12:55:24 | kashyap | sean-k-mooney: As abologna, the author of https://libvirt.org/pci-hotplug.html, seems to imply the 28 is not even a valid limit. | |
| 12:55:37 | sean-k-mooney | kashyap: proably not as we cant assume they are using a new version of qemu or whatever impose the 28 limit on arrch64 | |
| 12:56:29 | kashyap | sean-k-mooney: The thing is, we're not sure that 28 is an _actual_ limit or not. Nobody seem to have confirmed. | |
| 12:57:06 | sean-k-mooney | if you want to grab a aarch64 guest image and test then sure | |
| 12:57:21 | sean-k-mooney | but we shoudl play it safe with the default | |
| 12:57:41 | kashyap | Yeah, let me do the test. I want to be sure. | |
| 13:07:37 | stephenfin | gibi: Any chance you could take a look at https://review.opendev.org/#/c/660774/ again today and hit me up if you need more info? | |
| 13:07:56 | gibi | stephenfin: give me an hour | |
| 13:08:01 | stephenfin | ta | |
| 13:08:03 | gibi | stephenfin: I'm on a meeting now | |
| 13:08:10 | stephenfin | All good. Thanks :) | |
| 13:22:13 | kashyap | Does anyone here (or know someone who) uses OpenStack on AArch64? | |
| 13:23:12 | sean-k-mooney | there are some folk from lenaro that hang out on the openstack-kolla irc form time to time | |
| 13:25:52 | stephenfin | kashyap: Might want to talk to tonyb | |
| 13:26:40 | kashyap | stephenfin: Yep, noted | |
| 13:27:05 | kashyap | sean-k-mooney: Yeah, I was looking for 'hrw' | |
| 13:29:11 | kashyap | sean-k-mooney: What a beast this whole PCIe saga is | |
| 13:30:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506 | |
| 13:32:38 | sean-k-mooney | kashyap: well its in good hands. we could just do nothing and leave it to the operator to configur the config for there needs which is what nova originally opted to do | |
| 13:33:08 | sean-k-mooney | but if there is a sane default then that is also a good outcome too | |
| 13:33:16 | sean-k-mooney | brb | |
| 13:33:30 | kashyap | sean-k-mooney: Yeah, indeed. But was just exclaiming about the general subtlety involved here... | |
| 13:41:32 | lyarwood | mriedem / efried ; https://review.opendev.org/#/c/663011/ - morning, if you have time to day I'm looking for some non-RH core review on this libvirt specific bugfix. There's a change on top of this that's testing the q35 machine type in the gate. I'm looking into the extend volume failure at the moment. | |
| 13:41:53 | efried | lyarwood: looking | |
| 13:52:26 | efried | lyarwood: Are you looking to backport this? | |
| 13:53:38 | lyarwood | efried: only to stable/stein | |
| 13:53:57 | lyarwood | and the last I checked it was still clean | |
| 13:53:59 | lyarwood | just | |
| 13:54:02 | efried | orly? | |
| 13:54:21 | lyarwood | yeah I know right | |
| 13:54:23 | efried | I thought I'd seen a bunch of twiddling of test_driver that seems unavoidable considering how many places you hit | |
| 13:55:29 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663677 | |
| 13:55:32 | lyarwood | ^ just to show I'm not making it up | |
| 13:57:13 | stephenfin | lyarwood: comments incoming on that, btw | |
| 13:57:16 | stephenfin | efried: too | |