| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-05 | |||
| 21:04:05 | sean-k-mooney | icarusfactor: could that be form zun? | |
| 21:04:11 | mriedem | https://review.opendev.org/#/c/657016/ is my change where cdent pointed out that failure to delete the rp doesn't make us fail to delete the compute service | |
| 21:04:16 | mriedem | finally connecting all the dots | |
| 21:04:19 | mriedem | i'm slow and dumb | |
| 21:04:33 | icarusfactor | sean-k-mooney, Cant answer that. | |
| 21:04:59 | sean-k-mooney | icarusfactor: https://github.com/openstack/nova-docker | |
| 21:05:22 | sean-k-mooney | icarusfactor: it proably related to zun | |
| 21:05:55 | sean-k-mooney | mriedem: oh this is a recent change | |
| 21:06:08 | icarusfactor | sean-k-mooney, ok , will check zun out , that helps as I was going /dev/null fast. | |
| 21:06:14 | mriedem | sean-k-mooney: which? | |
| 21:06:24 | sean-k-mooney | https://review.opendev.org/#/c/657016/ | |
| 21:06:38 | sean-k-mooney | its from monday where cdent commented | |
| 21:08:05 | mriedem | i think i wrote that at the ptg, | |
| 21:08:09 | mriedem | but it's a follow on fix to https://review.opendev.org/#/q/I7b8622b178d5043ed1556d7bdceaf60f47e5ac80 | |
| 21:08:12 | mriedem | which isn't so new | |
| 21:08:32 | sean-k-mooney | oh may 3rd not june 3rd | |
| 21:08:39 | sean-k-mooney | i miss read teh commit date | |
| 21:08:43 | mriedem | so we used to always orphan the rps when when deleting a compute service, | |
| 21:09:03 | mriedem | then we tried to delete the rps, but if it failed we still deleted the copute service and didn't try all nodes in the case of ironic, | |
| 21:09:14 | mriedem | now we realize that we can still fail to delete the rps b/c of evacs and unconfirmed migrations | |
| 21:09:20 | mriedem | so not the worst, but still busted... | |
| 21:09:46 | mriedem | meanwhile, let's pile a bunch of new code into nova yay wee!!!! | |
| 21:10:23 | sean-k-mooney | hehe well stephen is trying to delete a tone of it too :) | |
| 21:10:33 | sean-k-mooney | but im guessing we shoudl update https://github.com/openstack/nova/blob/653515a45032811b6bc2f1d0fb651472005496ec/nova/scheduler/client/report.py#L2173 | |
| 21:10:52 | sean-k-mooney | to get teh allcotion form the RP via teh placmeent api right | |
| 21:11:11 | mriedem | stephen is deleting the stuff no one has been using for several years sure :) | |
| 21:11:12 | sean-k-mooney | and then if we combind that with your change for ironic that might do the right thing | |
| 21:11:30 | mriedem | i need to write the functional recreate test first before we start throwing fixes at it, | |
| 21:11:42 | mriedem | because there are several issues here i think and i need to start with the tests | |
| 21:13:19 | sean-k-mooney | sure but https://review.opendev.org/#/c/657016/2/nova/api/openstack/compute/services.py is calling delete_resource_provider | |
| 21:13:40 | mriedem | i know | |
| 21:13:59 | mriedem | ^ is no worse off than what we have today, it just handles 1:M ironic nodes, | |
| 21:14:07 | sean-k-mooney | so if we fix and test delete_resource_provider for a singel provider then we can layer your other fix on top. | |
| 21:14:15 | mriedem | cdent's -1 is that the commit message is asserting that if we fail to delete the rp we won't delete the compute service which is false | |
| 21:14:15 | sean-k-mooney | yes | |
| 21:14:40 | sean-k-mooney | i think they shoudl stay seperate patches too because its really two sperate problems | |
| 21:15:00 | mriedem | so before refactoring delete_resource_provider and how that works for allocations, i would need to think about whether or not those should be separate changes (i think they should for sanity) | |
| 21:15:12 | mriedem | right | |
| 21:15:57 | mriedem | but right now i have familial duties so can't work on this until tomorrow | |
| 21:16:29 | sean-k-mooney | mriedem: night o/ if you want me to try on work on part of this let me know | |
| 21:16:46 | sean-k-mooney | i need to go finish some spec reviews from yesterday | |
| 21:45:19 | openstackgerrit | Adam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/662105 | |
| 22:13:13 | openstackgerrit | Adam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/662105 | |
| 22:13:49 | openstackgerrit | Sundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification. https://review.opendev.org/603955 | |
| 23:26:11 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | |
| 23:26:11 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | |
| 23:26:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] use iptables in nova-multinode https://review.opendev.org/660782 | |
| 23:27:27 | artom | mriedem, dansmith, think I got everything ^^ Don't expect anything else to happen tonight, I'm gone after this anyways, just an FYI | |
| 23:27:34 | artom | *I don't expect | |
| #openstack-nova - 2019-06-06 | |||
| 02:17:52 | alex_xu | sean-k-mooney: thanks | |
| 02:18:29 | yonglihe | sean-k-mooney: thanks | |
| 03:09:19 | openstackgerrit | XiaojueGuan proposed openstack/nova master: Fix code intendent of file wsgi.py https://review.opendev.org/663487 | |
| 05:35:55 | openstackgerrit | Merged openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897 | |
| 05:48:36 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove an unused method https://review.opendev.org/663502 | |
| 07:32:51 | openstackgerrit | Sharat Sharma proposed openstack/nova master: Modifying install-guide to include public endpoint for identity service https://review.opendev.org/663530 | |
| 08:19:16 | kashyap | alex_xu: Want to put this through? I already had your +2 on it (and it now has +2 from Eric): https://review.opendev.org/#/c/661574/ | |
| 08:22:05 | alex_xu | kashyap: checking now | |
| 08:22:35 | lyarwood | mdbooth: morning, think I've worked out the test_show_update_rebuild_list_server RDO failure. It's a simple race, when passing the test isn't verifying the image as other tests have already downloaded it. | |
| 08:23:00 | mdbooth | lyarwood: Ouch! | |
| 08:23:04 | lyarwood | mdbooth: I can reproduce easily by running tempest.api.compute.servers.test_servers and everything passes and tempest.api.compute.servers.test_servers.ServerShowV263Test where the test fails | |
| 08:23:09 | mdbooth | lyarwood: Also, that's awesome sleuthing | |
| 08:23:34 | lyarwood | mdbooth: ta, the DNM change helped by not actually printing anything in the logs | |
| 08:23:45 | lyarwood | a true W T F moment again this morning | |
| 08:46:09 | openstackgerrit | Liang Fang proposed openstack/nova master: [WIP] Leverage OCF cache framework for VM disks https://review.opendev.org/663542 | |
| 09:04:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110 | |
| 09:04:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | |
| 09:04:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111 | |
| 09:04:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 09:04:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | |
| 09:04:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | |
| 09:04:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | |
| 09:04:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113 | |
| 09:07:30 | openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.opendev.org/323250 | |
| 09:09:43 | bauzas | lyarwood: FWIW, I'm categorizing https://bugs.launchpad.net/nova/+bug/1831538 as High since 'q35' isn't the gate default machine type | |
| 09:09:45 | openstack | Launchpad bug 1831538 in OpenStack Compute (nova) "IDE config drive CDROM doesn't work with q35 machine type" [High,In progress] - Assigned to Lee Yarwood (lyarwood) | |
| 09:10:13 | lyarwood | bauzas: ack that's fair | |
| 09:10:26 | bauzas | lyarwood: but if we consider 'q35' to be more useful to our users than 'pc', I think https://review.opendev.org/#/c/662887/ is much appreciated | |
| 09:11:01 | kashyap | bauzas: It's not necessarily "more useful"; in some cases 'pc' chipset maybe what the user precisely wants | |
| 09:11:02 | lyarwood | bauzas: yeah I spoke to artom yesterday about potentially dropping DNM from that | |
| 09:11:19 | bauzas | lyarwood: https://review.opendev.org/#/c/662887/ is still getting -1 from Zuul | |
| 09:11:27 | lyarwood | bauzas: it's an unrelated failure | |
| 09:11:34 | kashyap | bauzas: But in general, for new guests, we recommend 'q35'. | |
| 09:11:35 | lyarwood | bauzas: I rechecked this morning | |
| 09:12:01 | bauzas | oh sorry | |
| 09:12:45 | bauzas | kashyap: yeah i don't disagree, that's why we leave machine types to be configurable | |
| 09:13:14 | bauzas | kashyap: here I'm talking of choosing a default value for most users, and it looks to me 'q35' gives more benefits than 'pc' | |
| 09:13:32 | bauzas | so, technically, we should have it in the gate | |
| 09:13:37 | kashyap | Yep; also one reason I avoided changing the default in Nova (https://bugs.launchpad.net/nova/+bug/1780138), because we've delegated that decision to the orchestrator for now. | |
| 09:13:38 | openstack | Launchpad bug 1780138 in OpenStack Compute (nova) "Don't assume the guest machine type to be of 'pc'" [Medium,Confirmed] - Assigned to Kashyap Chamarthy (kashyapc) | |
| 09:13:43 | kashyap | [We may revisit it later] | |
| 09:14:04 | kashyap | bauzas: Yeah, agreed -- on testing in Gate. | |
| 09:16:13 | openstackgerrit | Merged openstack/nova master: Document mitigation for Intel MDS security flaws https://review.opendev.org/661574 | |
| 09:35:43 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add flavor metadata or metadata group https://review.opendev.org/663563 | |
| 09:37:33 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add flavor metadata or metadata group https://review.opendev.org/663563 | |
| 09:47:43 | openstackgerrit | Dongcan Ye proposed openstack/nova master: Raise BuildAbortException while updating instance task_state conflict https://review.opendev.org/633160 | |
| 10:34:39 | openstackgerrit | Sharat Sharma proposed openstack/nova master: "SUSPENDED" description changed in server_concepts guide and API REF https://review.opendev.org/663590 | |
| 10:53:17 | mdbooth | lyarwood: Re: https://review.opendev.org/#/c/663596/ has that test ever worked? | |
| 10:53:40 | mdbooth | I mean, it sorta worked, but only because we weren't doing image validation, right? | |
| 10:55:27 | lyarwood | mdbooth: correct | |
| 10:56:28 | lyarwood | mdbooth: so that change disables it by default and leaves some configurables we can wire up over in https://review.opendev.org/#/c/515210/ if we wanted to | |