Posted	Nick	Remark
#openstack-nova - 2019-06-03
20:54:47	efried	gimme a few
21:31:27	openstackgerrit	Merged openstack/nova master: Noop CantStartEngineError in targets_cell if API DB not configured https://review.opendev.org/581912
22:13:16	openstackgerrit	Merged openstack/nova master: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786
22:13:30	openstackgerrit	Merged openstack/nova master: Set/get group uuid when transforming RequestSpec to/from filter_properties https://review.opendev.org/662550
22:13:39	openstackgerrit	Merged openstack/nova master: Cleanup migrate flags https://review.opendev.org/651056
22:20:41	openstackgerrit	Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897
22:20:51	efried	mriedem, melwitt: ^
22:20:58	efried	hopefully I did that right.
22:21:15	mriedem	Sundar: efried: sean-k-mooney: gibi: my first attempt at the nova/cyborg spec https://review.opendev.org/#/c/603955/
22:21:47	efried	thanks mriedem
22:21:55	openstackgerrit	Michael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793
22:25:01	Sundar	mriedem: Thank you very much. Will respond soon.
23:41:47	openstackgerrit	Dustin Cowles proposed openstack/nova-specs master: Spec: Use OpenStack SDK in Nova https://review.opendev.org/662881
23:59:51	openstackgerrit	Artom Lifshitz proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
#openstack-nova - 2019-06-04
00:51:13	openstackgerrit	Matt Riedemann proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897
01:01:09	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/662894
01:03:28	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/662895
01:32:27	openstackgerrit	Brin Zhang proposed openstack/nova master: Replace the invalid index of nova-rocky releasenote https://review.opendev.org/662897
02:10:03	openstackgerrit	zhaixiaojun proposed openstack/python-novaclient master: Bump openstackdocstheme to 1.30.0 https://review.opendev.org/662905
02:53:32	openstackgerrit	zhaixiaojun proposed openstack/python-novaclient master: Blacklist python-cinderclient 4.0.0 https://review.opendev.org/662912
03:45:34	openstackgerrit	Artom Lifshitz proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887
04:08:33	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: WIP:Introduce scope_types in os-services https://review.opendev.org/645427
05:54:31	openstackgerrit	Merged openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056
06:36:12	openstackgerrit	Merged openstack/nova stable/stein: xenapi/agent: Change openssl error handling https://review.opendev.org/656304
07:35:37	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles and mapping in policy base class https://review.opendev.org/645452
07:39:22	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: WIP:Introduce scope_types in os-services https://review.opendev.org/645427
07:39:42	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create https://review.opendev.org/661237
07:40:50	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: WIP: Add new default roles in os-services API policies https://review.opendev.org/648480
07:57:40	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: WIP: Add new default roles in os-services API policies https://review.opendev.org/648480
07:58:12	kashyap	efried: Indeed, it was not me (on "live resize"). But I've followed it on-and-off
08:06:27	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/stein: Reset the stored logs at each notification test steps https://review.opendev.org/662965
08:24:17	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: WIP:Introduce scope_types in servers API https://review.opendev.org/662968
08:29:34	johnthetubaguy	gmann: I couldn't get my unit test to do what I expected with this: https://review.opendev.org/#/c/657823/2
08:29:40	johnthetubaguy	I am probably doing something dumb
08:31:12	gmann	johnthetubaguy: ok, i am updating the spec now with more mapping data. I will check your unit test thing after tnat
08:32:04	johnthetubaguy	gmann: sweet, lets refresh the spec first for sure
08:32:12	johnthetubaguy	this is implementation detail
08:33:19	kashyap	johnthetubaguy: In your copious free time, mind having a look at the Secure Boot spec, please? -- https://review.openstack.org/#/c/506720/
08:34:01	johnthetubaguy	its spec review day, so totally will take a look at that
08:34:02	kashyap	Before I respin to rephrase some text, just want to check if there's anything else anyone has. Near as I see, I've addressed all the feedback
08:34:09	kashyap	johnthetubaguy: Most excellent
08:34:27	johnthetubaguy	that and I have customers who will want this
08:36:58	kashyap	johnthetubaguy: Cool!
08:37:41	kashyap	johnthetubaguy: A good chunk of stuff is in Work Items
08:38:05	kashyap	johnthetubaguy: The thid point, that shows the use 'UefiShell.iso' is info-only; no need for us to run any of that.
08:38:42	kashyap	Because, all distributions that matter, ship OVMF "variables" (or "vars") files that have default UEFI keys enrolled.
08:38:52	kashyap	Anyway, it's a detail. We'll get to it when you're reviewing.
08:40:51	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: WIP: Add new default roles in servers API policies https://review.opendev.org/662971
08:42:09	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Change the default of notification_format to unversioned https://review.opendev.org/603079
08:57:10	johnthetubaguy	kashyap: I see what you mean about the work items thing... its normally like three lines
08:57:17	kashyap	:D
08:57:43	kashyap	johnthetubaguy: I wanted to remove some of the background stuff, to reduce text. As most of the stuff is automated for us by libvirt's new interface
08:57:59	kashyap	And I've working with distributions to ensure they're shipping the variables files
09:05:04	johnthetubaguy	kashyap: yeah, I think you could, finding it interesting, but don't feel qualified to review it
09:05:38	kashyap	johnthetubaguy: Okido; I'll leave it as is. I made sure to write clear sentences that add some value :D
09:07:17	johnthetubaguy	kashyap: I am putting some comments on the bits I would trim, like that list of distro details, I think just two distros to illustrate the complexity would do
09:07:41	kashyap	johnthetubaguy: Sure. Comment away
09:07:58	kashyap	johnthetubaguy: Aside: If you want to try a SecureBoot-enabled guest, here's an automated script I wrote for it: https://kashyapc.fedorapeople.org/Create-a-SecureBoot-enabled-VM.bash
09:08:17	johnthetubaguy	the ovmf loader paths in the xml... I thought libvirt did all that for us/
09:08:57	kashyap	johnthetubaguy: Are you referring to point-2 in the Work Items section?
09:09:07	kashyap	johnthetubaguy: Yes, the new libvirt does handle that for us.
09:09:19	johnthetubaguy	yeah, that is the bit
09:09:35	kashyap	I have a TODO to trim that second point to reflect that.
09:19:06	johnthetubaguy	kashyap: so this sounds harsh... but I think you need to turn your spec upside down, given the new libvirt version, and I guess that is what you are thinking too
09:19:35	kashyap	johnthetubaguy: Sorry, what do you mean upside down?
09:19:49	kashyap	johnthetubaguy: You mean, push the content from Work Items a bit above?
09:20:12	kashyap	Noting clearly that the new libvirt (and QEMU, OVMF / EDK2) version handles most of the work for us?
09:20:46	kashyap	(All harsh feedback is welcome :-) After spending so much time on my text, I need other eyes to help edit it.)
09:20:56	kashyap	s/other/others'/
09:21:32	johnthetubaguy	kashyap: trying to work out how to describe what I am thinking :)
09:22:09	kashyap	johnthetubaguy: Sure. Whatever brings clarity.
09:22:12	johnthetubaguy	so overall I think we are largely there, libvirt does all the work, it clearly is something useful
09:22:43	kashyap	"No mind is ever willingly deprived of the truth" — Plato
09:22:51	kashyap	johnthetubaguy: Yeah, indeed.
09:23:18	johnthetubaguy	so I think this spec was needed before libvirt did all the hard work
09:23:37	johnthetubaguy	and we still need a bunch of the detail for sure
09:23:46	johnthetubaguy	just wondering first about what is missing
09:23:51	johnthetubaguy	... so the last two work items
09:24:37	johnthetubaguy	actually, that is back to front, maybe I just say what I think I was expecting... which doesn't make it the right or only way, its just a data point
09:25:01	kashyap	Yeah, noted.
09:25:10	kashyap	Also, it's not just the last two points, surely?
09:25:48	kashyap	Also the point on making Nova use the firmware auto-selection feature?
09:25:49	kashyap	</os>
09:25:49	kashyap	<loader secure='yes'/>
09:25:49	kashyap	<os firmware='efi'>
09:25:56	johnthetubaguy	yeah, totally
09:26:14	johnthetubaguy	lets go through each bit of the spec quickly, I think its close
09:26:22	kashyap	Certainly.
09:26:54	johnthetubaguy	so problem and use cases, I think you could simplify it a little bit, line 51-52 and line 42-44 are good
09:27:47	kashyap	Right, I'll reword the "or other kernel code ..." thing, if you prefer.
09:28:05	johnthetubaguy	well, I mean those lines are vital... i.e. you need this for guests to protect against certain kinds of maleware, and by the way we already added this for hyper-v
09:28:08	kashyap	(It's just saying: either guest side malware or malware from kernel modules)
09:28:25	johnthetubaguy	the hypervisor kernel modules?
09:28:28	kashyap	johnthetubaguy: Added what? (The SecureBoot feature? Sure)
09:28:31	kashyap	Yes
09:28:58	johnthetubaguy	hmm, OK, I guess it does... :/ not sure
09:29:21	johnthetubaguy	anyways, the guest malware seems the key thing for the user
09:29:29	johnthetubaguy	sweet
09:30:38	johnthetubaguy	the proposed change thing: (1) copy hyper-v interface, (2) libvirt does all the work when we add the above XML, (3) scheduling to make sure we get on a capable host
09:30:56	johnthetubaguy	is there anything else from the "changes to nova" sense?

Earlier   Later