Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-03
13:49:57 efried ...I'm pretty sure? Now you got me doubting.
13:50:30 lyarwood efried: ah cool thanks, I'll try that now
14:04:57 kashyap efried: Heh, just looking. On the "SMT vulnerable" thing, yes, that didn't sit well with me either. Allow me to expand:
14:05:20 efried kashyap: Expand in the document
14:05:26 efried I believe you
14:05:32 kashyap efried: You will see "SMT vulnerable" when you have not disabled hyperthreading in the BIOS
14:05:40 kashyap (Yes, will certainly expand there, too.)
14:05:58 efried Yeah, so I don't know that that means. All I know is I see 'vulnerable' and that worries me.
14:06:17 efried but I don't know if "Mitigation: ... vulnerable" means I've mitigated the vulnerability
14:06:19 efried or what
14:06:36 efried maybe it'll be obvious to anybody who's actually qualified to be following this guide
14:06:40 efried if so, tell me that.
14:07:07 efried or maybe it would be clear by reading, from top to bottom, the link you referenced
14:07:17 efried which I did not do as part of my review :)
14:07:24 efried if so, you can tell me that too.
14:09:08 cdent fg
14:09:11 cdent oops ww
14:09:48 cdent I temporarily have more screen real estate than I can see in one glance
14:15:12 efried that sounds like a problem I want to have
14:18:08 edleafe Heh, I type into the wrong window at least once a day. Fortuantely, I don't type my passwords too often
14:23:09 kashyap edleafe: Hope you use a password manager :D
14:24:41 edleafe kashyap: Been using LastPass for 8 years now, and love it. But some VMs I use require passwords instead of SSH keys. LastPass doesn't work at a terminal :)
14:25:40 kashyap Nod; whatever works (and is not buggy).
14:26:03 kashyap efried: Whoops, missed the rest of the chat here. I'll respond to them all on the review.
14:39:12 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Add regression recreate test for bug 1830747 https://review.opendev.org/662774
14:39:13 openstack bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem)
14:51:27 efried kashyap, aspiers, mdbooth: Who's good with libvirt's use of lvm/cinder for swap devices?
14:51:41 efried ...or has the background to understand that fairly quickly
14:51:57 mdbooth efried: Me, probably
14:52:17 mdbooth *cinder* for swap?
14:52:19 efried mdbooth: Cool. Ima throw you on a review if you don't mind.
14:52:26 efried I'm not sure, really.
14:52:28 efried https://review.opendev.org/#/c/618621/
14:52:41 efried It's pretty raw at this point - I get the impression the contributor is very new to coding.
14:52:56 efried but perhaps you can provide guidance as to whether the fix is sane, going in the right direction.
14:53:17 kashyap efried: mdbooth indeed
14:54:23 efried mdbooth: Note that this came from ML thread http://lists.openstack.org/pipermail/openstack-discuss/2019-June/006807.html which I just responded to - but my response was only in the context of "here's how to get tests to pass".
14:54:35 efried I don't have the background to know whether the fix is any good.
14:55:05 mdbooth Ack. I have a short meeting in a couple of minutes, but I'll try to look at this properly within the next few hours.
14:55:11 efried thank you mdbooth
15:15:22 openstackgerrit Merged openstack/nova master: Add extra logging to request filters https://review.opendev.org/657629
15:25:43 mriedem just fyi, dfw nodes are having issues this morning so you'll be rechecking if you hit one of those nodes
15:26:11 mriedem error message of "('Connection broken: IncompleteRead(0 bytes read)', IncompleteRead(0 bytes read))"
15:31:40 gibi mriedem: left a comment in https://bugs.launchpad.net/nova/+bug/1829479
15:31:41 openstack Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Undecided,Incomplete]
15:38:27 openstackgerrit Merged openstack/nova master: Ensure that metadata proxy raises correct exception https://review.opendev.org/661480
15:47:03 efried thanks mriedem, seen a few of those :(
15:47:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix no propagation of nova context request_id https://review.opendev.org/662715
15:55:23 efried mriedem: Loading an instance from the db, setting expected_attrs makes it load those fields right away; if I don't do that, I can still access the fields, but they'll get loaded later, which is another db hit and therefore slow. Do I have this right?
15:56:36 mriedem correct
15:56:50 efried Cool, so https://review.opendev.org/#/c/662683/ is sane
15:56:50 mriedem e.g. https://review.opendev.org/#/c/657021/
15:57:15 mriedem i reported that bug but it should be hopefully what i said to do in the bug
15:58:12 efried oh
15:58:34 efried heh, yup, just so.
16:18:16 efried stephenfin: You around to send https://review.opendev.org/#/c/644793/ to its maker?
16:28:03 kashyap efried: It's a holiday in Ireland today.
16:28:09 kashyap (And a holiday in Belgium on Monday :D)
16:28:23 kashyap (Next one; so is in Germany and France, too.)
16:29:08 kashyap efried: Responded here: https://review.opendev.org/#/c/661574/3. I'd like to one thing: is my "short and unsatisfying statement" at the end amenable to you, given the complexity?
16:29:23 kashyap s/to/"to know"/
16:34:37 openstackgerrit Merged openstack/nova stable/stein: [ironic] Don't remove instance info twice in destroy https://review.opendev.org/662479
16:35:50 mdbooth Argh, gerrit--
16:36:14 kashyap mdbooth: Call it what it is: "Grrrrrrit!" :D
16:36:23 mdbooth haha
16:41:38 openstackgerrit John Garbutt proposed openstack/nova master: Move default policy target https://review.opendev.org/657696
16:41:39 openstackgerrit John Garbutt proposed openstack/nova master: Add functional test for admin_actions https://review.opendev.org/657698
16:41:39 openstackgerrit John Garbutt proposed openstack/nova master: Better policy unit tests https://review.opendev.org/657697
16:41:40 openstackgerrit John Garbutt proposed openstack/nova master: WIP: add scope check, see tests catch the change https://review.opendev.org/657823
17:15:48 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
17:23:17 efried kashyap: responded
17:24:51 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
17:25:09 aspiers efried: if Zuul likes this ^^^ then it should be ready to go
17:25:21 aspiers gotta dash, cya tomorrow
17:25:32 efried aspiers: Okay, did we already get the g-r patch through?
17:26:14 efried nope
17:26:22 efried so it will fail constraints job until https://review.opendev.org/#/c/662805/
17:26:54 aspiers g-r?
17:27:07 aspiers oh
17:27:22 efried sokay, just leave it as is and recheck once ^ lands
17:27:31 efried I'm not sure if depends
17:27:41 efried depends-on works to a requirements patch
17:27:49 aspiers Yeah OK
17:27:56 aspiers gotta dash, l8r!
17:28:29 efried o/
17:32:21 openstackgerrit Boris Bobrov proposed openstack/nova master: Use element when SEV was required https://review.opendev.org/662557
17:34:01 openstackgerrit Eric Fried proposed openstack/os-traits master: Create trait for NUMA subtree affinity https://review.opendev.org/657898
17:37:14 openstackgerrit Eric Fried proposed openstack/os-traits master: Create trait for device subtree affinity https://review.opendev.org/657898
17:38:03 openstackgerrit Eric Fried proposed openstack/os-traits master: Create trait for device subtree affinity https://review.opendev.org/662811
17:41:06 openstackgerrit Eric Fried proposed openstack/os-traits master: Create trait for NUMA subtree affinity https://review.opendev.org/657898
17:44:49 openstackgerrit Boris Bobrov proposed openstack/nova master: Add element to guest config for AMD SEV https://review.opendev.org/636318
17:51:18 openstackgerrit Boris Bobrov proposed openstack/nova master: Add iommu driver to devices https://review.opendev.org/644564
18:00:46 openstackgerrit Boris Bobrov proposed openstack/nova master: Allow guest devices to include https://review.opendev.org/644564
18:01:47 openstackgerrit Boris Bobrov proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565
18:02:28 openstackgerrit Boris Bobrov proposed openstack/nova master: Use element when SEV is required https://review.opendev.org/662557
18:02:42 openstackgerrit Boris Bobrov proposed openstack/nova master: Use element when SEV is required https://review.opendev.org/662557
18:02:54 openstackgerrit Boris Bobrov proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558
18:03:40 openstackgerrit Boris Bobrov proposed openstack/nova master: Add element to guest config for AMD SEV https://review.opendev.org/636318
18:05:58 openstackgerrit Boris Bobrov proposed openstack/nova master: Allow guest devices to include https://review.opendev.org/644564
18:06:42 openstackgerrit Boris Bobrov proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565

Earlier   Later